On Fri, 21 Mar 2025 17:39:37 GMT, Harshitha Onkar wrote:
>> Built-in Profiles are singleton objects and if the user happens to modify
>> this shared profile object via setData() then the modified version of the
>> profile is returned each time the same built-in profile is requested via
>> getI
On Thu, 13 Mar 2025 20:25:26 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> redudant stmt removed
>
> Marked as reviewed by prr (Reviewer).
@prrace I know that the CSR description is not part of
On Fri, 21 Mar 2025 17:39:37 GMT, Harshitha Onkar wrote:
>> Built-in Profiles are singleton objects and if the user happens to modify
>> this shared profile object via setData() then the modified version of the
>> profile is returned each time the same built-in profile is requested via
>> getI
On Fri, 21 Mar 2025 07:50:50 GMT, Roman Marchenko
wrote:
>> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
>> `Introspector.addMethod()` working properly when filtering methods out.
>>
>> Also, after PR discussion, added the approptiate test cases with
>> corresponding fixes
On Fri, 21 Mar 2025 08:28:00 GMT, Abhishek Kumar wrote:
> TestJTabbedPaneBackgroundColor.java test was failing intermittently in CI
> jobs. Test is modified to access UI components on EDT for stabilizations. CI
> testing seems fine after test change. Link attached in JBS.
This pull request has
> Built-in Profiles are singleton objects and if the user happens to modify
> this shared profile object via setData() then the modified version of the
> profile is returned each time the same built-in profile is requested via
> getInstance().
>
> It is good to protect Built-in profiles from su
On Fri, 21 Mar 2025 16:22:40 GMT, Alexey Ivanov wrote:
> If there were a way to re-enable the button again, it would render with
> `Font.DIALOG` instead of the custom font that I set when the button was
> created.
Indeed, the button font is changed permanently.
If I modify the test code:
On Fri, 21 Mar 2025 11:14:50 GMT, Abhishek Kumar wrote:
>> TestJTabbedPaneBackgroundColor.java test was failing intermittently in CI
>> jobs. Test is modified to access UI components on EDT for stabilizations. CI
>> testing seems fine after test change. Link attached in JBS.
>
> Abhishek Kumar
On Fri, 7 Mar 2025 18:44:24 GMT, Sergey Bylokhov wrote:
> Please summarize the use cases we discussed(in the description of this PR? or
> jbs) and how they are currently handled. It would be useful to document this
> since we don’t have a strict specification.
Adding a JBS comment with the des
> This update allows users to print with grayscale using color printers.
> Actually, it is not possible to use the "Monochrome" option from the "Color
> Appearance" panel. Also Chromaticity.MONOCHROME can't be used to print
> grayscale on color printers
> ([JDK-8315113](https://bugs.openjdk.org/
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Fri, 21 Mar 2025 11:14:50 GMT, Abhishek Kumar wrote:
>> TestJTabbedPaneBackgroundColor.java test was failing intermittently in CI
>> jobs. Test is modified to access UI components on EDT for stabilizations. CI
>> testing seems fine after test change. Link attached in JBS.
>
> Abhishek Kumar
> After "JDK-8339480: Build static-jdk image with a statically linked launcher"
> AIX was not able to build the new target. Therefore with "JDK-8345590 AIX
> 'make all' fails after JDK-8339480" the new target was disabled again.
>
> Now with this change we can enable the statically linked launch
On Fri, 21 Mar 2025 11:44:49 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
On Fri, 7 Mar 2025 22:03:08 GMT, Phil Race wrote:
>> src/java.desktop/macosx/classes/sun/print/GrayscaleProxyGraphics2D.java line
>> 3:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
>>> 3: * Copyright (c) 2024, BELLSOFT. All rights reserved.
>>
On Fri, 7 Mar 2025 21:17:01 GMT, Phil Race wrote:
>> GennadiyKrivoshein has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 15 commits:
>>
>> - Update copyright, fix typos, move the proxy to the macos
>> - Merge branch 'master' into
On Fri, 21 Mar 2025 07:50:50 GMT, Roman Marchenko
wrote:
>> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
>> `Introspector.addMethod()` working properly when filtering methods out.
>>
>> Also, after PR discussion, added the approptiate test cases with
>> corresponding fixes
> After "JDK-8339480: Build static-jdk image with a statically linked launcher"
> AIX was not able to build the new target. Therefore with "JDK-8345590 AIX
> 'make all' fails after JDK-8339480" the new target was disabled again.
>
> Now with this change we can enable the statically linked launch
javax.swing.plaf.basic.BasicButtonUI uses wrong FontMetrics object to layout
the text on a JButton.
The paint(Graphics, JComponent) method of BasicButtonUI calculates the
[FontMetrics](https://github.com/openjdk/jdk/blob/6656254c346ef505a48652fdf4dedd6edc020e33/src/java.desktop/share/classes/jav
On Thu, 20 Mar 2025 22:19:47 GMT, Magnus Ihse Bursie wrote:
>> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c line 1104:
>>
>>> 1102: Java_sun_awt_screencast_ScreencastHelper_closeSession(JNIEnv *env,
>>> jclass cls) {
>>> 1103: }
>>> 1104:
>>
>> Suggestion:
>>
>>
>>
>>
On Fri, 21 Mar 2025 07:29:16 GMT, Roman Marchenko
wrote:
> This wasn't aligned with the dot above. This was aligned by 8 spaces, the
> same as for `actual`. But OK if you like.
The dots in the chained calls for `expected` were aligned in the previous
version.
-
PR Review Comment
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Thu, 20 Mar 2025 14:30:58 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
On Thu, 20 Mar 2025 14:30:58 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
> TestJTabbedPaneBackgroundColor.java test was failing intermittently in CI
> jobs. Test is modified to access UI components on EDT for stabilizations. CI
> testing seems fine after test change. Link attached in JBS.
Abhishek Kumar has updated the pull request incrementally with one additional
On Thu, 20 Mar 2025 22:45:47 GMT, Magnus Ihse Bursie wrote:
>> I do not see a problem here, but in this case the
>> `Java_sun_awt_screencast_ScreencastHelper_getRGBPixelsImpl` is missing, as
>> the ScreencastHelper has 3 native methods.
>
> Ah, I see. I agree, that it makes more sense to either
On Fri, 21 Mar 2025 08:28:00 GMT, Abhishek Kumar wrote:
> TestJTabbedPaneBackgroundColor.java test was failing intermittently in CI
> jobs. Test is modified to access UI components on EDT for stabilizations. CI
> testing seems fine after test change. Link attached in JBS.
It seems you have ran
On Fri, 21 Mar 2025 07:47:49 GMT, Roman Marchenko
wrote:
>> test/jdk/java/beans/Introspector/DefaultMethodBeanPropertyTest.java line 319:
>>
>>> 317: public static void testScenario7() {
>>> 318: verifyMethods(D7.class,
>>> 319: "public void
>>> DefaultMethodBeanPropert
28 matches
Mail list logo
