Re: RFR: 8353592: Open source several scrollbar tests

2025-04-10 Thread Prasanta Sadhukhan
On Fri, 11 Apr 2025 06:37:58 GMT, Alexander Zvegintsev wrote: > Few scroll bar tests are open sourced. Testing looks good. Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24590#pullrequestreview-2759310132

RFR: 8353592: Open source several scrollbar tests

2025-04-10 Thread Alexander Zvegintsev
Few scroll bar tests are open sourced. Testing looks good. - Commit messages: - initial Changes: https://git.openjdk.org/jdk/pull/24590/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24590&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353592 Stats: 382 lines in

Re: RFR: JDK-8353486 : Open source Swing Tests - Set 4 [v3]

2025-04-10 Thread Tejesh R
On Tue, 8 Apr 2025 22:45:31 GMT, Harshitha Onkar wrote: >> Open-sourced the following Swing tests: >> >> 1. javax/swing/JFileChooser/bug4464774.java >> 2. javax/swing/JFileChooser/bug4522756.java >> 3. javax/swing/JFileChooser/bug4759934.java >> 4. javax/swing/JFileChooser/bug4943900.java >> 5.

Integrated: 8354317: [XWayland] Problem list two tests crashing XWayland server

2025-04-10 Thread Alexander Zvegintsev
On Thu, 10 Apr 2025 16:35:33 GMT, Alexander Zvegintsev wrote: > Problem list two tests crashing XWayland server > Corresponding issue [JDK-8354097](https://bugs.openjdk.org/browse/JDK-8354097) This pull request has now been integrated. Changeset: d8bed693 Author:Alexander Zvegintsev URL:

Re: RFR: 8354317: [XWayland] Problem list two tests crashing XWayland server

2025-04-10 Thread Alexander Zvegintsev
On Fri, 11 Apr 2025 05:49:02 GMT, Jayathirth D V wrote: > Suggestion: Since we will be streamlining things to run on Ubuntu 24.04 & > Wayland, we can use/add utility to determine whether we use Waylnad/Xorg and > disable tests on particular windowing system. > > Recently in OpenJFX, i was able

Re: RFR: 8354191: GTK LaF should use pre-multiplied alpha same as cairo

2025-04-10 Thread Maxim Kartashev
On Fri, 11 Apr 2025 03:42:07 GMT, Sergey Bylokhov wrote: >> The pixels that cairo produces for GTK LaF to draw on a Swing component have >> their alpha components pre-multiplied as per [the >> documentation](https://www.cairographics.org/manual/cairo-Image-Surfaces.html?spm=a2ty_o01.29997173.0.

RFR: 8354214: Open source Swing tests Batch 2

2025-04-10 Thread Jayathirth D V
Few swing JList tests are open sourced. - Commit messages: - 8354214: Open source Swing tests Batch 2 Changes: https://git.openjdk.org/jdk/pull/24588/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24588&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8354214 Stats:

Re: RFR: 8354317: [XWayland] Problem list two tests crashing XWayland server

2025-04-10 Thread Jayathirth D V
On Thu, 10 Apr 2025 16:35:33 GMT, Alexander Zvegintsev wrote: > Problem list two tests crashing XWayland server > Corresponding issue [JDK-8354097](https://bugs.openjdk.org/browse/JDK-8354097) Suggestion: Since we will be streamlining things to run on Ubuntu 24.04 & Wayland, we can use/add uti

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v3]

2025-04-10 Thread Manukumar V S
> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently > in CI, especially in MacOS machines. > Also the frame created in this test is not disposed which may interfere with > other tests. > > Fix: > Some stabilisations added and the frame is disposed properly. > > Testin

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v2]

2025-04-10 Thread Manukumar V S
On Fri, 11 Apr 2025 04:11:48 GMT, Sergey Bylokhov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Formatting changes > > test/jdk/java/awt/ScrollPane/bug8077409Test.java line 130: > >> 128

Re: RFR: 8352905: Open some JComboBox bugs 1

2025-04-10 Thread Prasanta Sadhukhan
On Mon, 7 Apr 2025 22:50:14 GMT, Alisen Chung wrote: > Updating and opening some tests test/jdk/javax/swing/JComboBox/bug4530952.java line 120: > 118: > 119: btnAction.setEnabled(false); > 120: frame.getContentPane().add(btnAction); all redundant getContentPane() can be remove

Re: RFR: 8352905: Open some JComboBox bugs 1

2025-04-10 Thread Prasanta Sadhukhan
On Mon, 7 Apr 2025 22:50:14 GMT, Alisen Chung wrote: > Updating and opening some tests test/jdk/javax/swing/JComboBox/bug4180054.java line 57: > 55: comboBox.setSelectedIndex(1); > 56: comboBox.setSelectedIndex(3); > 57: comboBox.setSelectedIndex(2); guess o

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v2]

2025-04-10 Thread Sergey Bylokhov
On Sat, 5 Apr 2025 11:52:19 GMT, Manukumar V S wrote: >> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently >> in CI, especially in MacOS machines. >> Also the frame created in this test is not disposed which may interfere with >> other tests. >> >> Fix: >> Some stabi

Re: RFR: 8352865: Open source several AWT TextComponent tests - Batch 2

2025-04-10 Thread Sergey Bylokhov
On Mon, 7 Apr 2025 07:24:31 GMT, Tejesh R wrote: > Open source these AWT TextComponent tests: > > java/awt/TextComponent/SelectionAndCaretColor/SelectionAndCaretColor.java > java/awt/TextComponent/SelectionTest/SelectionTest.java > java/awt/TextComponent/CorrectTextComponentSelectionTest/Correct

Re: RFR: 8353070: Clean up and open source couple AWT Graphics related tests (Part 1)

2025-04-10 Thread Sergey Bylokhov
On Sun, 6 Apr 2025 06:08:36 GMT, Alexander Zuev wrote: > Clean up and open source four tests, two manual and two automatic tests now. Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24472#pullrequestreview-2759093172

Integrated: 8352687: Opensource few JInternalFrame and JTextField tests

2025-04-10 Thread Prasanta Sadhukhan
On Mon, 7 Apr 2025 04:39:05 GMT, Prasanta Sadhukhan wrote: > Few JInternalFrame and JTextField tests are opensourced This pull request has now been integrated. Changeset: f955a8cb Author:Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/f955a8cbd2d1233af7f7e4b4e4bfcdbb5a8c

Re: RFR: 8352905: Open some JComboBox bugs 1

2025-04-10 Thread Sergey Bylokhov
On Mon, 7 Apr 2025 22:50:14 GMT, Alisen Chung wrote: > Updating and opening some tests test/jdk/javax/swing/JComboBox/bug4166593.java line 65: > 63: } > 64: > 65: if (frame != null) { frame is initialized on a different thread and accessed here without proper synchronization.

Re: RFR: 8353483: Open source some JProgressBar tests [v3]

2025-04-10 Thread Sergey Bylokhov
On Wed, 9 Apr 2025 18:22:56 GMT, Phil Race wrote: >> Open source 4 Swing JProgressBar tests. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8353483 Marked as reviewed by serb (Reviewer). - PR Review: https://gi

Re: RFR: 8352877: Opensource Several Font related tests - Batch 1

2025-04-10 Thread Sergey Bylokhov
On Wed, 9 Apr 2025 04:49:18 GMT, Abhishek Kumar wrote: > Font related Applet tests are converted to manual and open sourced. Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24536#pullrequestreview-2759077780

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Sergey Bylokhov
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8354191: GTK LaF should use pre-multiplied alpha same as cairo

2025-04-10 Thread Sergey Bylokhov
On Wed, 9 Apr 2025 14:42:05 GMT, Maxim Kartashev wrote: > The pixels that cairo produces for GTK LaF to draw on a Swing component have > their alpha components pre-multiplied as per [the > documentation](https://www.cairographics.org/manual/cairo-Image-Surfaces.html?spm=a2ty_o01.29997173.0.0.54

Re: RFR: 8353000: Open source several swing tests batch2

2025-04-10 Thread Sergey Bylokhov
On Wed, 9 Apr 2025 22:17:35 GMT, Damon Nguyen wrote: > Open-sourcing and standardizing several tests (metal) test/jdk/javax/swing/plaf/metal/MetalIconFactory/bug4952462.java line 57: > 55: > UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel"); > 56: > 57:

Re: RFR: 8354317: [XWayland] Problem list two tests crashing XWayland server

2025-04-10 Thread Sergey Bylokhov
On Thu, 10 Apr 2025 16:35:33 GMT, Alexander Zvegintsev wrote: > Problem list two tests crashing XWayland server > Corresponding issue [JDK-8354097](https://bugs.openjdk.org/browse/JDK-8354097) Marked as reviewed by serb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/245

Re: RFR: 8353138: Screen capture for test TaskbarPositionTest.java, failure case [v7]

2025-04-10 Thread Alexey Ivanov
On Mon, 7 Apr 2025 12:34:43 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Added screen capture in case of test failure using Robot. >> >> Please review and let me know your suggestion if any. > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one

Re: RFR: 8354191: GTK LaF should use pre-multiplied alpha same as cairo

2025-04-10 Thread Alexey Ushakov
On Wed, 9 Apr 2025 14:42:05 GMT, Maxim Kartashev wrote: > The pixels that cairo produces for GTK LaF to draw on a Swing component have > their alpha components pre-multiplied as per [the > documentation](https://www.cairographics.org/manual/cairo-Image-Surfaces.html?spm=a2ty_o01.29997173.0.0.54

Re: RFR: 8347826: Introspector shows wrong method list after 8071693 [v12]

2025-04-10 Thread Sergey Bylokhov
On Thu, 3 Apr 2025 09:21:38 GMT, Roman Marchenko wrote: >> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make >> `Introspector.addMethod()` working properly when filtering methods out. >> >> Also, after PR discussion, added the approptiate test cases with >> corresponding fixes in

Re: RFR: 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions [v4]

2025-04-10 Thread Alexey Ivanov
On Wed, 9 Apr 2025 17:46:19 GMT, Jeremy Wood wrote: > Ah, OK. So is there any outstanding question in this thread? No, it's resolved now. You throw an `Error` to make the test fail, and jtreg now reports a failed test without the fix. - PR Review Comment: https://git.openjdk.org/j

Re: RFR: 8352682: Opensource JComponent tests [v2]

2025-04-10 Thread Prasanta Sadhukhan
> Few JComponent tests are opensourced Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Use lambda - Changes: - all: https://git.openjdk.org/jdk/pull/24562/files - new: https://git.openjdk.org/jdk/pull/24562/fil

Re: RFR: 8353138: Screen capture for test TaskbarPositionTest.java, failure case [v7]

2025-04-10 Thread duke
On Mon, 7 Apr 2025 12:34:43 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Added screen capture in case of test failure using Robot. >> >> Please review and let me know your suggestion if any. > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one

Re: RFR: 8353000: Open source several swing tests batch2

2025-04-10 Thread Alexander Zvegintsev
On Wed, 9 Apr 2025 22:17:35 GMT, Damon Nguyen wrote: > Open-sourcing and standardizing several tests (metal) Marked as reviewed by azvegint (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24560#pullrequestreview-2758602209

Re: RFR: 8352687: Opensource few JInternalFrame and JTextField tests [v3]

2025-04-10 Thread Harshitha Onkar
On Thu, 10 Apr 2025 05:36:58 GMT, Prasanta Sadhukhan wrote: >> Few JInternalFrame and JTextField tests are opensourced > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Remove SkippedException Marked as reviewed by ho

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 18:30:22 GMT, Eirik Bjørsnøs wrote: >> If this is a French name, it's e acute: é. > >> If this is a French name, it's e acute: é. > > Supported by this Wikipedia page listing S.L as an LCMS developer: > > https://en.wikipedia.org/wiki/Little_CMS It's not a mistake in capita

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 19:06:35 GMT, Eirik Bjørsnøs wrote: > (BTW, I enjoyed seeing separate commits for the encoding and BOM changes, > makes it easier to verify each!) Thanks! I do very much like myself to review PRs that has separate logical commits, so I try to produce such myself. I'm glad t

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8353589: Open source a few Swing menu-related tests [v2]

2025-04-10 Thread Phil Race
> Open source a few tests related to Swing menus. Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8353589 - Changes: - all: https://git.openjdk.org/jdk/pull/24457/files - new: https://git.openjdk.org/jdk/pull/24457/file

RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Magnus Ihse Bursie
I have checked the entire code base for incorrect encodings, but luckily enough these were the only remaining problems I found. BOM (byte-order mark) is a method used for distinguishing big and little endian UTF-16 encodings. There is a special UTF-8 BOM, but it is discouraged. In the words of

Re: RFR: 8354191: GTK LaF should use pre-multiplied alpha same as cairo

2025-04-10 Thread Maxim Kartashev
On Wed, 9 Apr 2025 14:42:05 GMT, Maxim Kartashev wrote: > The pixels that cairo produces for GTK LaF to draw on a Swing component have > their alpha components pre-multiplied as per [the > documentation](https://www.cairographics.org/manual/cairo-Image-Surfaces.html?spm=a2ty_o01.29997173.0.0.54

Re: RFR: 8353304: Open source two JTabbedPane tests [v2]

2025-04-10 Thread Alexander Zuev
On Mon, 7 Apr 2025 16:28:44 GMT, Phil Race wrote: >> Open source two Swing JTabbedPane tests. >> One is problem listed for macOS because of the way Aqua displays tabs on the >> left + right. > > Phil Race has updated the pull request incrementally with one additional > commit since the last rev

Re: RFR: 8351913: ToolkitImage renders some gifs wrong [v2]

2025-04-10 Thread Jeremy Wood
> I do not have much background in LZW compression or in C, but I'm reasonably > confident this resolves the problem I'm observing. It looks like the > GifImageDecoder was not always correctly handling compression codes after the > table reached its limit of ~4096. If anyone has suggestions for

Re: RFR: 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions [v4]

2025-04-10 Thread Alexey Ivanov
On Sat, 5 Apr 2025 05:49:14 GMT, Jeremy Wood wrote: > Thank you for pointing out the `new Error` oversight. > > > The WriteJPEGThumbnailTest.jtr file says, the test failed > > That output is exactly what I would expect to see before this PR. Is it > possible you ran the test without invoking `

Re: RFR: 8352687: Opensource few JInternalFrame and JTextField tests

2025-04-10 Thread Harshitha Onkar
On Mon, 7 Apr 2025 04:39:05 GMT, Prasanta Sadhukhan wrote: > Few JInternalFrame and JTextField tests are opensourced test/jdk/javax/swing/JInternalFrame/bug4190516.java line 60: > 58: fr.getContentPane().add(jdp); > 59: > 60: JInternalFrame jif = new JInternalFrame("Title", t

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-10 Thread Alexey Ivanov
On Fri, 28 Mar 2025 09:41:22 GMT, Daniel Gredler wrote: > WTaskbarPeer contains a check as to whether the current Windows version is > Windows 7 or later. The current minimum supported version is Windows 10, so > this is no longer needed. > > There didn't seem to be a public test exercising th

Integrated: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles

2025-04-10 Thread Harshitha Onkar
On Thu, 13 Feb 2025 01:08:04 GMT, Harshitha Onkar wrote: > Built-in Profiles are singleton objects and if the user happens to modify > this shared profile object via setData() then the modified version of the > profile is returned each time the same built-in profile is requested via > getInsta

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v26]

2025-04-10 Thread Alexey Ivanov
On Thu, 10 Apr 2025 17:12:30 GMT, Harshitha Onkar wrote: >> Built-in Profiles are singleton objects and if the user happens to modify >> this shared profile object via setData() then the modified version of the >> profile is returned each time the same built-in profile is requested via >> getI

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Justin Lu
On Thu, 10 Apr 2025 08:44:28 GMT, Eirik Bjørsnøs wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace InputStreamReader with BufferedReader > > FWIW, I checked out the revision of the commit previous to this change

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Integrated: 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions

2025-04-10 Thread Jeremy Wood
On Wed, 5 Mar 2025 18:29:49 GMT, Jeremy Wood wrote: > JPEG segments can only be 65535-bytes long. (The marker length is expressed > as 2 bytes.) The problem in this ticket is that we were writing more than > 65535 bytes to a segment, which later caused parsing errors when we tried to > read th

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 17:23:37 GMT, Raffaello Giulietti wrote: > If this is a French name, it's e acute: é. Supported by this Wikipedia page listing S.L as an LCMS developer: https://en.wikipedia.org/wiki/Little_CMS - PR Review Comment: https://git.openjdk.org/jdk/pull/24566#discus

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-10 Thread Alexey Ivanov
On Mon, 7 Apr 2025 14:40:38 GMT, Daniel Gredler wrote: >> src/java.desktop/windows/classes/sun/awt/windows/WTaskbarPeer.java line 46: >> >>> 44: private static synchronized void init() { >>> 45: if (!initExecuted) { >>> 46: supported = ShellFolder.invoke(() -> nativeInit(

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Naoto Sato
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Erik Joelsson
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions [v10]

2025-04-10 Thread duke
On Wed, 9 Apr 2025 23:31:02 GMT, Jeremy Wood wrote: >> JPEG segments can only be 65535-bytes long. (The marker length is expressed >> as 2 bytes.) The problem in this ticket is that we were writing more than >> 65535 bytes to a segment, which later caused parsing errors when we tried to >> rea

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Raffaello Giulietti
On Thu, 10 Apr 2025 17:09:27 GMT, Naoto Sato wrote: >> I have checked the entire code base for incorrect encodings, but luckily >> enough these were the only remaining problems I found. >> >> BOM (byte-order mark) is a method used for distinguishing big and little >> endian UTF-16 encodings.

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v26]

2025-04-10 Thread Harshitha Onkar
> Built-in Profiles are singleton objects and if the user happens to modify > this shared profile object via setData() then the modified version of the > profile is returned each time the same built-in profile is requested via > getInstance(). > > It is good to protect Built-in profiles from su

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Naoto Sato
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v25]

2025-04-10 Thread Harshitha Onkar
> Built-in Profiles are singleton objects and if the user happens to modify > this shared profile object via setData() then the modified version of the > profile is returned each time the same built-in profile is requested via > getInstance(). > > It is good to protect Built-in profiles from su

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v24]

2025-04-10 Thread Alexey Ivanov
On Thu, 10 Apr 2025 04:15:31 GMT, Harshitha Onkar wrote: >> Built-in Profiles are singleton objects and if the user happens to modify >> this shared profile object via setData() then the modified version of the >> profile is returned each time the same built-in profile is requested via >> getI

Re: RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v24]

2025-04-10 Thread Alexey Ivanov
On Thu, 10 Apr 2025 04:15:31 GMT, Harshitha Onkar wrote: >> Built-in Profiles are singleton objects and if the user happens to modify >> this shared profile object via setData() then the modified version of the >> profile is returned each time the same built-in profile is requested via >> getI

RFR: 8354317: [XWayland] Problem list two tests crashing XWayland server

2025-04-10 Thread Alexander Zvegintsev
Problem list two tests crashing XWayland server Corresponding issue [JDK-8354097](https://bugs.openjdk.org/browse/JDK-8354097) - Commit messages: - 8354317: [XWayland] Problem list two tests crashing XWayland server Changes: https://git.openjdk.org/jdk/pull/24582/files Webrev: htt

RFR: 8354273: Restore even more pointless unicode characters to ASCII

2025-04-10 Thread Magnus Ihse Bursie
As a follow-up to [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some additional places where unicode characters are unnecessarily used instead of pure ASCII. - Commit messages: - 8354273: Restore even more pointless unicode characters to ASCII Changes: https:

Integrated: 8353586: Open source several toolkit tests

2025-04-10 Thread Alexander Zvegintsev
On Tue, 8 Apr 2025 14:40:01 GMT, Alexander Zvegintsev wrote: > A couple of tests are open sourced. This pull request has now been integrated. Changeset: 2ba80d24 Author:Alexander Zvegintsev URL: https://git.openjdk.org/jdk/commit/2ba80d2403f749a7d8d4e64139b796737bbb62bf Stats:

Re: RFR: 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions [v10]

2025-04-10 Thread Alexey Ivanov
On Wed, 9 Apr 2025 23:31:02 GMT, Jeremy Wood wrote: >> JPEG segments can only be 65535-bytes long. (The marker length is expressed >> as 2 bytes.) The problem in this ticket is that we were writing more than >> 65535 bytes to a segment, which later caused parsing errors when we tried to >> rea

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Raffaello Giulietti
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 11:46:45 GMT, Raffaello Giulietti wrote: > I guess the difference at L.1 in the various files is just the BOM? Yes. - PR Review Comment: https://git.openjdk.org/jdk/pull/24566#discussion_r2037357899

Re: RFR: 8352682: Opensource JComponent tests

2025-04-10 Thread Hendrik Schick
On Thu, 10 Apr 2025 06:36:49 GMT, Prasanta Sadhukhan wrote: > Few JComponent tests are opensourced test/jdk/javax/swing/JComponent/bug4247610.java line 109: > 107: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK); > 108: if (failed()) { > 109: throw new RuntimeExcep

Re: RFR: 8352682: Opensource JComponent tests

2025-04-10 Thread Hendrik Schick
On Thu, 10 Apr 2025 06:36:49 GMT, Prasanta Sadhukhan wrote: > Few JComponent tests are opensourced test/jdk/javax/swing/JComponent/bug4247610.java line 86: > 84: > 85: damager.addActionListener(new ActionListener() { > 86: public void actionPerformed(ActionEvent ev

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Raffaello Giulietti
On Thu, 10 Apr 2025 10:14:40 GMT, Magnus Ihse Bursie wrote: >> I have checked the entire code base for incorrect encodings, but luckily >> enough these were the only remaining problems I found. >> >> BOM (byte-order mark) is a method used for distinguishing big and little >> endian UTF-16 enc

Re: RFR: 8354273: Restore even more pointless unicode characters to ASCII [v2]

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 10:36:31 GMT, Magnus Ihse Bursie wrote: >> As a follow-up to >> [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some >> additional places where unicode characters are unnecessarily used instead of >> pure ASCII. > > Magnus Ihse Bursie has updated the pul

Re: RFR: 8354273: Restore even more pointless unicode characters to ASCII [v2]

2025-04-10 Thread Magnus Ihse Bursie
> As a follow-up to [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), > I found some additional places where unicode characters are unnecessarily > used instead of pure ASCII. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revis

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8352687: Opensource few JInternalFrame and JTextField tests [v2]

2025-04-10 Thread Prasanta Sadhukhan
> Few JInternalFrame and JTextField tests are opensourced Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Fix - Changes: - all: https://git.openjdk.org/jdk/pull/24474/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2025-04-10 Thread Eirik Bjørsnøs
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 08:08:02 GMT, Eirik Bjørsnøs wrote: >> If anything, I might be a bit worried that there are more incorrect >> conversions stemming from this PR, that my automated tools and manual >> scanning has not revealed. > > Some observations: > > 1: This PR seems to have been abondo

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Eirik Bjørsnøs
On Thu, 10 Apr 2025 07:32:18 GMT, Magnus Ihse Bursie wrote: >> You don't have to do that, I'm working on an omnibus UTF-8 fixing PR right >> now, where I will include a fix for this as well. > > If anything, I might be a bit worried that there are more incorrect > conversions stemming from this

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 07:31:37 GMT, Magnus Ihse Bursie wrote: >> Right, that `å` looks to have been incorrectly converted during the >> ISO-8859-1 to UTF-8 conversion. (I can't find the script used for conversion >> as this change is from some time ago.) >> >> Since the change occurs in a commen

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-10 Thread Magnus Ihse Bursie
On Wed, 9 Apr 2025 21:26:15 GMT, Justin Lu wrote: >> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties >> line 22: >> >>> 20: # Peter Smolik >>> 21: Cp1250 WINDOWS-1250 0x00FF >>> 22: # Patch attributed to hava...@underdusken.no (H�vard Wigtil) >> >> Th

RFR: 8351913: ToolkitImage renders some gifs wrong

2025-04-10 Thread Jeremy Wood
I do not have much background in LZW compression or in C, but I'm reasonably confident this resolves the problem I'm observing. It looks like the GifImageDecoder was not always correctly handling compression codes after the table reached its limit of ~4096. If anyone has suggestions for improvem

RFR: 8354077: Get rid of offscreenSharingEnabled windows flag

2025-04-10 Thread Sergey Bylokhov
Another unused obsoleted flag removed (offscreenSharingEnabled) from WindowsFlags. Its last usage was eliminated by [JDK-6725214](https://bugs.openjdk.org/browse/JDk-6725214) ("D3D: forward-port the new pipeline from 6u10"), see [commit](https://github.com/openjdk/jdk/commit/e4c9db984fe1a3a9d06