On Tue, 15 Apr 2025 04:32:12 GMT, Abhishek Kumar wrote:
>> Harshitha Onkar has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - review update
>> - review update
>
> test/jdk/javax/swing/JTabbedPane/bug4613811.java line 48:
>
>> 46:
>> 47
On Tue, 15 Apr 2025 17:20:16 GMT, Harshitha Onkar wrote:
>> Following tests are updates as part of this PR:
>>
>> 1. javax/swing/JRootPane/bug4614623.java - manual
>> 2. javax/swing/JTabbedPane/bug4613811.java - manual
>> 3. javax/swing/JWindow/bug4251781.java - manual
>> 4. javax/swing/JFrame/b
On Tue, 15 Apr 2025 20:18:49 GMT, Hendrik Schick wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Limit to 80 cols
>
> test/jdk/java/awt/Multiscreen/DialogTest.java line 210:
>
>> 208: }
>> 209:
> Several multi screen related Applet tests are converted to manual and open
> sourced.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Remove unused variable
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24654
On Tue, 15 Apr 2025 18:29:12 GMT, Alexander Zuev wrote:
>> Clean up and open source three tests related to the KeyEvent mechanics.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Small fixes based on review comments
LGTM
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Wed, 16 Apr 2025 00:00:59 GMT, Damon Nguyen wrote:
>> Open source a few Swing regression tests.
>
> test/jdk/javax/swing/JLabel/bug4945795.java line 61:
>
>> 59: JFrame mainFrame = new JFrame("Bug4945795");
>> 60: try {
>> 61:
>> UIManager.setLookAndFeel(UIManager
On Fri, 11 Apr 2025 05:52:47 GMT, Jayathirth D V wrote:
> Few swing JList tests are open sourced.
This pull request has now been integrated.
Changeset: 2be5bc84
Author:Jayathirth D V
URL:
https://git.openjdk.org/jdk/commit/2be5bc847a444f08a4ebb41b58e8a2bf4553d621
Stats: 340 line
On Thu, 10 Apr 2025 10:36:31 GMT, Magnus Ihse Bursie wrote:
>> As a follow-up to
>> [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some
>> additional places where unicode characters are unnecessarily used instead of
>> pure ASCII.
>
> Magnus Ihse Bursie has updated the pul
On Thu, 10 Apr 2025 06:36:49 GMT, Prasanta Sadhukhan
wrote:
> Few JComponent tests are opensourced
This pull request has now been integrated.
Changeset: 55afcb57
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/55afcb57a5d9dbc7bfad75e35df6b96932f6b074
Stats: 25
On Tue, 15 Apr 2025 10:03:42 GMT, Tejesh R wrote:
> Open source these AWT TextComponent tests:
>
> java/awt/TextComponent/BackgroundTest/BackgroundTest.java
> java/awt/TextComponent/DisableTest/DisableTest.java
> java/awt/TextComponent/TextFieldMargin/TextFieldMargin.java
> java/awt/TextComponen
Open-sourcing and standardizing several tests (windows & JSlider)
-
Commit messages:
- Initial opening
- Merge branch 'master' of github.com:DamonGuy/jdk
- Merge branch 'master' of github.com:DamonGuy/jdk
- Merge branch 'master' of github.com:DamonGuy/jdk
- Merge branch 'master'
On Tue, 15 Apr 2025 22:13:09 GMT, Phil Race wrote:
> Open source a few Swing regression tests.
Ran all manual tests. LGTM.
test/jdk/javax/swing/JLabel/bug4945795.java line 61:
> 59: JFrame mainFrame = new JFrame("Bug4945795");
> 60: try {
> 61:
> UIManager.setLookA
On Wed, 9 Apr 2025 21:47:07 GMT, Damon Nguyen wrote:
> Open-sourcing and standardizing several tests (JSplitPane JApplet JToolBar)
This pull request has now been integrated.
Changeset: a2dc9c71
Author:Damon Nguyen
URL:
https://git.openjdk.org/jdk/commit/a2dc9c71e47a1cdf70ab351c557a5
On Tue, 15 Apr 2025 00:44:17 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/JPopupMenu/bug4234793.java line 84:
>>
>>> 82:
>>> 83: Notice each time you perform a hide/cancel action an
>>> appropriate message should
>>> 84: appear in the log area
>>
>> _"Click to display t
> Open source some more Swing menu tests
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8354451
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24636/files
- new: https://git.openjdk.org/jdk/pull/24636/files/f4e10c4
On Tue, 15 Apr 2025 11:10:19 GMT, Hendrik Schick wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8354451
>
> test/jdk/javax/swing/JPopupMenu/bug4212464.java line 125:
>
>> 123: public void actionPerformed(ActionE
On Tue, 15 Apr 2025 00:23:52 GMT, Harshitha Onkar wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8354451
>
> test/jdk/javax/swing/JPopupMenu/bug4212464.java line 54:
>
>> 52:
>> 53: static String strM
On Tue, 15 Apr 2025 19:37:47 GMT, Damon Nguyen wrote:
>> Open-sourcing and standardizing several tests (JSplitPane JApplet JToolBar)
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update to setPreferredSize
Marked as revi
Open-sourcing and standardizing several tests (basic)
-
Commit messages:
- Update headers
- Initial opening of tests
- Merge branch 'master' of github.com:DamonGuy/jdk
- Merge branch 'master' of github.com:DamonGuy/jdk
- Merge branch 'master' of github.com:DamonGuy/jdk
- Merge b
Open source a few Swing regression tests.
-
Commit messages:
- 8354552
- 83545528354552owd
Changes: https://git.openjdk.org/jdk/pull/24668/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24668&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8354552
Stats: 323 lines
On Mon, 14 Apr 2025 21:52:02 GMT, Phil Race wrote:
> Open source some more Swing menu tests
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 161:
> 159: public void actionPerformed(ActionEvent e){
> 160: if(!popupMenu.isVisible())
> 161: popupMenu.show((C
On Tue, 15 Apr 2025 16:03:55 GMT, Abhishek Kumar wrote:
>> Several multi screen related Applet tests are converted to manual and open
>> sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Limit to 80 cols
test/jdk
On Mon, 14 Apr 2025 21:52:02 GMT, Phil Race wrote:
> Open source some more Swing menu tests
Marked as reviewed by kizune (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24636#pullrequestreview-2769672456
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote:
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
LGTM apart from minor inline suggestion.
Since the test has lot of tab movements, does CI testing look good on all
platforms on mult
On Wed, 9 Apr 2025 22:17:35 GMT, Damon Nguyen wrote:
> Open-sourcing and standardizing several tests (metal)
This pull request has now been integrated.
Changeset: 4e3f1848
Author:Damon Nguyen
URL:
https://git.openjdk.org/jdk/commit/4e3f1848eeb28a78d71c6ffbda31279cee3fc5ea
Stats:
On Fri, 11 Apr 2025 18:05:15 GMT, Harshitha Onkar wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to setPreferredSize
>
> test/jdk/javax/swing/JSplitPane/bug4749792.java line 53:
>
>> 51: JPanel rig
> Open-sourcing and standardizing several tests (JSplitPane JApplet JToolBar)
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Update to setPreferredSize
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24559/files
On Tue, 15 Apr 2025 05:19:38 GMT, Tejesh R wrote:
> Open source these AWT ScrollPane tests:
>
> java/awt/ScrollPane/ScrollPaneSize/ScrollPaneSize.java
> java/awt/ScrollPane/ScrollPaneAsNeededTest/ScrollPaneAsNeededTest.java
> java/awt/ScrollPane/ScrollPaneComponentTest/ScrollPaneComponentTest.ja
On Mon, 14 Apr 2025 11:17:55 GMT, Abhishek Kumar wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Small fixes based on review comments
>
> test/jdk/java/awt/event/KeyEvent/FrenchKeyboard.java line 27:
>
>> 25: *
> Clean up and open source three tests related to the KeyEvent mechanics.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Small fixes based on review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24609/
On Tue, 15 Apr 2025 17:35:10 GMT, Alexander Zuev wrote:
>> Clean up and open source two more tests related to KeyEvent mechanics.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed bug ids list
LGTM
-
Ma
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote:
> Details:
> Refactored code as requested in the Bug description.
>
> Tested and verified the test passes.
Can someone please review this? , it has been more than 10 days that it has
been out there.
Thank you!
-
PR Comment: h
On Mon, 14 Apr 2025 11:15:28 GMT, Abhishek Kumar wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed bug ids list
>
> test/jdk/java/awt/event/KeyEvent/KeyTest.java line 26:
>
>> 24: /*
>> 25: * @test
>> 26:
> Clean up and open source two more tests related to KeyEvent mechanics.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixed bug ids list
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24610/files
- new: http
On Thu, 3 Apr 2025 11:23:42 GMT, Daniel Gredler wrote:
> It looks like this regression actually fits into a longer series of fixes /
> regressions in this area:
>
> - [JDK-4517298](https://bugs.openjdk.org/browse/JDK-4517298) fixed metrics
> for zero-width characters, but broke some ligatures
On Mon, 14 Apr 2025 12:53:59 GMT, Prasanta Sadhukhan
wrote:
>> Few JComponent tests are opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Redundant method removed
Marked as reviewed by honkar (Reviewer).
On Tue, 15 Apr 2025 04:22:15 GMT, Abhishek Kumar wrote:
>> Harshitha Onkar has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - review update
>> - review update
>
> test/jdk/javax/swing/JRootPane/bug4614623.java line 62:
>
>> 60:
> Following tests are updates as part of this PR:
>
> 1. javax/swing/JRootPane/bug4614623.java - manual
> 2. javax/swing/JTabbedPane/bug4613811.java - manual
> 3. javax/swing/JWindow/bug4251781.java - manual
> 4. javax/swing/JFrame/bug4419914.java - manual, updated existing test by
> adding JWind
On Tue, 15 Apr 2025 05:19:38 GMT, Tejesh R wrote:
> Open source these AWT ScrollPane tests:
>
> java/awt/ScrollPane/ScrollPaneSize/ScrollPaneSize.java
> java/awt/ScrollPane/ScrollPaneAsNeededTest/ScrollPaneAsNeededTest.java
> java/awt/ScrollPane/ScrollPaneComponentTest/ScrollPaneComponentTest.ja
Several multi screen related Applet tests are converted to manual and open
sourced.
-
Commit messages:
- Applet test converted and open-sourced
Changes: https://git.openjdk.org/jdk/pull/24654/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24654&range=00
Issue: https://b
On Mon, 14 Apr 2025 12:53:59 GMT, Prasanta Sadhukhan
wrote:
>> Few JComponent tests are opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Redundant method removed
Marked as reviewed by jdv (Reviewer).
---
On Fri, 11 Apr 2025 13:16:58 GMT, Mikhail Yankelevich
wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use lambda
>
> test/jdk/javax/swing/JComponent/bug4247610.java line 29:
>
>> 27: * @summary Tests an un
On Tue, 15 Apr 2025 05:19:38 GMT, Tejesh R wrote:
> Open source these AWT ScrollPane tests:
>
> java/awt/ScrollPane/ScrollPaneSize/ScrollPaneSize.java
> java/awt/ScrollPane/ScrollPaneAsNeededTest/ScrollPaneAsNeededTest.java
> java/awt/ScrollPane/ScrollPaneComponentTest/ScrollPaneComponentTest.ja
Few Swing AbstractButton, JList and JMenu tests are open sourced.
-
Commit messages:
- Update
- 8354163: Open source Swing tests Batch 1
Changes: https://git.openjdk.org/jdk/pull/24650/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24650&range=00
Issue: https://bugs.ope
On Mon, 14 Apr 2025 21:52:02 GMT, Phil Race wrote:
> Open source some more Swing menu tests
test/jdk/javax/swing/JPopupMenu/bug4212464.java line 125:
> 123: public void actionPerformed(ActionEvent e) {
> 124: String str = e.getActionCommand();
> 125: if(str.equals(metalClass
On Tue, 15 Apr 2025 10:50:31 GMT, Tejesh R wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Limit to 80 cols
>
> test/jdk/java/awt/Multiscreen/DialogTest.java line 232:
>
>> 230:
>> 231: public String to
> Several multi screen related Applet tests are converted to manual and open
> sourced.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Limit to 80 cols
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24654/files
Open source these AWT ScrollPane tests:
java/awt/ScrollPane/ScrollPaneSize/ScrollPaneSize.java
java/awt/ScrollPane/ScrollPaneAsNeededTest/ScrollPaneAsNeededTest.java
java/awt/ScrollPane/ScrollPaneComponentTest/ScrollPaneComponentTest.java
java/awt/ScrollPane/ScrollPaneScrollType/ScrollPaneEventTyp
> This test was designed to manually verify that clicking on the JComboBox when
> the frame containing it is about to close does not cause an
> IllegalStateException.
>
> The test allowed the tester extra time to click on the JComboBox when closing
> the frame by adding a Thread.sleep() in the
> This test was designed to manually verify that clicking on the JComboBox when
> the frame containing it is about to close does not cause an
> IllegalStateException.
>
> The test allowed the tester extra time to click on the JComboBox when closing
> the frame by adding a Thread.sleep() in the
On Mon, 14 Apr 2025 23:58:40 GMT, Harshitha Onkar wrote:
> Following tests are updates as part of this PR:
>
> 1. javax/swing/JRootPane/bug4614623.java - manual
> 2. javax/swing/JTabbedPane/bug4613811.java - manual
> 3. javax/swing/JWindow/bug4251781.java - manual
> 4. javax/swing/JFrame/bug4419
On Tue, 15 Apr 2025 11:02:39 GMT, Tejesh R wrote:
>> Open source these AWT TextComponent tests:
>>
>> java/awt/TextComponent/SelectionAndCaretColor/SelectionAndCaretColor.java
>> java/awt/TextComponent/SelectionTest/SelectionTest.java
>> java/awt/TextComponent/CorrectTextComponentSelectionTest/C
On Tue, 15 Apr 2025 07:40:35 GMT, Jayathirth D V wrote:
>> Few swing JList tests are open sourced.
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update after review comments
LGTM now.
-
Marked as reviewed
On Mon, 14 Apr 2025 21:52:02 GMT, Phil Race wrote:
> Open source some more Swing menu tests
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 241:
> 239: // PopupMenuListener methods.
> 240:
> 241: public void popupMenuWillBecomeVisible(PopupMenuEvent e) {
Suggestion:
public
On Mon, 7 Apr 2025 09:04:29 GMT, Hendrik Schick wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated review comments
>
> test/jdk/java/awt/TextComponent/AltPlusNumberKeyCombinationsTest.java line 43:
>
>> 41:
On Mon, 7 Apr 2025 16:41:37 GMT, Phil Race wrote:
>> Open source a few tests related to Swing menus.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8353589
LGTM.
Also tested them on my macOS machine.
-
Marked a
On Tue, 15 Apr 2025 07:09:51 GMT, Jayathirth D V wrote:
> Few Swing AbstractButton, JList and JMenu tests are open sourced.
test/jdk/javax/swing/AbstractButton/bug4133768.java line 41:
> 39: import javax.swing.JToggleButton;
> 40: import javax.swing.SwingUtilities;
> 41: import java.awt.Color;
On Fri, 11 Apr 2025 04:14:49 GMT, Sergey Bylokhov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated review comments
>
> test/jdk/java/awt/TextComponent/SelectionAndCaretColor.java line 130:
>
>> 128: });
On Tue, 15 Apr 2025 09:35:27 GMT, Abhishek Kumar wrote:
> Several multi screen related Applet tests are converted to manual and open
> sourced.
test/jdk/java/awt/Multiscreen/DialogTest.java line 232:
> 230:
> 231: public String toString() {
> 232: return "Screen " + num +
> Open source these AWT TextComponent tests:
>
> java/awt/TextComponent/SelectionAndCaretColor/SelectionAndCaretColor.java
> java/awt/TextComponent/SelectionTest/SelectionTest.java
> java/awt/TextComponent/CorrectTextComponentSelectionTest/CorrectTextComponentSelectionTest.java
> java/awt/TextComp
Open source these AWT TextComponent tests:
java/awt/TextComponent/BackgroundTest/BackgroundTest.java
java/awt/TextComponent/DisableTest/DisableTest.java
java/awt/TextComponent/TextFieldMargin/TextFieldMargin.java
java/awt/TextComponent/ModifiersTest/ModifiersTest.java
-
Commit messag
On Tue, 15 Apr 2025 08:03:16 GMT, Jayathirth D V wrote:
>> Few Swing AbstractButton, JList and JMenu tests are open sourced.
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update after review comments
Marked as reviewed
On Tue, 15 Apr 2025 07:09:51 GMT, Jayathirth D V wrote:
> Few Swing AbstractButton, JList and JMenu tests are open sourced.
This pull request has now been integrated.
Changeset: b7837843
Author:Jayathirth D V
URL:
https://git.openjdk.org/jdk/commit/b78378437cf911a527331e6aaf36f96816
On Tue, 15 Apr 2025 07:28:39 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/AbstractButton/bug4133768.java line 54:
>>
>>> 52: private static AbstractButton[] buttons;
>>> 53: private static Point buttonLocation;
>>> 54: private static int buttonWidth, buttonHeight;
>>
>> d
On Tue, 15 Apr 2025 07:26:44 GMT, Prasanta Sadhukhan
wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update after review comments
>
> test/jdk/javax/swing/AbstractButton/bug4133768.java line 41:
>
>> 39: import
> Few Swing AbstractButton, JList and JMenu tests are open sourced.
Jayathirth D V has updated the pull request incrementally with one additional
commit since the last revision:
Update after review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24650/files
- new:
On Tue, 15 Apr 2025 07:26:58 GMT, Prasanta Sadhukhan
wrote:
>> Few Swing AbstractButton, JList and JMenu tests are open sourced.
>
> test/jdk/javax/swing/AbstractButton/bug4133768.java line 54:
>
>> 52: private static AbstractButton[] buttons;
>> 53: private static Point buttonLocation;
> Few swing JList tests are open sourced.
Jayathirth D V has updated the pull request incrementally with one additional
commit since the last revision:
Update after review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24588/files
- new: https://git.openjdk.org/j
On Mon, 14 Apr 2025 11:26:18 GMT, Abhishek Kumar wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update after review
>
> test/jdk/javax/swing/JList/bug4193267.java line 44:
>
>> 42: import java.awt.Color;
>> 43:
70 matches
Mail list logo
