Re: RFR: 8354365: Opensource few Modal and Full Screen related tests [v2]

2025-04-16 Thread Abhishek Kumar
> Few Modal and Full Screen related tests are converted from applet and open > sourced. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Review fix - Changes: - all: https://git.openjdk.org/jdk/pull/24685/files - n

Re: RFR: 8354191: GTK LaF should use pre-multiplied alpha same as cairo

2025-04-16 Thread duke
On Wed, 9 Apr 2025 14:42:05 GMT, Maxim Kartashev wrote: > The pixels that cairo produces for GTK LaF to draw on a Swing component have > their alpha components pre-multiplied as per [the > documentation](https://www.cairographics.org/manual/cairo-Image-Surfaces.html?spm=a2ty_o01.29997173.0.0.54

Re: RFR: 8354365: Opensource few Modal and Full Screen related tests [v2]

2025-04-16 Thread Tejesh R
On Thu, 17 Apr 2025 06:31:03 GMT, Abhishek Kumar wrote: >> Few Modal and Full Screen related tests are converted from applet and open >> sourced. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix Marked as revi

Integrated: 8352865: Open source several AWT TextComponent tests - Batch 2

2025-04-16 Thread Tejesh R
On Mon, 7 Apr 2025 07:24:31 GMT, Tejesh R wrote: > Open source these AWT TextComponent tests: > > java/awt/TextComponent/SelectionAndCaretColor/SelectionAndCaretColor.java > java/awt/TextComponent/SelectionTest/SelectionTest.java > java/awt/TextComponent/CorrectTextComponentSelectionTest/Correct

Re: RFR: 8354365: Opensource few Modal and Full Screen related tests [v2]

2025-04-16 Thread Abhishek Kumar
On Wed, 16 Apr 2025 13:49:49 GMT, Tejesh R wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review fix > > test/jdk/java/awt/FullScreen/NonfocusableFrameFullScreenTest.java line 128: > >> 126:

Re: RFR: JDK-8353942 : Open source Swing Tests - Set 5 [v3]

2025-04-16 Thread Harshitha Onkar
> Following test are open-sourced in this PR: > > - javax/swing/DataTransfer/DragOverFeedbackTest.java - manual > - javax/swing/DataTransfer/ListDragOverFeedbackTest.java - manual > - javax/swing/DataTransfer/bug4655513.java - automated > - javax/swing/SwingUtilities/bug4369355.java - automated >

Re: RFR: 8354418: Open source Swing tests Batch 4 [v2]

2025-04-16 Thread Jayathirth D V
> Open source some of the swing windows LAF tests Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Update after review comment - Changes: - all: https://git.openjdk.org/jdk/pull/24678/files - new: https://git.openjd

Re: RFR: 8354285: Open source Swing tests Batch 3 [v2]

2025-04-16 Thread Jayathirth D V
> Open source some of the swing LAF tests Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Update after review - Changes: - all: https://git.openjdk.org/jdk/pull/24677/files - new: https://git.openjdk.org/jdk/pull/2

Re: RFR: 8354285: Open source Swing tests Batch 3 [v2]

2025-04-16 Thread Jayathirth D V
On Thu, 17 Apr 2025 04:24:57 GMT, Abhishek Kumar wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review > > test/jdk/com/sun/java/swing/plaf/windows/MenuItem/4685843/bug4685843.java > line 75: > >>

Re: RFR: 8354552: Open source a few Swing tests

2025-04-16 Thread Prasanta Sadhukhan
On Tue, 15 Apr 2025 22:13:09 GMT, Phil Race wrote: > Open source a few Swing regression tests. Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24668#pullrequestreview-2774594125

Re: RFR: 8354493: Opensource Several MultiScreen and Insets related tests [v4]

2025-04-16 Thread Prasanta Sadhukhan
On Thu, 17 Apr 2025 05:43:16 GMT, Abhishek Kumar wrote: >> Several multi screen related Applet tests are converted to manual and open >> sourced. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Minor updates Marked as r

Re: RFR: 8354493: Opensource Several MultiScreen and Insets related tests [v4]

2025-04-16 Thread Abhishek Kumar
> Several multi screen related Applet tests are converted to manual and open > sourced. Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision: Minor updates - Changes: - all: https://git.openjdk.org/jdk/pull/24654/files

Re: RFR: 8354418: Open source Swing tests Batch 4

2025-04-16 Thread Abhishek Kumar
On Wed, 16 Apr 2025 08:54:29 GMT, Jayathirth D V wrote: > Open source some of the swing windows LAF tests test/jdk/com/sun/java/swing/plaf/windows/MenuItem/AcceleratorDelimiter/WindowsLAFMenuAcceleratorDelimiter.java line 64: > 62: Windows = "+". > 63: > 64: This test

Re: RFR: 8354285: Open source Swing tests Batch 3

2025-04-16 Thread Abhishek Kumar
On Wed, 16 Apr 2025 08:42:20 GMT, Jayathirth D V wrote: > Open source some of the swing LAF tests test/jdk/com/sun/java/swing/plaf/windows/MenuItem/4685843/bug4685843.java line 75: > 73: > 74: jMenu.setText("File"); > 75: jMenuItem.setText("JMenuItem"); minor changes: You can

Re: Proposal: A new common Image API

2025-04-16 Thread Philip Race
First, note than John Neffenger replied to this but only on openjfx-dev and the first thing I saw was the reply and couldn't see the original. After some consternation I tracked down this cross-post. Here's a link to the reply https://mail.openjdk.org/pipermail/openjfx-dev/2025-April/053616.html

Re: RFR: 8354561: Open source several swing tests batch0 [v2]

2025-04-16 Thread Alexander Zvegintsev
> Few more tests open sourced: > > javax/swing/JTextArea/4474400/bug4474400.java > javax/swing/border/TitledBorder/TransparentTitleTest.java > javax/swing/JComboBox/4139900/bug4139900.java > javax/swing/JComboBox/4174876/bug4174876.java Alexander Zvegintsev has updated the pull request incrementa

Re: RFR: JDK-8353486 : Open source Swing Tests - Set 4 [v3]

2025-04-16 Thread Alexander Zvegintsev
On Tue, 8 Apr 2025 22:45:31 GMT, Harshitha Onkar wrote: >> Open-sourced the following Swing tests: >> >> 1. javax/swing/JFileChooser/bug4464774.java >> 2. javax/swing/JFileChooser/bug4522756.java >> 3. javax/swing/JFileChooser/bug4759934.java >> 4. javax/swing/JFileChooser/bug4943900.java >> 5.

Re: RFR: JDK-8354340 : Open source Swing Tests - Set 6 [v2]

2025-04-16 Thread Alexander Zvegintsev
On Wed, 16 Apr 2025 20:20:24 GMT, Harshitha Onkar wrote: >> Following tests are open-sourced in this PR: >> >> - javax/swing/JViewport/ScrollRectToVisibleTest3.java - automated >> - javax/swing/JViewport/SetViewRepaint.java - manual > > Harshitha Onkar has updated the pull request incrementally

Re: RFR: JDK-8354340 : Open source Swing Tests - Set 6 [v2]

2025-04-16 Thread Harshitha Onkar
On Wed, 16 Apr 2025 22:28:49 GMT, Sergey Bylokhov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> extra newline > > test/jdk/javax/swing/JViewport/ScrollRectToVisibleTest3.java line 67: > >> 65: Rectang

Re: RFR: 8354451: Open source some more Swing popup menu tests [v2]

2025-04-16 Thread Phil Race
On Wed, 16 Apr 2025 08:13:27 GMT, Andrey Turbanov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8354451 > > test/jdk/javax/swing/JPopupMenu/bug4234793.java line 105: > >> 103: }; >> 104: >> 105: private st

Re: RFR: JDK-8353319 : Open source Swing tests - Set 3 [v3]

2025-04-16 Thread Harshitha Onkar
> Following tests are updates as part of this PR: > > 1. javax/swing/JRootPane/bug4614623.java - manual > 2. javax/swing/JTabbedPane/bug4613811.java - manual > 3. javax/swing/JWindow/bug4251781.java - manual > 4. javax/swing/JFrame/bug4419914.java - manual, updated existing test by > adding JWind

Re: RFR: JDK-8353319 : Open source Swing tests - Set 3 [v3]

2025-04-16 Thread Harshitha Onkar
On Wed, 16 Apr 2025 20:02:17 GMT, Damon Nguyen wrote: >> Did you miss this? > > Confirmed the same. May be platform specific. > ![image](https://github.com/user-attachments/assets/532cd1cd-93ef-4e4a-b810-de75cf1484ef) > ![image](https://github.com/user-attachments/assets/d910e179-cd45-4eca-a00a-3

Re: RFR: JDK-8354340 : Open source Swing Tests - Set 6 [v2]

2025-04-16 Thread Sergey Bylokhov
On Wed, 16 Apr 2025 20:20:24 GMT, Harshitha Onkar wrote: >> Following tests are open-sourced in this PR: >> >> - javax/swing/JViewport/ScrollRectToVisibleTest3.java - automated >> - javax/swing/JViewport/SetViewRepaint.java - manual > > Harshitha Onkar has updated the pull request incrementally

Re: RFR: JDK-8353942 : Open source Swing Tests - Set 5 [v2]

2025-04-16 Thread Harshitha Onkar
On Wed, 16 Apr 2025 22:27:38 GMT, Sergey Bylokhov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> @requires tag > > test/jdk/javax/swing/DataTransfer/bug4655513.java line 76: > >> 74: robot.delay(50

RFR: 8354466: Open some misc Swing bugs 9

2025-04-16 Thread Alisen Chung
Updating and opening some misc swing bugs - Commit messages: - opening tests Changes: https://git.openjdk.org/jdk/pull/24703/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24703&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8354466 Stats: 175 lines in 2 files cha

Re: RFR: 8354191: GTK LaF should use pre-multiplied alpha same as cairo

2025-04-16 Thread Sergey Bylokhov
On Fri, 11 Apr 2025 06:01:32 GMT, Maxim Kartashev wrote: >> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKEngine.java >> line 618: >> >>> 616: int index = transparency - 1; >>> 617: if (COLOR_MODELS[index] == null) { >>> 618: COLOR_MODELS

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v6]

2025-04-16 Thread Sergey Bylokhov
On Tue, 4 Mar 2025 21:19:09 GMT, Alexey Ivanov wrote: >> I think as of now it should be good enough, why do you think volatile will >> not help here? > >> I think as of now it should be good enough > > That's the problem, the presence of the `volatile` modifier creates a false > sense of threa

Re: RFR: JDK-8353942 : Open source Swing Tests - Set 5 [v2]

2025-04-16 Thread Sergey Bylokhov
On Wed, 16 Apr 2025 21:13:46 GMT, Harshitha Onkar wrote: >> Following test are open-sourced in this PR: >> >> - javax/swing/DataTransfer/DragOverFeedbackTest.java - manual >> - javax/swing/DataTransfer/ListDragOverFeedbackTest.java - manual >> - javax/swing/DataTransfer/bug4655513.java - automat

Re: RFR: 8353957: Open source several AWT ScrollPane tests - Batch 1

2025-04-16 Thread Sergey Bylokhov
On Wed, 16 Apr 2025 11:24:47 GMT, Tejesh R wrote: > Open source these AWT ScrollPane tests: > > java/awt/ScrollPane/ScrollPaneFlicker/ScrollPaneFlicker.java > java/awt/ScrollPane/ScrollbarsAsNeeded/ScrollbarsAsNeededTest.java > java/awt/ScrollPane/ScrollPanePaint/ScrollPanePaint.java > java/awt/

Re: RFR: 8352865: Open source several AWT TextComponent tests - Batch 2 [v3]

2025-04-16 Thread Sergey Bylokhov
On Wed, 16 Apr 2025 13:19:50 GMT, Tejesh R wrote: >> Open source these AWT TextComponent tests: >> >> java/awt/TextComponent/SelectionAndCaretColor/SelectionAndCaretColor.java >> java/awt/TextComponent/SelectionTest/SelectionTest.java >> java/awt/TextComponent/CorrectTextComponentSelectionTest/C

Re: RFR: 8352905: Open some JComboBox bugs 1 [v2]

2025-04-16 Thread Sergey Bylokhov
On Wed, 16 Apr 2025 08:22:19 GMT, Alisen Chung wrote: >> Updating and opening some tests > > Alisen Chung has updated the pull request incrementally with two additional > commits since the last revision: > > - update tests > - update tests test/jdk/javax/swing/JComboBox/bug4530952.java line

Re: RFR: 8352407: PixelInterleavedSampleModel with unused components throws RasterFormatException: Incorrect pixel stride [v2]

2025-04-16 Thread Sergey Bylokhov
On Thu, 3 Apr 2025 09:26:03 GMT, Nikita Gubarkov wrote: >>>I just accepted any pixel-interleaved surface with 4-byte stride and assumed >>>that I can blit it directly. >> >> So you implemented logic similar to [this >> one](https://github.com/openjdk/jdk/blob/bd74922157230c866802b4c5269da81e8

Re: RFR: JDK-8353942 : Open source Swing Tests - Set 5 [v2]

2025-04-16 Thread Harshitha Onkar
> Following test are open-sourced in this PR: > > - javax/swing/DataTransfer/DragOverFeedbackTest.java - manual > - javax/swing/DataTransfer/ListDragOverFeedbackTest.java - manual > - javax/swing/DataTransfer/bug4655513.java - automated > - javax/swing/SwingUtilities/bug4369355.java - automated >

RFR: JDK-8353942 : Open source Swing Tests - Set 5

2025-04-16 Thread Harshitha Onkar
Following test are open-sourced in this PR: - javax/swing/DataTransfer/DragOverFeedbackTest.java - manual - javax/swing/DataTransfer/ListDragOverFeedbackTest.java - manual - javax/swing/DataTransfer/bug4655513.java - automated - javax/swing/SwingUtilities/bug4369355.java - automated - javax/swing/

Re: RFR: JDK-8353942 : Open source Swing Tests - Set 5 [v2]

2025-04-16 Thread Damon Nguyen
On Wed, 16 Apr 2025 21:09:52 GMT, Harshitha Onkar wrote: >> test/jdk/javax/swing/DataTransfer/ListDragOverFeedbackTest.java line 101: >> >>> 99: list2.setLayoutOrientation(JList.VERTICAL_WRAP); >>> 100: list2.setTransferHandler(handler); >>> 101: list2.setBorder(BorderFac

Re: RFR: JDK-8353942 : Open source Swing Tests - Set 5

2025-04-16 Thread Harshitha Onkar
On Wed, 16 Apr 2025 20:52:28 GMT, Damon Nguyen wrote: >> Following test are open-sourced in this PR: >> >> - javax/swing/DataTransfer/DragOverFeedbackTest.java - manual >> - javax/swing/DataTransfer/ListDragOverFeedbackTest.java - manual >> - javax/swing/DataTransfer/bug4655513.java - automated

Re: RFR: JDK-8353942 : Open source Swing Tests - Set 5 [v2]

2025-04-16 Thread Harshitha Onkar
On Wed, 16 Apr 2025 20:53:38 GMT, Damon Nguyen wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> @requires tag > > test/jdk/javax/swing/DataTransfer/ListDragOverFeedbackTest.java line 101: > >> 99: list2.

Re: RFR: 8353213: Open source several swing tests batch3

2025-04-16 Thread Phil Race
On Tue, 15 Apr 2025 22:28:01 GMT, Damon Nguyen wrote: > Open-sourcing and standardizing several tests (basic) Marked as reviewed by prr (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24670#pullrequestreview-2773851456

Re: RFR: 8352793: Open source several AWT TextComponent tests - Batch 1 [v2]

2025-04-16 Thread Phil Race
On Wed, 16 Apr 2025 13:41:33 GMT, Tejesh R wrote: >> Open source these AWT TextComponent tests: >> >> java/awt/TextComponent/BackgroundTest/BackgroundTest.java >> java/awt/TextComponent/DisableTest/DisableTest.java >> java/awt/TextComponent/TextFieldMargin/TextFieldMargin.java >> java/awt/TextCo

Re: RFR: 8353445: Open source several AWT Menu tests - Batch 1

2025-04-16 Thread Phil Race
On Tue, 15 Apr 2025 06:14:33 GMT, Tejesh R wrote: > Open source these AWT Menu tests: > > java/awt/Menu/MenuVisibilityTest/MenuVisibilityTest.java > java/awt/Menu/MenuActionEventTest/MenuActionEventTest.java > java/awt/Menu/RmInHideTest/RmInHideTest.java > java/awt/Menu/SetShortCutTest/SetShortC

Re: RFR: JDK-8353942 : Open source Swing Tests - Set 5

2025-04-16 Thread Damon Nguyen
On Wed, 16 Apr 2025 20:37:19 GMT, Harshitha Onkar wrote: > Following test are open-sourced in this PR: > > - javax/swing/DataTransfer/DragOverFeedbackTest.java - manual > - javax/swing/DataTransfer/ListDragOverFeedbackTest.java - manual > - javax/swing/DataTransfer/bug4655513.java - automated >

Re: RFR: 8354451: Open source some more Swing popup menu tests [v2]

2025-04-16 Thread Phil Race
On Wed, 16 Apr 2025 20:29:49 GMT, Phil Race wrote: >> test/jdk/javax/swing/JPopupMenu/bug4234793.java line 97: >> >>> 95: } >>> 96: >>> 97: private static String[] numData = { >> >> Suggestion: >> >> private static String[] numData = { > > updated fixed - PR Review

Re: RFR: 8353958: Open source several AWT ScrollPane tests - Batch 2 [v2]

2025-04-16 Thread Phil Race
On Wed, 16 Apr 2025 13:38:24 GMT, Tejesh R wrote: >> Open source these AWT ScrollPane tests: >> >> java/awt/ScrollPane/ScrollPaneSize/ScrollPaneSize.java >> java/awt/ScrollPane/ScrollPaneAsNeededTest/ScrollPaneAsNeededTest.java >> java/awt/ScrollPane/ScrollPaneComponentTest/ScrollPaneComponentTe

Re: RFR: JDK-8353319 : Open source Swing tests - Set 3 [v2]

2025-04-16 Thread Damon Nguyen
On Wed, 16 Apr 2025 06:44:55 GMT, Abhishek Kumar wrote: >> test/jdk/javax/swing/JTabbedPane/bug4613811.java line 48: >> >>> 46: >>> 47: If the last tab (Tab 5) is visible, the right arrow >>> 48: button should be disabled. >> >> on macOS, >> >> When the 1st tab is visi

Re: RFR: 8354451: Open source some more Swing popup menu tests [v3]

2025-04-16 Thread Phil Race
> Open source some more Swing menu tests Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8354451 - Changes: - all: https://git.openjdk.org/jdk/pull/24636/files - new: https://git.openjdk.org/jdk/pull/24636/files/47f76fa

Re: RFR: 8354451: Open source some more Swing popup menu tests [v2]

2025-04-16 Thread Phil Race
On Wed, 16 Apr 2025 08:13:15 GMT, Andrey Turbanov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8354451 > > test/jdk/javax/swing/JPopupMenu/bug4234793.java line 97: > >> 95: } >> 96: >> 97: private static

Re: RFR: JDK-8354340 : Open source Swing Tests - Set 6 [v2]

2025-04-16 Thread Harshitha Onkar
> Following tests are open-sourced in this PR: > > - javax/swing/JViewport/ScrollRectToVisibleTest3.java - automated > - javax/swing/JViewport/SetViewRepaint.java - manual Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: extra newl

RFR: JDK-8354340 : Open source Swing Tests - Set 6

2025-04-16 Thread Harshitha Onkar
Following tests are open-sourced in this PR: - javax/swing/JViewport/ScrollRectToVisibleTest3.java - automated - javax/swing/JViewport/SetViewRepaint.java - manual - Commit messages: - swing tests set6 Changes: https://git.openjdk.org/jdk/pull/24697/files Webrev: https://webrevs.

Re: RFR: 8354106: Clean up and open source KeyEvent related tests (Part 2) [v2]

2025-04-16 Thread Phil Race
On Tue, 15 Apr 2025 17:35:10 GMT, Alexander Zuev wrote: >> Clean up and open source two more tests related to KeyEvent mechanics. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed bug ids list Marked as reviewed by p

Re: RFR: 8353655: Clean up and open source KeyEvent related tests (Part 1) [v2]

2025-04-16 Thread Phil Race
On Tue, 15 Apr 2025 18:29:12 GMT, Alexander Zuev wrote: >> Clean up and open source three tests related to the KeyEvent mechanics. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Small fixes based on review comments test

Re: RFR: 8354191: GTK LaF should use pre-multiplied alpha same as cairo

2025-04-16 Thread Phil Race
On Wed, 9 Apr 2025 14:42:05 GMT, Maxim Kartashev wrote: > The pixels that cairo produces for GTK LaF to draw on a Swing component have > their alpha components pre-multiplied as per [the > documentation](https://www.cairographics.org/manual/cairo-Image-Surfaces.html?spm=a2ty_o01.29997173.0.0.54

Re: RFR: 8354077: Get rid of offscreenSharingEnabled windows flag

2025-04-16 Thread Phil Race
On Wed, 9 Apr 2025 03:16:38 GMT, Sergey Bylokhov wrote: > Another unused obsoleted flag removed (offscreenSharingEnabled) from > WindowsFlags. Its last usage was eliminated by > [JDK-6725214](https://bugs.openjdk.org/browse/JDk-6725214) ("D3D: > forward-port the new pipeline from 6u10"), see

Re: RFR: 8334016: Make PrintNullString.java semi-automatic

2025-04-16 Thread Phil Race
On Tue, 8 Apr 2025 08:58:45 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > I have updated the test and made it semi-automatic (need to click "Print") . > Test will initiate a print and result will be generated automatic. > > Please review and let me know your suggestions. I don'

Re: RFR: 8353007: Open some JComboBox bugs 2 [v3]

2025-04-16 Thread Phil Race
On Wed, 16 Apr 2025 08:33:38 GMT, Alisen Chung wrote: >> Updating and opening some tests > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > update tests test/jdk/javax/swing/JComboBox/bug4201964.java line 52: > 50:

Re: RFR: 8352865: Open source several AWT TextComponent tests - Batch 2 [v3]

2025-04-16 Thread Phil Race
On Wed, 16 Apr 2025 13:19:50 GMT, Tejesh R wrote: >> Open source these AWT TextComponent tests: >> >> java/awt/TextComponent/SelectionAndCaretColor/SelectionAndCaretColor.java >> java/awt/TextComponent/SelectionTest/SelectionTest.java >> java/awt/TextComponent/CorrectTextComponentSelectionTest/C

Integrated: 8353589: Open source a few Swing menu-related tests

2025-04-16 Thread Phil Race
On Fri, 4 Apr 2025 20:30:50 GMT, Phil Race wrote: > Open source a few tests related to Swing menus. This pull request has now been integrated. Changeset: 98dac46a Author:Phil Race URL: https://git.openjdk.org/jdk/commit/98dac46aac2cea9790c1275208cc4c92e8e9a98a Stats: 294 lines i

Integrated: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI

2025-04-16 Thread Damon Nguyen
On Wed, 16 Apr 2025 16:46:02 GMT, Damon Nguyen wrote: > Test has a check for a red-ish color, but the range for the green and the > blue values were too loose. A light enough grey would still pass (ex: 200, > 190, 190). Reduced these from 200 to 80. Checked the color 200, 80, 80 on an > rgb co

Re: RFR: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI [v2]

2025-04-16 Thread Harshitha Onkar
On Wed, 16 Apr 2025 17:13:43 GMT, Damon Nguyen wrote: >> Test has a check for a red-ish color, but the range for the green and the >> blue values were too loose. A light enough grey would still pass (ex: 200, >> 190, 190). Reduced these from 200 to 80. Checked the color 200, 80, 80 on an >> rg

Re: RFR: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI

2025-04-16 Thread Damon Nguyen
On Wed, 16 Apr 2025 17:00:00 GMT, Harshitha Onkar wrote: > It is better to test it at uiScale of 1 especially on windows to avoid > fractional pixels side effects with `robot.getPixelColor` although this might > not be a problem on CI. > > ` * @run main/othervm -Dsun.java2d.uiScale=1 bug495246

Re: RFR: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI [v2]

2025-04-16 Thread Damon Nguyen
> Test has a check for a red-ish color, but the range for the green and the > blue values were too loose. A light enough grey would still pass (ex: 200, > 190, 190). Reduced these from 200 to 80. Checked the color 200, 80, 80 on an > rgb color wheel to decide that this color was red enough as th

Re: RFR: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI

2025-04-16 Thread Harshitha Onkar
On Wed, 16 Apr 2025 16:46:02 GMT, Damon Nguyen wrote: > Test has a check for a red-ish color, but the range for the green and the > blue values were too loose. A light enough grey would still pass (ex: 200, > 190, 190). Reduced these from 200 to 80. Checked the color 200, 80, 80 on an > rgb co

RFR: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI

2025-04-16 Thread Damon Nguyen
Test has a check for a red-ish color, but the range for the green and the blue values were too loose. A light enough grey would still pass (ex: 200, 190, 190). Reduced these from 200 to 80. Checked the color 200, 80, 80 on an rgb color wheel to decide that this color was red enough as the beginn

Re: RFR: 8354561: Open source several swing tests batch0

2025-04-16 Thread Tejesh R
On Wed, 16 Apr 2025 10:09:48 GMT, Alexander Zvegintsev wrote: > Few more tests open sourced: > > javax/swing/JTextArea/4474400/bug4474400.java > javax/swing/border/TitledBorder/TransparentTitleTest.java > javax/swing/JComboBox/4139900/bug4139900.java > javax/swing/JComboBox/4174876/bug4174876.j

Re: RFR: 8354365: Opensource few Modal and Full Screen related tests

2025-04-16 Thread Tejesh R
On Wed, 16 Apr 2025 11:27:22 GMT, Abhishek Kumar wrote: > Few Modal and Full Screen related tests are converted from applet and open > sourced. test/jdk/java/awt/FullScreen/NonfocusableFrameFullScreenTest.java line 128: > 126: frame.setAlwaysOnTop(true); > 127:

Re: RFR: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer [v3]

2025-04-16 Thread Alexey Ivanov
On Wed, 16 Apr 2025 13:40:10 GMT, Andrey Turbanov wrote: >> There is redundant `null` comparison in >> `sun.awt.windows.WToolkit.getFontPeer` >> Local variable `retval` can't be null after new object assignment. >> https://github.com/openjdk/jdk/blob/24de9dee80738fe6ab1fc726b071546c85bbf79a/src/

Re: RFR: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer [v3]

2025-04-16 Thread Andrey Turbanov
> There is redundant `null` comparison in `sun.awt.windows.WToolkit.getFontPeer` > Local variable `retval` can't be null after new object assignment. > https://github.com/openjdk/jdk/blob/24de9dee80738fe6ab1fc726b071546c85bbf79a/src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java#L604-L6

Re: RFR: 8352793: Open source several AWT TextComponent tests - Batch 1 [v2]

2025-04-16 Thread Tejesh R
On Wed, 16 Apr 2025 08:12:27 GMT, Andrey Turbanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/TextComponent/DisableTest.java line 88: > >> 86: ActionListener a

Re: RFR: 8352793: Open source several AWT TextComponent tests - Batch 1 [v2]

2025-04-16 Thread Tejesh R
On Wed, 16 Apr 2025 00:08:40 GMT, Damon Nguyen wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/TextComponent/BackgroundTest.java line 57: > >> 55:On li

Re: RFR: 8352793: Open source several AWT TextComponent tests - Batch 1 [v2]

2025-04-16 Thread Tejesh R
> Open source these AWT TextComponent tests: > > java/awt/TextComponent/BackgroundTest/BackgroundTest.java > java/awt/TextComponent/DisableTest/DisableTest.java > java/awt/TextComponent/TextFieldMargin/TextFieldMargin.java > java/awt/TextComponent/ModifiersTest/ModifiersTest.java Tejesh R has upd

Re: RFR: 8353958: Open source several AWT ScrollPane tests - Batch 2 [v2]

2025-04-16 Thread Tejesh R
On Tue, 15 Apr 2025 14:29:20 GMT, Hendrik Schick wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/ScrollPane/ScrollPaneComponentTest.java line 52: > >> 50:

Re: RFR: 8353958: Open source several AWT ScrollPane tests - Batch 2 [v2]

2025-04-16 Thread Tejesh R
> Open source these AWT ScrollPane tests: > > java/awt/ScrollPane/ScrollPaneSize/ScrollPaneSize.java > java/awt/ScrollPane/ScrollPaneAsNeededTest/ScrollPaneAsNeededTest.java > java/awt/ScrollPane/ScrollPaneComponentTest/ScrollPaneComponentTest.java > java/awt/ScrollPane/ScrollPaneScrollType/Scroll

Re: RFR: 8352865: Open source several AWT TextComponent tests - Batch 2 [v2]

2025-04-16 Thread Tejesh R
On Tue, 15 Apr 2025 12:28:33 GMT, Jayathirth D V wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/TextComponent/AltPlusNumberKeyCombinationsTest.java line 65: > >> 63: >>

Re: RFR: 8352865: Open source several AWT TextComponent tests - Batch 2 [v3]

2025-04-16 Thread Tejesh R
> Open source these AWT TextComponent tests: > > java/awt/TextComponent/SelectionAndCaretColor/SelectionAndCaretColor.java > java/awt/TextComponent/SelectionTest/SelectionTest.java > java/awt/TextComponent/CorrectTextComponentSelectionTest/CorrectTextComponentSelectionTest.java > java/awt/TextComp

Re: RFR: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer [v2]

2025-04-16 Thread Alexey Ivanov
On Wed, 16 Apr 2025 13:06:27 GMT, Andrey Turbanov wrote: >> There is redundant `null` comparison in >> `sun.awt.windows.WToolkit.getFontPeer` >> Local variable `retval` can't be null after new object assignment. >> https://github.com/openjdk/jdk/blob/24de9dee80738fe6ab1fc726b071546c85bbf79a/src/

Re: RFR: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer [v2]

2025-04-16 Thread Andrey Turbanov
> There is redundant `null` comparison in `sun.awt.windows.WToolkit.getFontPeer` > Local variable `retval` can't be null after new object assignment. > https://github.com/openjdk/jdk/blob/24de9dee80738fe6ab1fc726b071546c85bbf79a/src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java#L604-L6

Re: RFR: 8354561: Open source several swing tests batch0

2025-04-16 Thread Prasanta Sadhukhan
On Wed, 16 Apr 2025 10:09:48 GMT, Alexander Zvegintsev wrote: > Few more tests open sourced: > > javax/swing/JTextArea/4474400/bug4474400.java > javax/swing/border/TitledBorder/TransparentTitleTest.java > javax/swing/JComboBox/4139900/bug4139900.java > javax/swing/JComboBox/4174876/bug4174876.j

Re: RFR: 8354791: Use Hashtable.putIfAbsent in CSS constructor

2025-04-16 Thread Alexey Ivanov
On Tue, 12 Nov 2024 09:13:07 GMT, Andrey Turbanov wrote: > We can use Hashtable.putIfAbsent instead of pair `get`/`put` methods. > It's faster and cleaner. Marked as reviewed by aivanov (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22032#pullrequestreview-2772382527

Re: RFR: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer

2025-04-16 Thread Alexey Ivanov
On Thu, 16 Jan 2025 12:03:50 GMT, Andrey Turbanov wrote: > There is redundant `null` comparison in `sun.awt.windows.WToolkit.getFontPeer` > Local variable `retval` can't be null after new object assignment. > https://github.com/openjdk/jdk/blob/24de9dee80738fe6ab1fc726b071546c85bbf79a/src/java.de

Re: RFR: 8354493: Opensource Several MultiScreen and Insets related tests [v3]

2025-04-16 Thread Prasanta Sadhukhan
On Wed, 16 Apr 2025 06:17:27 GMT, Abhishek Kumar wrote: >> Several multi screen related Applet tests are converted to manual and open >> sourced. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Remove unused variable Ma

RFR: 8354365: Opensource few Modal and Full Screen related tests

2025-04-16 Thread Abhishek Kumar
Few Modal and Full Screen related tests are converted from applet and open sourced. - Commit messages: - Typo in Problemlist file - Converted from applet and open sourced Changes: https://git.openjdk.org/jdk/pull/24685/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24685

Re: Integrated: Merge ed30fce6df57b1cbf7a6efebabc3558550f8ec16

2025-04-16 Thread Jaikiran Pai
On Wed, 16 Apr 2025 11:20:36 GMT, Jaikiran Pai wrote: > This brings in the CPU25_04 changes into the master branch. Thank you Daniel for the review. - PR Comment: https://git.openjdk.org/jdk/pull/24683#issuecomment-2809280611

Integrated: Merge ed30fce6df57b1cbf7a6efebabc3558550f8ec16

2025-04-16 Thread Jaikiran Pai
This brings in the CPU25_04 changes into the master branch. - Commit messages: The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk/pull/24683/files Stats: 0 lines in 0 files changed: 0 ins; 0 del;

Integrated: Merge ed30fce6df57b1cbf7a6efebabc3558550f8ec16

2025-04-16 Thread Jaikiran Pai
On Wed, 16 Apr 2025 11:20:36 GMT, Jaikiran Pai wrote: > This brings in the CPU25_04 changes into the master branch. This pull request has now been integrated. Changeset: c6243fc2 Author:Jaikiran Pai URL: https://git.openjdk.org/jdk/commit/c6243fc27fafb1ff89f8610ead3acd87030caf95 Sta

RFR: 8353957: Open source several AWT ScrollPane tests - Batch 1

2025-04-16 Thread Tejesh R
Open source these AWT ScrollPane tests: java/awt/ScrollPane/ScrollPaneFlicker/ScrollPaneFlicker.java java/awt/ScrollPane/ScrollbarsAsNeeded/ScrollbarsAsNeededTest.java java/awt/ScrollPane/ScrollPanePaint/ScrollPanePaint.java java/awt/ScrollPane/ScrollPositionTest/ScrollPositionTest.java -

Re: Integrated: Merge ed30fce6df57b1cbf7a6efebabc3558550f8ec16

2025-04-16 Thread Daniel Fuchs
On Wed, 16 Apr 2025 11:20:36 GMT, Jaikiran Pai wrote: > This brings in the CPU25_04 changes into the master branch. LGTM - Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24683#pullrequestreview-2772164693

RFR: 8353446: Open source several AWT Menu tests - Batch 2

2025-04-16 Thread Tejesh R
Open source these AWT Menu tests: java/awt/Menu/OnFlyRepaintMenuTest/OnFlyRepaintMenuTest.java java/awt/Menu/DestroyMenuTest/DestroyMenuTest.java java/awt/Menu/MenuAddRemoveCrash/MenuAddRemoveCrash.java java/awt/Menu/MenuZOrderTest/MenuZOrderTest.java - Commit messages: - Open sourc

Re: RFR: 8351884: Refactor bug8033699.java test code

2025-04-16 Thread Dmitry Markov
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote: > Details: > Refactored code as requested in the Bug description. > > Tested and verified the test passes. Marked as reviewed by dmarkov (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24384#pullrequestreview-27720170

RFR: 8354561: Open source several swing tests batch0

2025-04-16 Thread Alexander Zvegintsev
Few more tests open sourced: javax/swing/JTextArea/4474400/bug4474400.java javax/swing/border/TitledBorder/TransparentTitleTest.java javax/swing/JComboBox/4139900/bug4139900.java javax/swing/JComboBox/4174876/bug4174876.java - Commit messages: - 8354561: Open source several swing te

Integrated: 8353832: Opensource FontClass, Selection and Icon tests

2025-04-16 Thread Abhishek Kumar
On Mon, 14 Apr 2025 05:57:16 GMT, Abhishek Kumar wrote: > Font Class, Selection adn Icon related Applet tests are converted to manual > and open sourced. This pull request has now been integrated. Changeset: 8c6b611f Author:Abhishek Kumar URL: https://git.openjdk.org/jdk/commit/8c6

Re: RFR: 8354273: Restore even more pointless unicode characters to ASCII [v2]

2025-04-16 Thread Magnus Ihse Bursie
On Wed, 16 Apr 2025 04:39:22 GMT, Phil Race wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove incorrectly copied "§anchor" > > src/java.xml/share/legal/xhtml11.md line 50: > >> 48: or derived from [titl

Proposal: A new common Image API

2025-04-16 Thread Glavo
Currently, there are multiple different image APIs in the Java ecosystem: AWT, JavaFX, Android, etc. What's worse, the Android platform does not provide support for AWT, making the Java ecosystem even more fragmented. There are some obvious problems with the current situation: * Third-party libra

RFR: 8354285: Open source Swing tests Batch 3

2025-04-16 Thread Jayathirth D V
Open source some of the swing LAF tests - Commit messages: - 8354285: Open source Swing tests Batch 3 Changes: https://git.openjdk.org/jdk/pull/24677/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24677&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8354285 Stats:

Re: RFR: 8352905: Open some JComboBox bugs 1 [v2]

2025-04-16 Thread Prasanta Sadhukhan
On Wed, 16 Apr 2025 08:22:19 GMT, Alisen Chung wrote: >> Updating and opening some tests > > Alisen Chung has updated the pull request incrementally with two additional > commits since the last revision: > > - update tests > - update tests Marked as reviewed by psadhukhan (Reviewer). --

Re: RFR: 8353007: Open some JComboBox bugs 2 [v3]

2025-04-16 Thread Alisen Chung
> Updating and opening some tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: update tests - Changes: - all: https://git.openjdk.org/jdk/pull/24496/files - new: https://git.openjdk.org/jdk/pull/24496/files/97c86b

Re: RFR: 8353007: Open some JComboBox bugs 2 [v2]

2025-04-16 Thread Alisen Chung
On Wed, 9 Apr 2025 00:13:38 GMT, Harshitha Onkar wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update jtreg > > test/jdk/javax/swing/JComboBox/bug4201964.java line 79: > >> 77: frame.add(panel); >> 78:

RFR: 8354791: Use Hashtable.putIfAbsent in CSS constructor

2025-04-16 Thread Andrey Turbanov
We can use Hashtable.putIfAbsent instead of pair `get`/`put` methods. It's faster and cleaner. - Commit messages: - [PATCH] CSS. Use Hashtable.putIfAbsent instead of pair get/put Changes: https://git.openjdk.org/jdk/pull/22032/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr

Re: RFR: 8352905: Open some JComboBox bugs 1 [v2]

2025-04-16 Thread Alisen Chung
On Fri, 11 Apr 2025 03:52:05 GMT, Sergey Bylokhov wrote: >> Alisen Chung has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update tests >> - update tests > > test/jdk/javax/swing/JComboBox/bug4166593.java line 65: > >> 63: } >>

Re: RFR: 8352905: Open some JComboBox bugs 1 [v2]

2025-04-16 Thread Alisen Chung
> Updating and opening some tests Alisen Chung has updated the pull request incrementally with two additional commits since the last revision: - update tests - update tests - Changes: - all: https://git.openjdk.org/jdk/pull/24495/files - new: https://git.openjdk.org/jdk/pull/

Re: RFR: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer

2025-04-16 Thread Tejesh R
On Thu, 16 Jan 2025 12:03:50 GMT, Andrey Turbanov wrote: > There is redundant `null` comparison in `sun.awt.windows.WToolkit.getFontPeer` > Local variable `retval` can't be null after new object assignment. > https://github.com/openjdk/jdk/blob/24de9dee80738fe6ab1fc726b071546c85bbf79a/src/java.de

RFR: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer

2025-04-16 Thread Andrey Turbanov
There is redundant `null` comparison in `sun.awt.windows.WToolkit.getFontPeer` Local variable `retval` can't be null after new object assignment. https://github.com/openjdk/jdk/blob/24de9dee80738fe6ab1fc726b071546c85bbf79a/src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java#L604-L605 --

  1   2   >