Re: RFR: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen [v11]

2025-04-30 Thread Sergey Bylokhov
On Tue, 25 Mar 2025 15:36:40 GMT, Sergey Bylokhov wrote: > So this seems to be a bug in macOS, as the reported mouse location is > incorrect while it is actually positioned at the edge? > > Probably, there are other macOS APIs that could be used to implement > Java_sun_lwawt_macosx_CCursorMana

Re: RFR: JDK-8355528 : Update HarfBuzz to 11.2.0

2025-04-30 Thread Damon Nguyen
On Wed, 30 Apr 2025 19:37:29 GMT, Harshitha Onkar wrote: > HarfBuzz upgraded to 11.2.0 > > 4 newly added files and 99 modified files. Marked as reviewed by dnguyen (Committer). - PR Review: https://git.openjdk.org/jdk/pull/24973#pullrequestreview-2808475596

Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v8]

2025-04-30 Thread Sergey Bylokhov
> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been > tweaked, see inline comments. > > Notes: > * We have a few XXXRepaint.java tests and in this patch, I updated all of > them to follow the change added to the ListRepaint.java > > @azvegint @aivanov-jdk please tak

Re: RFR: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen [v13]

2025-04-30 Thread Alisen Chung
> Currently on macOS when mouseMove is given an offscreen coordinate to move > the mouse to, mouseMove will physically clamp to the edge of the screen, but > if you try to grab the mouse location immediately after by using > MouseInfo.getPointerInfo().getLocation() you will get the value of the

Re: RFR: 8352149: open/test/jdk/java/awt/Frame/MultiScreenTest.java fails [v2]

2025-04-30 Thread Khalid Boulanouare
On Wed, 30 Apr 2025 17:21:21 GMT, Alexey Ivanov wrote: >>> #21942 >> >> Thanks @aivanov-jdk for suggesting the correct route. >> >> @kboulanou Please modify the test to run for all platforms and you can limit >> the number of graphics configuration to 10 for linux. > >> @kumarabhi006 I am awar

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v10]

2025-04-30 Thread ScientificWare
On Mon, 9 Dec 2024 09:56:15 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK-

RFR: JDK-8355528 : Update HarfBuzz to 11.2.0

2025-04-30 Thread Harshitha Onkar
HarfBuzz upgraded to 11.2.0 4 newly added files and 99 modified files. - Commit messages: - .md file - updated files - newly added files Changes: https://git.openjdk.org/jdk/pull/24973/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24973&range=00 Issue: https://bugs.o

Re: RFR: 8355561: [macos] Build failure with Xcode 16.3

2025-04-30 Thread Sergey Bylokhov
On Wed, 30 Apr 2025 10:29:36 GMT, Julian Waters wrote: > Why not new and delete? In most cases, we allocate raw buffers that are filled by macOS. We could use "std::vector+try/catch" instead, but since malloc/free is already used in this code, I followed the same pattern for consistency.

Re: RFR: 8352149: open/test/jdk/java/awt/Frame/MultiScreenTest.java fails [v2]

2025-04-30 Thread Alexey Ivanov
On Tue, 29 Apr 2025 14:15:40 GMT, Abhishek Kumar wrote: >>> I'm sure this problem was discussed somewhere… (I'll search for that >>> discussion later.) We should limit testing to default configurations only. >> >> It was in #21942, its description reads >> >>> I think the large number of XVisu

Re: RFR: 8352149: open/test/jdk/java/awt/Frame/MultiScreenTest.java fails [v2]

2025-04-30 Thread Khalid Boulanouare
On Tue, 29 Apr 2025 14:15:40 GMT, Abhishek Kumar wrote: >>> I'm sure this problem was discussed somewhere… (I'll search for that >>> discussion later.) We should limit testing to default configurations only. >> >> It was in #21942, its description reads >> >>> I think the large number of XVisu

Re: RFR: 8352149: open/test/jdk/java/awt/Frame/MultiScreenTest.java fails [v4]

2025-04-30 Thread Khalid Boulanouare
> Fixes issue in which the test fails when run on multi-screen machine. > > Tested on Ubuntu 24.04, MacOS 15 and Windows 11 > > JTREG > > runner starting test: java/awt/Frame/MultiScreenTest.java > runner finished test: java/awt/Frame/MultiScreenTest.java > Passed. Execution successful Khalid B

Re: RFR: 8352149: open/test/jdk/java/awt/Frame/MultiScreenTest.java fails [v3]

2025-04-30 Thread Khalid Boulanouare
> Fixes issue in which the test fails when run on multi-screen machine. > > Tested on Ubuntu 24.04, MacOS 15 and Windows 11 > > JTREG > > runner starting test: java/awt/Frame/MultiScreenTest.java > runner finished test: java/awt/Frame/MultiScreenTest.java > Passed. Execution successful Khalid B

Re: RFR: 8352149: open/test/jdk/java/awt/Frame/MultiScreenTest.java fails [v2]

2025-04-30 Thread Khalid Boulanouare
On Tue, 29 Apr 2025 14:15:40 GMT, Abhishek Kumar wrote: >>> I'm sure this problem was discussed somewhere… (I'll search for that >>> discussion later.) We should limit testing to default configurations only. >> >> It was in #21942, its description reads >> >>> I think the large number of XVisu

Re: RFR: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen [v11]

2025-04-30 Thread Alexander Zvegintsev
On Tue, 29 Apr 2025 20:28:57 GMT, Alisen Chung wrote: >> Here are a few cases where it still seems to fail after the update: >> >> >> Title: secondary above the primary >> Cmd: xrandr --output DP-0 --primary --pos 0x1440 --rotate normal --preferred >> --output DP-2 --pos 0x0 --rotate normal --

Re: RFR: 8347826: Introspector shows wrong method list after 8071693 [v12]

2025-04-30 Thread Alexey Ivanov
On Wed, 23 Apr 2025 00:25:20 GMT, Alexander Zvegintsev wrote: > FYI, one of the JCK introspector tests fails because of this change. The test > is quite complicated, so I am not able to provide a simple reproducer right > away. But I'll post it later. Indeed, there are some failures of JCK In

Integrated: 8351884: Refactor bug8033699.java test code

2025-04-30 Thread Rajat Mahajan
On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan wrote: > Details: > Refactored code as requested in the Bug description. > > Tested and verified the test passes. This pull request has now been integrated. Changeset: 482538b1 Author:Rajat Mahajan Committer: Alexey Ivanov URL: https:

Re: RFR: 8354791: Use Hashtable.putIfAbsent in CSS constructor [v2]

2025-04-30 Thread Alexey Ivanov
On Tue, 29 Apr 2025 13:51:38 GMT, Andrey Turbanov wrote: >> We can use Hashtable.putIfAbsent instead of pair `get`/`put` methods. >> It's faster and cleaner. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > add CSS. prefi

Integrated: 8354791: Use Hashtable.putIfAbsent in CSS constructor

2025-04-30 Thread Andrey Turbanov
On Tue, 12 Nov 2024 09:13:07 GMT, Andrey Turbanov wrote: > We can use Hashtable.putIfAbsent instead of pair `get`/`put` methods. > It's faster and cleaner. This pull request has now been integrated. Changeset: 0110acaa Author:Andrey Turbanov URL: https://git.openjdk.org/jdk/commit/0

Re: RFR: 8355561: [macos] Build failure with Xcode 16.3

2025-04-30 Thread Julian Waters
On Mon, 28 Apr 2025 19:47:03 GMT, Sergey Bylokhov wrote: > Multiple similar issues detected in PLATFORM_API_MacOSX_Ports.cpp more info > about https://github.com/llvm/llvm-project/issues/62836 > > jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_Ports.cpp:127:39: > error: varia