Re: RFR: 8339561: The test/jdk/java/awt/Paint/ListRepaint.java may fail after JDK-8327401 [v9]

2025-05-06 Thread Sergey Bylokhov
> Several tests modified by https://github.com/openjdk/jdk/pull/19339 have been > tweaked, see inline comments. > > Notes: > * We have a few XXXRepaint.java tests and in this patch, I updated all of > them to follow the change added to the ListRepaint.java > > @azvegint @aivanov-jdk please tak

Integrated: 8356208: Remove obsolete code in PSPrinterJob for plugin printing

2025-05-06 Thread Phil Race
On Mon, 5 May 2025 18:55:47 GMT, Phil Race wrote: > Delete the obsolete classes PluginPrinter and EPSPrinter. They were only ever > called by the Java Plugin printing for applets. This pull request has now been integrated. Changeset: 4e3ec3c0 Author:Phil Race URL: https://git.openj

Re: RFR: 8351913: ToolkitImage renders some gifs wrong [v4]

2025-05-06 Thread Jeremy Wood
> I do not have much background in LZW compression or in C, but I'm reasonably > confident this resolves the problem I'm observing. It looks like the > GifImageDecoder was not always correctly handling compression codes after the > table reached its limit of ~4096. If anyone has suggestions for

RFR: 8356320: GifImageDecoder can produce wrong image when GCE changes transparent pixel index

2025-05-06 Thread Jeremy Wood
When a gif frame's disposal code is DISPOSAL_BGCOLOR and we're maintaining a saved image: we have to flood-fill the frame's bounds. And if the transparent pixel index changes across frames: we could sometimes flood fill the wrong value, resulting in an opaque rectangle in the output image. (I k

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v3]

2025-05-06 Thread Jeremy Wood
> This resolves a gif parsing bug where an unwanted opaque rectangle could > appear under these conditions: > > 1. The disposal method for frames is 1 (meaning "do not dispose", aka > "DISPOSAL_SAVE") > 2. The transparent pixel is non-zero > 3. There's more than one such consecutive frame > > P

Integrated: 8355561: [macos] Build failure with Xcode 16.3

2025-05-06 Thread Sergey Bylokhov
On Mon, 28 Apr 2025 19:47:03 GMT, Sergey Bylokhov wrote: > Multiple similar issues detected in PLATFORM_API_MacOSX_Ports.cpp more info > about https://github.com/llvm/llvm-project/issues/62836 > > jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_Ports.cpp:127:39: > error: varia

Re: RFR: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object

2025-05-06 Thread Daniel Gredler
On Mon, 5 May 2025 23:45:36 GMT, Harshitha Onkar wrote: >> On other platforms like Windows and Linux, the `\n`, `\r` and `\t` >> characters are ignored when drawing text to a `Graphics2D` object. On macOS >> this is not currently the case. >> >> See, for example, `CMap.getControlCodeGlyph(int,

Re: RFR: 8343739: Test java/awt/event/KeyEvent/ExtendedKeyCode/ExtendedKeyCodeTest.java failed: Wrong extended key code [v3]

2025-05-06 Thread Sergey Bylokhov
On Fri, 2 May 2025 18:32:29 GMT, Alisen Chung wrote: > I've updated the test to include logging and ran the test 200x without > failures. I think it's ok to push the test with these changes so that if the > test ever does fail again we can use the logs and analyze the problem. I meant to run t

Re: Integrated: 8354273: Replace even more Unicode characters with ASCII

2025-05-06 Thread Andrew Thompson
> I believe the source code of the JDK should be in US-ASCII Why? This seems like a bizarre thing to believe free of context. In my experience using non-ascii regularly is the only way to make sure that tools which destroy non-ascii data are not introduced into tool chains which then break cas

Re: RFR: 8356208: Remove obsolete code in PSPrinterJob for plugin printing [v2]

2025-05-06 Thread Sergey Bylokhov
On Tue, 6 May 2025 18:37:31 GMT, Phil Race wrote: >> Delete the obsolete classes PluginPrinter and EPSPrinter. They were only >> ever called by the Java Plugin printing for applets. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events [v5]

2025-05-06 Thread Kevin Rushforth
On Tue, 29 Apr 2025 22:43:03 GMT, Pabulaner IV wrote: >> When trying to register an open URI handler when using JavaFX with a native >> menu, this task fails on Mac. >> Either the native menu is not shown or the URIs are not received. >> >> This pull request fixes this issue if AWT is registere

Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events [v5]

2025-05-06 Thread Kevin Rushforth
On Tue, 29 Apr 2025 22:43:03 GMT, Pabulaner IV wrote: >> When trying to register an open URI handler when using JavaFX with a native >> menu, this task fails on Mac. >> Either the native menu is not shown or the URIs are not received. >> >> This pull request fixes this issue if AWT is registere

Re: RFR: 8355561: [macos] Build failure with Xcode 16.3

2025-05-06 Thread Phil Race
On Mon, 28 Apr 2025 19:47:03 GMT, Sergey Bylokhov wrote: > Multiple similar issues detected in PLATFORM_API_MacOSX_Ports.cpp more info > about https://github.com/llvm/llvm-project/issues/62836 > > jdk/src/java.desktop/macosx/native/libjsound/PLATFORM_API_MacOSX_Ports.cpp:127:39: > error: varia

Re: RFR: 8356208: Remove obsolete code in PSPrinterJob for plugin printing [v2]

2025-05-06 Thread Phil Race
On Tue, 6 May 2025 02:42:56 GMT, Sergey Bylokhov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8356208 > > src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 272: > >> 270:/* non-null if printing E

Re: RFR: 8356208: Remove obsolete code in PSPrinterJob for plugin printing [v2]

2025-05-06 Thread Phil Race
On Tue, 6 May 2025 09:08:35 GMT, Andrey Turbanov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8356208 > > src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 533: > >> 531: try { >> 532

Re: RFR: 8356208: Remove obsolete code in PSPrinterJob for plugin printing [v2]

2025-05-06 Thread Phil Race
> Delete the obsolete classes PluginPrinter and EPSPrinter. They were only ever > called by the Java Plugin printing for applets. Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8356208 - Changes: - all: https://git.open

Re: RFR: 8353950: Clipboard interaction on Windows is unstable [v2]

2025-05-06 Thread Matthias Bläsing
On Mon, 14 Apr 2025 17:19:19 GMT, Matthias Bläsing wrote: >> - Introduce a lock into WClipboard that protects the code between >> openClipboard/closeClipboard invocations. >> The native side does not allow to open the clipboard multiple >> times or share the opened clipboard between multip

Integrated: 8354273: Replace even more Unicode characters with ASCII

2025-05-06 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 10:18:08 GMT, Magnus Ihse Bursie wrote: > As a follow-up to [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), > I found some additional places where unicode characters are unnecessarily > used instead of pure ASCII. This pull request has now been integrated. Chan

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v2]

2025-05-06 Thread Jeremy Wood
On Tue, 6 May 2025 10:43:02 GMT, Mikhail Yankelevich wrote: >> Jeremy Wood has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - 8356137: removing sentence fragment >> >>This is in response to: >>https://github.com/openjdk/jdk/

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v2]

2025-05-06 Thread Jeremy Wood
> This resolves a gif parsing bug where an unwanted opaque rectangle could > appear under these conditions: > > 1. The disposal method for frames is 1 (meaning "do not dispose", aka > "DISPOSAL_SAVE") > 2. The transparent pixel is non-zero > 3. There's more than one such consecutive frame > > P

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v2]

2025-05-06 Thread Jeremy Wood
On Tue, 6 May 2025 10:33:47 GMT, Mikhail Yankelevich wrote: >> Jeremy Wood has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - 8356137: removing sentence fragment >> >>This is in response to: >>https://github.com/openjdk/jdk/

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v9]

2025-05-06 Thread Alexey Ivanov
On Tue, 29 Apr 2025 01:23:00 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v9]

2025-05-06 Thread duke
On Tue, 29 Apr 2025 01:23:00 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Integrated: JDK-8355528 : Update HarfBuzz to 11.2.0

2025-05-06 Thread Harshitha Onkar
On Wed, 30 Apr 2025 19:37:29 GMT, Harshitha Onkar wrote: > HarfBuzz upgraded to 11.2.0 > > 4 newly added files and 99 modified files. This pull request has now been integrated. Changeset: b21b3a38 Author:Harshitha Onkar URL: https://git.openjdk.org/jdk/commit/b21b3a38a5dbc7eb23c4bd

Re: RFR: 8354273: Replace even more Unicode characters with ASCII [v3]

2025-05-06 Thread Naoto Sato
On Tue, 6 May 2025 14:16:32 GMT, Magnus Ihse Bursie wrote: >> As a follow-up to >> [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some >> additional places where unicode characters are unnecessarily used instead of >> pure ASCII. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8354273: Replace even more Unicode characters with ASCII [v3]

2025-05-06 Thread Magnus Ihse Bursie
On Tue, 6 May 2025 14:16:32 GMT, Magnus Ihse Bursie wrote: >> As a follow-up to >> [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some >> additional places where unicode characters are unnecessarily used instead of >> pure ASCII. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8354273: Replace even more Unicode characters with ASCII [v3]

2025-05-06 Thread Magnus Ihse Bursie
> As a follow-up to [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), > I found some additional places where unicode characters are unnecessarily > used instead of pure ASCII. Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The increm

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes

2025-05-06 Thread Mikhail Yankelevich
On Mon, 5 May 2025 17:07:11 GMT, Jeremy Wood wrote: > This resolves a gif parsing bug where an unwanted opaque rectangle could > appear under these conditions: > > 1. The disposal method for frames is 1 (meaning "do not dispose", aka > "DISPOSAL_SAVE") > 2. The transparent pixel is non-zero >

Re: RFR: 8356208: Remove obsolete code in PSPrinterJob for plugin printing

2025-05-06 Thread Andrey Turbanov
On Mon, 5 May 2025 18:55:47 GMT, Phil Race wrote: > Delete the obsolete classes PluginPrinter and EPSPrinter. They were only ever > called by the Java Plugin printing for applets. src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 533: > 531: try { > 532: