On Mon, 19 May 2025 05:37:05 GMT, Jeremy Wood wrote:
>> Unfortunately I'm unable to reproduce this failure. I slowed the test down;
>> it passes on my machine before and after this PR.
>>
>> I added a little bit of logging that might also help identify what's
>> happening.
>>
>> Does anyone h
On Tue, 20 May 2025 18:18:51 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JFileChooser/HTMLFileName.java line 59:
>
>> 57: ComboBox re
On Wed, 21 May 2025 04:39:33 GMT, Sergey Bylokhov wrote:
> > Since it is regression of 4265389: JSplitPane does not support
> > ComponentOrientation where setComponentOrientation method is added, it made
> > sense to me to set the divider location in that method before rendering the
> > left a
On Wed, 21 May 2025 03:51:53 GMT, Prasanta Sadhukhan
wrote:
>Since it is regression of 4265389: JSplitPane does not support
>ComponentOrientation where setComponentOrientation method is added, it made
>sense to me to set the divider location in that method before rendering the
>left and right
On Tue, 20 May 2025 19:40:04 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - File merge
>> - Review comment fix, latch and other changes
>> - Test Stabilization
On Wed, 21 May 2025 01:45:46 GMT, Sergey Bylokhov wrote:
> Did you have a chance to reproduce this bug and see how it works? When I run
> it on my laptop I can see the mouse moving out and in of the list and
> clicking inside of it, but for some reason the events are not sent.
I couldn't repro
> Test was failing on macOS 14.7.1 system in CI pipeline. Logged output
> suggests that the mouse exit event is not triggered and thus the test fails.
> Increased number of list items and adjusted the X and Y offset for mouse move
> events, so the mouse pointer will be within the frame and added
On Wed, 21 May 2025 02:30:50 GMT, Sergey Bylokhov wrote:
> > This is because when we added support for ComponentOrientation for
> > JSplitPane, even though the left and right compoent is drawn the divider
> > location is not set and was set to initial value and not to the value set
> > by user
Graphics copyArea overflow check bails out of copying pixels if there is
overflow.
The spec says ""If a portion of the source rectangle lies outside the bounds of
the component, or is obscured by another window or component, {@code copyArea}
*will be unable to copy* the associated pixels"
which
Small unification of "header size" constants, as of now the CMM code uses:
1. sun.java2d.cmm.ProfileDataVerifier.HEADER_SIZE introduced in JDK-8013430
2. java.awt.color.ICC_Profile.HEADER_SIZE introduced in
[JDK-8347377](https://bugs.openjdk.org/browse/JDK-8347377)
3. Hardcoded literal 128
--
> There are some compilation failures noticed in the recently open sourced test
> javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to
> missing import statements and a missing dependency file MenuItemTest.java.
>
> Fix: I have added the required import statements and added
On Tue, 20 May 2025 04:34:36 GMT, Prasanta Sadhukhan
wrote:
>> The issue is when a JSplitPane is embedded inside a lazily-initialized
>> panel, and this panel is displayed using a dialog created via
>> JOptionPane.createDialog(), the divider location is not preserved when
>> reopening the dia
On Tue, 20 May 2025 07:53:30 GMT, Abhishek Kumar wrote:
>> Test was failing on macOS 14.7.1 system in CI pipeline. Logged output
>> suggests that the mouse exit event is not triggered and thus the test fails.
>> Increased number of list items and adjusted the X and Y offset for mouse
>> move ev
On Tue, 20 May 2025 20:16:46 GMT, Alexey Ivanov wrote:
> Is it possible that the button hovered by mouse looks the same way as the
> default one?
That's the big question this unit test is trying to answer. (So: I'm not sure.)
> Did the original test move the mouse before getting pixel color of
On Tue, 20 May 2025 10:33:21 GMT, Alexander Zvegintsev
wrote:
>>> I'm not sure if it's really needed, since many tests already depend on the
>>> `java.awt.Robot` itself, CI has a one-time manual task to set up all the
>>> required permissions for the `java.awt.Robot`, so automated tests provid
On Mon, 19 May 2025 23:06:39 GMT, Alexander Zvegintsev
wrote:
>> The issue is the inability to move the mouse cursor using `java.awt.Robot`
>> on Oracle Linux 10 (which has not yet been released). FIY, the OL10 is no
>> longer provides an Xorg session, so only Wayland is available.
>> It is a
On Tue, 20 May 2025 22:09:37 GMT, Phil Race wrote:
>> Update the some code examples and accompanying images to no longer mention
>> or display as applets.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8357176
> Ok .. here'
On Tue, 20 May 2025 22:33:57 GMT, Phil Race wrote:
> I don't think that necessary for this case.
But it is possible and will not freeze this change in stone forever.
-
PR Comment: https://git.openjdk.org/jdk/pull/24991#issuecomment-2896035156
On Tue, 20 May 2025 22:09:37 GMT, Phil Race wrote:
>> Update the some code examples and accompanying images to no longer mention
>> or display as applets.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8357176
Ok .. here's
On Tue, 20 May 2025 22:25:12 GMT, Sergey Bylokhov wrote:
> btw why not mark this as an incubator/preview feature and look at the reviews?
I don't think that necessary for this case.
> I wonder about the limitation to `java.io.File` as source for sound clips.
> Allowing playback from an `InputS
On Tue, 13 May 2025 21:28:24 GMT, Phil Race wrote:
>> A simple API to replace java.applet.AudioClip
>>
>> CSR is now created : https://bugs.openjdk.org/browse/JDK-8356200
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 835604
On Tue, 20 May 2025 20:00:16 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8357176
>
> src/java.desktop/share/classes/java/awt/BorderLayout.java line 103:
>
>> 101: *
>> 102: *
>> 103: * impo
> Update the some code examples and accompanying images to no longer mention or
> display as applets.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8357176
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25278/files
On Tue, 20 May 2025 21:17:22 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8357176
>
> src/java.desktop/share/classes/java/awt/GridLayout.java line 50:
>
>> 48: *
>> 49: * EventQueue.invo
On Tue, 20 May 2025 20:30:21 GMT, Phil Race wrote:
>> Update the some code examples and accompanying images to no longer mention
>> or display as applets.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8357176
src/java.desk
> Update the some code examples and accompanying images to no longer mention or
> display as applets.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8357176
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25278/files
On Fri, 16 May 2025 23:04:28 GMT, Phil Race wrote:
> Update the some code examples and accompanying images to no longer mention or
> display as applets.
> > It seems the new screenshots could be improved by capturing them on a HiDPI
> > (Retina) display, as the current images appear blurry. An
On Tue, 20 May 2025 11:17:39 GMT, Jayathirth D V wrote:
> I think the original issue of getting same RGB color for both default and
> non-default button is happening because when we move mouse pointer to a
> location and pick the color from the same location using robot, sometimes it
> picks t
On Fri, 16 May 2025 23:04:28 GMT, Phil Race wrote:
> Update the some code examples and accompanying images to no longer mention or
> display as applets.
src/java.desktop/share/classes/java/awt/BorderLayout.java line 103:
> 101: *
> 102: *
> 103: * import java.awt.BorderLayout;
Should we r
On Tue, 20 May 2025 18:59:33 GMT, Sergey Bylokhov wrote:
>> It doesn't matter, it looks… `localL` is `null` if and only if listener is
>> `null`.
>>
>> However, I'd put the null-check above the call to `deProxyAWTEventListener`
>> to avoid any confusion.
>
> listener and proxy are public class
On Tue, 20 May 2025 07:53:30 GMT, Abhishek Kumar wrote:
>> Test was failing on macOS 14.7.1 system in CI pipeline. Logged output
>> suggests that the mouse exit event is not triggered and thus the test fails.
>> Increased number of list items and adjusted the X and Y offset for mouse
>> move ev
On Tue, 20 May 2025 19:12:21 GMT, Phil Race wrote:
> BTW I tried a couple of times to upload javadoc to cr.openjdk.org so I could
> show the new rendered javadoc but uploads failed ...
I experienced some issues with uploading files to cr.openjdk.org some time ago;
recently it worked well, howe
On Tue, 20 May 2025 07:53:30 GMT, Abhishek Kumar wrote:
>> Test was failing on macOS 14.7.1 system in CI pipeline. Logged output
>> suggests that the mouse exit event is not triggered and thus the test fails.
>> Increased number of list items and adjusted the X and Y offset for mouse
>> move ev
On Mon, 19 May 2025 12:44:35 GMT, Alexey Ivanov wrote:
>> Update the some code examples and accompanying images to no longer mention
>> or display as applets.
>
> src/java.desktop/share/classes/java/awt/GridBagLayout.java line 243:
>
>> 241: * right-to-left container.
>> 242: *
>> 243: *
>
On Tue, 20 May 2025 18:34:28 GMT, Manukumar V S wrote:
>> There are some compilation failures noticed in the recently open sourced
>> test javax/swing/JMenuItem/bug6197830.java. The compilation failures are due
>> to missing import statements and a missing dependency file MenuItemTest.java.
>>
On Tue, 20 May 2025 17:01:26 GMT, Alexey Ivanov wrote:
>> Manukumar V S has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments fixed : Rearranged and reused code by creating a new
>> Helper MenuItemTestHelper.java
>
> test/jdk/
On Mon, 19 May 2025 12:23:27 GMT, Alexey Ivanov wrote:
>> Looks like yes. I think it's worth to create a separate issue to fix it.
>
> It doesn't matter, it looks… `localL` is `null` if and only if listener is
> `null`.
>
> However, I'd put the null-check above the call to `deProxyAWTEventListe
On Mon, 19 May 2025 13:52:16 GMT, Tejesh R wrote:
>> The rendering of the directory names are handled as JLabel w.r.t Look and
>> feel and also either Details/List view. Though FilePane creates basic
>> rendering for these two few Look and Feel define their own renderers and
>> also ComboBox D
On Tue, 13 May 2025 03:05:32 GMT, Sergey Bylokhov wrote:
>>> Exception in thread "AWT-EventQueue-0" java.nio.file.InvalidPathException:
>>> Illegal char <<> at index 0: SWING ROCKS!!!111
>>> at
>>> java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:191)
>>>
> There are some compilation failures noticed in the recently open sourced test
> javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to
> missing import statements and a missing dependency file MenuItemTest.java.
>
> Fix: I have added the required import statements and added
On Tue, 20 May 2025 16:33:38 GMT, Alexey Ivanov wrote:
>> Manukumar V S has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments fixed : Rearranged and reused code by creating a new
>> Helper MenuItemTestHelper.java
>
> test/jdk/
On Tue, 20 May 2025 16:18:48 GMT, Manukumar V S wrote:
>> There are some compilation failures noticed in the recently open sourced
>> test javax/swing/JMenuItem/bug6197830.java. The compilation failures are due
>> to missing import statements and a missing dependency file MenuItemTest.java.
>>
> There are some compilation failures noticed in the recently open sourced test
> javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to
> missing import statements and a missing dependency file MenuItemTest.java.
>
> Fix: I have added the required import statements and added
On Wed, 14 May 2025 21:28:37 GMT, Harshitha Onkar wrote:
>> The following line results in unused-result warning on linux/clang.
>>
>>
>> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring
>> return value of function
>> declared with 'warn_unused_result' attribute [-W
On Wed, 14 May 2025 21:28:37 GMT, Harshitha Onkar wrote:
>> The following line results in unused-result warning on linux/clang.
>>
>>
>> /java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: ignoring
>> return value of function
>> declared with 'warn_unused_result' attribute [-W
On Tue, 20 May 2025 07:53:30 GMT, Abhishek Kumar wrote:
>> Test was failing on macOS 14.7.1 system in CI pipeline. Logged output
>> suggests that the mouse exit event is not triggered and thus the test fails.
>> Increased number of list items and adjusted the X and Y offset for mouse
>> move ev
On Mon, 24 Mar 2025 13:41:44 GMT, Zdenek Zambersky wrote:
> This fixes stack smashing issue in awt library on linux s390x. (jdk compiled
> with `-fstack-protector-strong`)
>
> Fix is based on patch
> [submitted](https://mail.openjdk.org/pipermail/awt-dev/2019-July/015337.html)
> in JDK-822791
On Tue, 20 May 2025 14:18:06 GMT, Zdenek Zambersky wrote:
>>> That looks right, and it should also be good for backports. The root cause
>>> must be a bug in Xlib, though. Has anyone found it, or reported it?
>>
>> That was my thought too : "Looks reasonable although it seems an odd
>> behavi
On Fri, 16 May 2025 18:19:22 GMT, Phil Race wrote:
> That looks right, and it should also be good for backports. The root cause
> must be a bug in Xlib, though. Has anyone found it, or reported it?
I have not identified the root cause. I think bug could also be in kinput2 or
it's interaction w
On Mon, 19 May 2025 12:16:57 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - File merge
>> - Review comment fix, latch and other changes
>> - Test Stabilization
On Tue, 20 May 2025 12:03:23 GMT, Alexey Ivanov wrote:
> > > I see that `MenuItemTest` class exists in `bug4729669.java`:
> > > https://github.com/openjdk/jdk/blob/e961b13cd68bc352b86af17c7e53df8537519beb/test/jdk/javax/swing/JMenuItem/bug4729669.java#L80
> > >
> > > Is it similar to the one tha
On Wed, 7 May 2025 12:28:52 GMT, Manukumar V S wrote:
> Clarified the purpose of forcePass() and forceFail() methods and recommended
> usage of these methods.
>
> forcePass() contained an incorrect sample; it's addressed by
> [JDK-8355441](https://bugs.openjdk.org/browse/JDK-8355441).
>
> The
On Tue, 20 May 2025 11:52:58 GMT, Alexey Ivanov wrote:
> > > I see that `MenuItemTest` class exists in `bug4729669.java`:
> > > https://github.com/openjdk/jdk/blob/e961b13cd68bc352b86af17c7e53df8537519beb/test/jdk/javax/swing/JMenuItem/bug4729669.java#L80
> > >
> > > Is it similar to the one tha
On Tue, 20 May 2025 11:31:01 GMT, Manukumar V S wrote:
> > I see that `MenuItemTest` class exists in `bug4729669.java`:
> > https://github.com/openjdk/jdk/blob/e961b13cd68bc352b86af17c7e53df8537519beb/test/jdk/javax/swing/JMenuItem/bug4729669.java#L80
> >
> > Is it similar to the one that you co
On Mon, 19 May 2025 05:37:05 GMT, Jeremy Wood wrote:
>> Unfortunately I'm unable to reproduce this failure. I slowed the test down;
>> it passes on my machine before and after this PR.
>>
>> I added a little bit of logging that might also help identify what's
>> happening.
>>
>> Does anyone h
On Tue, 20 May 2025 10:15:11 GMT, Alexey Ivanov wrote:
> I see that `MenuItemTest` class exists in `bug4729669.java`:
>
> https://github.com/openjdk/jdk/blob/e961b13cd68bc352b86af17c7e53df8537519beb/test/jdk/javax/swing/JMenuItem/bug4729669.java#L80
>
> Is it similar to the one that you copied?
On Mon, 19 May 2025 23:02:54 GMT, Sergey Bylokhov wrote:
> > I'm not sure if it's really needed, since many tests already depend on the
> > `java.awt.Robot` itself, CI has a one-time manual task to set up all the
> > required permissions for the `java.awt.Robot`, so automated tests provide
> >
On Tue, 20 May 2025 07:32:41 GMT, Manukumar V S wrote:
> There are some compilation failures noticed in the recently open sourced test
> javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to
> missing import statements and a missing dependency file MenuItemTest.java.
>
> F
> Test was failing on macOS 14.7.1 system in CI pipeline. Logged output
> suggests that the mouse exit event is not triggered and thus the test fails.
> Increased number of list items and adjusted the X and Y offset for mouse move
> events, so the mouse pointer will be within the frame and added
There are some compilation failures noticed in the recently open sourced test
javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to
missing import statements and a missing dependency file MenuItemTest.java.
Fix: I have added the required import statements and added the code-
> Test was failing on macOS 14.7.1 system in CI pipeline. Logged output
> suggests that the mouse exit event is not triggered and thus the test fails.
> Increased number of list items and adjusted the X and Y offset for mouse move
> events, so the mouse pointer will be within the frame and added
61 matches
Mail list logo
