> Use PassFailJFrame to streamline the test
> java/awt/print/Dialog/DialogType.java, as is for several of the manual tests.
>
> Modified Manual Test Passed when run using jtreg.
Srinivas Mandalika has updated the pull request incrementally with one
additional commit since the last revision:
On Thu, 19 Jun 2025 19:13:10 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/print/Dialog/DialogType.java line 80:
>>
>>> 78: Attribute[] attrs = aset.toArray();
>>> 79: for (int i = 0; i < attrs.length; i++) {
>>> 80: System.out.println(attrs[i]);
>>
>> Is it better
On Thu, 19 Jun 2025 17:48:08 GMT, Alexey Ivanov wrote:
>>> > Also that other constructor (which github won't let me comment on)
>>> > installs the description even if the image is null.
>>>
>>> I don't see it as a problem.
>>>
>>> If the app developer wants to initialise the object with `null`
On Thu, 19 Jun 2025 03:01:15 GMT, Prasanta Sadhukhan
wrote:
>> When trying to call 'icon.setImage(null);' where 'icon' is an instance of
>> ImageIcon, a null pointer exception is thrown at runtime.
>> The code tried to get the `id` for that image and instantiates
>> `MediaTracker` to associate
> When trying to call 'icon.setImage(null);' where 'icon' is an instance of
> ImageIcon, a null pointer exception is thrown at runtime.
> The code tried to get the `id` for that image and instantiates `MediaTracker`
> to associate the null image to that `id` and checks the status of loading
> th
On Thu, 19 Jun 2025 04:10:20 GMT, Prasanta Sadhukhan
wrote:
>> RBMenuItem's and CBMenuItem's checkmark on the left side are not visible
>> while running on Windows L&F as background color is same as
>> RBMenuItem/CBMenuItem's checkmark..
>> Modified the color so that they are visible..
>
> Pra
On Thu, 19 Jun 2025 16:45:11 GMT, Alexey Ivanov wrote:
>> getVisibleEditorRect() return the bounds of the text editor and the return
>> value is used to to set-size/paint the
>> `javax.swing.text.View` of this text editor component.
>> "the allocation" refers to what allocated area the view nee
Issue is RadioButtonMenuItem and CheckBoxMenuItem bullet/checkmark icon is not
displayed in WindowsL&F when the test is run with NimbusL&F.
This is because `WindowsIconFactory#VistaMenuItemCheckIcon.paintIcon` called
`getLaFIcon()` which returns a empty NimbusIcon which causes no icons to be
dra
On Thu, 19 Jun 2025 10:23:46 GMT, Alexey Ivanov wrote:
> It may be impossible to reproduce the problem without referencing
> WindowsButtonUI. If it's possible, I'm all for it.
That should be checked on old jdk build.
> The bug was in Windows L&F, I don't think it's applicable to other L&F.
It
On Wed, 18 Jun 2025 03:56:13 GMT, Prasanta Sadhukhan
wrote:
> RBMenuItem's and CBMenuItem's checkmark on the left side are not visible
> while running on Windows L&F as background color is same as
> RBMenuItem/CBMenuItem's checkmark..
> Modified the color so that they are visible..
This pull
On Thu, 19 Jun 2025 19:45:48 GMT, Alexey Ivanov wrote:
>> This PR removes the usage of AppContext from the GraphicsDevice class. The
>> original use case was to store the full-screen window in some AppContext,
>> which was necessary in the context of plugin/appletviewer environments.
>> Howeve
On Thu, 19 Jun 2025 13:27:50 GMT, Matthias Bläsing
wrote:
> 8353950: Clipboard interaction on Windows is unstable
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25897#pullrequestreview-2943976568
> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
> can call `List.remove(Object)` directly. It's faster and cleaner.
> `eventsList` is an ArrayList.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
835
On Wed, 18 Jun 2025 14:13:19 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8359053
>
> src/java.desktop/share/classes/java/awt/doc-files/Modality.html line 353:
>
>> 351: the default type w
On Thu, 19 Jun 2025 10:11:57 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Test fix
>> - javadoc wording..clear image desscription if image is null
>
> src/java.desktop/share/classes/j
On Thu, 5 Jun 2025 20:58:19 GMT, Jean-Noël Rouvignac wrote:
>> src/java.desktop/share/classes/javax/sound/midi/Track.java line 202:
>>
>>> 200: synchronized(eventsList) {
>>> 201: if (set.remove(event)) {
>>> 202: if (eventsList.remove(event)) {
>>
>> Can be
On Wed, 23 Apr 2025 08:53:57 GMT, Andrey Turbanov wrote:
> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
> can call `List.remove(Object)` directly. It's faster and cleaner.
> `eventsList` is an ArrayList.
Changes requested by aivanov (Reviewer).
-
PR
On Mon, 16 Jun 2025 06:17:32 GMT, Sergey Bylokhov wrote:
> This PR removes the usage of AppContext from the GraphicsDevice class. The
> original use case was to store the full-screen window in some AppContext,
> which was necessary in the context of plugin/appletviewer environments.
> However,
On Wed, 11 Jun 2025 13:18:47 GMT, Daniel Jeliński wrote:
> Add an exception check after a JNI static method call, and re-enable checks
> for CallStatic in JNICheck.sh test.
>
> I verified that the JNICheck test is passing on all headless and headful
> platforms I had access to (Windows, Linux
On Thu, 12 Jun 2025 12:44:12 GMT, Daniel Jeliński wrote:
>> If this check is not needed, then why are we adding it?
>
> just so we don't forget to add it when we modify the enclosing function. The
> call to `CallStaticBooleanMethod` is located pretty far from the end of the
> function, and can
On Thu, 19 Jun 2025 04:10:20 GMT, Prasanta Sadhukhan
wrote:
>> RBMenuItem's and CBMenuItem's checkmark on the left side are not visible
>> while running on Windows L&F as background color is same as
>> RBMenuItem/CBMenuItem's checkmark..
>> Modified the color so that they are visible..
>
> Pra
On Thu, 19 Jun 2025 10:26:39 GMT, Abhishek Kumar wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review Feedback: Instructions Update
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 80:
>
>> 78:
On Thu, 19 Jun 2025 09:15:08 GMT, Srinivas Mandalika
wrote:
>> Use PassFailJFrame to streamline the test
>> java/awt/print/Dialog/DialogType.java, as is for several of the manual tests.
>>
>> Modified Manual Test Passed when run using jtreg.
>
> Srinivas Mandalika has updated the pull request
Hi Mark,
The default look and feel is Metal on all OS except for macOS where the
default is Aqua.
You can modify the default look and feel using the the
|swing.defaultlaf| property, and it works for me as expected. The
default look and feel of an application is initialised to the class in
t
On Thu, 19 Jun 2025 17:00:09 GMT, Phil Race wrote:
> And consistency seems the best choice.
Then our best choice is not to touch `ImageIcon(Image)` and leave it to throw
`NullPointerException`.
All the constructors except for `ImageIcon((String) null)` throw
`NullPointerException` if the firs
On Wed, 18 Jun 2025 15:25:42 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties
> line
Hi,
thanks for testing and checking. I created:
https://github.com/openjdk/jdk/pull/25897
And tested the changes prior to opening the PR locally.
Thank you
Matthias
Am Montag, dem 16.06.2025 um 15:46 -0700 schrieb Philip Race:
> I've looked at the code and I think overall it is an improvement
On Thu, 19 Jun 2025 13:27:50 GMT, Matthias Bläsing
wrote:
> 8353950: Clipboard interaction on Windows is unstable
Testing:
- Tests from `test/jdk/java/awt/Clipboard` were successfully run with fastdebug
and release configuration. It was verified, that the new test fails before the
change and
On Thu, 19 Jun 2025 17:03:13 GMT, Phil Race wrote:
> Right. What I am obliged to do in order to satisfy one specific TCK test.
> Nothing more.
Thank you! It makes perfect sense.
Looks good to me.
-
PR Comment: https://git.openjdk.org/jdk/pull/25881#issuecomment-2988718647
On Wed, 18 Jun 2025 17:57:26 GMT, Phil Race wrote:
> Clarify the behaviour of new HeadlessException().getMessage()
> The spec. is updated to be clear that empty means null, not an empty string.
> > > Should each constructor specify how the message returned by `getMessage`
> > > is constructed i
On Wed, 18 Jun 2025 17:57:26 GMT, Phil Race wrote:
> Clarify the behaviour of new HeadlessException().getMessage()
> The spec. is updated to be clear that empty means null, not an empty string.
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/
On Thu, 19 Jun 2025 10:08:33 GMT, Alexey Ivanov wrote:
>>> Also that other constructor (which github won't let me comment on) installs
>>> the description even if the image is null.
>>
>> I don't see it as a problem.
>>
>> If the app developer wants to initialise the object with `null` image a
On Thu, 19 Jun 2025 04:01:49 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line
>> 1033:
>>
>>> 1031: /**
>>> 1032: * Gets the allocation to give the root View.
>>> 1033: * The Rectangle returned has nothing to do with vi
On Thu, 19 Jun 2025 11:11:32 GMT, Manukumar V S wrote:
>> Issue:
>> MyanmarTextTest.java produces a false positive result when some of the test
>> preconditions are not met. It checks whether certain fonts are present in
>> the system, for example, 'Padauk' on Linux. If the required font is mis
On Thu, 19 Jun 2025 11:11:32 GMT, Manukumar V S wrote:
>> Issue:
>> MyanmarTextTest.java produces a false positive result when some of the test
>> preconditions are not met. It checks whether certain fonts are present in
>> the system, for example, 'Padauk' on Linux. If the required font is mis
On Wed, 18 Jun 2025 22:55:12 GMT, Damon Nguyen wrote:
>> This change is to restore the original intent of the test by updating the
>> instructions to check that the type of Cursor is preserved when clicked and
>> dragged. Now the test correctly has instructions to check that an I-beam
>> curso
8353950: Clipboard interaction on Windows is unstable
-
Commit messages:
- Backport 92be7821f5d5cbf5fe0244b41b2b7b1ada898df0
Changes: https://git.openjdk.org/jdk/pull/25897/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25897&range=00
Issue: https://bugs.openjdk.org/brow
> Issue:
> MyanmarTextTest.java produces a false positive result when some of the test
> preconditions are not met. It checks whether certain fonts are present in the
> system, for example, 'Padauk' on Linux. If the required font is missing, the
> test simply returns early, and the test ends up
On Thu, 19 Jun 2025 04:02:30 GMT, Prasanta Sadhukhan
wrote:
>> getVisibleEditorRect() return the bounds of the text editor and the return
>> value is used to to set-size/paint the
>> `javax.swing.text.View` of this text editor component.
>> "the allocation" refers to what allocated area the vi
On Thu, 19 Jun 2025 09:15:08 GMT, Srinivas Mandalika
wrote:
>> Use PassFailJFrame to streamline the test
>> java/awt/print/Dialog/DialogType.java, as is for several of the manual tests.
>>
>> Modified Manual Test Passed when run using jtreg.
>
> Srinivas Mandalika has updated the pull request
On Thu, 19 Jun 2025 10:10:46 GMT, Sergey Bylokhov wrote:
> It would be good if we could eliminate the reference to WindowsButtonUI.
But we want the regression to reproduce the original problem. The problem was
specific to `WindowsButtonUI`, in `WindowsGraphicsUtils` according to comments
in th
On Thu, 19 Jun 2025 03:01:15 GMT, Prasanta Sadhukhan
wrote:
>> When trying to call 'icon.setImage(null);' where 'icon' is an instance of
>> ImageIcon, a null pointer exception is thrown at runtime.
>> The code tried to get the `id` for that image and instantiates
>> `MediaTracker` to associate
On Thu, 19 Jun 2025 04:35:17 GMT, Prasanta Sadhukhan
wrote:
> We dont know the exact order of setDescription call..
What do you mean?
It's a constructor, nothing else has been called on the instance yet.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2156
On Wed, 18 Jun 2025 05:54:30 GMT, Tejesh R wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added SkippedException when Printer is unavailable.
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 62:
>
>>
On Thu, 19 Jun 2025 09:47:28 GMT, Alexey Ivanov wrote:
>> Compilation error on windows with `WindowsButtonUI` used. Replaced it with
>> `BasicButtonUI` to maintain overriding the `paintText` method but this was
>> not the same as Windows L&F buttons. I attempted to import `WindowsButtonUI`
>>
On Thu, 19 Jun 2025 10:06:17 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 232:
>>
>>> 230: Object o = image.getProperty("comment", imageObserver);
>>> 231: if (o instanceof String) {
>>> 232: description = (String) o;
>>
On Wed, 18 Jun 2025 22:21:22 GMT, Phil Race wrote:
> Also that other constructor (which github won't let me comment on) installs
> the description even if the image is null.
I don't see it as a problem.
If the app developer wants to initialise the object with `null` image and a
description, w
On Thu, 19 Jun 2025 03:42:21 GMT, Manukumar V S wrote:
>> Issue:
>> MyanmarTextTest.java produces a false positive result when some of the test
>> preconditions are not met. It checks whether certain fonts are present in
>> the system, for example, 'Padauk' on Linux. If the required font is mis
On Wed, 18 Jun 2025 22:53:20 GMT, Damon Nguyen wrote:
> > Please confirm that you can reproduce JDK-4991587 by the updated test.
>
> The updated test does contain all of the text within the blue border now as
> expected (instead of overlapping or being outside the borders of the
> textRect, as
On Wed, 18 Jun 2025 19:28:18 GMT, Damon Nguyen wrote:
> Compilation error on windows with `WindowsButtonUI` used. Replaced it with
> `BasicButtonUI` to maintain overriding the `paintText` method but this was
> not the same as Windows L&F buttons. I attempted to import `WindowsButtonUI`
> and e
> Use PassFailJFrame to streamline the test
> java/awt/print/Dialog/DialogType.java, as is for several of the manual tests.
>
> Modified Manual Test Passed when run using jtreg.
Srinivas Mandalika has updated the pull request incrementally with one
additional commit since the last revision:
On Wed, 18 Jun 2025 22:26:46 GMT, Phil Race wrote:
> > Should each constructor specify how the message returned by `getMessage` is
> > constructed instead of _directing to the specification of `getMessage` for
> > details_?
>
> 100% no. I am not wasting time on that. This whole spec. is gettin
On Wed, 18 Jun 2025 05:46:14 GMT, Abhishek Kumar wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added SkippedException when Printer is unavailable.
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 59:
On Wed, 18 Jun 2025 05:58:22 GMT, Tejesh R wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added SkippedException when Printer is unavailable.
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 52:
>
>>
On Wed, 18 Jun 2025 05:54:40 GMT, Tejesh R wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added SkippedException when Printer is unavailable.
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 64:
>
>>
On Wed, 18 Jun 2025 05:45:53 GMT, Abhishek Kumar wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added SkippedException when Printer is unavailable.
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 53:
On Wed, 18 Jun 2025 05:42:05 GMT, Abhishek Kumar wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added SkippedException when Printer is unavailable.
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 47:
> Use PassFailJFrame to streamline the test
> java/awt/print/Dialog/DialogType.java, as is for several of the manual tests.
>
> Modified Manual Test Passed when run using jtreg.
Srinivas Mandalika has updated the pull request incrementally with two
additional commits since the last revision:
There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead in
Aqua LAF which updates
[LEAD_SELECTION_PATH_PROPERTY](https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/swing/JTree.html#LEAD_SELECTION_PATH_PROPERTY).
Other L&F uses "ctrl DOWN/UP" to selectNex
On Wed, 23 Apr 2025 08:53:57 GMT, Andrey Turbanov wrote:
> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
> can call `List.remove(Object)` directly. It's faster and cleaner.
> `eventsList` is an ArrayList.
src/java.desktop/share/classes/javax/sound/midi/Track.java
No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
can call `List.remove(Object)` directly. It's faster and cleaner.
`eventsList` is an ArrayList.
-
Commit messages:
- [PATCH] Remove unnecessary List.indexOf key from Track.remove
Changes: https://git.openj
On Wed, 23 Apr 2025 17:26:38 GMT, Chen Liang wrote:
>> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we
>> can call `List.remove(Object)` directly. It's faster and cleaner.
>> `eventsList` is an ArrayList.
>
> src/java.desktop/share/classes/javax/sound/midi/Track.java
On Thu, 29 May 2025 22:21:12 GMT, Phil Race wrote:
>it is one succinct line
But it's not one line - it's 2 lines
https://github.com/openjdk/jdk/blob/08b1fa4cb39e56497052e3ee13e679c8734cf7c5/src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java#L174-L175
>there is nothing wrong with
63 matches
Mail list logo
