Re: RFR: 8360070: AccessibleText.getBeforeIndex returns null for last character

On Mon, 23 Jun 2025 23:24:14 GMT, Sergey Bylokhov wrote: > I am not sure about the statement above. I think the check should take care > of the direction, which is -1 in your case I think the check is to ensure the passed index parameter is to verify the boundary of text length. > This is act

client-libs-dev@openjdk.org

Ctrl+Shift+Down/Up does extend row selection down or up in Aqua L&F as it does in native tree view in Finder. Fixed the keybindings. - Commit messages: - 8360462: [macosx] row selection not working with Ctrl+Shift+Down/Up in AquaL&F Changes: https://git.openjdk.org/jdk/pull/25966/

RFR: 8360120: Bundled macOS applications not receiving OpenURL events when launched as subprocess

Added an on-demand installation of the native OpenURL event handler to the `Application.setOpenURIHandler()`. This does not break the specification for the affected API, since the requirement of the application being bundled and containing `CFBundleURLTypes` in the `Info.plist` is still valid:

Re: RFR: 8008222: [macosx] selectNextChangeLead is not implemented for Tree in Aqua LAF [v2]

On Tue, 24 Jun 2025 12:11:52 GMT, Prasanta Sadhukhan wrote: >> There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead >> in Aqua LAF which updates >> [LEAD_SELECTION_PATH_PROPERTY](https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/swing/JTree.html#LEAD_

Re: RFR: 8360070: AccessibleText.getBeforeIndex returns null for last character

On Tue, 24 Jun 2025 23:00:03 GMT, Sergey Bylokhov wrote: > > I think the check is to ensure the passed index parameter is to verify the > > boundary of text length. > > Yes, but the index passed to the method is `an index within the text`, so it > should be from 0 to length - 1. You can take a

Re: RFR: 8008222: [macosx] selectNextChangeLead is not implemented for Tree in Aqua LAF [v2]

On Tue, 24 Jun 2025 12:11:52 GMT, Prasanta Sadhukhan wrote: >> There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead >> in Aqua LAF which updates >> [LEAD_SELECTION_PATH_PROPERTY](https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/swing/JTree.html#LEAD_

Re: RFR: 8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus Lo

On Fri, 20 Jun 2025 03:09:32 GMT, Prasanta Sadhukhan wrote: > Issue is RadioButtonMenuItem and CheckBoxMenuItem bullet/checkmark icon is > not displayed in WindowsL&F when the test is run with NimbusL&F. > This is because `WindowsIconFactory#VistaMenuItemCheckIcon.paintIcon` called > `getLaFIc

Re: RFR: 8008222: [macosx] selectNextChangeLead is not implemented for Tree in Aqua LAF [v2]

On Tue, 24 Jun 2025 12:11:52 GMT, Prasanta Sadhukhan wrote: >> There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead >> in Aqua LAF which updates >> [LEAD_SELECTION_PATH_PROPERTY](https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/swing/JTree.html#LEAD_

Re: RFR: 8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus Lo

On Tue, 24 Jun 2025 17:23:47 GMT, Alexey Ivanov wrote: > If there were another L&F to test, or if Windows L&F weren't the last in the > list, the test will continue to fail because the current L&F will again be > different from Windows L&F. But there isn't..The L&F the test wanted to test and

Re: RFR: 8360070: AccessibleText.getBeforeIndex returns null for last character [v2]

> `AccessibleText.getBeforeIndex` method returns `null for last characte`r due > to the **wrong boundary value condition check**. > This method returns `null` when the `passed index parameter` is equal to > `text's length` which is incorrect. > `getBeforeIndex` method should return `null` only if

Re: RFR: 8159055: ImageIcon.setImage and ImageIcon(Image) constructor can't handle null parameter [v11]

On Mon, 23 Jun 2025 21:17:05 GMT, ExE Boss wrote: >> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 233: >> >>> 231: Object o = image.getProperty("comment", imageObserver); >>> 232: if (o instanceof String) { >>> 233: description = (String) o; >> >> T

Re: RFR: 8360070: AccessibleText.getBeforeIndex returns null for last character

On Mon, 23 Jun 2025 23:24:14 GMT, Sergey Bylokhov wrote: >> `AccessibleText.getBeforeIndex` method returns `null for last characte`r due >> to the **wrong boundary value condition check**. >> This method returns `null` when the `passed index parameter` is equal to >> `text's length` which is in

Re: RFR: 8008222: [macosx] selectNextChangeLead is not implemented for Tree in Aqua LAF [v2]

On Tue, 24 Jun 2025 12:11:52 GMT, Prasanta Sadhukhan wrote: >> There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead >> in Aqua LAF which updates >> [LEAD_SELECTION_PATH_PROPERTY](https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/swing/JTree.html#LEAD_

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

On Tue, 24 Jun 2025 14:59:18 GMT, Weijun Wang wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update to german translations > > src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties > l

Re: RFR: 8360070: AccessibleText.getBeforeIndex returns null for last character

On Tue, 24 Jun 2025 11:34:04 GMT, Abhishek Kumar wrote: > I think the check is to ensure the passed index parameter is to verify the > boundary of text length. Yes, but the index passed to the method is `an index within the text`, so it should be from 0 to length - 1. You can take a look at th

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v5]

> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK since the previous L10n drop. Alisen Chung has updated the pull request incrementally with three additional commits since the last revision: - Update src/jdk.compiler/share/classes/com/s

Re: RFR: 8159055: ImageIcon.setImage and ImageIcon(Image) constructor can't handle null parameter [v10]

On Fri, 20 Jun 2025 12:13:23 GMT, Alexey Ivanov wrote: >> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 389: >> >>> 387: this.image = image; >>> 388: if (image == null) { >>> 389: this.description = null; >> >> We must not change the description. Why

Re: RFR: 8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus Lo

On Tue, 24 Jun 2025 16:14:28 GMT, Prasanta Sadhukhan wrote: > I dont think the test is invalid..It was in closed repo and tested for so > many years before it got opensourced L&F is anyway applied to entire > component tree in the fix via `SwingUtilities.updateComponentTreeUI(frame);` I belie

Re: RFR: 8358526: Clarify behavior of java.awt.HeadlessException constructed with no-args

On Tue, 24 Jun 2025 12:43:37 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/Headless/HeadlessExceptionTest.java line 37: >> >>> 35: public static void main (String[] args) { >>> 36: String nullmsg = new HeadlessException().getMessage(); >>> 37: String emptymsg = new HeadlessE

Re: RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v27]

> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is > shown without radiobutton in WIndowsLookAndFeel as there was no provision of > drawing the radiobutton alongside icon. > If icon is not there, the radiobutton is drawn. Added provision of drawing > the radiobutton win

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

On Wed, 18 Jun 2025 16:43:02 GMT, Alexey Ivanov wrote: >> There is still only one space, the new one is a full width colon (U+FF1A). >> Localization rules have been observed to make the switch from regular colons >> (U+003A) into the full width version depending on the language. > > Thank you f

Re: RFR: 8008222: [macosx] selectNextChangeLead is not implemented for Tree in Aqua LAF [v2]

> There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead > in Aqua LAF which updates > [LEAD_SELECTION_PATH_PROPERTY](https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/swing/JTree.html#LEAD_SELECTION_PATH_PROPERTY). > Other L&F uses "ctrl DOWN/UP" to

Re: RFR: 8358526: Clarify behavior of java.awt.HeadlessException constructed with no-args

On Fri, 20 Jun 2025 22:22:53 GMT, Harshitha Onkar wrote: >> Clarify the behaviour of new HeadlessException().getMessage() >> The spec. is updated to be clear that empty means null, not an empty string. > > test/jdk/java/awt/Headless/HeadlessExceptionTest.java line 37: > >> 35: public static

Re: RFR: 8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus Lo

On Fri, 20 Jun 2025 03:09:32 GMT, Prasanta Sadhukhan wrote: > Issue is RadioButtonMenuItem and CheckBoxMenuItem bullet/checkmark icon is > not displayed in WindowsL&F when the test is run with NimbusL&F. > This is because `WindowsIconFactory#VistaMenuItemCheckIcon.paintIcon` called > `getLaFIc

Re: RFR: 8008222: [macosx] selectNextChangeLead is not implemented for Tree in Aqua LAF

On Thu, 19 Jun 2025 07:59:57 GMT, Prasanta Sadhukhan wrote: > There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead > in Aqua LAF which updates > [LEAD_SELECTION_PATH_PROPERTY](https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/swing/JTree.html#LEAD_SEL

Re: RFR: 8360070: AccessibleText.getBeforeIndex returns null for last character [v3]

> `AccessibleText.getBeforeIndex` method returns `null for last characte`r due > to the **wrong boundary value condition check**. > This method returns `null` when the `passed index parameter` is equal to > `text's length` which is incorrect. > `getBeforeIndex` method should return `null` only if

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: "Smudge" factor on Mac OSX mouse events?

On Mon, Jun 23, 2025 at 10:54 PM Jeremy Wood wrote: > I can’t speak to the Apple Magic Mouse specifically, but at my old job we > wrote a work-around > > for a very similar-sounding co

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las