On Wed, 16 Jul 2025 06:20:22 GMT, Tejesh R wrote:
>> `frame.requestFocus()` tries to make the frame current focus owner but it
>> does not guarantee that focus will be granted. So, to be on safer side, it's
>> better to bring the frame to the front and the request keyboard focus.
>
> According
On Wed, 16 Jul 2025 05:48:43 GMT, SendaoYan wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> copyright year update
>
> test/jdk/javax/swing/JMenuBar/TestMenuMnemonicLinuxAndMac.java line 120:
>
>> 118: fr
On Wed, 16 Jul 2025 06:12:11 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JMenuBar/TestMenuMnemonicLinuxAndMac.java line 120:
>>
>>> 118: frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
>>> 119: frame.setVisible(true);
>>> 120: frame.toFront();
>>
>> ` frame.
> Test is failing on intermittently on macOS and ubuntu machine in CI testing.
> Test stabilization done by requesting focus for the frame before starting the
> testing.
>
> Ran the test before and after the fix and there is no failure after test
> stabilization for multiple run.
> CI link is a
On Wed, 16 Jul 2025 05:25:39 GMT, Tejesh R wrote:
>> Test is failing on intermittently on macOS and ubuntu machine in CI testing.
>> Test stabilization done by requesting focus for the frame before starting
>> the testing.
>>
>> Ran the test before and after the fix and there is no failure aft
On Tue, 15 Jul 2025 05:40:17 GMT, Abhishek Kumar wrote:
> Test is failing on intermittently on macOS and ubuntu machine in CI testing.
> Test stabilization done by requesting focus for the frame before starting the
> testing.
>
> Ran the test before and after the fix and there is no failure af
On Tue, 15 Jul 2025 05:40:17 GMT, Abhishek Kumar wrote:
> Test is failing on intermittently on macOS and ubuntu machine in CI testing.
> Test stabilization done by requesting focus for the frame before starting the
> testing.
>
> Ran the test before and after the fix and there is no failure af
On Tue, 15 Jul 2025 19:31:54 GMT, Phil Race wrote:
> No issue was raised because no one knew any better. Now we know.
But people would have noted the difference if native app renders it differently
in Windows 10..Now both bullet/checkmark and imageicon is superimposed on top
of each other..if
On Wed, 16 Jul 2025 03:40:43 GMT, Brent Christian wrote:
> This brings in cpu25_07 changes.
This pull request has now been integrated.
Changeset: 0e6bf005
Author:Brent Christian
URL:
https://git.openjdk.org/jdk/commit/0e6bf0055057fae844748a300551549553f59f03
Stats: 358 lines in
> This brings in cpu25_07 changes.
Brent Christian has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/26340/files
On Wed, 16 Jul 2025 03:40:43 GMT, Brent Christian wrote:
> This brings in cpu25_07 changes.
Marked as reviewed by jpai (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26340#pullrequestreview-3023001849
This brings in cpu25_07 changes.
-
Commit messages:
- 8360147: Better Glyph drawing redux
- 8355884: [macos] java/awt/Frame/I18NTitle.java fails on MacOS
- 8350991: Improve HTTP client header handling
- 8349594: Enhance TLS protocol support
- 8349584: Improve compiler processing
On Tue, 15 Jul 2025 22:34:21 GMT, Phil Race wrote:
>> there is even a bug for Cleaner that the reachabilityFence should be moved
>> to the end of register:
>> https://bugs.openjdk.org/browse/JDK-8291867
>> If there are no objectiosn I'll add it to the Disposer.addRecord in a
>> separate bug.
>
On Tue, 15 Jul 2025 22:38:07 GMT, Phil Race wrote:
>> src/java.desktop/macosx/classes/apple/laf/JRSUIControl.java line 138:
>>
>>> 136: }
>>> 137: cfDictionaryPtr = 0;
>>> 138: }
>>
>> Is it possible for this method to be called twice? It seems that not all
>> o
On Tue, 15 Jul 2025 22:39:48 GMT, Phil Race wrote:
>> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 153:
>>
>>> 151: }
>>> 152:
>>> 153: public synchronized void dispose() {
>>
>> Why the method is synchronized? we can call it on a different threads via
On Tue, 15 Jul 2025 21:14:54 GMT, Sergey Bylokhov wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 153:
>
>> 151
On Tue, 15 Jul 2025 20:24:46 GMT, Sergey Bylokhov wrote:
>> Eliminate a finalize() method in the Swing macOS implementation.
>>
>> I tested that the dispose method is being called by running this small test
>> in combination with some 'println' statements in the source code (now
>> removed)
>>
On Tue, 15 Jul 2025 21:43:04 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/macosx/classes/apple/laf/JRSUIControl.java line 115:
>>
>>> 113: flipped = other.flipped;
>>> 114: cfDictionaryPtr = getCFDictionary(flipped);
>>> 115: if (cfDictionaryPtr == 0) throw new Runtime
On Tue, 15 Jul 2025 20:24:36 GMT, Sergey Bylokhov wrote:
>> Eliminate a finalize() method in the Swing macOS implementation.
>>
>> I tested that the dispose method is being called by running this small test
>> in combination with some 'println' statements in the source code (now
>> removed)
>>
On Tue, 15 Jul 2025 05:40:17 GMT, Abhishek Kumar wrote:
> Test is failing on intermittently on macOS and ubuntu machine in CI testing.
> Test stabilization done by requesting focus for the frame before starting the
> testing.
>
> Ran the test before and after the fix and there is no failure af
On Tue, 15 Jul 2025 20:42:15 GMT, Phil Race wrote:
> Remove a finalize() method in CGraphicsEnvironment, replacing it with
> Disposer.
>
> I don't see a way to add a test to verify this clean up.
src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 153:
> 151: }
> 15
Remove a finalize() method in CGraphicsEnvironment, replacing it with Disposer.
I don't see a way to add a test to verify this clean up.
-
Commit messages:
- 8362291
Changes: https://git.openjdk.org/jdk/pull/26332/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26332&range
On Tue, 3 Jun 2025 06:38:25 GMT, Sergey Bylokhov wrote:
> This PR updates the last (!!) remaining platform-specific part of the
> java.desktop module: macos.
> The unix/windows were previously addressed in:
> https://github.com/openjdk/jdk/pull/24170 ,
> https://github.com/openjdk/jdk/pull/249
On Tue, 15 Jul 2025 19:57:56 GMT, Phil Race wrote:
> Eliminate a finalize() method in the Swing macOS implementation.
>
> I tested that the dispose method is being called by running this small test
> in combination with some 'println' statements in the source code (now removed)
>
> import java
On Tue, 15 Jul 2025 19:57:56 GMT, Phil Race wrote:
> Eliminate a finalize() method in the Swing macOS implementation.
>
> I tested that the dispose method is being called by running this small test
> in combination with some 'println' statements in the source code (now removed)
>
> import java
Eliminate a finalize() method in the Swing macOS implementation.
I tested that the dispose method is being called by running this small test in
combination with some 'println' statements in the source code (now removed)
import javax.swing.JTabbedPane;
import javax.swing.plaf.TabbedPaneUI;
publi
On Mon, 14 Jul 2025 17:00:35 GMT, Anass Baya wrote:
> The getFocusableWindowState() method is not intended to modify the
> configuration; doing so can cause recursive re-entry on Linux.
What's causing the recursive re-entry? Is the bug in the code path in linux
when calling getFocusableWindowS
On Mon, 14 Jul 2025 05:16:11 GMT, Prasanta Sadhukhan
wrote:
> > Shouldn't Windows 10 do it the new way too ?
>
> I didn't intentionally change the design for Windows 10 as that was the
> behaviour which was in existence (even though by "accident" as we learnt) for
> so long our JDK code for W
On Tue, 15 Jul 2025 03:58:55 GMT, Sergey Bylokhov wrote:
>> I modified Abhishek's test:
>>
>>
>> System.out.println(" i bef at aft");
>> for (int i : new int[] {0, 1, 2, 8, 9, 10}) {
>> System.out.printf("%2d%5s%5s%5s\n",
>>
On Mon, 14 Jul 2025 08:36:57 GMT, Abhishek Kumar wrote:
>> **Issue** : VO doesn't announce Tab items of a JTabbedPane as RadioButton
>> which is wrong.
>>
>> **Analysis** : That is due to the role mapping of tab items as
>> `NSAccessibilityRadioButtonRole` in `JavaAccessibilityUtilities.m` fi
On Wed, 25 Jun 2025 07:03:33 GMT, Dmitry Kulikov wrote:
>> Added an on-demand installation of the native OpenURL event handler to the
>> `Application.setOpenURIHandler()`.
>>
>> This does not break the specification for the affected API, since the
>> requirement of the application being bundle
31 matches
Mail list logo
