On Tue, 15 Jul 2025 05:40:17 GMT, Abhishek Kumar wrote:
> Test is failing on intermittently on macOS and ubuntu machine in CI testing.
> Test stabilization done by requesting focus for the frame before starting the
> testing.
>
> Ran the test before and after the fix and there is no failure af
On Wed, 2 Jul 2025 15:05:27 GMT, Abhishek Kumar wrote:
> **Issue** : VO doesn't announce Tab items of a JTabbedPane as RadioButton
> which is wrong.
>
> **Analysis** : That is due to the role mapping of tab items as
> `NSAccessibilityRadioButtonRole` in `JavaAccessibilityUtilities.m` file.
>
On Thu, 17 Jul 2025 21:16:04 GMT, Phil Race wrote:
>> Replace finalization with 2D Disposer
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8362452
Marked as reviewed by kizune (Reviewer).
-
PR Review: https://g
On Mon, 14 Jul 2025 08:36:57 GMT, Abhishek Kumar wrote:
>> **Issue** : VO doesn't announce Tab items of a JTabbedPane as RadioButton
>> which is wrong.
>>
>> **Analysis** : That is due to the role mapping of tab items as
>> `NSAccessibilityRadioButtonRole` in `JavaAccessibilityUtilities.m` fi
On Thu, 17 Jul 2025 21:25:08 GMT, Phil Race wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since th
On Thu, 17 Jul 2025 21:30:10 GMT, Phil Race wrote:
> Replace CFont.finalize() with a disposer.
LGTM
-
Marked as reviewed by kizune (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26373#pullrequestreview-3031933694
On Thu, 17 Jul 2025 17:04:25 GMT, Khalid Boulanouare wrote:
> In Windows machines, the click lands on the reduce control of the window, and
> this causes the windows to be iconified and the test fails.
WHich test in particular? or is it all tests have this behavior?
> The test needs to click o
On Thu, 17 Jul 2025 21:30:10 GMT, Phil Race wrote:
> Replace CFont.finalize() with a disposer.
Please update the copyright year..
-
Marked as reviewed by psadhukhan (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26373#pullrequestreview-3031680013
On Wed, 16 Jul 2025 22:45:21 GMT, Phil Race wrote:
>> Eliminate a finalize() method in the Swing macOS implementation.
>>
>> I tested that the dispose method is being called by running this small test
>> in combination with some 'println' statements in the source code (now
>> removed)
>>
>> i
On Thu, 17 Jul 2025 21:16:04 GMT, Phil Race wrote:
>> Replace finalization with 2D Disposer
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8362452
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 639:
On Thu, 17 Jul 2025 11:12:56 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JMenuBar/TestMenuMnemonicLinuxAndMac.java line 120:
>>
>>> 118: frame.setVisible(true);
>>> 119: frame.toFront();
>>> 120: frame.requestFocus();
>>
>> If you are particular about focus being
On Thu, 17 Jul 2025 21:16:04 GMT, Phil Race wrote:
>> Replace finalization with 2D Disposer
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8362452
Marked as reviewed by psadhukhan (Reviewer).
-
PR Review: https
On Thu, 17 Jul 2025 21:16:04 GMT, Phil Race wrote:
>> Replace finalization with 2D Disposer
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8362452
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git
On Thu, 17 Jul 2025 21:30:10 GMT, Phil Race wrote:
> Replace CFont.finalize() with a disposer.
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26373#pullrequestreview-3031652098
On Wed, 16 Jul 2025 22:45:21 GMT, Phil Race wrote:
>> Eliminate a finalize() method in the Swing macOS implementation.
>>
>> I tested that the dispose method is being called by running this small test
>> in combination with some 'println' statements in the source code (now
>> removed)
>>
>> i
On Thu, 17 Jul 2025 21:25:08 GMT, Phil Race wrote:
>> Remove a finalize() method in CGraphicsEnvironment, replacing it with
>> Disposer.
>>
>> I don't see a way to add a test to verify this clean up.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since th
On Thu, 17 Jul 2025 21:20:06 GMT, Phil Race wrote:
>> I tried to compare how Cleaner and Disposer are used. I found that in most
>> cases Cleaner uses `this` as the object to track. But Disposer often uses a
>> separate object like disposerReferent or some kind of anchor. This patch is
>> one
Replace CFont.finalize() with a disposer.
-
Commit messages:
- 8362557
Changes: https://git.openjdk.org/jdk/pull/26373/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26373&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8362557
Stats: 14 lines in 1 file changed: 9
On Thu, 17 Jul 2025 00:32:34 GMT, Brent Christian wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8362291
>
> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 98:
>
>> 96: /** Reference to t
> Remove a finalize() method in CGraphicsEnvironment, replacing it with
> Disposer.
>
> I don't see a way to add a test to verify this clean up.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8362291
-
Changes:
- all:
On Thu, 17 Jul 2025 05:42:12 GMT, Sergey Bylokhov wrote:
>> I think that's right. At first I thought you were referring to the
>> constructor of the thing that wants to use the cleaner, but you mean the
>> constructor of the Cleanable itself may be still under construction when the
>> referent
On Thu, 17 Jul 2025 08:00:15 GMT, Prasanta Sadhukhan
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8362452
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 661:
>
>> 659:
>> 660: pri
> Replace finalization with 2D Disposer
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8362452
-
Changes:
- all: https://git.openjdk.org/jdk/pull/26359/files
- new: https://git.openjdk.org/jdk/pull/26359/files/f054d5a8
On Thu, 17 Jul 2025 04:29:10 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8362452
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 651:
>
>> 649:
>> 650: pub
On Mon, 7 Jul 2025 15:27:58 GMT, Khalid Boulanouare wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request with a new target base due
On Thu, 17 Jul 2025 08:04:34 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove build util
>
> test/jdk/javax/swing/JMenuBar/TestMenuMnemonicLinuxAndMac.java line 120:
>
>> 118:
On Wed, 16 Jul 2025 10:34:24 GMT, Abhishek Kumar wrote:
>> Test is failing on intermittently on macOS and ubuntu machine in CI testing.
>> Test stabilization done by requesting focus for the frame before starting
>> the testing.
>>
>> Ran the test before and after the fix and there is no failu
On Mon, 7 Jul 2025 21:41:18 GMT, Alexander Zvegintsev
wrote:
> Callbacks in the
> `src/java.desktop/unix/native/libawt_xawt/awt/screencast_portal.c` file
> normally have the following pattern:
>
>
> helper->isDone = TRUE;
> callbackEnd();
> // return;
>
>
> Failing to call `callbackEnd()`
On Wed, 16 Jul 2025 10:34:24 GMT, Abhishek Kumar wrote:
>> Test is failing on intermittently on macOS and ubuntu machine in CI testing.
>> Test stabilization done by requesting focus for the frame before starting
>> the testing.
>>
>> Ran the test before and after the fix and there is no failu
On Wed, 16 Jul 2025 20:47:23 GMT, Phil Race wrote:
> Replace finalization with 2D Disposer
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 661:
> 659:
> 660: private static native long createNSPrintInfo();
> 661: private static native void disposeNSPrintInfo(long
On Mon, 7 Jul 2025 15:27:58 GMT, Khalid Boulanouare wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid
On Wed, 16 Jul 2025 12:44:45 GMT, Matthias Baesken wrote:
> We have build errors on AIX , seems related to
> [JDK-8354415](https://bugs.openjdk.org/browse/JDK-8354415) :
>
>
> === Output from failing command(s) repeated here ===
> * For target support_native_java.desktop_libawt_xawt_awt_Graphi
On Wed, 16 Jul 2025 12:44:45 GMT, Matthias Baesken wrote:
> We have build errors on AIX , seems related to
> [JDK-8354415](https://bugs.openjdk.org/browse/JDK-8354415) :
>
>
> === Output from failing command(s) repeated here ===
> * For target support_native_java.desktop_libawt_xawt_awt_Graphi
34 matches
Mail list logo
