> Some useful methods in ExtendedRobot should be migrated into Robot itself so
> that ExtendedRobot can be removed in the future. The tests using
> ExtendedRobot for these migrated methods are changed to use only Robot
> (removing unnecessary building of ExtendedRobot).
Alisen Chung has updated
Remove finalize() from WInputMethod.java - it is used to free a native id.
Also the reason dispose() didn't free it seems no longer relevant.
Although I did see (when instrumenting) that dispose() was called when I
disposed() the Frame referencing the IM,
I don't know if I can be sure that is alwa
On Fri, 8 Aug 2025 08:10:09 GMT, Matthias Baesken wrote:
>> java/awt/font/FontNames/LocaleFamilyNames.java is slow on Windows and on
>> some machines it even times out.
>> Add some logging to the test, and we could also increase the test timeout a
>> bit.
>
> Matthias Baesken has updated the pu
On Wed, 6 Aug 2025 22:34:30 GMT, Phil Race wrote:
>> This PR removes javax/imageio/stream/ImageInputStreamImpl.finalize()
>> As a result, sub-classes which over-ride it to be empty no longer need to do
>> so.
>> Also it means that the 2 remaining classes which used it no longer can.
>> FileCache
On Fri, 8 Aug 2025 16:37:36 GMT, Daniel Gredler wrote:
> Addresses recent slight performance regressions in some J2DBench benchmarks
> focused on text drawing.
>
> `CCharToGlyphMapper` and `CompositeGlyphMapper` cache glyph IDs, but after
> JDK-8353230 they weren't caching glyph IDs for chars
On Fri, 8 Aug 2025 19:39:52 GMT, Phil Race wrote:
> > Can `MemoryCacheImageOutputStream` be included in this PR?
>
> Why ? It has nothing to dispose.
Doesn't it have a `cache`, similar to `MemoryCacheImageInputStream` ?
`public class MemoryCacheImageOutputStream extends ImageOutputStreamImpl {
On Fri, 8 Aug 2025 19:48:31 GMT, Brent Christian wrote:
> > > Can `MemoryCacheImageOutputStream` be included in this PR?
> >
> >
> > Why ? It has nothing to dispose.
>
> Doesn't it have a `cache`, similar to `MemoryCacheImageInputStream ` ?
>
> `public class MemoryCacheImageOutputStream exten
On Fri, 8 Aug 2025 19:32:34 GMT, Brent Christian wrote:
> Can `MemoryCacheImageOutputStream` be included in this PR?
Why ? It has nothing to dispose.
-
PR Comment: https://git.openjdk.org/jdk/pull/26650#issuecomment-3169104939
On Wed, 6 Aug 2025 22:34:30 GMT, Phil Race wrote:
>> This PR removes javax/imageio/stream/ImageInputStreamImpl.finalize()
>> As a result, sub-classes which over-ride it to be empty no longer need to do
>> so.
>> Also it means that the 2 remaining classes which used it no longer can.
>> FileCache
On Wed, 6 Aug 2025 14:43:55 GMT, Christian Heilmann wrote:
> Were you able to follow my explanations? Is there anything else I can do, to
> get the pull request through the review?
Sorry, I've been unable to thoroughly look at it. I'll get to this code review
next week.
-
PR Comm
On Fri, 8 Aug 2025 07:23:46 GMT, Andrey Turbanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDesktopPaneUI.java
>> line 33:
>>
>>> 31: import java.beans.*;
>>> 32:
>>> 33: import java.awt.event.ActionEvent;
>>
>> I suggest expanding all the wildcard imports:
>>
>>
>
4 of the 6 JDK ImageWriters flush the stream at the end of writing. 2 (TIFF and
GIF) do not.
This will matter if you are using a caching ImageOutputStream.
This fix makes it consistent.
-
Commit messages:
- 8364768
Changes: https://git.openjdk.org/jdk/pull/26703/files
Webrev:
Addresses recent slight performance regressions in some J2DBench benchmarks
focused on text drawing.
`CCharToGlyphMapper` and `CompositeGlyphMapper` cache glyph IDs, but after
JDK-8353230 they weren't caching glyph IDs for chars which might be affected by
the raw / non-raw glyph distinction, si
On Thu, 7 Aug 2025 21:01:46 GMT, Alexey Ushakov wrote:
>> I don't really understand how this could simplify the check.
>> For wrapping, instead of `obj == null ? null : new WeakReference<>(obj)` it
>> would become `Optional.ofNullable(obj).flatMap(e -> Optional.of(new
>> WeakReference<>(obj)))`
On Thu, 7 Aug 2025 23:04:21 GMT, Alisen Chung wrote:
>> Some useful methods in ExtendedRobot should be migrated into Robot itself so
>> that ExtendedRobot can be removed in the future. The tests using
>> ExtendedRobot for these migrated methods are changed to use only Robot
>> (removing unnece
On Thu, 7 Aug 2025 22:58:06 GMT, Alisen Chung wrote:
> I've updated the current tests in to remove /client/lib from the tests I
> already removed ER from
However, it seems that some of the touch tests are still using the ER, which
will result in a compilation failure when run with CI.
For inst
On Thu, 7 Aug 2025 12:06:02 GMT, Nikita Gubarkov wrote:
>> For "true" null objects, reset the ref itself to null. Non-null ref with
>> null content means that the object was GC'ed. GC'ed state always behaves as
>> not-equal to the new one, causing corresponding ops to be written into RQ.
>>
>>
On Fri, 8 Aug 2025 08:10:09 GMT, Matthias Baesken wrote:
>> java/awt/font/FontNames/LocaleFamilyNames.java is slow on Windows and on
>> some machines it even times out.
>> Add some logging to the test, and we could also increase the test timeout a
>> bit.
>
> Matthias Baesken has updated the pu
On Fri, 8 Aug 2025 10:03:18 GMT, Jayathirth D V wrote:
>> ByteArrayOutputStream stmt part of try-with-resources block.
>
> I understand, but line no 55 has extra space instead of usual 4 space
> indentation which is followed in next line.
> Also its a good practice to wait for a day after replyi
On Thu, 7 Aug 2025 21:27:53 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/image/XBMDecoder/XBMDecoderTest.java line 55:
>>
>>> 53: System.out.println("--- Testing " + fileName + " ---");
>>> 54: try (FileInputStream fis = new FileInputStream(file);
>>> 55:
> java/awt/font/FontNames/LocaleFamilyNames.java is slow on Windows and on some
> machines it even times out.
> Add some logging to the test, and we could also increase the test timeout a
> bit.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the las
On Thu, 7 Aug 2025 16:48:16 GMT, Phil Race wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> reduce timeout value
>
> test/jdk/java/awt/font/FontNames/LocaleFamilyNames.java line 29:
>
>> 27: * @summary Tests t
On Thu, 7 Aug 2025 16:21:41 GMT, Alexey Ivanov wrote:
>> Looks like no reasons for it to be instance field
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDesktopPaneUI.java
> line 33:
>
>> 31: import java.beans.*;
>> 32:
>> 33: import java.awt.event.ActionEvent;
>
> I suggest
23 matches
Mail list logo
