On Wed, 13 Aug 2025 18:47:37 GMT, Phil Race wrote:
> Now that Scoped Values is no longer preview, the desktop module does not need
> the entry in the base module-info.java
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26765#pullrequestreview
On Tue, 12 Aug 2025 12:27:58 GMT, Prasanta Sadhukhan
wrote:
> An inadvertent copy-paste error in assignment is fixed
This pull request has now been integrated.
Changeset: 9dcc502c
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/9dcc502cc83773561707f2afe9aee1f9e238
On Wed, 6 Aug 2025 09:43:48 GMT, Ravi Gupta wrote:
>> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java
>> left debris on system whenever fails its required frame.dispose() in finally
>> block.
>>
>>
>> finally {
>> EventQueue.invokeAndWait(ExtraButtonDrag:
On Wed, 6 Aug 2025 20:10:24 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix correcting character limit to undo all changes and leave file
>> untouched.
>> - Convert test to auto. Revert T
> When testing jtreg manual tests, some tests had unclear instructions. This PR
> is an attempt at updating these tests for clarity.
>
> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared
> to native apps and outputs drag events even when the mouse pointer is dragged
On Tue, 12 Aug 2025 20:46:03 GMT, Phil Race wrote:
> Image I/O's ImageReader and ImageWriter have never had finalize() methods,
> yet have a gratuitous mention of finalize(). This should be removed. Simple
> doc only change
>
> CSR for review : https://bugs.openjdk.org/browse/JDK-8365410
Mark
On Wed, 6 Aug 2025 20:15:08 GMT, Alexey Ivanov wrote:
>> When testing jtreg manual tests, some tests had unclear instructions. This
>> PR is an attempt at updating these tests for clarity.
>>
>> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared
>> to native apps and
On Tue, 5 Aug 2025 18:47:28 GMT, Phil Race wrote:
>> When testing jtreg manual tests, some tests had unclear instructions. This
>> PR is an attempt at updating these tests for clarity.
>>
>> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared
>> to native apps and out
On Thu, 31 Jul 2025 13:31:49 GMT, Nikita Gubarkov wrote:
> For "true" null objects, reset the ref itself to null. Non-null ref with null
> content means that the object was GC'ed. GC'ed state always behaves as
> not-equal to the new one, causing corresponding ops to be written into RQ.
>
> Alt
On Wed, 13 Aug 2025 16:07:45 GMT, Nikita Gubarkov wrote:
>> For "true" null objects, reset the ref itself to null. Non-null ref with
>> null content means that the object was GC'ed. GC'ed state always behaves as
>> not-equal to the new one, causing corresponding ops to be written into RQ.
>>
>
On Wed, 13 Aug 2025 16:07:45 GMT, Nikita Gubarkov wrote:
>> For "true" null objects, reset the ref itself to null. Non-null ref with
>> null content means that the object was GC'ed. GC'ed state always behaves as
>> not-equal to the new one, causing corresponding ops to be written into RQ.
>>
>
On Wed, 13 Aug 2025 09:54:56 GMT, Jayathirth D V wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8364434: Inconsistent BufferedContext state after GC
>>
>> Skip the test if Color was not GC'ed
>
> Test runn
On Wed, 13 Aug 2025 16:07:45 GMT, Nikita Gubarkov wrote:
>> For "true" null objects, reset the ref itself to null. Non-null ref with
>> null content means that the object was GC'ed. GC'ed state always behaves as
>> not-equal to the new one, causing corresponding ops to be written into RQ.
>>
>
> For "true" null objects, reset the ref itself to null. Non-null ref with null
> content means that the object was GC'ed. GC'ed state always behaves as
> not-equal to the new one, causing corresponding ops to be written into RQ.
>
> Although I could not find practical scenarios where refs other
On Wed, 13 Aug 2025 13:49:11 GMT, Alexander Zvegintsev
wrote:
>> Although the issues are theoretically possible on any platform when using
>> `BufferedContext`, in practice it is only known to reproduce on Metal.
>> So if we consider only known scenarios, we could as well limit it to macOS.
>>
On Wed, 13 Aug 2025 09:44:33 GMT, Andrey Turbanov wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> After suggestions from Erik and Andrey
>
> test/langtools/tools/lib/toolbox/ToolBox.java line 480:
>
>> 478:
>> 479
On Wed, 13 Aug 2025 13:25:48 GMT, Erik Joelsson wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> After suggestions from Erik and Andrey
>
> make/RunTests.gmk line 939:
>
>> 937:
>> 938: JTREG_AUTO_PROBLEM_LISTS :
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing the timeout factor, I am also using a library call to
On Wed, 13 Aug 2025 07:26:59 GMT, Serguei Spitsyn wrote:
> I've reviewed the Serviceability related tweaks and I'm okay with them in
> general. But I'm curious if you do not see any timeouts with this anymore.
I only got the four timeouts described in the description, I got a few other
failure
On Tue, 12 Aug 2025 17:13:42 GMT, Nikita Gubarkov wrote:
>> test/jdk/java/awt/ColorClass/WeakColorTest.java line 39:
>>
>>> 37: * @summary Check that garbage-collecting Color before accelerated
>>> painting is complete does not cause artifacts.
>>> 38: * @library /test/lib
>>> 39: * @run mai
On Wed, 13 Aug 2025 01:51:44 GMT, SendaoYan wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to chang
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote:
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing
On Tue, 12 Aug 2025 12:00:37 GMT, Nikita Gubarkov wrote:
>> For "true" null objects, reset the ref itself to null. Non-null ref with
>> null content means that the object was GC'ed. GC'ed state always behaves as
>> not-equal to the new one, causing corresponding ops to be written into RQ.
>>
>
On Tue, 12 Aug 2025 17:52:02 GMT, Chris Plummer wrote:
> > sun/tools/jhsdb/BasicLauncherTest.java
> > I am unsure about this one, it has not failed on my runs before, even with
> > a timeout factor of 0.7, maybe I was unlucky.
>
> @lkorinth Can you send me a link to the failure?
I sent it to y
On Wed, 13 Aug 2025 01:47:43 GMT, SendaoYan wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to chang
On Tue, 12 Aug 2025 12:00:37 GMT, Nikita Gubarkov wrote:
>> For "true" null objects, reset the ref itself to null. Non-null ref with
>> null content means that the object was GC'ed. GC'ed state always behaves as
>> not-equal to the new one, causing corresponding ops to be written into RQ.
>>
>
On Tue, 12 Aug 2025 12:00:37 GMT, Nikita Gubarkov wrote:
>> For "true" null objects, reset the ref itself to null. Non-null ref with
>> null content means that the object was GC'ed. GC'ed state always behaves as
>> not-equal to the new one, causing corresponding ops to be written into RQ.
>>
>
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote:
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing
On Wed, 13 Aug 2025 07:19:51 GMT, Tejesh R wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java
>>
>> Co-authored-by: Alexey Ivanov
>
>> Fo
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote:
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing
On Tue, 12 Aug 2025 14:00:00 GMT, Khalid Boulanouare wrote:
> For test : java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java, the fix
> suggested is to return false in method isValidForPixelCheck for embedded
> frame, in which case the component is set to null. For more details see bug:
> [JD
On Tue, 12 Aug 2025 18:56:56 GMT, Phil Race wrote:
> It seems that finalize() in X11InputMethodBase.java isn't useful.
> It calls dispose(), which in all actual implementations has just one native
> resource to release, which
> is a native struct of type X11InputMethodData (this is a JDK-defined
On Tue, 12 Aug 2025 18:56:56 GMT, Phil Race wrote:
> It seems that finalize() in X11InputMethodBase.java isn't useful.
> It calls dispose(), which in all actual implementations has just one native
> resource to release, which
> is a native struct of type X11InputMethodData (this is a JDK-defined
33 matches
Mail list logo
