Re: RFR: 8365569: Remove finalize from JavaSoundAudioClip.java

2025-08-14 Thread Sergey Bylokhov
On Thu, 14 Aug 2025 17:27:09 GMT, Phil Race wrote: > This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of > the implementation is in a delegate > com/sun/media/sound/JavaSoundAudioClipDelegate.java > > Then a disposer can be used to free the audio resources held by the del

RFR: 8361606 : ConsumeNextMnemonicKeyTypedTest.java fails on Windows: character typed with VK_A: a

2025-08-14 Thread Anass Baya
**Analysis :** When the problem occurred, the key press event related to the mnemonic triggered the item selection. However, as we returned to the menu, the subsequent key typed event arrived and was treated as a normal key press instead of being recognized as part of the mnemonic sequence. **P

Re: RFR: 8365180: Remove sun.awt.windows.WInputMethod.finalize()

2025-08-14 Thread Sergey Bylokhov
On Fri, 8 Aug 2025 21:38:27 GMT, Phil Race wrote: > Remove finalize() from WInputMethod.java - it is used to free a native id. > Also the reason dispose() didn't free it seems no longer relevant. > Although I did see (when instrumenting) that dispose() was called when I > disposed() the Frame re

Re: RFR: 8365292: Remove javax.imageio.spi.ServiceRegistry.finalize()

2025-08-14 Thread Sergey Bylokhov
On Tue, 12 Aug 2025 19:32:33 GMT, Phil Race wrote: > Remove javax.imageio.spi.ServiceRegistry.finalize() since it is deprecated > for removal. > The impact of this should be minimal. The IIORegistry will now be a singleton > - which it already was > in practice since Applets are no longer supp

Re: RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v2]

2025-08-14 Thread Alexey Ivanov
On Thu, 14 Aug 2025 16:55:35 GMT, Phil Race wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8365389 > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java > line 719: > >> 717: private vo

Re: RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v2]

2025-08-14 Thread Alexey Ivanov
On Thu, 14 Aug 2025 16:53:27 GMT, Phil Race wrote: >> This refactors some Swing code to pass args instead of using statics >> The bug report suggests some further refactoring which could be considered >> later, but the most >> important thing to do is to eliminate using statics to pass args. >>

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v2]

2025-08-14 Thread Doug Simon
On Wed, 13 Aug 2025 14:22:08 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

RFR: 8365569: Remove finalize from JavaSoundAudioClip.java

2025-08-14 Thread Phil Race
This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of the implementation is in a delegate com/sun/media/sound/JavaSoundAudioClipDelegate.java Then a disposer can be used to free the audio resources held by the delegate when the JavaSoundAudioClip becomes unreachable. --

Re: RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v2]

2025-08-14 Thread Phil Race
On Thu, 14 Aug 2025 16:53:27 GMT, Phil Race wrote: >> This refactors some Swing code to pass args instead of using statics >> The bug report suggests some further refactoring which could be considered >> later, but the most >> important thing to do is to eliminate using statics to pass args. >>

Re: RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v2]

2025-08-14 Thread Phil Race
> This refactors some Swing code to pass args instead of using statics Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8365389 - Changes: - all: https://git.openjdk.org/jdk/pull/26783/files - new: https://git.openjdk.or

RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI

2025-08-14 Thread Phil Race
This refactors some Swing code to pass args instead of using statics - Commit messages: - 8365389 Changes: https://git.openjdk.org/jdk/pull/26783/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26783&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8365389 Stats: 30

Re: RFR: 8359955: Regressions ~7% in several J2DBench in 25-b26

2025-08-14 Thread Daniel Gredler
On Fri, 8 Aug 2025 21:26:26 GMT, Phil Race wrote: >> Addresses recent slight performance regressions in some J2DBench benchmarks >> focused on text drawing. >> >> `CCharToGlyphMapper` and `CompositeGlyphMapper` cache glyph IDs, but after >> JDK-8353230 they weren't caching glyph IDs for chars

Integrated: 8365416: java.desktop no longer needs preview feature access

2025-08-14 Thread Phil Race
On Wed, 13 Aug 2025 18:47:37 GMT, Phil Race wrote: > Now that Scoped Values is no longer preview, the desktop module does not need > the entry in the base module-info.java This pull request has now been integrated. Changeset: b0f98df7 Author:Phil Race URL: https://git.openjdk.org/j

Re: RFR: 8365416: java.desktop no longer needs preview feature access

2025-08-14 Thread Jaikiran Pai
On Wed, 13 Aug 2025 18:47:37 GMT, Phil Race wrote: > Now that Scoped Values is no longer preview, the desktop module does not need > the entry in the base module-info.java Marked as reviewed by jpai (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/26765#pullrequestreview-