On Tue, 29 Jul 2025 17:22:09 GMT, Phil Race wrote:
>> Jayathirth D V has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
On Fri, 1 Aug 2025 00:31:45 GMT, Alisen Chung wrote:
>> Jayathirth D V has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commit
On Thu, 21 Aug 2025 02:30:11 GMT, Prasanta Sadhukhan
wrote:
> The `ImageIcon(Image)` constructor sets the description field to the value of
> "comment" property if it's a string. The `ImageIcon(Image, String)`
> constructor calls ImageIcon(Image). Since the two-parameter constructor
> explici
> We need to throw appropriate exception when we pass invalid image index
> values to ImageReader.getImageTypes().
> We throw IOOBE in all other plugins except JPEG, Added appropriate check to
> throw IOOBE when JpegImageReader has invalid image index.
Jayathirth D V has updated the pull request
On Mon, 18 Aug 2025 16:49:48 GMT, Alexey Ivanov wrote:
> Add the missing `@Override` annotations to anonymous classes implementing
> `WindowsMenuItemUIAccessor`.
>
> PR #24170 for [JDK-8352638](https://bugs.openjdk.org/browse/JDK-8352638)
> added the `@Override` annotations to `getMenuItem` an
On Tue, 19 Aug 2025 17:25:03 GMT, Sergey Bylokhov wrote:
> the test might be updated to render components into the buffered image and
> then compare exact values.
And what does it test then? The original bug was about dragging the internal
frame creates artifacts on the underlying component. B
On Thu, 21 Aug 2025 01:21:56 GMT, Damon Nguyen wrote:
> Ubuntu machine has multiple failing java awt tests. When looking at the
> screenshots of the desktop when each test fails, a white square can be seen
> at the top-left of the desktop.
>
> src="https://github.com/user-attachments/assets/5
The `ImageIcon(Image)` constructor sets the description field to the value of
"comment" property if it's a string. The `ImageIcon(Image, String)` constructor
calls ImageIcon(Image). Since the two-parameter constructor explicitly provides
the value for the description field, the implicitly set va
> Test compares specific pixels with expected color and needed color profile
> setting in macOS26 is not available it seems.
> Since the pixel color difference is slightly off, I have added a tolerance
> which had been present in many other tests so it's not without precedent
Prasanta Sadhukhan
On Thu, 21 Aug 2025 02:04:29 GMT, Prasanta Sadhukhan
wrote:
>> Test compares specific pixels with expected color and needed color profile
>> setting in macOS26 is not available it seems.
>> Since the pixel color difference is slightly off, I have added a tolerance
>> which had been present in
On Tue, 19 Aug 2025 06:14:21 GMT, Prasanta Sadhukhan
wrote:
> Test compares specific pixels with expected color and needed color profile
> setting in macOS26 is not available it seems.
> Since the pixel color difference is slightly off, I have added a tolerance
> which had been present in many
On Tue, 19 Aug 2025 20:12:40 GMT, Phil Race wrote:
>> This refactors some Swing code to pass args instead of using statics
>> The bug report suggests some further refactoring which could be considered
>> later, but the most
>> important thing to do is to eliminate using statics to pass args.
>>
Ubuntu machine has multiple failing java awt tests. When looking at the
screenshots of the desktop when each test fails, a white square can be seen at
the top-left of the desktop.
https://github.com/user-attachments/assets/52d023f6-18ff-46d4-98c4-e2e332ab6a03";
/>
This seems to be similar to t
On Wed, 20 Aug 2025 21:30:13 GMT, Phil Race wrote:
>> 4197755 is marked as a duplicate of
>> [JDK-8176501](https://bugs.openjdk.org/browse/JDK-8176501) , but I think
>> that is a mistake. The complaint in that ticket still reproduces, and it is
>> resolved in this PR.
>>
>> The complaint is:
On Tue, 19 Aug 2025 06:14:21 GMT, Prasanta Sadhukhan
wrote:
> Test compares specific pixels with expected color and needed color profile
> setting in macOS26 is not available it seems.
> Since the pixel color difference is slightly off, I have added a tolerance
> which had been present in many
On Wed, 20 Aug 2025 15:21:39 GMT, Magnus Ihse Bursie wrote:
> I realize that this is highly hardware dependent, but test times tend to be
> Pareto distributed, so a very quick test maybe takes 1 second on fast
> machines and 10 on slow,
@magicus unfortunately that is often not the case in pra
On Sun, 10 Aug 2025 04:35:43 GMT, Jeremy Wood wrote:
> 4197755 is marked as a duplicate of
> [JDK-8176501](https://bugs.openjdk.org/browse/JDK-8176501) , but I think that
> is a mistake. The complaint in that ticket still reproduces, and it is
> resolved in this PR.
>
> The complaint is: Arc2
On Wed, 20 Aug 2025 20:09:20 GMT, Phil Race wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 1167:
>>
>>> 1165: */
>>> 1166: @BeanProperty(description
>>> 1167: = "Whether grid lines should be drawn in between the
>>> cells.")
>>
>> It probably need a
On Fri, 15 Aug 2025 01:32:06 GMT, Sergey Bylokhov wrote:
> How about modifying the listeners list implementations to store listeners
> using weak references instead(not sure it will be better that the current
> patch)? it seems current implementation can cause memory leaks?
Memory leaks ? Whe
On Fri, 15 Aug 2025 20:06:21 GMT, Sergey Bylokhov wrote:
>> I thought about that whilst making the change, but
>> (1) The javax.imagio.ImageIO class has this code
>>
>> private static final IIORegistry theRegistry =
>> IIORegistry.getDefaultInstance();
>>
>> So it is going to get initiali
> Remove javax.imageio.spi.ServiceRegistry.finalize() since it is deprecated
> for removal.
> The impact of this should be minimal. The IIORegistry will now be a singleton
> - which it already was
> in practice since Applets are no longer supported. Since it is a singleton,
> it will persist fo
On Fri, 15 Aug 2025 22:09:15 GMT, Phil Race wrote:
>>> > There are still static fields to store colors in `WindowsMenuItemUI`, do
>>> > you want to get rid of those too? My bug report implied removing them,
>>> > yet currently the static fields with colors remain intact in
>>> > `WindowsMenuIt
On Mon, 18 Aug 2025 17:05:26 GMT, Alexey Ivanov wrote:
> Since `WindowsMenuUI` is a final class after PR #24170 for
> [JDK-8352638](https://bugs.openjdk.org/browse/JDK-8352638)), it cannot be
> extended, therefore the `protected` modifier doesn't make sense.
>
> Mark both `menuBarHeight` and `
On Wed, 20 Aug 2025 11:16:15 GMT, Prasanta Sadhukhan
wrote:
>> Hi Reviewers,
>>
>> Updated the Bean Property description with meaningful string for
>> JTable.setShowGrid.
>>
>> Pleas review and let me know your suggestions if any.
>
> src/java.desktop/share/classes/javax/swing/JTable.java lin
On Wed, 20 Aug 2025 09:30:31 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> Updated the Bean Property description with meaningful string for
> JTable.setShowGrid.
>
> Pleas review and let me know your suggestions if any.
Marked as reviewed by prr (Reviewer).
-
PR Re
On Wed, 20 Aug 2025 17:05:59 GMT, Leo Korinth wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to cha
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts
> to individual test cases so that I am able to run them with a timeout factor
> of 0.7 (some margin to the checked in factor of one)
>
> In addition to changing the timeout factor, I am also using a library call to
On Wed, 19 Mar 2025 11:23:13 GMT, Nikita Gubarkov wrote:
> 8352407: PixelInterleavedSampleModel with unused components throws
> RasterFormatException: Incorrect pixel stride
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/24111
On Wed, 6 Aug 2025 09:43:48 GMT, Ravi Gupta wrote:
>> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java
>> left debris on system whenever fails its required frame.dispose() in finally
>> block.
>>
>>
>> finally {
>> EventQueue.invokeAndWait(ExtraButtonDrag:
On Wed, 20 Aug 2025 16:24:43 GMT, Leo Korinth wrote:
>> doc/testing.md line 385:
>>
>>> 383: (`-timeoutFactor`). Also, some test cases that programmatically wait a
>>> 384: certain amount of time will apply this factor. If we run in
>>> 385: forced compilation mode (`-Xcomp`), [RunTest.gmk](../m
On Wed, 20 Aug 2025 15:17:02 GMT, Magnus Ihse Bursie wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> after suggestion from Daniel
>
> doc/testing.md line 385:
>
>> 383: (`-timeoutFactor`). Also, some test cases tha
On Mon, 18 Aug 2025 16:34:21 GMT, Leo Korinth wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to cha
On Mon, 18 Aug 2025 16:34:21 GMT, Leo Korinth wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to cha
On Wed, 20 Aug 2025 12:53:23 GMT, David Holmes wrote:
>> But what this PR do is change the timeoutFactor in general and find out all
>> the tests which may timeout after the timeoutFactor has been changed.
>>
>> The old default timeout before this PR is 120 * 4, after this PR the new
>> defaul
On Tue, 19 Aug 2025 14:54:16 GMT, Khalid Boulanouare wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khali
On Tue, 19 Aug 2025 06:38:01 GMT, SendaoYan wrote:
>> No change should be made to any explicit setting of the timeoutFactor in
>> general as that could cause mass timeouts to occur (old default timeout =
>> 120 * 10 = 1200 but new default = 120 * 2.5 = 300!).
>>
>> However I see the concern o
On Fri, 8 Aug 2025 17:31:03 GMT, Phil Race wrote:
> 4 of the 6 JDK ImageWriters flush the stream at the end of writing. 2 (TIFF
> and GIF) do not.
>
> This will matter if you are using a caching ImageOutputStream.
>
> This fix makes it consistent.
src/java.desktop/share/classes/com/sun/image
On Wed, 20 Aug 2025 05:27:03 GMT, Phil Race wrote:
> There seem to be un-related changes in this PR. Please check.
In [this](https://github.com/openjdk/jdk/pull/26002#issuecomment-3023050372)
PR, they asked not to create multiple tickets for the same issues… even if they
are in different files
On Fri, 15 Aug 2025 17:05:18 GMT, Sergey Bylokhov wrote:
> > The pointer pf is dereferenced in line 324 without checking for nullptr,
> > although earlier in line 274 the same pointer is checked for nullptr, which
> > indicates that it can be null.
>
> It is better first to confirm whether thi
On Wed, 20 Aug 2025 09:30:31 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> Updated the Bean Property description with meaningful string for
> JTable.setShowGrid.
>
> Pleas review and let me know your suggestions if any.
src/java.desktop/share/classes/javax/swing/JTable.java line
Hi Reviewers,
Updated the Bean Property description with meaningful string for
JTable.setShowGrid.
Pleas review and let me know your suggestions if any.
-
Commit messages:
- 8302057: Wrong BeanProperty description for JTable.setShowGrid
Changes: https://git.openjdk.org/jdk/pull/2
On Mon, 18 Aug 2025 16:03:23 GMT, Anass Baya wrote:
> This test was recently automated and is failing intermittently in the CI due
> to timing issues.
> This enhancement aims to stabilize the test and also adds the missing null
> pointer check.
test/jdk/javax/swing/DataTransfer/bug4655513.java
On Wed, 6 Aug 2025 05:48:33 GMT, Prasanta Sadhukhan
wrote:
>> it is "that" row being pointed to by visibleRect
>> and yes CSR is needed but I want to finalise the wordings first.
>
> @prrace Can we just say "it will return >=0" or "it will return a
> non-negative number" instead of explaining w
On Fri, 8 Aug 2025 16:37:36 GMT, Daniel Gredler wrote:
> Addresses recent slight performance regressions in some J2DBench benchmarks
> focused on text drawing.
>
> `CCharToGlyphMapper` and `CompositeGlyphMapper` cache glyph IDs, but after
> JDK-8353230 they weren't caching glyph IDs for chars
44 matches
Mail list logo
