On Fri, 22 Aug 2025 23:52:39 GMT, Phil Race wrote:
> But what was wrong with frame-by-frame, that "all subsequent frames" fixes ?
I'm not sure I understand what you're asking; this bug demonstrates what was
wrong with the frame-by-frame response.
Another way to phrase it might be:
A gif works
On Fri, 22 Aug 2025 17:39:10 GMT, Phil Race wrote:
> Some text describing the Beans.instantiate lookup process existed only on the
> method that used the now removed AppletInitializer.
> Since there are two other Beans.instantiate methods, we need to move that
> text to the remaining methods.
>
On Fri, 22 Aug 2025 22:18:15 GMT, Sergey Bylokhov wrote:
> Do we have any tests that verify it actually works as described in the
> updated specification?
If you didn't see any, there probably aren't.
Well I guess there may be JCK ones, since this came from JCK. But that's out of
scope here. I
On Fri, 22 Aug 2025 22:53:28 GMT, Jeremy Wood wrote:
>> If there are two consecutive frames that use DISPOSAL_SAVE, but the
>> transparent pixel index changed: we might accidentally send the wrong data
>> to the ImageConsumer.
>>
>> We already had logic that submits info "the hard way" (see co
On Thu, 21 Aug 2025 23:18:07 GMT, Phil Race wrote:
>> Jeremy Wood has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 32 commits:
>>
>> - 8357034: re-wrapping line breaks
>> - 8356137, 8357034: add debug option to dump PNGs of frame
> If there are two consecutive frames that use DISPOSAL_SAVE, but the
> transparent pixel index changed: we might accidentally send the wrong data to
> the ImageConsumer.
>
> We already had logic that submits info "the hard way" (see comment in code);
> this PR just makes sure we trigger that b
On Fri, 22 Aug 2025 17:39:10 GMT, Phil Race wrote:
> Some text describing the Beans.instantiate lookup process existed only on the
> method that used the now removed AppletInitializer.
> Since there are two other Beans.instantiate methods, we need to move that
> text to the remaining methods.
>
On Wed, 6 Aug 2025 07:51:00 GMT, Prasanta Sadhukhan
wrote:
>> It seems JList.getScrollableUnitIncrement can sometime return 0 instead of
>> positive number which is not specified in the javadoc which can lead to
>> confusion. Clarified javadoc as to when it can return 0.
>
> Prasanta Sadhukhan
On Fri, 22 Aug 2025 03:36:24 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated the Bean Property description with meaningful string for
>> JTable.setShowGrid.
>>
>> Pleas review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull re
On Fri, 8 Aug 2025 17:31:03 GMT, Phil Race wrote:
> 4 of the 6 JDK ImageWriters flush the stream at the end of writing. 2 (TIFF
> and GIF) do not.
>
> This will matter if you are using a caching ImageOutputStream.
>
> This fix makes it consistent.
This pull request has now been integrated.
On Fri, 22 Aug 2025 18:21:18 GMT, Volker Simonis wrote:
> > I already ran all our automated tests, and I'm not too surprised they pass,
> > since they probably don't cover this as well as they should.
>
> Thanks!
>
> > I think it would be possible and a good idea to add a test. All you need to
On Tue, 19 Aug 2025 14:41:54 GMT, Volker Simonis wrote:
>> ### TL;DR
>>
>> This is a fix for what I think is a regression since the introduction of
>> HarfBuzz in JDK 9. The problem is that the algorithm which converts the
>> glyph vector produced by the layout engine into a corresponding char
On Fri, 22 Aug 2025 17:18:40 GMT, Phil Race wrote:
> or don't do it.
Adding `/timeout=480` is more or less don't do anything.
The default timeout (if omitting `/timeout=...`) is 120, so:
master: TIMEOUT_FACTOR=4 and /timeout=120 give you actual 480 timeout.
patch: TIMEOUT_FACTOR=1 and /timeou
On Thu, 21 Aug 2025 21:39:42 GMT, Phil Race wrote:
> I already ran all our automated tests, and I'm not too surprised they pass,
> since they probably don't cover this as well as they should.
Thanks!
> I think it would be possible and a good idea to add a test. All you need to
> do is find a
Some text describing the Beans.instantiate lookup process existed only on the
method that used the now removed AppletInitializer.
Since there are two other Beans.instantiate methods, we need to move that text
to the remaining methods.
Note that one of the methods is also deprecated for removal,
On Fri, 22 Aug 2025 05:51:38 GMT, Phil Race wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update testing.md, remove makefile link, fix bad text
>
> test/jdk/javax/sound/sampled/Clip/AudioContentHandlers.java line
> This PR will consolidate fixes of the following bugs:
>
> https://bugs.openjdk.org/browse/JDK-8361188
> https://bugs.openjdk.org/browse/JDK-8361189
> https://bugs.openjdk.org/browse/JDK-8361190
> https://bugs.openjdk.org/browse/JDK-8361191
> https://bugs.openjdk.org/browse/JDK-8361192
> https://
> This PR will consolidate fixes of the following bugs:
>
> https://bugs.openjdk.org/browse/JDK-8361188
> https://bugs.openjdk.org/browse/JDK-8361189
> https://bugs.openjdk.org/browse/JDK-8361190
> https://bugs.openjdk.org/browse/JDK-8361191
> https://bugs.openjdk.org/browse/JDK-8361192
> https://
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request incrementally with two
ad
On Fri, 22 Aug 2025 09:26:44 GMT, Khalid Boulanouare wrote:
>> test/jdk/java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java line 67:
>>
>>> 65: frame.getContentPane().setLayout(new
>>> BoxLayout(frame.getContentPane(), BoxLayout.Y_AXIS));
>>> 66: frame.setSize(200, 200);
>>> 67
On Wed, 20 Aug 2025 13:12:43 GMT, Prasanta Sadhukhan
wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 39
>> additio
Don’t you also have to update the components in the layout manager?
On Wed, 20 Aug 2025 17:05:59 GMT, Leo Korinth wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to cha
On Fri, 22 Aug 2025 03:53:13 GMT, Prasanta Sadhukhan
wrote:
> When the component orientation is changed from LTR to RTL or the other way
> around, JSplitPane exchanges the left and right components. However, it does
> this by adding and removing components instead of swapping the leftComponent
Hi all,
`BufferedImage.getRGB(int, int, int, int, int[], int, int)` is often used
for processing of individual image pixels. A common pattern is to loop
through each row of pixels, calling this method once per row to populate
the row pixel `int[]` and then process it.
There are many types of `Buf
Ok, thanks for elaborating. I'll submit a PR for review soon.
Take care,
Daniel
On Fri, Aug 22, 2025 at 7:11 AM Philip Race wrote:
> I suppose they won't be that surprised, since it has been the behaviour
> already.
>
> I think it unlikely that an app throws null at TextLayout on purpose
> k
On Thu, 21 Aug 2025 19:14:52 GMT, Phil Race wrote:
>> 4 of the 6 JDK ImageWriters flush the stream at the end of writing. 2 (TIFF
>> and GIF) do not.
>>
>> This will matter if you are using a caching ImageOutputStream.
>>
>> This fix makes it consistent.
>
> Phil Race has updated the pull req
On Tue, 19 Aug 2025 17:22:01 GMT, Manukumar V S wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 39
>> additional co
On Fri, 22 Aug 2025 03:53:13 GMT, Prasanta Sadhukhan
wrote:
> When the component orientation is changed from LTR to RTL or the other way
> around, JSplitPane exchanges the left and right components. However, it does
> this by adding and removing components instead of swapping the leftComponent
> This PR will consolidate fixes of the following bugs:
>
> https://bugs.openjdk.org/browse/JDK-8361188
> https://bugs.openjdk.org/browse/JDK-8361189
> https://bugs.openjdk.org/browse/JDK-8361190
> https://bugs.openjdk.org/browse/JDK-8361191
> https://bugs.openjdk.org/browse/JDK-8361192
> https://
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request with a new target base due
On Mon, 9 Dec 2024 09:56:15 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8314731 : Adds support for the alt attribute in the image type input
>> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>>
>> This is tracked in JBS as
>> - [JDK-
On Thu, 21 Aug 2025 04:58:12 GMT, Jayathirth D V wrote:
>> We need to throw appropriate exception when we pass invalid image index
>> values to ImageReader.getImageTypes().
>> We throw IOOBE in all other plugins except JPEG, Added appropriate check to
>> throw IOOBE when JpegImageReader has inv
On Fri, 15 Aug 2025 16:46:16 GMT, Alexey Ivanov wrote:
> Position the two frames with menu bars in left-to-right and right-to-left
> orientations below the frame that allows changing the look and feel.
>
> Additionally, amend the instructions and refactor the code, show an error
> message to t
On Fri, 22 Aug 2025 03:36:24 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated the Bean Property description with meaningful string for
>> JTable.setShowGrid.
>>
>> Pleas review and let me know your suggestions if any.
>
> Renjith Kannath Pariyangad has updated the pull re
35 matches
Mail list logo
