Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v30]

2025-09-03 Thread Prasanta Sadhukhan
On Wed, 3 Sep 2025 09:22:17 GMT, Khalid Boulanouare wrote: >> Many Mixing tests failed because the work around click lands on the >> minimizing area in the window control and causes the tests to fail. >> >> This fix changes the width of base frames which allows most of tests to pass. > > Khalid

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v27]

2025-09-03 Thread Prasanta Sadhukhan
On Wed, 3 Sep 2025 09:12:14 GMT, Khalid Boulanouare wrote: >> But the frame should be disposed *after* the test is executed, more >> specifically in finally block so am still not sure about this addition > > @prsadhuk My understanding is that test which extend > `GlassPaneOverlappingTestBase` u

Re: RFR: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently [v4]

2025-09-03 Thread Manukumar V S
> Issue: > java/awt/Focus/ComponentLostFocusTest.java fails intermittently(2/40) with an > exception " Execution failed: `main' threw exception: > java.lang.RuntimeException: TextField got no focus! Test failed." > I have seen it failing in all platforms, but predominantly in macos platform. > It

Re: RFR: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently [v5]

2025-09-03 Thread Manukumar V S
> Issue: > java/awt/Focus/ComponentLostFocusTest.java fails intermittently(2/40) with an > exception " Execution failed: `main' threw exception: > java.lang.RuntimeException: TextField got no focus! Test failed." > I have seen it failing in all platforms, but predominantly in macos platform. > It

Re: RFR: 8251928: [macos] the printer DPI always be 72, cause some content lost when print out [v4]

2025-09-03 Thread Phil Race
On Tue, 2 Sep 2025 11:26:30 GMT, GennadiyKrivoshein wrote: >> The fix for the https://bugs.openjdk.org/browse/JDK-8251928. >> >> **Description**. >> This PR contains changes to be able to print with DPI higher than 72 on >> macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob. >>

Re: RFR: 4138921: TextLayout handling of empty strings [v2]

2025-09-03 Thread Daniel Gredler
> `TextLayout` should deal more gracefully with zero length strings. Currently > the exception listed below is the one that is thrown. > > `new TextLayout("", f, new FontRenderContext(null, false, false));` > >> Exception in thread "main" java.lang.IllegalArgumentException: Zero length >> string

Re: RFR: 4138921: TextLayout handling of empty strings

2025-09-03 Thread Phil Race
On Tue, 26 Aug 2025 17:40:12 GMT, Daniel Gredler wrote: > `TextLayout` should deal more gracefully with zero length strings. Currently > the exception listed below is the one that is thrown. > > `new TextLayout("", f, new FontRenderContext(null, false, false));` > >> Exception in thread "main"

Re: RFR: 4138921: TextLayout handling of empty strings

2025-09-03 Thread Phil Race
On Wed, 3 Sep 2025 13:57:41 GMT, Daniel Gredler wrote: >> src/java.desktop/share/classes/java/awt/font/TextLayout.java line 516: >> >>> 514: >>> 515: int start = text.getBeginIndex(); >>> 516: int limit = text.getEndIndex(); >> >> Why do we call text.first() twice, on line 516

Re: RFR: 4138921: TextLayout handling of empty strings

2025-09-03 Thread Daniel Gredler
On Wed, 3 Sep 2025 00:44:36 GMT, Sergey Bylokhov wrote: >> `TextLayout` should deal more gracefully with zero length strings. Currently >> the exception listed below is the one that is thrown. >> >> `new TextLayout("", f, new FontRenderContext(null, false, false));` >> >>> Exception in thread

Re: RFR: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently [v3]

2025-09-03 Thread Mikhail Yankelevich
On Wed, 3 Sep 2025 05:23:02 GMT, Manukumar V S wrote: >> Issue: >> java/awt/Focus/ComponentLostFocusTest.java fails intermittently(2/40) with >> an exception " Execution failed: `main' threw exception: >> java.lang.RuntimeException: TextField got no focus! Test failed." >> I have seen it failin

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v30]

2025-09-03 Thread Khalid Boulanouare
> Many Mixing tests failed because the work around click lands on the > minimizing area in the window control and causes the tests to fail. > > This fix changes the width of base frames which allows most of tests to pass. Khalid Boulanouare has updated the pull request with a new target base due

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v27]

2025-09-03 Thread Khalid Boulanouare
On Wed, 3 Sep 2025 03:58:56 GMT, Prasanta Sadhukhan wrote: >> The GlassPaneOverlappingTestBase tests are not multi-frame tests, they do >> not use multiple frames where each frame has an AWT component to test Swing >> with that AWT component. If the frame is disposed in the >> SimpleOverlappi

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-09-03 Thread Leo Korinth
On Mon, 25 Aug 2025 13:48:10 GMT, Albert Mingkun Yang wrote: >> It is a way to give a "4x" lowest value, while not multiplying a 10x factor >> with four resulting in a 40x factor. I think (but I am not sure) that it >> would sometime time out if I only used the given timeout factor and not >>

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v27]

2025-09-03 Thread Khalid Boulanouare
On Sun, 31 Aug 2025 09:15:27 GMT, Khalid Boulanouare wrote: >> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 172: >> >>> 170: if (!await) { >>> 171: throw new RuntimeException("Ancestor frame didn't >>> receive " + >>> 172:

Re: RFR: 8361606 : ConsumeNextMnemonicKeyTypedTest.java fails on Windows: character typed with VK_A: a [v3]

2025-09-03 Thread Damon Nguyen
On Sat, 30 Aug 2025 19:54:39 GMT, Anass Baya wrote: > Could you please confirm whether the proposed fix resolves the issue on > macOS, since you're able to reproduce it on it? The fix does not. When testing on macOS, it does not seem like Aqua L&F even touches `menuKeyPressed()` in `BasicPopup

Re: RFR: 8365569: Remove finalize from JavaSoundAudioClip.java

2025-09-03 Thread Phil Race
On Tue, 2 Sep 2025 08:35:37 GMT, Tejesh R wrote: >> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of >> the implementation is in a delegate >> com/sun/media/sound/JavaSoundAudioClipDelegate.java >> >> Then a disposer can be used to free the audio resources held by the

Re: RFR: 4138921: TextLayout handling of empty strings

2025-09-03 Thread Sergey Bylokhov
On Tue, 26 Aug 2025 17:40:12 GMT, Daniel Gredler wrote: > `TextLayout` should deal more gracefully with zero length strings. Currently > the exception listed below is the one that is thrown. > > `new TextLayout("", f, new FontRenderContext(null, false, false));` > >> Exception in thread "main"

Re: RFR: 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print [v2]

2025-09-03 Thread Phil Race
On Fri, 18 Jul 2025 13:19:10 GMT, Christian Heilmann wrote: >> This PR fixes a bug that caused no or the wrong set of pages to be printed >> when using page ranges on macOS. >> >> The main fix is to change the 'location' value of the returned NSRange from >> the knowsPageRange method to 1 in t