Re: RFR: 8364146: JList getScrollableUnitIncrement return 0 [v4]

2025-09-06 Thread Prasanta Sadhukhan
> It seems JList.getScrollableUnitIncrement can sometime return 0 instead of > positive number which is not specified in the javadoc which can lead to > confusion. Clarified javadoc as to when it can return 0. Prasanta Sadhukhan has updated the pull request incrementally with one additional com

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v30]

2025-09-06 Thread Alexey Ivanov
On Thu, 4 Sep 2025 11:19:10 GMT, Alexey Ivanov wrote: >> Khalid Boulanouare has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 46 >> additional com

Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist [v2]

2025-09-06 Thread duke
On Fri, 5 Sep 2025 05:31:31 GMT, Sarvesh Kumar Jain wrote: >> The test is problem listed with incorrect bug JDK-6849371, >> The bug JDK-6849371 is for a different test and it is closed. >> A new bug has been raised for ChoiceMouseWheelTest.java test failure. > > Sarvesh Kumar Jain has updated the

RFR: 8366149: JNI exception pending in Java_sun_awt_X11GraphicsDevice_pGetBounds of awt_GraphicsEnv.c:1484

2025-09-06 Thread Damon Nguyen
In the scenario where AWT's UNLOCK API encounters a pendingException, the env pointer throws the pendingException (as seen in `awt.h`). However, in `Java_sun_awt_X11GraphicsDevice_pGetBounds`, after `AWT_UNLOCK`, the bounds var is set. The exception check does not occur until after the bounds is

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v36]

2025-09-06 Thread Khalid Boulanouare
> Many Mixing tests failed because the work around click lands on the > minimizing area in the window control and causes the tests to fail. > > This fix changes the width of base frames which allows most of tests to pass. Khalid Boulanouare has updated the pull request incrementally with one ad

Re: RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v3]

2025-09-06 Thread Prasanta Sadhukhan
On Fri, 5 Sep 2025 09:21:58 GMT, Srinivas Mandalika wrote: >> test/jdk/java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java line 151: >> >>> 149: robot.setAutoDelay(150); >>> 150: robot.setAutoWaitForIdle(true); >>> 151: if (!windowFocusGainedLatch.await(1500, >>> Ti

Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist [v2]

2025-09-06 Thread Prasanta Sadhukhan
On Fri, 5 Sep 2025 05:51:36 GMT, Sarvesh Kumar Jain wrote: >> test/jdk/ProblemList.txt line 263: >> >>> 261: java/awt/print/PrinterJob/PSQuestionMark.java 7003378 generic-all >>> 262: java/awt/print/PrinterJob/GlyphPositions.java 7003378 generic-all >>> 263: java/awt/Choice/ChoiceMouseWheelTest/

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v30]

2025-09-06 Thread duke
On Wed, 3 Sep 2025 09:22:17 GMT, Khalid Boulanouare wrote: >> Many Mixing tests failed because the work around click lands on the >> minimizing area in the window control and causes the tests to fail. >> >> This fix changes the width of base frames which allows most of tests to pass. > > Khalid

Re: RFR: 8364146: JList getScrollableUnitIncrement return 0 [v3]

2025-09-06 Thread Prasanta Sadhukhan
On Fri, 22 Aug 2025 22:16:48 GMT, Phil Race wrote: > And if the rectangle you pass in has a y that is = the height of the list, > then scrolling in a positive direction also returns 0. > If it is GREATER than the height, then I get back a negative increment ! I tried Rectangle cell = list.get

Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist

2025-09-06 Thread Sarvesh Kumar Jain
On Fri, 5 Sep 2025 05:05:21 GMT, Prasanta Sadhukhan wrote: > That new bugid 8366852 needs to be added in the problemlist for this bug then > instead of removing the entry. @prsadhuk Updated. - PR Comment: https://git.openjdk.org/jdk/pull/27085#issuecomment-3257117653

Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist [v2]

2025-09-06 Thread Sarvesh Kumar Jain
On Fri, 5 Sep 2025 05:53:40 GMT, Prasanta Sadhukhan wrote: >> I attached the test execution link in the bug 8366852, please check. > > that was for 21 not mainline.. there are 2 links, first one is ML, 2nd is 21. - PR Review Comment: https://git.openjdk.org/jdk/pull/27085#discussi