Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v3]

2025-09-10 Thread Stuart Marks
On Wed, 10 Sep 2025 17:33:05 GMT, Weijun Wang wrote: >> Allow password hiding even if there is no `System.console`. A manual test is >> included. > > Weijun Wang has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > >

Re: RFR: 8367348: Enhance PassFailJFrame to support links in HTML [v3]

2025-09-10 Thread Alexey Ivanov
On Wed, 10 Sep 2025 16:57:20 GMT, Weijun Wang wrote: >> Add HTML link processing ability in instructions. For example: >> >> PassFailJFrame.builder() >> .instructions(htmlWithLinks) >> .addHyperlinkListener(e -> { >> if (e.getEventType() == HyperlinkEvent.EventType.AC

Re: RFR: 8023263: [TESTBUG] Test closed/java/awt/Focus/InactiveWindowTest/InactiveFocusRace fails due to not enough time to initialize graphic components [v2]

2025-09-10 Thread Prasanta Sadhukhan
> Test was failing due to lack of time between initializing graphics components > and test start. > Added robot delay and execution under EDT. > > Several iterations of test is passing so deproblemlisting, CI job link in JBS Prasanta Sadhukhan has updated the pull request incrementally with one

Re: RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v5]

2025-09-10 Thread Prasanta Sadhukhan
On Mon, 8 Sep 2025 08:42:35 GMT, Srinivas Mandalika wrote: >> The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object >> monitors and wait/notify to synchronise actions in the test. >> >> Using CountDownLatch could make the test simpler, shorter, clearer. >> Tested the cod

Re: RFR: 8366852: java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java test is failing

2025-09-10 Thread Prasanta Sadhukhan
On Tue, 9 Sep 2025 06:28:08 GMT, Alexander Zvegintsev wrote: > There are several major issues with the test: > > 1. The `frameExited` variable is set to true when the mouse pointer exits the > frame. The test does not expect this to happen with the first mouse click on > the `choice` when the

Re: RFR: 8023263: [TESTBUG] Test closed/java/awt/Focus/InactiveWindowTest/InactiveFocusRace fails due to not enough time to initialize graphic components [v2]

2025-09-10 Thread Prasanta Sadhukhan
On Thu, 11 Sep 2025 02:41:34 GMT, Sergey Bylokhov wrote: >> Test does >> - renders inactiveFrame >> - renders activeFrame >> - wait for active frame to be active >> - press on second button in inactive frame >> - wait for second button should be focus owner >> - Check Button2 should be the focus

Integrated: 8361530: Test javax/swing/GraphicsConfigNotifier/StalePreferredSize.java timed out

2025-09-10 Thread Phil Race
On Wed, 10 Sep 2025 18:20:13 GMT, Phil Race wrote: > This test takes an insane amount of time on some systems. I just saw it take > 1,042 seconds to PASS on an x64 Mac. > It doesn't help that there are 3 @run commands. > But also it loops over L&Fs, fonts, etc, testing many component types and

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v12]

2025-09-10 Thread ScientificWare
> This is referenced in Java Bug Database as > - [JDK-8314731 : Adds support for the alt attribute in the image type input > HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) > > This is tracked in JBS as > - [JDK-8314731 : Add support for the alt attribute in the image type i

Re: RFR: 8361530: Test javax/swing/GraphicsConfigNotifier/StalePreferredSize.java timed out

2025-09-10 Thread Phil Race
On Thu, 11 Sep 2025 04:37:19 GMT, Prasanta Sadhukhan wrote: > It seems bold and italic testing is removed.. Yes. That is the idea. - PR Comment: https://git.openjdk.org/jdk/pull/27200#issuecomment-3277584561

Re: RFR: 8361530: Test javax/swing/GraphicsConfigNotifier/StalePreferredSize.java timed out

2025-09-10 Thread Prasanta Sadhukhan
On Wed, 10 Sep 2025 18:20:13 GMT, Phil Race wrote: > This test takes an insane amount of time on some systems. I just saw it take > 1,042 seconds to PASS on an x64 Mac. > It doesn't help that there are 3 @run commands. > But also it loops over L&Fs, fonts, etc, testing many component types and

Re: RFR: 8365379: SU3.applyInsets may produce wrong results [v5]

2025-09-10 Thread Renjith Kannath Pariyangad
On Thu, 11 Sep 2025 02:34:40 GMT, Sergey Bylokhov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> two additional commits since the last revision: >> >> - Replaced eol char >> - Replaced eol char > > test/jdk/javax/swing/SwingUtilities/8365379/bug8365379

Re: RFR: 8365379: SU3.applyInsets may produce wrong results [v6]

2025-09-10 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the insets calculation, similar calculation observed in > **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified code > > Please review and let me know your suggestions if any. Renjith Kannath Pariyangad has updated the pull request incremen

Re: RFR: 8365379: SU3.applyInsets may produce wrong results [v5]

2025-09-10 Thread Sergey Bylokhov
On Wed, 10 Sep 2025 11:09:10 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the insets calculation, similar calculation observed in >> **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified >> code >> >> Please review and let me know your sugg

Re: RFR: 8366149: JNI exception pending in Java_sun_awt_X11GraphicsDevice_pGetBounds of awt_GraphicsEnv.c:1484 [v2]

2025-09-10 Thread Damon Nguyen
> In the scenario where AWT's UNLOCK API encounters a pendingException, the env > pointer throws the pendingException (as seen in `awt.h`). However, in > `Java_sun_awt_X11GraphicsDevice_pGetBounds`, after `AWT_UNLOCK`, the bounds > var is set. The exception check does not occur until after the b

Re: RFR: 8023263: [TESTBUG] Test closed/java/awt/Focus/InactiveWindowTest/InactiveFocusRace fails due to not enough time to initialize graphic components

2025-09-10 Thread Sergey Bylokhov
On Wed, 10 Sep 2025 03:55:43 GMT, Prasanta Sadhukhan wrote: >> I didn't get the "previous version"..I just added a delay between the UI >> creation and test start. >> Earlier also, init is called to do UI creation and then start is immediately >> called which sets >> >> inactiveFrame.setVisi

Re: RFR: 8361606 : ConsumeNextMnemonicKeyTypedTest.java fails on Windows: character typed with VK_A: a [v3]

2025-09-10 Thread Anass Baya
On Mon, 25 Aug 2025 10:43:51 GMT, Anass Baya wrote: >> **Analysis :** >> When the problem occurrs, the key press event related to the mnemonic >> triggers the item selection. However, as we returned to the menu, the >> subsequent key typed event arrived and was treated as a normal key press >>

RFR: 8367376: call setUpdatePending(false) in a finally block

2025-09-10 Thread Jeremy Wood
Previously: If DesktopProperty#updateAllUIs threw an exception, we would never reset the update-pending property to false. This means any subsequent call to `updateUI()` would not attempt to call `updateAllUIs()` With this change: Subsequent calls to DesktopProperty#updateUI() can still trigger

Re: RFR: 8367348: Enhance PassFailJFrame to support links in HTML [v3]

2025-09-10 Thread Weijun Wang
> Add HTML link processing ability in instructions. For example: > > PassFailJFrame.builder() > .instructions(htmlWithLinks) > .addHyperlinkListener(e -> { > if (e.getEventType() == HyperlinkEvent.EventType.ACTIVATED) { > performActionOnLink(e.getDescrip

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v3]

2025-09-10 Thread Weijun Wang
On Wed, 10 Sep 2025 19:36:54 GMT, Francesco Andreuzzi wrote: >> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Merge branch 'master' into 8354469 >> - decouple PassFailJFrame.java change; sim

Re: RFR: 4138921: TextLayout handling of empty strings [v2]

2025-09-10 Thread Daniel Gredler
On Wed, 3 Sep 2025 20:11:24 GMT, Daniel Gredler wrote: >> `TextLayout` should deal more gracefully with zero length strings. Currently >> the exception listed below is the one that is thrown. >> >> `new TextLayout("", f, new FontRenderContext(null, false, false));` >> >>> Exception in thread "

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v3]

2025-09-10 Thread Francesco Andreuzzi
On Wed, 10 Sep 2025 17:33:05 GMT, Weijun Wang wrote: >> Allow password hiding even if there is no `System.console`. A manual test is >> included. > > Weijun Wang has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > >

RFR: 8361530: Test javax/swing/GraphicsConfigNotifier/StalePreferredSize.java timed out

2025-09-10 Thread Phil Race
This test takes an insane amount of time on some systems. I just saw it take 1,042 seconds to PASS on an x64 Mac. It doesn't help that there are 3 @run commands. But also it loops over L&Fs, fonts, etc, testing many component types and created 4.600 top level frames and 2,300 popups I don't thi

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v3]

2025-09-10 Thread Weijun Wang
> Allow password hiding even if there is no `System.console`. A manual test is > included. Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' into 8354469 - decouple PassFailJFrame.ja

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v2]

2025-09-10 Thread Weijun Wang
> Allow password hiding even if there is no `System.console`. A manual test is > included. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: decouple PassFailJFrame.java change; simplify code flow - Changes: - all: https

Integrated: 8367348: Enhance PassFailJFrame to support links in HTML

2025-09-10 Thread Weijun Wang
On Wed, 10 Sep 2025 16:17:58 GMT, Weijun Wang wrote: > Add HTML link processing ability in instructions. For example: > > PassFailJFrame.builder() > .instructions(htmlWithLinks) > .addHyperlinkListener(e -> { > if (e.getEventType() == HyperlinkEvent.EventType.ACTIVATE

Re: RFR: 8367348: Enhance PassFailJFrame to support links in HTML [v4]

2025-09-10 Thread Weijun Wang
> Add HTML link processing ability in instructions. For example: > > PassFailJFrame.builder() > .instructions(htmlWithLinks) > .addHyperlinkListener(e -> { > if (e.getEventType() == HyperlinkEvent.EventType.ACTIVATED) { > performActionOnLink(e.getDescrip

Re: RFR: 8367348: Enhance PassFailJFrame to support links in HTML [v2]

2025-09-10 Thread Weijun Wang
> Add HTML link processing ability in instructions. For example: > > PassFailJFrame.builder() > .instructions(htmlWithLinks) > .addHyperlinkListener(e -> { > if (e.getEventType() == HyperlinkEvent.EventType.ACTIVATED) { > performActionOnLink(e.getDescrip

Re: RFR: 8367348: Enhance PassFailJFrame to support links in HTML [v2]

2025-09-10 Thread Weijun Wang
On Wed, 10 Sep 2025 16:28:24 GMT, Alexey Ivanov wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> show the caret > > test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 657: > >> 655: text.setBorder(cre

Re: RFR: 8367348: Enhance PassFailJFrame to support links in HTML

2025-09-10 Thread Alexey Ivanov
On Wed, 10 Sep 2025 16:17:58 GMT, Weijun Wang wrote: > Add HTML link processing ability in instructions. For example: > > PassFailJFrame.builder() > .instructions(htmlWithLinks) > .addHyperlinkListener(e -> { > if (e.getEventType() == HyperlinkEvent.EventType.ACTIVATE

RFR: 8367348: Enhance PassFailJFrame to support links in HTML

2025-09-10 Thread Weijun Wang
Add HTML link processing ability in instructions. For example: PassFailJFrame.builder() .instructions(htmlWithLinks) .addHyperlinkListener(e -> { if (e.getEventType() == HyperlinkEvent.EventType.ACTIVATED) { performActionOnLink(e.getDescription());

Integrated: 8162380: [TEST_BUG] MouseEvent/.../AltGraphModifierTest.java has only "Fail" button

2025-09-10 Thread Prasanta Sadhukhan
On Tue, 9 Sep 2025 06:55:27 GMT, Prasanta Sadhukhan wrote: > Test was made to fail due to presence of only "Fail" button instead of both > "Pass" and "Fail". > > Modified the test to use PFJ and also clarified the instruction for Windows > and Linux This pull request has now been integrated.

RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep

2025-09-10 Thread Weijun Wang
Allow password hiding even if there is no `System.console`. A manual test is included. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/27196/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=27196&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v11]

2025-09-10 Thread Alexey Ivanov
On Mon, 8 Sep 2025 09:13:09 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK-

Re: RFR: 8162380: [TEST_BUG] MouseEvent/.../AltGraphModifierTest.java has only "Fail" button [v4]

2025-09-10 Thread Alexey Ivanov
On Wed, 10 Sep 2025 08:20:28 GMT, Prasanta Sadhukhan wrote: >> Test was made to fail due to presence of only "Fail" button instead of both >> "Pass" and "Fail". >> >> Modified the test to use PFJ and also clarified the instruction for Windows >> and Linux > > Prasanta Sadhukhan has updated th

Re: Java crashes using musl-1.2.5

2025-09-10 Thread Konstantin Kletschke
On Wed, Sep 10, 2025 at 05:34:21AM -0700, Kevin Rushforth wrote: > Given where it is crashing, I recommend sending your message to > core-libs-dev 'at' openjdk.org instead. This isn't a Java client libs issue. Thanks for the hint Kevin, I will do accordingly. Regards

Re: Java crashes using musl-1.2.5

2025-09-10 Thread Kevin Rushforth
Given where it is crashing, I recommend sending your message to core-libs-dev 'at' openjdk.org instead. This isn't a Java client libs issue. -- Kevin On 9/10/2025 2:54 AM, Konstantin Kletschke wrote: Hello, I am used to crosscompile openjdk for cortex-a[7|8|9] manually or using buildroot fram

Re: RFR: 8365379: SU3.applyInsets may produce wrong results [v5]

2025-09-10 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the insets calculation, similar calculation observed in > **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified code > > Please review and let me know your suggestions if any. Renjith Kannath Pariyangad has updated the pull request incremen

Re: RFR: 8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update

2025-09-10 Thread Srinivas Mandalika
On Mon, 8 Sep 2025 09:44:30 GMT, Srinivas Mandalika wrote: > Test Name: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java > Updated the test instructions for better clarity, formatting and removed its > entry from the ProblemList.txt. Can someone take a quick look and provide feedback on t

Re: RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v5]

2025-09-10 Thread Srinivas Mandalika
On Mon, 8 Sep 2025 08:42:35 GMT, Srinivas Mandalika wrote: >> The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object >> monitors and wait/notify to synchronise actions in the test. >> >> Using CountDownLatch could make the test simpler, shorter, clearer. >> Tested the cod

Re: RFR: 8365379: SU3.applyInsets may produce wrong results [v4]

2025-09-10 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the insets calculation, similar calculation observed in > **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified code > > Please review and let me know your suggestions if any. Renjith Kannath Pariyangad has updated the pull request incremen

Re: RFR: 8365379: SU3.applyInsets may produce wrong results [v3]

2025-09-10 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the insets calculation, similar calculation observed in > **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified code > > Please review and let me know your suggestions if any. Renjith Kannath Pariyangad has updated the pull request incremen

Re: RFR: 8365379: SU3.applyInsets may produce wrong results

2025-09-10 Thread Renjith Kannath Pariyangad
On Tue, 9 Sep 2025 17:27:56 GMT, Sergey Bylokhov wrote: >> Hi Reviewers, >> >> I have updated the insets calculation, similar calculation observed in >> **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified >> code >> >> Please review and let me know your suggestions if an

Re: RFR: 8365379: SU3.applyInsets may produce wrong results [v2]

2025-09-10 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > I have updated the insets calculation, similar calculation observed in > **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified code > > Please review and let me know your suggestions if any. Renjith Kannath Pariyangad has updated the pull request incremen

Java crashes using musl-1.2.5

2025-09-10 Thread Konstantin Kletschke
Hello, I am used to crosscompile openjdk for cortex-a[7|8|9] manually or using buildroot framework without severe Problems. ARM EABIhf 32Bit. However recently I got in contact with a customer's rootfs using musl-1.2.5 instead of musl-1.2.4 which I was used to and had no problems with. Severe deb

Re: RFR: 8162380: [TEST_BUG] MouseEvent/.../AltGraphModifierTest.java has only "Fail" button [v2]

2025-09-10 Thread Prasanta Sadhukhan
On Tue, 9 Sep 2025 20:41:06 GMT, Alexander Zvegintsev wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Clarify instruction > > test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java

Re: RFR: 8162380: [TEST_BUG] MouseEvent/.../AltGraphModifierTest.java has only "Fail" button [v4]

2025-09-10 Thread Prasanta Sadhukhan
> Test was made to fail due to presence of only "Fail" button instead of both > "Pass" and "Fail". > > Modified the test to use PFJ and also clarified the instruction for Windows > and Linux Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8162380: [TEST_BUG] MouseEvent/.../AltGraphModifierTest.java has only "Fail" button [v2]

2025-09-10 Thread Alexander Zvegintsev
On Wed, 10 Sep 2025 02:25:00 GMT, Prasanta Sadhukhan wrote: >> test/jdk/java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java >> line 52: >> >>> 50: Navigate to >>> 51: System Settings-> Keyboard-> Special Character >>> Entry >>> 52