On Tue, 5 Dec 2023 16:48:55 GMT, Anton Bobrov wrote:
> This patch adds re-try logic to libpipewire screencast error handling as
> discussed in PR #16794 and also brings some additional error handling and
> thread safety improvements. Specifically around cleanup order where
On Wed, 6 Dec 2023 18:04:59 GMT, Alexander Zvegintsev
wrote:
>> Anton Bobrov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8321176: remove RuntimeException and address review comments
>
> Looks good to m
On Wed, 6 Dec 2023 19:20:22 GMT, Phil Race wrote:
>> Anton Bobrov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8321176: remove RuntimeException and address review comments
>
> src/java.deskt
On Wed, 6 Dec 2023 19:05:31 GMT, Phil Race wrote:
>> Such change requires a [CSR](https://wiki.openjdk.org/display/csr) .
>> If we want to get this fix into JDK 22, we don't have time for CSR, since
>> JDK 22 will be forked this Thursday.
>
> It is beyond that. It is an incompatible change. It w
On Wed, 6 Dec 2023 18:04:59 GMT, Alexander Zvegintsev
wrote:
>> Anton Bobrov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8321176: remove RuntimeException and address review comments
>
> Looks good to m
On Wed, 6 Dec 2023 09:08:55 GMT, Anton Bobrov wrote:
>> This patch adds re-try logic to libpipewire screencast error handling as
>> discussed in PR #16794 and also brings some additional error handling and
>> thread safety improvements. Specifically around cleanup order w
such exceptions thru the call tree does not
> make much sense as most public API users won't even know how to handle them
> without knowing native implementation specifics.
Anton Bobrov has updated the pull request incrementally with one additional
commit since the las
On Tue, 5 Dec 2023 20:22:32 GMT, Phil Race wrote:
>> This patch adds re-try logic to libpipewire screencast error handling as
>> discussed in PR #16794 and also brings some additional error handling and
>> thread safety improvements. Specifically around cleanup order where
>> incorrect orderin
On Tue, 5 Dec 2023 16:48:55 GMT, Anton Bobrov wrote:
> This patch adds re-try logic to libpipewire screencast error handling as
> discussed in PR #16794 and also brings some additional error handling and
> thread safety improvements. Specifically around cleanup order where
This patch adds re-try logic to libpipewire screencast error handling as
discussed in PR #16794 and also brings some additional error handling and
thread safety improvements. Specifically around cleanup order where incorrect
ordering lead to native memory corruption issues, and lock/unlock accou
On Thu, 23 Nov 2023 13:00:06 GMT, Anton Bobrov wrote:
> This patch addresses the issues described in the
> https://bugs.openjdk.org/browse/JDK-8320655 by fixing the proper locking and
> signalling around libpipewire thread loop condition variables and also fixing
> libpipewire err
On Fri, 1 Dec 2023 15:00:50 GMT, Alexander Zvegintsev
wrote:
>> @azvegint do you think it would make sense to do it in the native code or in
>> the upper level Java code ? AND also how many times do you think it would
>> make sense to retry provided this could be a permanent pipewire error and
ncast
> API. This makes the screencast robot stable enough to consistently make it
> thru the entire javax/swing jtreg suite without hanging and also
> significantly reduces CPU consumption as there is no longer any burning
> spinners since they are now waiting on related conditio
ncast
> API. This makes the screencast robot stable enough to consistently make it
> thru the entire javax/swing jtreg suite without hanging and also
> significantly reduces CPU consumption as there is no longer any burning
> spinners since they are now waiting on related conditio
On Fri, 1 Dec 2023 14:00:59 GMT, Alexander Zvegintsev
wrote:
>> @azvegint Thanks for reviewing this Alexander! I dont think re-trying here
>> is gonna work at all. The libpipewire docs leave a lot to be desired so I
>> was using their code as reference for this patch and according to their
>>
On Fri, 1 Dec 2023 13:44:21 GMT, Maxim Kartashev wrote:
>> @mkartashev hey, a fellow Sun comrade! (i still have my Sun badge too) :)
>>
>> This is for similar reasons to the existing 'sessionClosed' being volatile
>> ie bc multiple threads can read/write it and in this particular case a
>> lim
On Fri, 1 Dec 2023 11:21:59 GMT, Maxim Kartashev wrote:
>> This patch addresses the issues described in the
>> https://bugs.openjdk.org/browse/JDK-8320655 by fixing the proper locking and
>> signalling around libpipewire thread loop condition variables and also
>> fixing libpipewire error dete
On Thu, 30 Nov 2023 21:41:53 GMT, Alexander Zvegintsev
wrote:
>> This patch addresses the issues described in the
>> https://bugs.openjdk.org/browse/JDK-8320655 by fixing the proper locking and
>> signalling around libpipewire thread loop condition variables and also
>> fixing libpipewire err
This patch addresses the issues described in the
https://bugs.openjdk.org/browse/JDK-8320655 by fixing the proper locking and
signalling around libpipewire thread loop condition variables and also fixing
libpipewire error detection and signalling and propagation to the screencast
API. This make
19 matches
Mail list logo
