On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the
On Sun, 16 Jun 2024 21:31:50 GMT, Phil Race wrote:
> Verified on Ubuntu 24.04
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19739#pullrequestreview-2121932893
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>>
On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
>
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Thu, 15 Feb 2024 12:26:11 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Fri, 9 Feb 2024 13:42:02 GMT, Magnus Ihse Bursie wrote:
>> This is an attempt to finally implement the idea brought forward in
>> JDK-8295729: Properties files is essentially source code. It should have
>> the same whitespace checks as all other source code, so we don't get
>> spurious
On Fri, 2 Feb 2024 15:22:03 GMT, Magnus Ihse Bursie wrote:
> Inspired by (the later backed-out)
> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to
> enable `-Wpedantic` for clang. This has already found some irregularities in
> the code, like mistakenly using `#import`
On Tue, 23 Jan 2024 00:58:27 GMT, Sergey Bylokhov wrote:
> The next bug in freetype was fixed upstream and fix already merged to OpenJDK:
> https://gitlab.freedesktop.org/freetype/freetype/-/issues/1245
> So now we can revert the workaround in the JDK:
>
build log for '] Error'.
>> HELP: Run 'make doctor' to diagnose build problems.
>>
>> make[1]: *** [main] Error 1
>> make: *** [images] Error 2
>
> null has updated the pull request incrementally with one additional commit
> since the last revision:
&
On Thu, 2 Nov 2023 07:14:14 GMT, null wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>>
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This
On Fri, 13 Oct 2023 18:01:44 GMT, Mikael Vidstedt wrote:
>> macOS 10.x is no longer receiving updates - the most recent/last release was
>> 10.15.7 back in July of 2022. It's time to bump the target macOS version
>> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>>
>> This
On Wed, 11 Oct 2023 17:49:14 GMT, Mikael Vidstedt wrote:
> macOS 10.x is no longer receiving updates - the most recent/last release was
> 10.15.7 back in July of 2022. It's time to bump the target macOS version
> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>
> This change
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in.
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in.
On Tue, 5 Sep 2023 23:12:51 GMT, Chris Plummer wrote:
> I wonder if this is the right thing to do for the hprof files. I believe they
> originated from some hprof tools that we no longer ship. 3rd parties might
> choose to integrate them into their own tools.
Do you think I should revert
There are a number of files in the `test` directory that have an incorrect
copyright header, which includes the "classpath" exception text. This patch
removes that text from all test files that I could find it in. I did this using
a combination of `sed` and `grep`. Reviewing this patch is
On Mon, 4 Sep 2023 07:40:11 GMT, Matthias Baesken wrote:
>> After looking at the build results of a jdk22 build on RHEL 8.4 Linux
>> ppc64le that uses a ppc64le-linux-gnu-to-ppc64le-linux-gnu-fedora27-gcc11.3.0
>> devkit we observed those unwanted paths in libsplashscreen.so .
>> See those
On Fri, 1 Sep 2023 15:11:17 GMT, Matthias Baesken wrote:
>> After looking at the build results of a jdk22 build on RHEL 8.4 Linux
>> ppc64le that uses a ppc64le-linux-gnu-to-ppc64le-linux-gnu-fedora27-gcc11.3.0
>> devkit we observed those unwanted paths in libsplashscreen.so .
>> See those
On Fri, 1 Sep 2023 13:39:58 GMT, Matthias Baesken wrote:
>> make/autoconf/lib-x11.m4 line 90:
>>
>>> 88: fi
>>> 89: # Also remove the -R setting for devkit usage
>>> 90: if test "x$with_devkit" != "x" && test "x$with_devkit" != "xno";
>>> then
>>
>> This should rather check if
On Fri, 1 Sep 2023 11:02:36 GMT, Matthias Baesken wrote:
> After looking at the build results of a jdk22 build on RHEL 8.4 Linux ppc64le
> that uses a ppc64le-linux-gnu-to-ppc64le-linux-gnu-fedora27-gcc11.3.0
> devkit we observed those unwanted paths in libsplashscreen.so .
> See those objdump
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the
On Mon, 3 Jul 2023 17:15:17 GMT, Daniel Jeliński wrote:
> Please review this patch that configures C++ arguments on build jobs that
> involve compiling CPP files. As a result of this change, CPP files are
> compiled with `-std:c++14` command line argument instead of `-std:c11`, which
> is
On Thu, 29 Jun 2023 07:41:11 GMT, David Holmes wrote:
> This seems to run contrary to the requirement that files end in a newline,
> which git will complain about if the newline is missing.
The patch is leaving exactly one newline at the end of the file.
-
PR Comment:
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for
On Sat, 24 Jun 2023 06:47:48 GMT, Vladimir Sitnikov
wrote:
> I've posted the suggetion to add .editorconfig on ide-support-dev, however,
> the list does not seem to be active:
> https://mail.openjdk.org/pipermail/ide-support-dev/2023-June/000281.html
I think that sounds like a reasonable
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
The update to Java.gmk is good.
-
Marked as reviewed by erikj (Reviewer).
PR Review:
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
The changes look ok.
-
Marked as reviewed by erikj (Reviewer).
PR Review:
On Fri, 16 Jun 2023 22:10:08 GMT, Daniel D. Daugherty
wrote:
> @erikj - You did a round of Mach5 testing on the JDK22 version of this fix.
> Do you have plans to redo that testing for the JDK21 backport?
I have done testing of the JDK 21 version of the patch and it's running cleanly.
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a
tial linking step for building static libraries with clang on
> linux.
>- On macosx, workaround the long argument issue for 'AR' with relative
> path.
>
>Tested building jdk-image and static-libs-image on linux-x64 (for both gcc
> and clang) and macosx-x64 (clang) man
> - Merge branch 'master' into JDK-8307858
> - Address comments/suggestions from @erikj79:
>- Only do partial linking step for building static libraries with clang on
> linux.
> - On macosx, workaround the long argument issue for 'AR' with relative
>
On Thu, 1 Jun 2023 23:38:03 GMT, Jiangli Zhou wrote:
> Sounds good for solving the macosx `ar` limitation differently. I'll change
> that. We can also exclude the partial linking part for gcc (due the older
> tool issue that you've found). Any concerns with including partial linking
> step
On Fri, 26 May 2023 20:26:02 GMT, Jiangli Zhou wrote:
> > Another possibility might be the user provided `BUILD_LDCXX` includes extra
> > options in the testing build (?). If that's the case, we probably could
> > define a separate `BUILD_LD_PARTIAL` with no added options. In our
> >
On Wed, 24 May 2023 20:29:09 GMT, Erik Joelsson wrote:
> My build job is still running, but it has failed in two distinct ways
> already. See below for mac fix. Our cross build of arm32 fails with this
> message:
>
> ```
> [2023-05-24T19:25:15,310Z]
> /opt/mach5/meso
On Mon, 22 May 2023 21:27:58 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Add $$($1_LD) $$($1_SYSROOT_LDFLAGS) to $1_VARDEPS if $(TOOLCHAIN_TYPE)
>>
On Mon, 22 May 2023 19:40:00 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Mon, 22 May 2023 19:21:52 GMT, Jiangli Zhou wrote:
>> Thanks @erikj79. Could you please help provide some more info on the build
>> failure:
>>
>> Which macOs version ran into the build issue? My mac is on Ventura 13.3.1
>> (a). It builds successfully for the `static-libs-image` target.
>>
On Fri, 19 May 2023 21:13:24 GMT, Erik Joelsson wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling th
On Fri, 19 May 2023 20:18:53 GMT, Jiangli Zhou wrote:
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> -
On Wed, 17 May 2023 12:26:22 GMT, xpbob wrote:
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
>
On Fri, 12 May 2023 12:01:43 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Many of those are in the aix or ppc specific codebase and could be addressed
> by small adjustments.
> A lot
On Wed, 10 May 2023 20:38:50 GMT, Jiangli Zhou wrote:
> > This change caused all our builds but Linux to fail. Did you verify on
> > other platforms than Linux at all? I see you have GHA turned off.
>
> Sorry about the issue. There were failed workflows after I merged with the
> latest JDK
On Wed, 10 May 2023 17:13:13 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Build hotspot libjvm.a and JDK static libraries for
On Tue, 9 May 2023 23:06:23 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle
On Tue, 9 May 2023 21:46:42 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle
On Mon, 8 May 2023 10:29:56 GMT, Matthias Baesken wrote:
> After the harfbuzz 7.2 update we run into
>
> /linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8:
> error: offset '4' outside bounds of constant string [-Werror=array-bounds]
> 281 | bool
On Sat, 6 May 2023 01:41:11 GMT, Jie Fu wrote:
>> The fix disables expansion-to-defined warning for gcc.
>> Thanks.
>
> Jie Fu has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Add comment
Marked as reviewed by erikj (Reviewer).
On Fri, 5 May 2023 16:52:22 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle
On Thu, 4 May 2023 14:18:44 GMT, Alexander Zvegintsev
wrote:
> Modern Linux systems often come with
> [Wayland](https://wayland.freedesktop.org/) by default.
> This comes with some difficulties, and one of them is the inability to get
> screenshots from the system.
> This is because we now
On Wed, 3 May 2023 17:05:29 GMT, Severin Gehwolf wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update based on @erikj79 review comments and suggestions:
>> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN)
On Wed, 3 May 2023 17:58:25 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/VM static libraries:
>>
>> - Create libjvm.a together with other JDK static libraries
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when
On Fri, 28 Apr 2023 23:25:17 GMT, Erik Joelsson wrote:
>>> I pulled this PR and had a go at building it. For me it failed with errors
>>> like this:
>>>
>>> ```
>>> /home/erik/git/jdk/build/linux-x64/images/static-libs/lib/libjvm.a(os_
On Fri, 28 Apr 2023 22:32:34 GMT, Jiangli Zhou wrote:
> Erik, could you please share your
> `support/native/java.base/java/BUILD_LAUNCHER_javastatic_static_link.cmdline`?
> This generated .cmdline file contains the static linking command. Here is
> the linking command from my build:
I can't
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for
On Fri, 28 Apr 2023 11:59:52 GMT, Alan Bateman wrote:
> If I understand the make file changes proposed here, it runs the native
> linker to create "javastatic" with the launcher, libjvm and other JNI libs
> linked into one executable, this is generated and copied into the run-time
> image
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64,
On Fri, 14 Apr 2023 14:31:31 GMT, Roger Riggs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed isPPC64().
>> Consolidated switch cases in ArchTest.
>> Moved mapping of build TARGET_OS and TARGET_CPU to the
On Wed, 5 Apr 2023 15:58:08 GMT, Roger Riggs wrote:
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86,
On Fri, 31 Mar 2023 21:27:08 GMT, Joshua Cao wrote:
>> Builds successfully with GCC 7
>>
>>
>> gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-15)
>> Copyright (C) 2017 Free Software Foundation, Inc.
>> This is free software; see the source for copying conditions. There is NO
>> warranty; not even
On Thu, 30 Mar 2023 21:05:40 GMT, Joshua Cao wrote:
> Builds successfully with GCC 7
>
>
> gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-15)
> Copyright (C) 2017 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for
On Thu, 30 Mar 2023 21:24:02 GMT, Sergey Bylokhov wrote:
> If we will going forward with this patch, can we exclude the warning for the
> old compilers only? as was mentioned in the JBS the gcc10+ compiles that code
> fine.
The build system doesn't have a convenient way of selectively disable
On Thu, 9 Mar 2023 06:12:26 GMT, Harshitha Onkar wrote:
>> HarfBuzz library updated from v4.4.1 to v7.0.1
>>
>> - harfbuzz.md file updated
>> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid
>> build issues on linux and macos targets.
>> - GPOS.hh moved to Layout to
On Tue, 28 Feb 2023 14:17:11 GMT, Dmitry Markov wrote:
>> Added the section devoted to client UI test which use Robot API
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
Marked as reviewed by erikj (Reviewer).
On Tue, 28 Feb 2023 11:03:41 GMT, Dmitry Markov wrote:
>> Added the section devoted to client UI test which use Robot API
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix review findings
doc/testing.md line 666:
>
On Tue, 28 Feb 2023 06:47:37 GMT, Jayathirth D V wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 130:
>>
>>> 128: BUILD_LIBAWT_debug_mem.c_CFLAGS := -w
>>> 129: # This option improves performance of FillRect/FillOval in Java2D by
>>> 15% for some gcc
>>> 130:
On Mon, 27 Feb 2023 16:16:50 GMT, Jayathirth D V wrote:
>> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of
>> gcc optimizations from -O1 level for libawt build. This improved our
>> J2DBench performance numbers in some options considerably.
>>
>> Recent changes done
On Mon, 27 Feb 2023 11:49:27 GMT, Jayathirth D V wrote:
> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of
> gcc optimizations from -O1 level for libawt build. This improved our J2DBench
> performance numbers in some options considerably.
>
> Recent changes done
On Thu, 19 Jan 2023 20:00:56 GMT, Dan Lutker wrote:
> Disabling warnings for bundled Freetype
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12102
On Thu, 17 Nov 2022 19:05:36 GMT, Alisen Chung wrote:
> Redo of 8295369: Update LCMS to 2.14
> Update LCMS to newest release.
> Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a
> build error in linux.
> Automatic tests and J2D demo tests were run.
Build change looks
On Sun, 23 Oct 2022 20:10:35 GMT, Sergey Bylokhov wrote:
> The Java2d do not use "half" float in the image layouts, so we can disable it
> in the LittleCMS library during the build. It is possible to do using
>
On Tue, 25 Oct 2022 10:40:05 GMT, Aleksey Shipilev wrote:
> Fails like this:
>
>
> * For target
> support_native_java.desktop_libsplashscreen_splashscreen_impl.obj:
> splashscreen_impl.c
>
On Mon, 24 Oct 2022 20:01:26 GMT, Magnus Ihse Bursie wrote:
> [JDK-8294466](https://bugs.openjdk.org/browse/JDK-8294466) trimmed down the
> set of disabled warnings. Unfortunately it turned out that running slowdebug
> on linux on Oracle's CI triggered yet another warning in libsplashscreen.
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Thu, 20 Oct 2022 10:24:28 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the accessibility native code.
>
> Any warnings that
On Thu, 20 Oct 2022 10:36:08 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in java.desktop native libraries.
>
> Any warnings that
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase
On Thu, 20 Oct 2022 10:36:08 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in java.desktop native libraries.
>
> Any warnings that
On Thu, 20 Oct 2022 10:24:28 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the accessibility native code.
>
> Any warnings that
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
Marked as reviewed by erikj (Reviewer).
-
PR:
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote:
> Markdown files are basically source code for documentation. It should have
> the same whitespace checks as all other source code, so we don't get spurious
> trailing whitespace changes.
Thank you! Since I enabled visible whitespace
On Thu, 11 Aug 2022 09:56:29 GMT, Daniel Jeliński wrote:
> Remove `java.base:include` from `EXTRA_HEADER_DIRS`.
>
> The directory contains base versions of the files present in
> `/support/modules_include/java.base`; the latter is automatically
> [included in every JDK library
>
90 matches
Mail list logo