On Sat, 30 Mar 2024 02:56:58 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this trivial change to remove dead code in
>> splashscreen_sys.c?
>>
>> -Man
>
> Man Cao has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Update copyrig
On Fri, 29 Mar 2024 23:00:56 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone review this trivial change to remove dead code in
> splashscreen_sys.c?
>
> -Man
LGTM
Shall we also update the copyright year?
-
Marked as reviewed by jiefu (Reviewer).
PR Review: https://git.openjdk.o
On Fri, 15 Mar 2024 12:07:49 GMT, Jie Fu wrote:
> Please review this trivial change.
> Thanks.
This pull request has now been integrated.
Changeset: bf990c8b
Author: Jie Fu
URL:
https://git.openjdk.org/jdk/commit/bf990c8b32f1ce050450d94f4f8706e5a01aa3ec
Stats: 1 line in
On Fri, 15 Mar 2024 12:38:23 GMT, Alexander Zvegintsev
wrote:
>> Please review this trivial change.
>> Thanks.
>
> Marked as reviewed by azvegint (Reviewer).
Thanks @azvegint for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/18326#issuecomment-1999581499
On Thu, 14 Mar 2024 16:48:57 GMT, Alexander Zuev wrote:
>> Convert test to the automatic main and move it from its own folder since it
>> is no longer required.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor updat
Please review this trivial change.
Thanks.
-
Commit messages:
- 8328269: NonFocusablePopupMenuTest.java should be marked as headful
Changes: https://git.openjdk.org/jdk/pull/18326/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18326&range=00
Issue: https://bugs.openjdk.o
On Thu, 2 Nov 2023 07:11:49 GMT, null wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>> I
On Thu, 2 Nov 2023 04:29:01 GMT, null wrote:
> Build failure with GCC8.3.1
>
> === Output from failing command(s) repeated here ===
> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
> In func
On Thu, 27 Jul 2023 19:01:35 GMT, Aleksey Shipilev wrote:
>> There is a simple build failure after
>> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
>>
>>
>> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
>> In file included from
>> /h
On Mon, 24 Jul 2023 10:21:52 GMT, Aleksey Shipilev wrote:
> There is a simple build failure after
> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
>
>
> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
> In file included from
> /home/bui
On Thu, 18 May 2023 03:15:53 GMT, xpbob wrote:
>> configure --enable-debug
>>
>> error: infinite recursion detected [-Werror=infinite-recursion]
>> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>>
>> configure
>>
>> java.desktop/share/native/libharfbuzz/graph/../hb-ot-
On Wed, 17 May 2023 12:26:22 GMT, xpbob wrote:
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-c
On Wed, 17 May 2023 12:26:22 GMT, xpbob wrote:
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-c
On Wed, 17 May 2023 18:49:44 GMT, Phil Race wrote:
> This is a duplicate of https://bugs.openjdk.org/browse/JDK-8307210
I don't think so since it also fixes the build broken due to
`-Werror=infinite-recursion`.
Actually, `-Werror=infinite-recursion` was first introduced in GCC12.
So the build
On Sat, 6 May 2023 01:14:50 GMT, Jie Fu wrote:
> The fix disables expansion-to-defined warning for gcc.
> Thanks.
This pull request has now been integrated.
Changeset: 64c09628
Author: Jie Fu
URL:
https://git.openjdk.org/jdk/commit/64c09628664fd19c281723f15bf677c52e360acd
On Mon, 8 May 2023 13:29:26 GMT, Erik Joelsson wrote:
>> Jie Fu has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Add comment
>
> Marked as reviewed by erikj (Reviewer).
Thanks @erikj79 for the review.
--
On Sat, 6 May 2023 01:41:11 GMT, Jie Fu wrote:
>> The fix disables expansion-to-defined warning for gcc.
>> Thanks.
>
> Jie Fu has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Add comment
It failed with gcc8 &a
> The fix disables expansion-to-defined warning for gcc.
> Thanks.
Jie Fu has updated the pull request incrementally with one additional commit
since the last revision:
Add comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13850/files
- new: https://git.openj
The fix disables expansion-to-defined warning for gcc.
Thanks.
-
Commit messages:
- 8307569: Build with gcc8 is broken after JDK-8307301
Changes: https://git.openjdk.org/jdk/pull/13850/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13850&range=00
Issue: https://bugs.openj
On Fri, 28 Apr 2023 23:59:18 GMT, Sergey Bylokhov wrote:
> The test uses the `DragSource.getDefaultDragSource()` which throws
> HeadlessException. The test should be marked as headful.
LGTM
-
Marked as reviewed by jiefu (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/1373
On Tue, 25 Apr 2023 12:43:42 GMT, Prasanta Sadhukhan
wrote:
> Newly added GetGraphicsTest should be headful as it uses a Frame
>
>
> java.awt.HeadlessException:
> No X11 DISPLAY variable was set,
> or no headful library support was found,
> but this program performed an operation which require
On Tue, 25 Apr 2023 13:33:00 GMT, Prasanta Sadhukhan
wrote:
> My PR is already out for this https://git.openjdk.org/jdk/pull/13639 before
> yours...
OK.
So just close this one.
-
PR Comment: https://git.openjdk.org/jdk/pull/13640#issuecomment-1521836192
On Tue, 25 Apr 2023 13:16:33 GMT, Jie Fu wrote:
> Add `@key headful` in the test.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/13640
Add `@key headful` in the test.
-
Commit messages:
- 8306849: Missing headful in java/awt/Graphics/GetGraphicsTest.java
Changes: https://git.openjdk.org/jdk/pull/13640/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13640&range=00
Issue: https://bugs.openjdk.org/browse/JDK
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>
On Tue, 17 Jan 2023 18:12:44 GMT, Phil Race wrote:
> client changes are OK by me.
Thanks @prrace .
-
PR: https://git.openjdk.org/jdk/pull/12005
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>
On Tue, 17 Jan 2023 04:29:31 GMT, David Holmes wrote:
> Hotspot changes are good.
Thanks @dholmes-ora .
-
PR: https://git.openjdk.org/jdk/pull/12005
On Mon, 16 Jan 2023 08:51:34 GMT, Jie Fu wrote:
> For the libzip issues, are these in the native methods or when compiling the
> zlib code, just wondering if there are bug reports for upstream there too.
Mainly caused by files under `src/java.base/share/native/libzip/zlib/`.
I'm
On Mon, 16 Jan 2023 08:21:47 GMT, Alan Bateman wrote:
> Is there a list of the issues building libjli? I don't see the in the PR or
> the JBS issue. For the libzip issues, are these in the native methods or when
> compiling the zlib code, just wondering if there are bug reports for upstream
>
On Sat, 14 Jan 2023 15:03:42 GMT, Kevin Rushforth wrote:
> Normally, such changes in third-party libraries need to be done upstream, and
> not locally. @prrace can confirm.
Thanks @kevinrushforth for your review.
Yes, it had been fixed in the upstream and I just follow it.
Please see https://g
Hi all,
Please review the fix for the build failure with clang-15.
1. -Wbitwise-instead-of-logical
1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the warning
2) src/hotspot/share/runtime/notificationThread.cpp <--- keep the code and
disable warnings
3) src/hotspot/s
33 matches
Mail list logo
