On Thu, 1 Jun 2023 13:16:49 GMT, JoKern65 wrote:
> This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared
> code https://github.com/openjdk/jdk/pull/14146
> It handles the part in java.desktop.
> prrace had already reviewed this part in the original pr.
>
On Thu, 1 Jun 2023 17:31:28 GMT, JoKern65 wrote:
>> This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared
>> code https://github.com/openjdk/jdk/pull/14146
>> It handles the part in java.desktop.
>> prrace had already reviewed this part in the orig
wt_xawt/awt/gtk2_interface.c:1180:29: error:
> using the result of an assignment as a condition without parentheses
> [-Werror,-Wparentheses]
> if (init_result = (NULL == gtk2_widgets[_GTK_CHECK_MENU_ITEM_TYPE]))
> ^
> solved by adding line
> DISABLED_WARNINGS_clang_aix_gtk2_interfac
This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared
code https://github.com/openjdk/jdk/pull/14146
It handles the part in java.desktop.
prrace had already reviewed this part in the original pr.
Here are the handled errors for which we use the same warning disabling as gcc.
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>&
On Thu, 25 May 2023 09:14:14 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Some of those are in shared codebase and could be addressed by small
> adjustments.
&g
On Tue, 30 May 2023 21:44:17 GMT, JoKern65 wrote:
>> src/hotspot/share/runtime/javaThread.cpp line 115:
>>
>>> 113: #include
>>> 114: #endif
>>> 115:
>>
>> Could these conditionals be included in globalDefinitions_xlc.hpp instead?
&g
On Tue, 30 May 2023 18:42:54 GMT, Coleen Phillimore wrote:
>> JoKern65 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> forgotton _
>
> src/hotspot/share/runtime/javaThread.cpp line 115:
>
>&g
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>&
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>&
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>&
be somewhere else in the
> OpenJDK C/C++ code.
JoKern65 has updated the pull request incrementally with one additional commit
since the last revision:
forgotton _
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14146/files
- new: https://git.openjdk.org/jdk/pull/14
On Thu, 25 May 2023 15:18:41 GMT, Kim Barrett wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those ch
When using the new xlc17 compiler (based on a recent clang) to build OpenJDk on
AIX , we run into various "warnings as errors".
Some of those are in shared codebase and could be addressed by small
adjustments.
A lot of those changes are in hotspot, some might be somewhere else in the
OpenJDK C/C
On Wed, 24 May 2023 03:13:34 GMT, Kim Barrett wrote:
>> Strange the last resulting change I see is
>> `struct shmid_ds shm_buf{};`
>
> That's not what I see in this PR, and not what I see in the repository after
> the integration. Where are you seeing
> that? (If in your local repository, mayb
On Thu, 18 May 2023 15:20:22 GMT, Kim Barrett wrote:
>> Use
>>
>> struct shmid_ds shm_buf{};
>>
>> to _value-initialize_. Calls the default constructor if there is one.
>> Otherwise, performs _zero-initialization_,
>> which is what we want here.
>
> The final suggested change (to direct-value
On Fri, 12 May 2023 12:01:43 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Many of those are in the aix or ppc specific codebase and could be addressed
> by smal
On Fri, 12 May 2023 16:16:01 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Many of those are in the aix or ppc specific codebase and could be addressed
&
in hotspot, some might be somewhere else in the
> OpenJDK C/C++ code.
> With this PR we address only the platform dependent code changes.
JoKern65 has updated the pull request incrementally with one additional commit
since the last revision:
followed the suggested changes
---
On Mon, 15 May 2023 09:32:26 GMT, Kim Barrett wrote:
>> I see, so `size` is kind of macro-like, and is just textually splicing its
>> argument expression into another expression.
>> And without the added parens the resulting full expression for the assert
>> isn't checking what's intended, due
On Fri, 12 May 2023 22:01:46 GMT, Kim Barrett wrote:
>> JoKern65 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes
>
> src/java.desktop/aix/native/libawt/porting_aix.c line 49:
>
>&g
On Fri, 12 May 2023 21:59:11 GMT, Kim Barrett wrote:
>> JoKern65 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes
>
> src/hotspot/os/aix/os_aix.cpp line 464:
>
>> 462: gu
On Fri, 12 May 2023 21:56:50 GMT, Kim Barrett wrote:
>> JoKern65 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes
>
> src/hotspot/cpu/ppc/ppc.ad line 11444:
>
>> 11442:
in hotspot, some might be somewhere else in the
> OpenJDK C/C++ code.
> With this PR we address only the platform dependent code changes.
JoKern65 has updated the pull request incrementally with one additional commit
since the last revision:
cosmetic changes
-
Changes:
- all: h
On Fri, 12 May 2023 12:01:43 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Many of those are in the aix or ppc specific codebase and could be addressed
> by smal
On Fri, 12 May 2023 12:01:43 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Many of those are in the aix or ppc specific codebase and could be addressed
> by smal
When using the new xlc17 compiler (based on a recent clang) to build OpenJDk on
AIX , we run into various "warnings as errors".
Many of those are in the aix or ppc specific codebase and could be addressed by
small adjustments.
A lot of those changes are in hotspot, some might be somewhere else in
27 matches
Mail list logo
