Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-04-05 Thread Joachim Kern
On Fri, 14 Mar 2025 15:41:56 GMT, Joachim Kern wrote: > After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v3]

2025-04-05 Thread Joachim Kern
On Fri, 21 Mar 2025 10:33:10 GMT, Magnus Ihse Bursie wrote: >> Joachim Kern has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added needed include > > make/StaticLibs.gmk line 117: > >> 115:

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-04-04 Thread Joachim Kern
On Mon, 17 Mar 2025 10:02:12 GMT, Joachim Kern wrote: >> make/StaticLibs.gmk line 116: >> >>> 114: #DEPS := $(STATIC_LIB_FILE), \ >>> 115: #OUTPUT_FILE := $(STATIC_LIB_EXPORT_FILES), \ >>> 116: #COMMAND := $(AR) $(ARFLAGS) -w $(patsubst %.exp,

Integrated: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-24 Thread Joachim Kern
On Fri, 14 Mar 2025 15:41:56 GMT, Joachim Kern wrote: > After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-03-21 Thread Joachim Kern
ortunately I > was not able to make it function. So I still have my "raw" solution in place, > but my last try with `SetupExecute` as comment beneath. Help is welcome. Joachim Kern has updated the pull request incrementally with one additional commit since the last revision: foll

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v4]

2025-03-21 Thread Joachim Kern
ortunately I > was not able to make it function. So I still have my "raw" solution in place, > but my last try with `SetupExecute` as comment beneath. Help is welcome. Joachim Kern has updated the pull request incrementally with one additional commit since the last revision: foll

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v3]

2025-03-20 Thread Joachim Kern
ortunately I > was not able to make it function. So I still have my "raw" solution in place, > but my last try with `SetupExecute` as comment beneath. Help is welcome. Joachim Kern has updated the pull request incrementally with one additional commit since the last revision: ad

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v3]

2025-03-20 Thread Joachim Kern
On Thu, 20 Mar 2025 14:30:58 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-833

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v2]

2025-03-18 Thread Joachim Kern
ortunately I > was not able to make it function. So I still have my "raw" solution in place, > but my last try with `SetupExecute` as comment beneath. Help is welcome. Joachim Kern has updated the pull request incrementally with one additional commit since the last revision: fo

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-18 Thread Joachim Kern
On Mon, 17 Mar 2025 15:01:10 GMT, Joachim Kern wrote: >> Looks like this variable is misspelled (missing "S"). >> >> DEPS := $(STATIC_LIB_FILE), \ >> >> Also note that by default log level INFO is not printed. You would need to >> run the build wi

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-17 Thread Joachim Kern
On Mon, 17 Mar 2025 13:14:44 GMT, Erik Joelsson wrote: >> The problem seems to be that `$(generate_export_list)` is empty and I do not >> know why. > > Looks like this variable is misspelled (missing "S"). > > DEPS := $(STATIC_LIB_FILE), \ > > Also note that by default log level INFO is not pr

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-17 Thread Joachim Kern
On Fri, 14 Mar 2025 17:35:02 GMT, Erik Joelsson wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >>

RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-15 Thread Joachim Kern
After "JDK-8339480: Build static-jdk image with a statically linked launcher" AIX was not able to build the new target. Therefore with "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was disabled again. Now with this change we can enable the statically linked launcher target

Integrated: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors

2025-01-28 Thread Joachim Kern
On Wed, 22 Jan 2025 15:34:36 GMT, Joachim Kern wrote: > We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on > clang 17) as a feasible compiler for jdk25, because in combination with the > 17.1.3 runtime this would enable the support for ubsan. > Unfortunat

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-01-24 Thread Joachim Kern
On Thu, 23 Jan 2025 20:31:03 GMT, Phil Race wrote: >> Joachim Kern has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove old solution > > If absolutely nothing else needs fp_pipewire.h I guess that oug

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-01-23 Thread Joachim Kern
36:20 >36 extern jfieldID g_BImgRasterID; > and the corresponding c-File >jfieldID g_BImgRasterID; > > The other possible solution would be to compile everything with > -Wno-tentative-definitions > which could be set in flags-cflags.m4, if compiling with clang 17.

Re: RFR: 8327701: Remove the xlc toolchain [v4]

2024-03-13 Thread Joachim Kern
On Tue, 12 Mar 2024 15:27:29 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >>

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Mon, 11 Mar 2024 08:59:03 GMT, Joachim Kern wrote: >> make/autoconf/flags-cflags.m4 line 687: >> >>> 685: PICFLAG="-fPIC" >>> 686: PIEFLAG="-fPIE" >>> 687: elif test "x$TOOLCHAIN_TYPE" = xclang && tes

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Fri, 8 Mar 2024 15:48:08 GMT, Magnus Ihse Bursie wrote: >> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building >> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect >> clang by another name, and it uses the clang toolchain in the JDK build. >> T

Re: RFR: 8327701: Remove the xlc toolchain [v2]

2024-03-11 Thread Joachim Kern
On Fri, 8 Mar 2024 15:31:18 GMT, Magnus Ihse Bursie wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert SEARCH_PATH changes > > make/autoconf/flags-cflags.m4 line 687: > >> 685: PICFLAG="-fPIC" >> 686

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-12 Thread Joachim Kern
On Thu, 8 Feb 2024 14:47:26 GMT, Joachim Kern wrote: >> And also `#define statvfs statvfs64` is not necessary with the same >> explanation as for the `opendir` defines above -- sorry again. >> The very only difference between statvfs and statvfs64 is that the >> filesy

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-08 Thread Joachim Kern
On Thu, 8 Feb 2024 09:03:10 GMT, Joachim Kern wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Once more, remove AIX dirent64 et al defines > > And also `#define statvfs statvf

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v10]

2024-02-08 Thread Joachim Kern
On Thu, 8 Feb 2024 07:44:18 GMT, Magnus Ihse Bursie wrote: >> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we >> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK >> native libraries. > > Magnus Ihse Bursie has updated the pull request increme

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v9]

2024-02-07 Thread Joachim Kern
On Tue, 6 Feb 2024 08:18:14 GMT, Magnus Ihse Bursie wrote: >> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we >> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK >> native libraries. > > Magnus Ihse Bursie has updated the pull request increme

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v7]

2024-02-05 Thread Joachim Kern
On Mon, 5 Feb 2024 12:07:45 GMT, Matthias Baesken wrote: > Current commit compiles nicely on AIX. One issue we might still have > statvfs/statvfs64 is not mentioned here in the table of functions/structs > redefined on AIX > https://www.ibm.com/docs/en/aix/7.1?topic=volumes-writing-programs-th