On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before package
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or imp
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial and
On Tue, 23 May 2023 20:24:18 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to ProblemList some tests:
> [JDK-8308716](https://bugs.openjdk.org/browse/JDK-8308716) ProblemList
> java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with
> genzgc on windows-x64
> [JDK-8308718](
On Thu, 4 May 2023 20:49:26 GMT, Daniel D. Daugherty wrote:
> Trivial fixes to ProblemList a few tests:
> - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList
> jdk/incubator/vector/LoadJsvmlTest.java on windows-x64
> - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-830749
On Tue, 25 Apr 2023 18:52:16 GMT, Archie Cobbs wrote:
>> The `Introspector` class was never updated to include `default` methods
>> inherited from interfaces.
>>
>> This patch attempts to fix that omission.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge o
On Thu, 20 Apr 2023 22:21:39 GMT, Archie L. Cobbs wrote:
> > The fix overall looks fine, but I'm not seeing why you think it needs a
> > CSR. It is just a bug fix.
>
> I'm not sure if it does or not. According to the [CSR
> FAQ](https://wiki.openjdk.org/display/csr/CSR+FAQs), _Behavioral
> co
On Tue, 17 Jan 2023 20:06:01 GMT, Joe Darcy wrote:
> Use new javadoc capabilities courtesy JDK-8200337 to use more readable in
> javadoc source anchors AWT's Shape interface. Analogous change is out for
> review in core libs, JDK-8300133.
This pull request has now been integrat
Use new javadoc capabilities courtesy JDK-8200337 to use more readable in
javadoc source anchors AWT's Shape interface. Analogous change is out for
review in core libs, JDK-8300133.
-
Commit messages:
- JDK-8300279: Use generalized see and link tags in core libs in client libs
Cha
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not strictly used as no
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote:
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
This pull
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base
On Mon, 3 Oct 2022 20:04:38 GMT, Phil Race wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make directory.
>
> src/jdk.accessibility/windows/native/include/bridge/AccessBrid
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base
On Mon, 3 Oct 2022 17:17:39 GMT, Joe Darcy wrote:
> > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> > might warrant a separate PR..?
>
> Filed a few follow-up bugs:
>
> JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbre
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
On Fri, 30 Sep 2022 20:25:28 GMT, Joe Darcy wrote:
> Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> might warrant a separate PR..?
Filed a few follow-up bugs:
JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbrella)
JDK-829472
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk
On Fri, 30 Sep 2022 17:38:54 GMT, Phil Race wrote:
> This is correct. AccessBridge.h is published with the include/header files of
> the JDK and anyone reading it there can't exactly make use of "../"
Update to persistent git links.
-
PR: https://git.openjdk.org/jdk/pull/10501
On Fri, 30 Sep 2022 13:59:12 GMT, Magnus Ihse Bursie wrote:
> Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> might warrant a separate PR..?
Yes; I think it is sufficient to update src and doc with this PR.
-
PR: https://git.openjdk.org/jdk/pull/10501
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target base
On Fri, 30 Sep 2022 00:48:02 GMT, Mikael Vidstedt wrote:
> Switch to https where needed/applicable while at it?
Good idea; might as well do the update in a single changeset.
-
PR: https://git.openjdk.org/jdk/pull/10501
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with two
With the domain change from openjdk.java.net to openjdk.org, references to URLs
in the sources should be updated.
Updates were made using a shell script. I"ll run a copyright updater before any
push.
-
Commit messages:
- JDK-8294618: Update openjdk.java.net => openjdk.org
Changes
On Sat, 17 Sep 2022 08:41:19 GMT, Alan Bateman wrote:
>> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for
>> removal, and remove the remaining special handling of ThreadDeath from the
>> JDK.
>>
>> Thread.stop is inherently unsafe and has been deprecated since JDK 1.
gt; Not sure why only in this case was the compatibility important.
>
> I'd like to hear what @jddarcy (Joe Darcy) thinks about all of this.
For the equals contract, members of an equivalence class should all be equal to
each other, meaning they are substitutable for each other in
On Fri, 10 Jun 2022 09:39:48 GMT, Martin Desruisseaux wrote:
> `AffineTransform.equals(Object)` and `hashCode()` break two contracts:
>
> * `A.equals(A)` returns `false` if at least one affine transform coefficient
> is NaN.
> * `A.equals(B)` should imply `A.hashCode() == B.hashCode()`, but it
31 matches
Mail list logo
