Re: RFR: 8340801: Disable ubsan checks in some awt/2d coding [v4]

2024-10-14 Thread Lutz Schmidt
On Fri, 11 Oct 2024 18:05:58 GMT, Kim Barrett wrote: >> Matthias Baesken has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> comm

Re: RFR: 8340801: Disable ubsan checks in some awt/2d coding [v4]

2024-10-14 Thread Lutz Schmidt
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote: >> There is some old awt/2d coding where warnings occur when running with ubsan >> enabled binaries. >> However at most of these locations the coding should work (at least on our >> supported platform set) so the warnings can be disabled

Re: RFR: JDK-8307604: gcc12 based Alpine build broken build after JDK-8307301

2023-05-08 Thread Lutz Schmidt
On Mon, 8 May 2023 10:29:56 GMT, Matthias Baesken wrote: > After the harfbuzz 7.2 update we run into > > /linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8: > error: offset '4' outside bounds of constant string [-Werror=array-bounds] > 281 | bool get_poi

Re: RFR: JDK-8304054: Linux: NullPointerException from FontConfiguration.getVersion in case no fonts are installed

2023-04-12 Thread Lutz Schmidt
On Wed, 15 Mar 2023 16:02:36 GMT, Matthias Baesken wrote: > On Linux Alpine we were running in the jtreg awt tests into a lot of NPEs > like this : > > java.lang.InternalError: java.lang.reflect.InvocationTargetException > at java.desktop/sun.font.FontManagerFactory$1.run(FontManagerFactory.jav

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v10]

2023-04-12 Thread Lutz Schmidt
On Wed, 12 Apr 2023 03:44:45 GMT, Amit Kumar wrote: > Another remark: Old JDK on s390 used "os.arch = zArch_64", current one > "os.arch = s390x". @offamitkumar: You probably want to take a look. zArch_64 is not relevant/not used in the OpenJDK port to IBM System z. As noted elsewhere in the PR

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-07 Thread Lutz Schmidt
On Fri, 7 Apr 2023 11:21:33 GMT, Thomas Stuefe wrote: >> Hello Thomas, that change was based on the review comment here >> https://github.com/openjdk/jdk/pull/13357#discussion_r1159810942 > > Okay, Lutz is the expert here. Sorry for the noise. Just to let my voice be heard directly after being

Re: RFR: JDK-8304334: java/awt/color/ICC_ColorSpace/ToFromCIEXYZRoundTrip.java times out on slow platforms

2023-03-20 Thread Lutz Schmidt
On Fri, 17 Mar 2023 09:08:56 GMT, Matthias Baesken wrote: > The ToFromCIEXYZRoundTrip test times out on slow platforms , especially when > (fast)debug binaries are used. > This was observed on Alpine Linux and AIX in our automated tests. Setting an > increased timeout for the test helps to red

Re: RFR: JDK-8298093: improve cleanup and error handling of awt_parseColorModel in awt_parseImage.c [v3]

2022-12-07 Thread Lutz Schmidt
On Wed, 7 Dec 2022 08:54:29 GMT, Matthias Baesken wrote: >> The cleanup and error handling in function awt_parseColorModel in >> awt_parseImage.c could be improved. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > small

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

2022-11-16 Thread Lutz Schmidt
On Wed, 16 Nov 2022 06:43:29 GMT, Xue-Lei Andrew Fan wrote: >> src/hotspot/share/utilities/utf8.cpp line 521: >> >>> 519: } else { >>> 520: if (p + 6 >= end) break; // string is truncated >>> 521: os::snprintf(p, 7, "\\u%04x", c); >> >> This should be 6, or? We have 6 chara

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v6]

2022-11-15 Thread Lutz Schmidt
On Mon, 14 Nov 2022 19:44:17 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8296812: sprintf is deprecated in Xcode 14 [v4]

2022-11-15 Thread Lutz Schmidt
On Mon, 14 Nov 2022 05:32:20 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns, and the >> use of it causing building failure. The build could pass if warnings are >> disabled for codes that u

Re: RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-11-11 Thread Lutz Schmidt
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote: > Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused > parameter warnings: > > Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s) This is a moving target, and the changes depend on the build mode

Re: RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-11-10 Thread Lutz Schmidt
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote: > Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused > parameter warnings: > > Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s) As an interim solution until LCMS 2.14 has been pulled in, you co