Integrated: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently

2025-09-05 Thread Manukumar V S
On Tue, 2 Sep 2025 07:16:20 GMT, Manukumar V S wrote: > Issue: > java/awt/Focus/ComponentLostFocusTest.java fails intermittently(2/40) with an > exception " Execution failed: `main' threw exception: > java.lang.RuntimeException: TextField got no focus! Test failed."

Re: RFR: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently [v4]

2025-09-03 Thread Manukumar V S
redominantly in macos platform. > It fails sometimes in CI also. > > Fix: > Added a countdownlatch for tracking focusGained > Added screenshot logic > > Testing: > Tested in all mach5 platforms and got all PASS. Manukumar V S has updated the pull request incremental

Re: RFR: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently [v5]

2025-09-03 Thread Manukumar V S
redominantly in macos platform. > It fails sometimes in CI also. > > Fix: > Added a countdownlatch for tracking focusGained > Added screenshot logic > > Testing: > Tested in all mach5 platforms and got all PASS. Manukumar V S has updated the pull request incrementally with one

Re: RFR: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently [v3]

2025-09-02 Thread Manukumar V S
redominantly in macos platform. > It fails sometimes in CI also. > > Fix: > Added a countdownlatch for tracking focusGained > Added screenshot logic > > Testing: > Tested in all mach5 platforms and got all PASS. Manukumar V S has updated the pull request incrementally with one

Re: RFR: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently [v2]

2025-09-02 Thread Manukumar V S
redominantly in macos platform. > It fails sometimes in CI also. > > Fix: > Added a countdownlatch for tracking focusGained > Added screenshot logic > > Testing: > Tested in all mach5 platforms and got all PASS. Manukumar V S has updated the pull request incrementally with one

RFR: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently

2025-09-02 Thread Manukumar V S
Issue: java/awt/Focus/ComponentLostFocusTest.java fails intermittently(2/40) with an exception " Execution failed: `main' threw exception: java.lang.RuntimeException: TextField got no focus! Test failed." I have seen it failing in all platforms, but predominantly in macos platform. It fails somet

Re: RFR: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block [v9]

2025-08-25 Thread Manukumar V S
On Wed, 6 Aug 2025 09:43:48 GMT, Ravi Gupta wrote: >> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java >> left debris on system whenever fails its required frame.dispose() in finally >> block. >> >> >> finally { >> EventQueue.invokeAndWait(ExtraButtonDrag:

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v25]

2025-08-19 Thread Manukumar V S
On Tue, 19 Aug 2025 14:54:16 GMT, Khalid Boulanouare wrote: >> Many Mixing tests failed because the work around click lands on the >> minimizing area in the window control and causes the tests to fail. >> >> This fix changes the width of base frames which allows most of tests to pass. > > Khali

Withdrawn: 8364506: javax/swing/Popup/TaskbarPositionTest.java can fail subsequent tests on MacOS

2025-08-18 Thread Manukumar V S
On Mon, 4 Aug 2025 15:14:30 GMT, Manukumar V S wrote: > Issue: > javax/swing/Popup/TaskbarPositionTest.java can fail subsequent tests on MacOS > because of using 'Cntrl+Down Arrow' as this acts as a shortcut in MacOS to > show all windows related to the focused one.

Re: RFR: 8364506: javax/swing/Popup/TaskbarPositionTest.java can fail subsequent tests on MacOS

2025-08-18 Thread Manukumar V S
On Mon, 4 Aug 2025 15:14:30 GMT, Manukumar V S wrote: > Issue: > javax/swing/Popup/TaskbarPositionTest.java can fail subsequent tests on MacOS > because of using 'Cntrl+Down Arrow' as this acts as a shortcut in MacOS to > show all windows related to the focused one.

RFR: 8364506: javax/swing/Popup/TaskbarPositionTest.java can fail subsequent tests on MacOS

2025-08-04 Thread Manukumar V S
Issue: javax/swing/Popup/TaskbarPositionTest.java can fail subsequent tests on MacOS because of using 'Cntrl+Down Arrow' as this acts as a shortcut in MacOS to show all windows related to the focused one. Fix: Change the 'Cntrl' key to 'Shift' Testing: Tested in all supported platforms using ma

[jdk25] Withdrawn: 8358697: TextLayout/MyanmarTextTest.java passes if no Myanmar font is found

2025-07-21 Thread Manukumar V S
On Mon, 21 Jul 2025 08:48:41 GMT, Manukumar V S wrote: > Hi all, > > This pull request contains a backport of commit > [bcad87ea](https://github.com/openjdk/jdk/commit/bcad87eacbd7fbfd3254479b7e061bab34e64aec) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

Re: [jdk25] RFR: 8358697: TextLayout/MyanmarTextTest.java passes if no Myanmar font is found

2025-07-21 Thread Manukumar V S
On Mon, 21 Jul 2025 08:48:41 GMT, Manukumar V S wrote: > Hi all, > > This pull request contains a backport of commit > [bcad87ea](https://github.com/openjdk/jdk/commit/bcad87eacbd7fbfd3254479b7e061bab34e64aec) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

Re: [jdk25] RFR: 8358697: TextLayout/MyanmarTextTest.java passes if no Myanmar font is found

2025-07-21 Thread Manukumar V S
rg/jdk) repository. >> >> The commit being backported was authored by Manukumar V S on 24 Jun 2025 and >> was reviewed by Alexey Ivanov. >> >> Testing: Tested well on all platforms using Mach5 and got full Pass. >> >> Thanks! > > Is this a mistake ?

[jdk25] RFR: 8358697: TextLayout/MyanmarTextTest.java passes if no Myanmar font is found

2025-07-21 Thread Manukumar V S
Hi all, This pull request contains a backport of commit [bcad87ea](https://github.com/openjdk/jdk/commit/bcad87eacbd7fbfd3254479b7e061bab34e64aec) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Manukumar V S on 24 Jun 2025 and was

[jdk25] Integrated: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-07-07 Thread Manukumar V S
On Fri, 4 Jul 2025 09:27:33 GMT, Manukumar V S wrote: > This is the backport of a test stabilisation fix done by @manukumarvs and > approved by @aivanov-jdk. > > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the

[jdk25] RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-07-04 Thread Manukumar V S
This is the backport of a test stabilisation fix done by @manukumarvs and approved by @aivanov-jdk. Issue: In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar. This may open some other UI item and may interfere further testing on that mac

Integrated: 8361115: javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException

2025-07-03 Thread Manukumar V S
On Tue, 1 Jul 2025 04:57:05 GMT, Manukumar V S wrote: > Issue: > javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of > RuntimeException whenever a test failure occurs. > This causes unnecessary extra attention in CI systems and triggers task > failures

RFR: 8361115: javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException

2025-06-30 Thread Manukumar V S
Issue: javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException whenever a test failure occurs. This causes unnecessary extra attention in CI systems and triggers task failures as throwing an Error will write the error message to System.err and the CI system w

Integrated: 8358697: TextLayout/MyanmarTextTest.java passes if no Myanmar font is found

2025-06-23 Thread Manukumar V S
On Wed, 18 Jun 2025 16:20:14 GMT, Manukumar V S wrote: > Issue: > MyanmarTextTest.java produces a false positive result when some of the test > preconditions are not met. It checks whether certain fonts are present in the > system, for example, 'Padauk' on Linux. I

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v6]

2025-06-19 Thread Manukumar V S
may lead to a misinterpretation of the test as being headless, which > it is not. > > Fix: > Need to throw jtreg.SkippedException in cases where some pre-conditions for > running the test are not met. > > Testing: > Tested using mach5 in all available platforms and got f

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v4]

2025-06-18 Thread Manukumar V S
On Wed, 18 Jun 2025 20:26:51 GMT, Alexey Ivanov wrote: >> My comment was ONLY about Linux. I definitely didn't expect to see the fonts >> for other platforms updated. >> They can be a list of one font. > > That's how I read your suggestion too. > > Yet I like the idea of a platform-independent

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v5]

2025-06-18 Thread Manukumar V S
may lead to a misinterpretation of the test as being headless, which > it is not. > > Fix: > Need to throw jtreg.SkippedException in cases where some pre-conditions for > running the test are not met. > > Testing: > Tested using mach5 in all available platforms and got f

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v4]

2025-06-18 Thread Manukumar V S
may lead to a misinterpretation of the test as being headless, which > it is not. > > Fix: > Need to throw jtreg.SkippedException in cases where some pre-conditions for > running the test are not met. > > Testing: > Tested using mach5 in all available platforms and got f

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v3]

2025-06-18 Thread Manukumar V S
may lead to a misinterpretation of the test as being headless, which > it is not. > > Fix: > Need to throw jtreg.SkippedException in cases where some pre-conditions for > running the test are not met. > > Testing: > Tested using mach5 in all available platforms and got f

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v2]

2025-06-18 Thread Manukumar V S
may lead to a misinterpretation of the test as being headless, which > it is not. > > Fix: > Need to throw jtreg.SkippedException in cases where some pre-conditions for > running the test are not met. > > Testing: > Tested using mach5 in all available platforms and got f

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met

2025-06-18 Thread Manukumar V S
On Wed, 18 Jun 2025 17:00:53 GMT, Phil Race wrote: > I don't understand how what you changed related to the stated problem. In > fact I don't see the point of this PR at all. Sorry @prrace, my earlier description was ambiguous. I have updated it. In fact, the issue is about reporting a false p

Integrated: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-06-18 Thread Manukumar V S
On Wed, 18 Jun 2025 09:33:50 GMT, Manukumar V S wrote: > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the taskbar. This may open some other UI item and may > interfere further testing on that machine. > > Fix:

RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result on headless machines

2025-06-18 Thread Manukumar V S
Issue: java/awt/font/TextLayout/MyanmarTextTest.java passes on headless machines even though it creates GUI components. Ideally, when you create some GUI components in your code in a headless machine, it should through HeadlessException, but MyanmarTextTest.java seems to suppress it and gives a

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar [v2]

2025-06-18 Thread Manukumar V S
the screen by calling > frame.setLocationRelativeTo(null). > > Testing: > Tested manually and using Mach5(20 times in 3 machines) and got all PASS and > never triggered unwanted clicks on taskbar. Manukumar V S has updated the pull request incrementally with one additional commit since the

RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-06-18 Thread Manukumar V S
Issue: In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar. This may open some other UI item and may interfere further testing on that machine. Fix: Move the test UI to the centre of the screen by calling frame.setLocationRelativeTo(null)

Integrated: 8341370: Test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails intermittently on macOS-aarch64

2025-05-23 Thread Manukumar V S
On Wed, 21 May 2025 13:13:46 GMT, Manukumar V S wrote: > ShapeNotSetSometimes.java fails intermittently with a RuntimeException on > macOS-aarch64 > Test threw exception: java.lang.RuntimeException: Test failed. The shape has > not been applied. > > Fix: > The test has be

Re: RFR: 8341370: Test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails intermittently on macOS-aarch64 [v2]

2025-05-22 Thread Manukumar V S
g: > After fixing the test, it has been run 40 times per platform(Windows, Linux, > MacOS x64 and MacOS aarch64) using Mach5 and got 100% pass rate . Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Formatting ch

Integrated: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java

2025-05-22 Thread Manukumar V S
On Tue, 20 May 2025 07:32:41 GMT, Manukumar V S wrote: > There are some compilation failures noticed in the recently open sourced test > javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to > missing import statements and a missing dependency file MenuItem

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v9]

2025-05-22 Thread Manukumar V S
statements and added the code-piece > from MenuItemTest.java as a method getMenuItemTestFrame(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Removed unwanted code for positioning the UI - Changes: - all: https://g

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v7]

2025-05-22 Thread Manukumar V S
statements and added the code-piece > from MenuItemTest.java as a method getMenuItemTestFrame(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Added blank lines to seperate logic code pieces - Changes: - all: https

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v6]

2025-05-22 Thread Manukumar V S
On Thu, 22 May 2025 10:44:48 GMT, Alexey Ivanov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added final modifier to the class MenuItemTestHelper > > test/jdk/java

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v8]

2025-05-22 Thread Manukumar V S
statements and added the code-piece > from MenuItemTest.java as a method getMenuItemTestFrame(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Removed trailing whitespace - Changes: - all: https://git.openjdk.org/jd

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v5]

2025-05-21 Thread Manukumar V S
statements and added the code-piece > from MenuItemTest.java as a method getMenuItemTestFrame(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Removed unwanted code, location of imports - Chang

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v6]

2025-05-21 Thread Manukumar V S
statements and added the code-piece > from MenuItemTest.java as a method getMenuItemTestFrame(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Added final modifier to the class MenuItemTestHelper - Chang

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v2]

2025-05-21 Thread Manukumar V S
On Tue, 20 May 2025 19:18:06 GMT, Alexey Ivanov wrote: >> test/jdk/javax/swing/JMenuItem/MenuItemTest/MenuItemTestHelper.java line 43: >> >>> 41: import javax.swing.UIManager; >>> 42: >>> 43: class MenuItemTestHelper { >> >> I would've kept `MenuItemTest` as the name of the class. It's fine ei

RFR: 8341370: Test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails intermittently on macOS-aarch64

2025-05-21 Thread Manukumar V S
ShapeNotSetSometimes.java fails intermittently with a RuntimeException on macOS-aarch64 Test threw exception: java.lang.RuntimeException: Test failed. The shape has not been applied. Fix: The test has been modified to take a screenshot of the area and then analyse the pixel color in the screens

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v4]

2025-05-20 Thread Manukumar V S
statements and added the code-piece > from MenuItemTest.java as a method getMenuItemTestFrame(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Formatting changes,cosmetic changes,PassFailJF

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v3]

2025-05-20 Thread Manukumar V S
statements and added the code-piece > from MenuItemTest.java as a method getMenuItemTestFrame(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Formatting changes,copyright,cosmetic changes,etc -

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v2]

2025-05-20 Thread Manukumar V S
statements and added the code-piece > from MenuItemTest.java as a method getMenuItemTestFrame(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Rearranged and reused code by creating a new Helper MenuI

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java

2025-05-20 Thread Manukumar V S
On Tue, 20 May 2025 12:03:23 GMT, Alexey Ivanov wrote: > > > I see that `MenuItemTest` class exists in `bug4729669.java`: > > > https://github.com/openjdk/jdk/blob/e961b13cd68bc352b86af17c7e53df8537519beb/test/jdk/javax/swing/JMenuItem/bug4729669.java#L80 > > > > > > Is it similar to the one tha

Integrated: 8355515: Clarify the purpose of forcePass() and forceFail() methods

2025-05-20 Thread Manukumar V S
On Wed, 7 May 2025 12:28:52 GMT, Manukumar V S wrote: > Clarified the purpose of forcePass() and forceFail() methods and recommended > usage of these methods. > > forcePass() contained an incorrect sample; it's addressed by > [JDK-8355441](https://bugs.openjdk.or

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java

2025-05-20 Thread Manukumar V S
On Tue, 20 May 2025 10:15:11 GMT, Alexey Ivanov wrote: > I see that `MenuItemTest` class exists in `bug4729669.java`: > > https://github.com/openjdk/jdk/blob/e961b13cd68bc352b86af17c7e53df8537519beb/test/jdk/javax/swing/JMenuItem/bug4729669.java#L80 > > Is it similar to the one that you copied?

RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java

2025-05-20 Thread Manukumar V S
There are some compilation failures noticed in the recently open sourced test javax/swing/JMenuItem/bug6197830.java. The compilation failures are due to missing import statements and a missing dependency file MenuItemTest.java. Fix: I have added the required import statements and added the code-

Re: RFR: 8355515: Clarify the purpose of forcePass() and forceFail() methods [v3]

2025-05-19 Thread Manukumar V S
l() has been expanded, too. > > > A new section in the description of the PassFailJFrame added to describe > forcePass() and forceFail(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Forcibly wo

Re: RFR: 8355515: Clarify the purpose of forcePass() and forceFail() methods [v2]

2025-05-18 Thread Manukumar V S
l() has been expanded, too. > > > A new section in the description of the PassFailJFrame added to describe > forcePass() and forceFail(). Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed

Re: RFR: 8355515: Clarify the purpose of forcePass() and forceFail() methods

2025-05-18 Thread Manukumar V S
On Fri, 16 May 2025 12:16:40 GMT, Alexey Ivanov wrote: > After reading the description again, I started to wonder which adverb suits > better: [‘forcibly’](https://en.wiktionary.org/wiki/forcibly) or > [‘forcefully’](https://en.wiktionary.org/wiki/forcefully). Does any native > English speaker

Re: RFR: 8355515: Clarify the purpose of forcePass() and forceFail() methods

2025-05-13 Thread Manukumar V S
On Wed, 7 May 2025 12:28:52 GMT, Manukumar V S wrote: > Clarified the purpose of forcePass() and forceFail() methods and recommended > usage of these methods. > > forcePass() contained an incorrect sample; it's addressed by > [JDK-8355441](https://bugs.openjdk.or

RFR: 8355515: Clarify the purpose of forcePass() and forceFail() methods

2025-05-07 Thread Manukumar V S
Clarified the purpose of forcePass() and forceFail() methods and recommended usage of these methods. forcePass() contained an incorrect sample; it's addressed by [JDK-8355441](https://bugs.openjdk.org/browse/JDK-8355441). The description of forceFail() has been expanded, too. A new section in

Integrated: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI

2025-05-05 Thread Manukumar V S
On Fri, 28 Mar 2025 11:09:03 GMT, Manukumar V S wrote: > java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently > in CI, especially in MacOS machines. > Also the frame created in this test is not disposed which may interfere with > other tests. >

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v5]

2025-05-02 Thread Manukumar V S
b20. > With JDK 8u60b04: > Exception in thread "main" java.lang.RuntimeException: Wrong position of > component in ScrollPane > at bug8077409Test.main(bug8077409Test.java:142) > > With JDK 8u60b20: > Passed. Manukumar V S has updated the pull req

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v4]

2025-05-02 Thread Manukumar V S
On Mon, 28 Apr 2025 09:32:26 GMT, Manukumar V S wrote: >> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently >> in CI, especially in MacOS machines. >> Also the frame created in this test is not disposed which may interfere with >> other te

Integrated: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc

2025-04-29 Thread Manukumar V S
On Wed, 23 Apr 2025 23:50:06 GMT, Manukumar V S wrote: > The javadoc for PassFailJFrame.forcePass suggests an anti-pattern of forcibly > passing the test if a resource is unavailable. > > If a resource is unavailable or a feature isn't supported, the test should > throw jt

Re: RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v4]

2025-04-29 Thread Manukumar V S
On Mon, 28 Apr 2025 20:58:41 GMT, Harshitha Onkar wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated line number in code link > > test/jdk/java/awt/regtesthelpers/PassFailJFr

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v3]

2025-04-28 Thread Manukumar V S
On Sat, 26 Apr 2025 02:56:55 GMT, Sergey Bylokhov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Code reformatting, changed the indentation to the >> s

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v3]

2025-04-28 Thread Manukumar V S
On Sat, 26 Apr 2025 02:54:58 GMT, Sergey Bylokhov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Code reformatting, changed the indentation to the >> s

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v4]

2025-04-28 Thread Manukumar V S
is disposed properly. > > Testing: > Tested 100 times per > platform(macosx-x64,macosx-aarch64,windows-x64,linux-x64) and got all PASS. Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Removed unwante

Re: RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v4]

2025-04-25 Thread Manukumar V S
ass should be used in semi-automatic tests when the test > determines that all the conditions for passing the test are met. > Please refer: JDK-8355366 and https://github.com/openjdk/jdk/pull/24820 > > Testing > This is a javadoc change, so not testing required. Manukumar V S has up

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v3]

2025-04-25 Thread Manukumar V S
On Fri, 11 Apr 2025 05:34:15 GMT, Manukumar V S wrote: >> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently >> in CI, especially in MacOS machines. >> Also the frame created in this test is not disposed which may interfere with >> other te

Integrated: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests

2025-04-25 Thread Manukumar V S
On Thu, 24 Apr 2025 16:36:56 GMT, Manukumar V S wrote: > Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests from > java.awt.Desktop package. These tests should be fixed similar to > [JDK-8352109](https://bugs.openjdk.org/browse/JDK-8352109) and > jtreg.Skip

Re: RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v2]

2025-04-24 Thread Manukumar V S
On Thu, 24 Apr 2025 16:32:11 GMT, Alexey Ivanov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Formatting changes, added reference to a real test > > te

Re: RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v3]

2025-04-24 Thread Manukumar V S
ass should be used in semi-automatic tests when the test > determines that all the conditions for passing the test are met. > Please refer: JDK-8355366 and https://github.com/openjdk/jdk/pull/24820 > > Testing > This is a javadoc change, so not testing required. Manukumar V S has up

RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests

2025-04-24 Thread Manukumar V S
Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests from java.awt.Desktop package. These tests should be fixed similar to [JDK-8352109](https://bugs.openjdk.org/browse/JDK-8352109) and jtreg.SkippedException should be used instead of PassFailJFrame.forcePass(). Affected tests:

Re: RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests [v2]

2025-04-24 Thread Manukumar V S
On Thu, 24 Apr 2025 15:24:00 GMT, Alexey Ivanov wrote: > I assume you tried merging master but something went awry along the lines… > 281 files changed instead of 3 doesn't look good. Sorry, it somehow got messed up, I will create a fresh PR. - PR Comment: https://git.openjdk.org/

Re: RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests [v4]

2025-04-24 Thread Manukumar V S
java/awt/Desktop/EditAndPrintTest/EditAndPrintTest.java > > Testing: > All the changed tests are tested manually and found to be working fine. Manukumar V S has updated the pull request with a new target base due to a merge or a rebase. - Changes: https://git.openjd

Withdrawn: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests

2025-04-24 Thread Manukumar V S
On Wed, 23 Apr 2025 09:35:25 GMT, Manukumar V S wrote: > Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests from > java.awt.Desktop package. These tests should be fixed similar to > [JDK-8352109](https://bugs.openjdk.org/browse/JDK-8352109) and > jtreg.Skip

Re: RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v2]

2025-04-24 Thread Manukumar V S
On Thu, 24 Apr 2025 14:22:00 GMT, Alexey Ivanov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Formatting changes, added reference to a real test > > te

Re: RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests [v3]

2025-04-24 Thread Manukumar V S
java/awt/Desktop/EditAndPrintTest/EditAndPrintTest.java > > Testing: > All the changed tests are tested manually and found to be working fine. Manukumar V S has updated the pull request incrementally with 29 additional commits since the last revision: - Review comments fixed : Changed t

Re: RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v2]

2025-04-24 Thread Manukumar V S
ass should be used in semi-automatic tests when the test > determines that all the conditions for passing the test are met. > Please refer: JDK-8355366 and https://github.com/openjdk/jdk/pull/24820 > > Testing > This is a javadoc change, so not testing required. Manukumar V S has up

RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc

2025-04-23 Thread Manukumar V S
The javadoc for PassFailJFrame.forcePass suggests an anti-pattern of forcibly passing the test if a resource is unavailable. If a resource is unavailable or a feature isn't supported, the test should throw jtreg.SkippedException. PassFailJFrame.forcePass should be used in semi-automatic tests w

Re: RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests

2025-04-23 Thread Manukumar V S
On Wed, 23 Apr 2025 19:57:59 GMT, Alexey Ivanov wrote: > I submitted [JDK-8355441](https://bugs.openjdk.org/browse/JDK-8355441) to > remove the description of the incorrect usage from `PassFailJFrame.forcePass` > javadoc. > > Feel free to assign to yourself and fix the issue. Raised https://g

Re: RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests [v2]

2025-04-23 Thread Manukumar V S
java/awt/Desktop/EditAndPrintTest/EditAndPrintTest.java > > Testing: > All the changed tests are tested manually and found to be working fine. Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Update Copyright year - Cha

RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests

2025-04-23 Thread Manukumar V S
Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests from java.awt.Desktop package. These tests should be fixed similar to [JDK-8352109](https://bugs.openjdk.org/browse/JDK-8352109) and jtreg.SkippedException should be used instead of PassFailJFrame.forcePass(). Affected tests:

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v3]

2025-04-18 Thread Manukumar V S
On Fri, 11 Apr 2025 05:34:15 GMT, Manukumar V S wrote: >> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently >> in CI, especially in MacOS machines. >> Also the frame created in this test is not disposed which may interfere with >> other te

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v3]

2025-04-10 Thread Manukumar V S
is disposed properly. > > Testing: > Tested 100 times per > platform(macosx-x64,macosx-aarch64,windows-x64,linux-x64) and got all PASS. Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Code reformattin

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v2]

2025-04-10 Thread Manukumar V S
On Fri, 11 Apr 2025 04:11:48 GMT, Sergey Bylokhov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Formatting changes > > test/jdk/java/awt/ScrollPan

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v2]

2025-04-07 Thread Manukumar V S
On Sat, 5 Apr 2025 11:52:19 GMT, Manukumar V S wrote: >> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently >> in CI, especially in MacOS machines. >> Also the frame created in this test is not disposed which may interfere with >> other te

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v2]

2025-04-05 Thread Manukumar V S
On Tue, 1 Apr 2025 02:42:46 GMT, Damon Nguyen wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Formatting changes > > test/jdk/java/awt/ScrollPane/bug807740

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v2]

2025-04-05 Thread Manukumar V S
is disposed properly. > > Testing: > Tested 100 times per > platform(macosx-x64,macosx-aarch64,windows-x64,linux-x64) and got all PASS. Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Formatting changes

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v2]

2025-04-05 Thread Manukumar V S
On Fri, 28 Mar 2025 15:43:44 GMT, lawrence.andrews wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Formatting changes > > test/jdk/java/awt/ScrollPane/bug8077

RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI

2025-03-28 Thread Manukumar V S
java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI, especially in MacOS machines. Also the frame created in this test is not disposed which may interfere with other tests. Fix: Some stabilisations added and the frame is disposed properly. Testing: Tested 100 time

Integrated: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported

2025-03-19 Thread Manukumar V S
On Sun, 16 Mar 2025 08:56:24 GMT, Manukumar V S wrote: > **Issue** > java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not > supported > > **Reason** > In `MailTest.java`, there is a condition check(`if > (!desktop.isSupported(Desktop.Action.MAIL))`)

Re: RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported [v3]

2025-03-18 Thread Manukumar V S
an UnsupportedOperationException. So, the fix is to return > from the constructor immediately if the operation is 'unsupported'. > > **Testing** > This is a manual test, so it is tested locally and found to be working fine. Manukumar V S has updated the pull request incremen

Re: RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported [v2]

2025-03-18 Thread Manukumar V S
On Tue, 18 Mar 2025 20:37:43 GMT, Alexey Ivanov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Added SkippedException instead of forcePass(), >> C

Re: RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported [v2]

2025-03-18 Thread Manukumar V S
an UnsupportedOperationException. So, the fix is to return > from the constructor immediately if the operation is 'unsupported'. > > **Testing** > This is a manual test, so it is tested locally and found to be working fine. Manukumar V S has updated the pull request increm

Re: RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported [v2]

2025-03-18 Thread Manukumar V S
On Tue, 18 Mar 2025 17:52:48 GMT, Alexey Ivanov wrote: >> Manukumar V S has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments fixed : Added SkippedException instead of forcePass(), >> C

Re: RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported

2025-03-18 Thread Manukumar V S
On Sun, 16 Mar 2025 08:56:24 GMT, Manukumar V S wrote: > **Issue** > java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not > supported > > **Reason** > In `MailTest.java`, there is a condition check(`if > (!desktop.isSupported(Desktop.Action.MAIL))`)

RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported

2025-03-16 Thread Manukumar V S
**Issue** java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported **Reason** In `MailTest.java`, there is a condition check(`if (!desktop.isSupported(Desktop.Action.MAIL))`) which will force pass the test if the corresponding 'Action' is not supported by the platfor

Integrated: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible

2024-10-22 Thread Manukumar V S
On Wed, 16 Oct 2024 18:37:23 GMT, Manukumar V S wrote: > This issue can be fixed by setting the preferred scrollable viewport size of > the two tables using > JTable table = new JTable(data, columnNames); > + table.setPreferredScrollableViewportSize(table.getP

Re: RFR: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible [v4]

2024-10-22 Thread Manukumar V S
On Mon, 21 Oct 2024 15:44:54 GMT, Manukumar V S wrote: >> This issue can be fixed by setting the preferred scrollable viewport size of >> the two tables using >> JTable table = new JTable(data, columnNames); >> + table.setPreferredScrollableViewportSiz

Re: RFR: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible [v4]

2024-10-21 Thread Manukumar V S
ified manually in my > local system > Screenshots of before and after the fix are attached in the bug. Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Removed the extra blank line - Changes: - a

Re: RFR: 8342098: Write a test to compare the images [v3]

2024-10-21 Thread Manukumar V S
On Mon, 21 Oct 2024 10:25:26 GMT, Abhishek Kumar wrote: > > The test initially failed on my local mac machine running Sonoma 14.6 also, > > but when I changed the colour profile to sRGB, it started passing, > > @kumarabhi006 can you please check the colour profile on your machine?. > > I don't

Re: RFR: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible [v3]

2024-10-21 Thread Manukumar V S
ified manually in my > local system > Screenshots of before and after the fix are attached in the bug. Manukumar V S has updated the pull request incrementally with one additional commit since the last revision: Review comments fixed : Copyright year added, re-arranged imports, removed author t

Re: RFR: 8342098: Write a test to compare the images [v3]

2024-10-21 Thread Manukumar V S
On Fri, 18 Oct 2024 15:54:24 GMT, Naveen Narayanan wrote: >> This testcase checks for the following: >> >> 1. An image is drawn on the screen and a portion of it is captured using a >> Robot. It is tested by comparing whether the captured image is same as the >> source image. >> >> Testing:

Re: RFR: 8342098: Write a test to compare the images [v3]

2024-10-21 Thread Manukumar V S
On Mon, 21 Oct 2024 04:44:19 GMT, Abhishek Kumar wrote: > @Naveenam-Oracle Test failed on my local mac machine running `Sonoma 14.5`. The test initially failed on my local mac machine running Sonoma 14.6 also, but when I changed the colour profile to sRGB, it started passing, @kumarabhi006 can

  1   2   3   >