Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-04-05 Thread Martin Doerr
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v4]

2025-03-21 Thread Martin Doerr
On Fri, 21 Mar 2025 11:44:49 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8349751: AIX build failure after upgrade pipewire to 1.3.81 [v4]

2025-02-14 Thread Martin Doerr
On Fri, 14 Feb 2025 04:52:31 GMT, Phil Race wrote: >> Alexander Zvegintsev has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains seven commits: >> >> - Merge master >> - move fix to spa/utils/endian.h >> - merge "if defined" >> - 83

Re: RFR: 8349751: AIX build failure after upgrade pipewire to 1.3.81 [v4]

2025-02-14 Thread Martin Doerr
On Thu, 13 Feb 2025 11:55:53 GMT, Alexander Zvegintsev wrote: >> Filed as a separate issue to keep the #23426 clean. >> >> Fix is the same as in the >> `src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h` >> part of the [JDK-8309703](https://bugs.openjdk.org/browse/JDK-830

Re: RFR: 8347576: Error output in libjsound has non matching format strings [v5]

2025-01-16 Thread Martin Doerr
On Thu, 16 Jan 2025 15:36:54 GMT, Matthias Baesken wrote: >> When enabling the jsound ERROR and TRACE reporting (see >> src/java.desktop/share/native/libjsound/Configure.h >> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libjsound/Configure.h#L32 >> ), we run into so

Re: RFR: 8347576: Error output in libjsound has non matching format strings [v2]

2025-01-14 Thread Martin Doerr
On Tue, 14 Jan 2025 10:51:56 GMT, Matthias Baesken wrote: >> When enabling the jsound ERROR and TRACE reporting (see >> src/java.desktop/share/native/libjsound/Configure.h >> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libjsound/Configure.h#L32 >> ), we run into so

Re: RFR: 8347576: Error output in libjsound has non matching format strings

2025-01-13 Thread Martin Doerr
On Mon, 13 Jan 2025 14:54:09 GMT, Matthias Baesken wrote: > When enabling the jsound ERROR and TRACE reporting (see > src/java.desktop/share/native/libjsound/Configure.h > https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libjsound/Configure.h#L32 > ), we run into some b

Re: RFR: 8339364: AIX build fails: various unused variable and function warnings [v3]

2024-09-03 Thread Martin Doerr
On Tue, 3 Sep 2024 07:26:53 GMT, Matthias Baesken wrote: >> We get a couple of warnings as errors on AIX because of unused variables or >> functions , for example : >> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c

Re: RFR: 8339364: AIX build fails: various unused variable and function warnings [v2]

2024-09-02 Thread Martin Doerr
On Mon, 2 Sep 2024 13:25:51 GMT, Matthias Baesken wrote: >> We get a couple of warnings as errors on AIX because of unused variables or >> functions , for example : >> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs

2024-01-30 Thread Martin Doerr
On Tue, 30 Jan 2024 14:02:41 GMT, Matthias Baesken wrote: >>> Yes there is a nice define in the AIX header >> >> *sigh* On linux, they go to some lengths to avoid this, using a __REDEFINE >> mechanism. Oh well. >> >> Anyway, I think this particular can be resolved by not including the >> sta

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2023-08-23 Thread Martin Doerr
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad > Th

Re: RFR: 8309703: AIX build fails after JDK-8280982

2023-06-12 Thread Martin Doerr
On Mon, 12 Jun 2023 14:13:15 GMT, Matthias Baesken wrote: > 8309703: AIX build fails after JDK-8280982 This is a must have for JDK 21. Fixes AIX build. Low risk because code is protected by ifdefs and change is small. - Marked as reviewed by mdoerr (Reviewer). PR Review: https://

Re: RFR: JDK-8309703: AIX build fails after JDK-8280982 [v2]

2023-06-09 Thread Martin Doerr
On Fri, 9 Jun 2023 10:42:59 GMT, Matthias Baesken wrote: >> After >> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982): [Wayland] >> [XWayland] java.awt.Robot taking screenshots >> the AIX build fails. >> We get >> >> * For target support_native_java.desktop_libawt_xawt_screencast_pipe

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-26 Thread Martin Doerr
On Fri, 26 May 2023 16:58:41 GMT, Thomas Stuefe wrote: >> The crazy thing is that `malloc` is defined! That means all places where we >> use the term malloc are getting replaced without such a workaround. (E.g. >> for log tags.) > > So, we do this only for malloc? Not for calloc, posix_memalign

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-26 Thread Martin Doerr
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Some of those are in shared codebase and could be addressed by small >> adjustments. >> A lot of those chang

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code

2023-05-25 Thread Martin Doerr
On Thu, 25 May 2023 15:04:32 GMT, Kim Barrett wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Some of those are in shared codebase and could be addressed by small >> adjustments. >> A lot of those ch

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

2023-05-15 Thread Martin Doerr
On Fri, 12 May 2023 21:51:59 GMT, Kim Barrett wrote: >> src/hotspot/cpu/ppc/c1_LIRGenerator_ppc.cpp line 426: >> >>> 424: // Missing test if instr is commutative and if we should swap. >>> 425: if (right.value()->type()->as_LongConstant() && >>> 426: (x->op() == Bytecodes::_lsub && >>

Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

2023-05-15 Thread Martin Doerr
On Fri, 12 May 2023 16:16:01 GMT, JoKern65 wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Many of those are in the aix or ppc specific codebase and could be addressed >> by small adjustments. >> A l

Re: RFR: JDK-8307604: gcc12 based Alpine build broken build after JDK-8307301

2023-05-08 Thread Martin Doerr
On Mon, 8 May 2023 10:29:56 GMT, Matthias Baesken wrote: > After the harfbuzz 7.2 update we run into > > /linuxmuslx86_64/jdk-dev/src/java.desktop/share/native/libharfbuzz/OT/glyf/Glyph.hh:281:8: > error: offset '4' outside bounds of constant string [-Werror=array-bounds] > 281 | bool get_poi

Re: RFR: JDK-8307603: [AIX] Broken build after JDK-8307301

2023-05-08 Thread Martin Doerr
On Mon, 8 May 2023 10:45:00 GMT, Matthias Baesken wrote: > The AIX build is broken after > [JDK-8307301](https://bugs.openjdk.org/browse/JDK-8307301) which updated > harfbuzz to 7.2 . > This was expected because an older AIX workaround was removed. > Bringing back the AIX workaround solves the

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v17]

2023-04-24 Thread Martin Doerr
On Fri, 21 Apr 2023 20:26:12 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v15]

2023-04-19 Thread Martin Doerr
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X

Re: RFR: JDK-8304291: [AIX] Broken build after JDK-8301998

2023-04-19 Thread Martin Doerr
On Wed, 19 Apr 2023 10:38:19 GMT, Matthias Baesken wrote: > After the latest harfbuzz update, the AIX build is broken. The old clang > compiler from xlc16 does not compile harfbuzz correctly. > First issue in hb-algs.hh is that xlc16 clang still sets some GNUC-related > macros, so we do not ru

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v13]

2023-04-12 Thread Martin Doerr
On Wed, 12 Apr 2023 17:31:49 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v12]

2023-04-12 Thread Martin Doerr
On Tue, 11 Apr 2023 21:09:43 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v11]

2023-04-11 Thread Martin Doerr
On Tue, 11 Apr 2023 18:35:56 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v10]

2023-04-11 Thread Martin Doerr
On Tue, 11 Apr 2023 17:58:54 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v10]

2023-04-11 Thread Martin Doerr
On Tue, 11 Apr 2023 17:58:54 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v9]

2023-04-11 Thread Martin Doerr
On Tue, 11 Apr 2023 10:26:02 GMT, ExE Boss wrote: >> test/jdk/jdk/internal/util/ArchTest.java line 128: >> >>> 126: case RISCV64 -> true; >>> 127: case S390 -> false; >>> 128: case PPC64 -> true; >> >> This is not always true. The PPC64 architecture supports

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v9]

2023-04-11 Thread Martin Doerr
On Sat, 8 Apr 2023 18:00:53 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X8

Re: RFR: JDK-8304334: java/awt/color/ICC_ColorSpace/ToFromCIEXYZRoundTrip.java times out on slow platforms

2023-03-20 Thread Martin Doerr
On Fri, 17 Mar 2023 09:08:56 GMT, Matthias Baesken wrote: > The ToFromCIEXYZRoundTrip test times out on slow platforms , especially when > (fast)debug binaries are used. > This was observed on Alpine Linux and AIX in our automated tests. Setting an > increased timeout for the test helps to red

Re: RFR: JDK-8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures [v2]

2022-09-09 Thread Martin Doerr
On Fri, 26 Aug 2022 07:54:24 GMT, Matthias Baesken wrote: >> https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-multibytetowidechar >> states about MultiByteToWideChar : "The function returns 0 if it does not >> succeed" and lists a few failure cases. >> However we m