[Windows] Why does AWT generate KEY_TYPED events in response to WM_SYSCHAR messages?

2024-06-10 Thread Nikita Provotorov
ns. Are there any cons of dropping this logic? I was trying to git blame the codebase to find some info in a particular commit, but the corresponding change was included in the repository initial commit. Searching in the mailing list and the bug tracker didn't help neither. Best regards, Nikita Provotorov

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v11]

2024-06-06 Thread Nikita Provotorov
On Wed, 5 Jun 2024 23:33:32 GMT, 柳鲲鹏 wrote: >> 柳鲲鹏 has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains 10 additional commits since the >> last

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v11]

2024-05-08 Thread Nikita Provotorov
On Sun, 5 May 2024 10:17:40 GMT, 柳鲲鹏 wrote: >> Candidat box can moving with caret on windows version. Someone must wrote >> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. >> Why it doesn't work, is the key problem. >> >> 1, I wrote a example for linux: >>

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v10]

2024-05-08 Thread Nikita Provotorov
On Wed, 1 May 2024 16:49:08 GMT, Phil Race wrote: >> I am back now. Who can check and merge this code? > > @quantum6 - See all the messages in the log above. > YOU need to issue the "/open" command before any one can re-review this. > > But whatever happened to @NikitkoCent ? He said he had an

Re: Is it valid to call JComponent#paintImmediately on a non-EDT thread (yet)?

2023-11-21 Thread Nikita Provotorov
s into account, so it must be fixed, mustn't it? Thanks in advance! Best regards, Nikita Provotorov On Fri, Nov 17, 2023 at 7:42 PM Philip Race wrote: > No, the code that calls setText() is where it starts. > > -phil. > > On 11/17/23 2:51 AM, Nikita Provotorov wrote: > > Than

Re: Is it valid to call JComponent#paintImmediately on a non-EDT thread (yet)?

2023-11-17 Thread Nikita Provotorov
258> is wrong because it doesn't make sure if *javax.swing.JComponent#paintImmediately* is called on EDT only (e.g. via *SwingUtilities#invokeLater*)? Best regards, Nikita Provotorov On Thu, Nov 16, 2023 at 9:30 PM Philip Race wrote: > Because (like in this case), an AWT component might

Is it valid to call JComponent#paintImmediately on a non-EDT thread (yet)?

2023-11-15 Thread Nikita Provotorov
sun.awt.X11.XTextAreaPeer.setText > at java.awt.TextComponent.setText Best regards, Nikita Provotorov

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v2]

2023-08-17 Thread Nikita Provotorov
On Thu, 17 Aug 2023 18:27:27 GMT, Phil Race wrote: >> Hi, guys! I want to notice that JetBrains is working on the issue too and >> we're going to propose our own fix. > > @NikitkoCent you wrote "Hi, guys! I want to notice that JetBrains is working > on the issue too and we're going to propose

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v2]

2023-08-17 Thread Nikita Provotorov
On Thu, 16 Mar 2023 08:33:35 GMT, 柳鲲鹏 wrote: >> Candidat box can moving with caret on windows version. Someone must wrote >> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. >> Why it doesn't work, is the key problem. >> >> 1, I wrote a example for linux: >>

Re: RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea [v2]

2023-06-28 Thread Nikita Provotorov
On Thu, 16 Mar 2023 08:33:35 GMT, 柳鲲鹏 wrote: >> Candidat box can moving with caret on windows version. Someone must wrote >> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. >> Why it doesn't work, is the key problem. >> >> 1, I wrote a example for linux: >>

Re: RFR: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks

2023-06-21 Thread Nikita Provotorov
On Mon, 17 Oct 2022 23:36:47 GMT, Sergey Bylokhov wrote: >> Hi there! >> JetBrains has faced with a bug on Apple M2 MacBooks when tapping (_not_ >> pressing) with two fingers on a trackpad generates wrong mouse modifiers >> (which are returned by >>

When don't MOUSE_DRAGGED events have pressed mouse buttons?

2023-06-20 Thread Nikita Provotorov
handled explicitly? AFAIU *MOUSE_DRAGGED* events always have some pressed mouse buttons, otherwise that’s not possible to drag, don’t they? Best regards, Nikita Provotorov

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v2]

2023-06-19 Thread Nikita Provotorov
On Mon, 19 Jun 2023 08:56:04 GMT, Abhishek Kumar wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java >> line 1121: >> >>> 1119: @Override >>> 1120: public int getAccessibleChildrenCount(JComponent c) { >>> 1121: return 2; >> >> I think the

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox

2023-06-16 Thread Nikita Provotorov
On Thu, 15 Jun 2023 15:58:18 GMT, Abhishek Kumar wrote: > The issue exist only for non-editable combobox and the root cause is > accessible object is not created due to incorrect index returned from > component class which results in no a11y API invoked. > > Proposed solution is to return the

Re: RFR: 8307145: windowsaccessbridge.dll is missing 4 critical methods in its C API

2023-05-03 Thread Nikita Provotorov
On Tue, 2 May 2023 16:52:04 GMT, Phil Race wrote: > These don't seem to be part of the public API, so this is probably deliberate > and not a bug. > https://docs.oracle.com/javase/accessbridge/2.0.2/api.htm#jab-api-specification @prrace should non-public API methods be removed from .DEF then?

Re: RFR: 8306072: Open source several AWT MouseInfo related tests [v3]

2023-04-24 Thread Nikita Provotorov
On Mon, 24 Apr 2023 14:11:00 GMT, lawrence.andrews wrote: >> Yeah, getting the values within EDT and used for `Robot` operations outside. >> Isn't it allowed ? > > It is allowed please use transient keyword for xPos & yPos @lawrence-andrew, BTW, why `transient`? Should it be `volatile`

How to find all keyboard-related manual tests?

2023-01-30 Thread Nikita Provotorov
ll sources by the "/manual" substring. The next thing I've tried is to find all usages of the class *java.awt.event.KeyEvent* among all found "/manual" entries. But I believe it won't give me a complete list of such tests. Could anyone advise anything? Best regards, Nikita Provotorov

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard [v2]

2023-01-24 Thread Nikita Provotorov
On Tue, 24 Jan 2023 20:14:20 GMT, Alisen Chung wrote: >> Removed check for MapVirtualKeyEx return value causing some keys to become >> undefined > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > readded check for dead key

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

2023-01-18 Thread Nikita Provotorov
On Tue, 17 Jan 2023 22:13:18 GMT, Alisen Chung wrote: >> Removed check for MapVirtualKeyEx return value causing some keys to become >> undefined > > My (US QWERTY) keyboard doesn't have a key between the Z and L shift keys, so > I used the on screen keyboard in German. I typed the OEM 102 key

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

2023-01-13 Thread Nikita Provotorov
On Fri, 6 Jan 2023 22:07:33 GMT, Alisen Chung wrote: > Removed check for MapVirtualKeyEx return value causing some keys to become > undefined Hello, guys! I've just checked behavior of the fix and it actually breaks the case described in the

Integrated: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks

2022-10-14 Thread Nikita Provotorov
On Mon, 26 Sep 2022 17:36:04 GMT, Nikita Provotorov wrote: > Hi there! > JetBrains has faced with a bug on Apple M2 MacBooks when tapping (_not_ > pressing) with two fingers on a trackpad generates wrong mouse modifiers > (which are returned by > [MouseEvent.getMod

Re: RFR: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks

2022-10-14 Thread Nikita Provotorov
On Mon, 3 Oct 2022 20:38:43 GMT, Phil Race wrote: >> I don't have an M2 device to check, but I think (judging to the code) if we >> add `jmodifiers == 0` check here then users making a tap holding the Control >> will receive the mouse events with `modifiers` == `CTRL_DOWN_MASK | >>

Re: RFR: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks

2022-09-30 Thread Nikita Provotorov
On Fri, 30 Sep 2022 21:38:50 GMT, Nikita Provotorov wrote: >> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java >> line 83: >> >>> 81: int jmodifiers = NSEvent.nsToJavaModifiers(modifierFlags); >>> 82: if ((je

RFR: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks

2022-09-27 Thread Nikita Provotorov
Hi there! JetBrains has faced with a bug on Apple M2 MacBooks when tapping (_not_ pressing) with two fingers on a trackpad generates wrong mouse modifiers (which are returned by