On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or imp
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial and
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
This pull request has now been integrated.
Changeset: a4e97aa4
Author: Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/a4e97aa4ebe6fcfc3ed9e45ed81df1d55e52d621
Stats: 4 lines in 1 f
On Tue, 22 Aug 2023 14:55:18 GMT, Pavel Rappo wrote:
>> Please review this trivial PR.
>
> Pavel Rappo has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'master' i
> Please review this trivial PR.
Pavel Rappo has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- Merge branch 'master' into 8314753
- Initial commit
-
Changes: https://git.openjdk.org/jdk/pul
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
CC'ing client-libs-dev because @beaninfo and @Note and jmx-dev because of
@since.unbundled, which might've been used for JMX before 2007.
-
PR Comment: https://git.openjdk.org/j
On Wed, 7 Jun 2023 14:19:16 GMT, Pavel Rappo wrote:
> Please review this long-awaited change to documentation inheritance.
>
> This change improves "methods comment algorithm" and introduces directed
> documentation inheritance. While "methods comment algorithm&
t; {@inheritDoc S}
>
> Which is exactly what I did to counterbalance some of the JDK API
> Documentation changes caused by the change to "methods comment algorithm".
Pavel Rappo has updated the pull request with a new target base due to a merge
or a rebase. The incremental webre
On Wed, 14 Jun 2023 01:15:51 GMT, Martin Buchholz wrote:
> * we never want to inherit AbstractFoo @implNotes
`@implNote`, `@apiNote` and `@implSpec` can only be inherited via explicit
`{@inheritDoc}`:
@implSpec {@inheritDoc}
> * ConcurrentMap does _not_ have the same spec as ConcurrentHas
On Wed, 14 Jun 2023 01:19:57 GMT, Martin Buchholz wrote:
> We don't currently have a way to diff rendered javadoc, like my ancient
> BlenderRev hack?
I've generated something you might find helpful:
https://cr.openjdk.org/~prappo/8285368/specdiff/overview-summary.html
-
PR Commen
On Thu, 8 Jun 2023 14:47:13 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment
t; {@inheritDoc S}
>
> Which is exactly what I did to counterbalance some of the JDK API
> Documentation changes caused by the change to "methods comment algorithm".
Pavel Rappo has updated the pull request with a new target base due to a merge
or a rebase. The incremental webre
On Thu, 8 Jun 2023 15:47:26 GMT, Pavel Rappo wrote:
>> I admit I can't parse this sentence:
>>
>>> then the answer is that it's not necessary for keeping the API
>>> documentation unchanged.
>>
>> Do you mean that you didn't add `@
On Thu, 8 Jun 2023 15:16:09 GMT, Alexey Ivanov wrote:
>> The directed `{@inheritDoc }` works for the main description,
>> `@throws`, `@param` and `@return` tags. If your question is about why that
>> particular doc comment does not use this:
>>
>> @param e {@inheritDoc BlockingDeque}
>>
>
t; {@inheritDoc S}
>
> Which is exactly what I did to counterbalance some of the JDK API
> Documentation changes caused by the change to "methods comment algorithm".
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
feedback
On Wed, 7 Jun 2023 20:33:00 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback: make warning less scary
>
> test/langtools/jdk/javadoc/doc
On Thu, 8 Jun 2023 09:55:27 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment
On Thu, 8 Jun 2023 09:55:27 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment
On Thu, 8 Jun 2023 10:33:17 GMT, Alan Bateman wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback: remove unduly restrictive warning
>
> src/java.base/share/classes/java/util/Tree
On Wed, 7 Jun 2023 21:39:33 GMT, Jonathan Gibbons wrote:
>> The general criticism here is whether we should restrict in any way the set
>> of super types from which one can inherit documentation, and/or what should
>> the set of checks be?
>>
>> For example, if a method in C inherits a method
t; {@inheritDoc S}
>
> Which is exactly what I did to counterbalance some of the JDK API
> Documentation changes caused by the change to "methods comment algorithm".
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
feedback:
On Thu, 8 Jun 2023 09:18:04 GMT, Pavel Rappo wrote:
>> test/langtools/jdk/javadoc/doclet/testDirectedInheritance/TestDirectedInheritance.java
>> line 289:
>>
>>> 287:
>>> 288: /*
>>> 289: * C1.m inherits documentation from B1.m explicit
t; {@inheritDoc S}
>
> Which is exactly what I did to counterbalance some of the JDK API
> Documentation changes caused by the change to "methods comment algorithm".
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
sugges
On Wed, 7 Jun 2023 20:23:09 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback: make warning less scary
>
> test/langtools/jdk/javadoc/
t; {@inheritDoc S}
>
> Which is exactly what I did to counterbalance some of the JDK API
> Documentation changes caused by the change to "methods comment algorithm".
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision
On Wed, 7 Jun 2023 18:55:10 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback: make warning less scary
>
> src/jdk.javadoc/share/classes/jdk/javadoc/in
t; {@inheritDoc S}
>
> Which is exactly what I did to counterbalance some of the JDK API
> Documentation changes caused by the change to "methods comment algorithm".
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revisio
t; {@inheritDoc S}
>
> Which is exactly what I did to counterbalance some of the JDK API
> Documentation changes caused by the change to "methods comment algorithm".
Pavel Rappo has updated the pull request with a new target base due to a merge
or a rebase. The incremental webre
On Wed, 7 Jun 2023 19:16:51 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback: make warning less scary
>
> src/jdk.javadoc/share/classes/jdk/javadoc
On Wed, 7 Jun 2023 19:13:55 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback: make warning less scary
>
> src/jdk.javadoc/share/classes/jdk/javadoc
On Wed, 7 Jun 2023 20:29:07 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback: make warning less scary
>
> test/langtools/jdk/javadoc/
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment
t; {@inheritDoc S}
>
> Which is exactly what I did to counterbalance some of the JDK API
> Documentation changes caused by the change to "methods comment algorithm".
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 7 Jun 2023 14:19:16 GMT, Pavel Rappo wrote:
> Please review this long-awaited change to documentation inheritance.
>
> This change improves "methods comment algorithm" and introduces directed
> documentation inheritance. While "methods comment algorithm&
On Wed, 7 Jun 2023 15:27:28 GMT, Jonathan Gibbons wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search
Please review this long-awaited change to documentation inheritance.
This change improves "methods comment algorithm" and introduces directed
documentation inheritance. While "methods comment algorithm" -- automatic
search for inheritable documentation -- has been improved, it still cannot read
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observabl
seem to occur in infrequently updated third-party code (e.g.
> javax.xml), which I assume we shouldn't touch unless necessary.
> * I will update copyright years after (and if) the fix had been approved, as
> required.
Pavel Rappo has updated the pull request with a new target bas
On Fri, 3 Mar 2023 08:15:49 GMT, Alexey Ivanov wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect on
On Thu, 2 Mar 2023 16:23:17 GMT, Alexey Ivanov wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect on
Please review this superficial documentation cleanup that was triggered by
unrelated analysis of doc comments in JDK API.
The only effect that this multi-area PR has on the JDK API Documentation (i.e.
the observable effect on the generated HTML pages) can be summarized as follows:
diff -ur
On Wed, 25 Jan 2023 18:00:33 GMT, Weijun Wang wrote:
>> The translation tool didn't seem to translate this. Either because it
>> couldn't or because it somehow missed it. I'm not sure which, but I'm open
>> to replacing this with a translation suggestion you have. Or I can leave it
>> as is.
>
On Tue, 27 Sep 2022 11:43:08 GMT, Pavel Rappo wrote:
> This adds exception documentation to JDK methods that would otherwise lose
> that documentation once JDK-8287796 is integrated. While adding this
> exception documentation now does not change [^1] the JDK API Documentation,
On Fri, 30 Sep 2022 19:15:17 GMT, Phil Race wrote:
> If the docs end up the same as you say that is fine by me since for the two
> ImageIO classes that seems to be what we'd want.
Since this change does not affect HTML pages for java.desktop, I take it as
"approved".
> But inheritDoc behaviou
On Wed, 28 Sep 2022 13:36:18 GMT, Daniel Fuchs wrote:
> If you can assert that the generated docs are the same before and after the
> proposed change then that's enough for me.
Would it suffice if I show the result of the diff between JDK API Documentation
built at the tip of this PR branch (d
On Wed, 28 Sep 2022 13:34:08 GMT, Daniel Fuchs wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert an extraneous change to jdk.javadoc
>
> src/java.naming/share/
ndex pages. There's
> one relatively significant change. This change is in jdk.jshell, where some
> methods disappeared from "Methods declared in ..." section and other
> irregularities. We are aware of this and have filed JDK-8291803 to fix the
> root cause.
> [^2]: In
This adds exception documentation to JDK methods that would otherwise lose that
documentation once JDK-8287796 is integrated. While adding this exception
documentation now does not change [^1] the JDK API Documentation, it will
automatically counterbalance the effect that JDK-8287796 will have.
53 matches
Mail list logo
