Re: RFR: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html [v2]

2024-11-07 Thread Prasanta Sadhukhan
On Wed, 6 Nov 2024 19:32:20 GMT, Harshitha Onkar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restrict to linux > > test/jdk/java/awt/PrintJob/PrintCheckboxTest/PrintChec

Re: RFR: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html [v3]

2024-11-07 Thread Prasanta Sadhukhan
> Test was pointing to missing html file, probably due to old Applet usage. > Test is updated to use PFJ.. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: tag correction - Changes: - all:

Re: RFR: 8343601: javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java fails in ubuntu 22.04

2024-11-07 Thread Prasanta Sadhukhan
On Tue, 5 Nov 2024 20:20:06 GMT, Phil Race wrote: > "linux left dock placement can be a problem with this top-left rendering." > > are you saying that the dock is the actual problem here ? Why has it never > been a problem on other 22.04 systems ? I could make it fail once in windows when I sa

Re: RFR: 8343601: javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java fails in ubuntu 22.04 [v2]

2024-11-07 Thread Prasanta Sadhukhan
on radiobutton, checkbox etc and linux left dock > placement can be a problem with this top-left rendering. > > Fix is made to render the frame at the center. > Repeated iteration of the test run in 22.04 OCI instance is ok. Prasanta Sadhukhan has updated the pull request incrementally

RFR: 8343601: javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java fails in ubuntu 22.04

2024-11-05 Thread Prasanta Sadhukhan
It is seen that javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java fails in ubuntu 22.04 OCI instance. It is seen that test frame is being rendered at top-left of screen instead of at the center, and robot mouseMove is being used to point and click on radiobutton, checkbox etc and

Integrated: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access

2024-11-04 Thread Prasanta Sadhukhan
On Wed, 30 Oct 2024 02:50:08 GMT, Prasanta Sadhukhan wrote: > Couple of printing tests dont have "public" modifier so CI testing fails to > run this test citing IllegalAccessException. > Fix is made to made the test class public. > > Additionally, modified PrintDlgPag

Re: RFR: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access [v4]

2024-11-04 Thread Prasanta Sadhukhan
On Mon, 4 Nov 2024 09:26:44 GMT, Abhishek Kumar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor formatting > > test/jdk/java/awt/print/Dialog/PrintDlgPag

Re: RFR: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access [v5]

2024-11-04 Thread Prasanta Sadhukhan
> Couple of printing tests dont have "public" modifier so CI testing fails to > run this test citing IllegalAccessException. > Fix is made to made the test class public. > > Additionally, modified PrintDlgPageable.java to use PFJ and made > StreamPrintingOrientati

Re: RFR: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access [v3]

2024-11-04 Thread Prasanta Sadhukhan
On Mon, 4 Nov 2024 07:30:43 GMT, Abhishek Kumar wrote: > Minor formatting changes. fixed.. - PR Comment: https://git.openjdk.org/jdk/pull/21780#issuecomment-2454102970

Re: RFR: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access [v4]

2024-11-04 Thread Prasanta Sadhukhan
> Couple of printing tests dont have "public" modifier so CI testing fails to > run this test citing IllegalAccessException. > Fix is made to made the test class public. > > Additionally, modified PrintDlgPageable.java to use PFJ and made > StreamPrintingOrientati

Re: RFR: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html [v2]

2024-11-03 Thread Prasanta Sadhukhan
> Test was pointing to missing html file, probably due to old Applet usage. > Test is updated to use PFJ.. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Restrict to linux - Changes: - all:

Re: RFR: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html [v2]

2024-11-03 Thread Prasanta Sadhukhan
On Thu, 31 Oct 2024 18:47:55 GMT, Harshitha Onkar wrote: >> test/jdk/java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java >> line 81: >> >>> 79: String[] instructions = >>> 80: { >>> 81: "Linux or Solaris with XToolkit ONLY!", >> >>> "Linux or Solaris wi

Re: RFR: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access [v3]

2024-10-30 Thread Prasanta Sadhukhan
> Couple of printing tests dont have "public" modifier so CI testing fails to > run this test citing IllegalAccessException. > Fix is made to made the test class public. > > Additionally, modified PrintDlgPageable.java to use PFJ and made > StreamPrintingOrientati

RFR: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html

2024-10-30 Thread Prasanta Sadhukhan
Test was pointing to missing html file, probably due to old Applet usage. Test is updated to use PFJ.. - Commit messages: - 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html Chang

Re: RFR: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access [v2]

2024-10-30 Thread Prasanta Sadhukhan
> Couple of printing tests dont have "public" modifier so CI testing fails to > run this test citing IllegalAccessException. > Fix is made to made the test class public. > > Additionally, modified PrintDlgPageable.java to use PFJ and made > StreamPrintingOrientati

Re: RFR: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access [v2]

2024-10-30 Thread Prasanta Sadhukhan
On Wed, 30 Oct 2024 11:03:18 GMT, Tejesh R wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove some redundant code > > test/jdk/java/awt/print/Dialog/PrintDlgP

RFR: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper cannot access

2024-10-29 Thread Prasanta Sadhukhan
Couple of printing tests dont have "public" modifier so CI testing fails to run this test citing IllegalAccessException. Fix is made to made the test class public. Additionally, modified PrintDlgPageable.java to use PFJ and made StreamPrintingOrientation.java automated. - Commit me

Integrated: 8343037: Missing @since tag on JColorChooser.showDialog overload

2024-10-29 Thread Prasanta Sadhukhan
On Tue, 29 Oct 2024 08:34:05 GMT, Prasanta Sadhukhan wrote: > [JDK-8051548](https://bugs.openjdk.org/browse/JDK-8051548) in Java 9 added a > new overload of `JColorChooser.showDialog` but `@since` tag is missing..The > fix also added couple of new methods to AbstractColorChooserP

RFR: 8343037: Missing @since tag on JColorChooser.showDialog overload

2024-10-29 Thread Prasanta Sadhukhan
[JDK-8051548](https://bugs.openjdk.org/browse/JDK-8051548) in Java 9 added a new overload of `JColorChooser.showDialog` but `@since` tag is missing..The fix also added couple of new methods to AbstractColorChooserPanel.java where also `@since` tag is added - Commit messages: - 834

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]

2024-10-25 Thread Prasanta Sadhukhan
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]

2024-10-24 Thread Prasanta Sadhukhan
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-24 Thread Prasanta Sadhukhan
On Thu, 24 Oct 2024 17:27:33 GMT, Alexey Ivanov wrote: > > I think we have finally decided that jtreg tag will come after copyright > > and before imports...Applicable for all modified javax_swing tests in this > > PR... > > Did we agree on that? Atleast client-dev team did.. See this initial

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Tue, 22 Oct 2024 16:46:53 GMT, Phil Race wrote: >> Not specific to JEP 486, this should be done as part of a different issue. > > agreed there were many tests modified in javax_swing in this PR where the author tag is removed, only this is missed so I pointed it out... - PR Rev

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Tue, 22 Oct 2024 16:44:59 GMT, Phil Race wrote: >> This should be addressed in a more general separate task, and not part of >> this PR since it does not have anything to do with the changes in this JEP. > > Agreed. This is not a "clean up / update tests" task. > If it is a change on some lin

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v3]

2024-10-08 Thread Prasanta Sadhukhan
On Tue, 8 Oct 2024 11:04:51 GMT, Tejesh R wrote: >> Open source these AWT Mouse tests: >> >> java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java >> java/awt/Dialog/FileDialogWrongNameCrash.java >> java/awt/Dialog/DialogResizeTest.java >> java/awt/Dialog/GetLocationTest_1.java >> java/awt/

Re: RFR: 8340173: Open source some Component/Panel/EventQueue tests - Set2

2024-10-07 Thread Prasanta Sadhukhan
On Tue, 8 Oct 2024 00:15:23 GMT, Damon Nguyen wrote: > Following tests are added as part of this PR: > > 1. > /java/awt/LightweightComponent/MultipleAddNotifyTest/MultipleAddNotifyTest.java > - CONVERTED TO AUTO > 2. /java/awt/LightweightComponent/PopupTest/PopupTest.java - MANUAL > 3. /java/a

Re: RFR: 8341257: Open source few DND tests - Set1 [v2]

2024-10-07 Thread Prasanta Sadhukhan
On Mon, 7 Oct 2024 17:59:11 GMT, Damon Nguyen wrote: >> Following tests are added as part of this PR: >> >> 1. /java/awt/dnd/NonAsciiFilenames/NonAsciiFilenames.java - MANUAL >> 2. >> /java/awt/dnd/DnDRemoveFocusOwnerCrashTest/DnDRemoveFocusOwnerCrashTest.java >> - AUTO >> 3. /java/awt/dnd/DnD

Re: RFR: 8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException [v4]

2024-10-07 Thread Prasanta Sadhukhan
On Sun, 4 Aug 2024 21:44:33 GMT, Phil Race wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use EventQueue.invokeLater > > I think we still have some things to look at here >

Re: RFR: 8341000: Open source some of the AWT Window tests [v5]

2024-10-03 Thread Prasanta Sadhukhan
On Fri, 4 Oct 2024 05:30:16 GMT, Jayathirth D V wrote: >> Clean up and open source some of the AWT window tests. >> Automated test `InvalidFocusLostEventTest.java` is verified in our CI also >> and it passes on all platforms. > > Jayathirth D V has updated the pull request incrementally with one

Re: RFR: 8341258: Open source few various AWT tests - Set1

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 21:49:46 GMT, Damon Nguyen wrote: > Following tests are added as part of this PR: > > ./java/awt/GradientPaint/JerkyGradient.java - MANUAL > ./java/awt/GradientPaint/ShearTest.java - MANUAL > ./java/awt/CardLayout/RemoveComponentTest/RemoveComponentTest.java - MANUAL Marked a

Re: RFR: 8340967: Open source few Cursor tests - Set2

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 21:37:37 GMT, Damon Nguyen wrote: > Following tests are added as part of this PR: > > ./java/awt/Cursor/CustomCursorTest/CustomCursorTest.java - MANUAL > ./java/awt/Cursor/BlockedWindowTest/BlockedWindowTest.java - MANUAL > ./java/awt/Cursor/SetCursorTest/SetCursorTest.java -

Re: RFR: 8340966: Open source few Checkbox and Cursor tests - Set1

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 21:20:04 GMT, Damon Nguyen wrote: > Following tests are added as part of this PR: > > ./java/awt/CheckboxGroup/DynamicChangeTest/DynamicChangeTest.java - MANUAL > ./java/awt/Cursor/NullCursorTest/NullCursorTest.java - MANUAL > ./java/awt/Cursor/HiddenDialogParentTest/HiddenDia

Re: RFR: 8340417: Open source some MenuBar tests - Set1

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 21:07:55 GMT, Damon Nguyen wrote: > Following tests are added as part of this PR: > > ./java/awt/MenuBar/MenuBarRemoveMenu/MenuBarRemoveMenuTest.java - MANUAL > ./java/awt/MenuBar/MenuNPE/MenuNPE.java - AUTO > ./java/awt/MenuBar/MenuBarSetFont/CellsResize.java - MANUAL > ./jav

Re: RFR: 8341111: open source several AWT tests including menu shortcut tests [v2]

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 19:21:29 GMT, Phil Race wrote: >> Open source several AWT tests, mostly related to menu short cuts. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 834 Marked as reviewed by psadhukhan (Reviewer).

Re: RFR: 8340164: Open source few Component tests - Set1 [v3]

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 21:30:24 GMT, Damon Nguyen wrote: >> Following tests are added as part of this PR: >> >> /java/awt/LightweightComponent/LightweightFontTest/LightweightFontTest.java >> (Manual with PassFailJFrame) >> /java/awt/LightweightComponent/LightWeightTabFocus/LightWeightTabFocus.java

Re: RFR: 8340164: Open source few Component tests - Set1 [v3]

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 21:30:24 GMT, Damon Nguyen wrote: >> Following tests are added as part of this PR: >> >> /java/awt/LightweightComponent/LightweightFontTest/LightweightFontTest.java >> (Manual with PassFailJFrame) >> /java/awt/LightweightComponent/LightWeightTabFocus/LightWeightTabFocus.java

Re: RFR: 8341000: Open source some of the AWT Window tests [v4]

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 12:48:30 GMT, Jayathirth D V wrote: >> test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java >> line 98: >> >>> 96: // we should check focus after all events are processed, >>> 97: // since focus transfers are asynchronous >>> 98:

Re: RFR: 8340625: Open source additional Component tests (part 3)

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 09:18:18 GMT, Alexander Zuev wrote: > Clean up and open source three more Component related regression tests. Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/21322#pullrequestreview-2345399859

Re: RFR: 8341000: Open source some of the AWT Window tests [v4]

2024-10-03 Thread Prasanta Sadhukhan
On Thu, 3 Oct 2024 08:15:58 GMT, Jayathirth D V wrote: >> Clean up and open source some of the AWT window tests. >> Automated test `InvalidFocusLostEventTest.java` is verified in our CI also >> and it passes on all platforms. > > Jayathirth D V has updated the pull request incrementally with one

Re: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v6]

2024-10-03 Thread Prasanta Sadhukhan
On Wed, 2 Oct 2024 18:32:16 GMT, Harshitha Onkar wrote: >> Following tests are updated in this PR: >> >> 1. test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java >> 2. test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java >> 3. test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java >> 4.

Re: RFR: 8341111: open source several AWT tests including menu shortcut tests

2024-10-02 Thread Prasanta Sadhukhan
On Tue, 1 Oct 2024 16:31:39 GMT, Phil Race wrote: > Open source several AWT tests, mostly related to menu short cuts. test/jdk/java/awt/MenuShortcut/ActionCommandTest.java line 53: > 51: static volatile Menu m; > 52: static volatile MenuBar mb; > 53: static volatile MenuItem mi; Al

Integrated: 8341177: Opensource few List and a Window test

2024-10-02 Thread Prasanta Sadhukhan
On Tue, 1 Oct 2024 09:32:58 GMT, Prasanta Sadhukhan wrote: > Opensource few AWT List and a Window test This pull request has now been integrated. Changeset: 602408e4 Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/602408e4f3848b30299ea94264e88ead5361a310 St

Re: RFR: 8341128: open source some 2d graphics tests

2024-10-02 Thread Prasanta Sadhukhan
On Tue, 1 Oct 2024 16:45:15 GMT, Phil Race wrote: > open source a few 2d graphics related tests for line drawing, text > performance, image rendering. Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/21292#pullrequestreview-2344532723

RFR: 8341177: Opensource few List and a Window test

2024-10-01 Thread Prasanta Sadhukhan
Opensource few AWT List and a Window test - Commit messages: - 8341177: Opensource few List and a Window test Changes: https://git.openjdk.org/jdk/pull/21282/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21282&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341177

Re: RFR: 8341000: Open source some of the AWT Window tests

2024-10-01 Thread Prasanta Sadhukhan
On Tue, 1 Oct 2024 09:12:15 GMT, Jayathirth D V wrote: > Clean up and open source some of the AWT window tests. > Automated test `InvalidFocusLostEventTest.java` is verified in our CI also > and it passes on all platforms. test/jdk/java/awt/Window/BadConfigure/BadConfigure.java line 68: > 66:

Re: RFR: 8341191: Open source few more AWT FileDialog tests

2024-10-01 Thread Prasanta Sadhukhan
On Tue, 1 Oct 2024 05:06:10 GMT, Abhishek Kumar wrote: > AWT File Dialog related tests are converted from applet to manual and moved > to open. Marked as reviewed by psadhukhan (Reviewer). test/jdk/java/awt/FileDialog/SavedDirInitTest.java line 31: > 29: import java.awt.event.ActionListener;

Re: RFR: 8340432: Open source some MenuBar tests - Set2 [v2]

2024-10-01 Thread Prasanta Sadhukhan
On Mon, 30 Sep 2024 16:53:00 GMT, Damon Nguyen wrote: >> Following tests are added as part of this PR: >> >> /java/awt/MenuBar/MenuBarOnDisabledFrame/MenuBarOnDisabledFrame.java (Manual >> with PassFailJFrame) >> /java/awt/MenuBar/MenuBarAddRemoveTest/MenuBarAddRemoveTest.java (Manual >> with

Re: RFR: 8340458: Open source additional Component tests (part 2) [v2]

2024-09-30 Thread Prasanta Sadhukhan
On Mon, 30 Sep 2024 22:32:19 GMT, Alexander Zuev wrote: >> Clean up and open source four more tests. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Moved variables initialization into the method that is called on EDT; >

Integrated: 8340719: Open source AWT List tests

2024-09-30 Thread Prasanta Sadhukhan
On Mon, 30 Sep 2024 03:07:17 GMT, Prasanta Sadhukhan wrote: > Opensource few AWT List tests... This pull request has now been integrated. Changeset: b11066b5 Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/b11066b56b69b2c526539e712cef47723098597f Stats:

Re: RFR: 8340719: Open source AWT List tests [v2]

2024-09-30 Thread Prasanta Sadhukhan
> Opensource few AWT List tests... Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Formatting - Changes: - all: https://git.openjdk.org/jdk/pull/21253/files - new: https://git.openjdk.org/jdk/pull/21253/fi

Re: RFR: 8340719: Open source AWT List tests [v2]

2024-09-30 Thread Prasanta Sadhukhan
On Mon, 30 Sep 2024 11:52:22 GMT, Abhishek Kumar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Formatting > > test/jdk/java/awt/List/HandlingKeyEventIfMousePressedTest.

Re: RFR: 8340164: Open source few Component tests - Set1

2024-09-29 Thread Prasanta Sadhukhan
On Mon, 30 Sep 2024 00:08:25 GMT, Damon Nguyen wrote: > Following tests are added as part of this PR: > > /java/awt/LightweightComponent/LightweightFontTest/LightweightFontTest.java > (Manual with PassFailJFrame) > /java/awt/LightweightComponent/LightWeightTabFocus/LightWeightTabFocus.java > (

Re: RFR: 8340432: Open source some MenuBar tests - Set2

2024-09-29 Thread Prasanta Sadhukhan
On Sun, 29 Sep 2024 23:54:13 GMT, Damon Nguyen wrote: > Following tests are added as part of this PR: > > /java/awt/MenuBar/MenuBarOnDisabledFrame/MenuBarOnDisabledFrame.java (Manual > with PassFailJFrame) > /java/awt/MenuBar/MenuBarAddRemoveTest/MenuBarAddRemoveTest.java (Manual with > PassFa

Re: RFR: 8340458: Open source additional Component tests (part 2)

2024-09-29 Thread Prasanta Sadhukhan
On Fri, 27 Sep 2024 20:33:07 GMT, Alexander Zuev wrote: > Clean up and open source four more tests. test/jdk/java/awt/Component/BackgroundColorTest/InitialBackgroundSettingTest.java line 52: > 50: Scrollbar bar = new Scrollbar(Scrollbar.HORIZONTAL); > 51: Button button = new Button("I

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]

2024-09-29 Thread Prasanta Sadhukhan
On Fri, 27 Sep 2024 10:09:22 GMT, Tejesh R wrote: >> Open source these AWT Mouse tests: >> >> java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java >> java/awt/Dialog/FileDialogWrongNameCrash.java >> java/awt/Dialog/DialogResizeTest.java >> java/awt/Dialog/GetLocationTest_1.java >> java/awt

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]

2024-09-29 Thread Prasanta Sadhukhan
On Fri, 27 Sep 2024 11:55:21 GMT, Prasanta Sadhukhan wrote: >> I'm getting this error if I use ` PassFailJFrame.log` to `componentResize` >> method. >> `java.lang.NullPointerException: Cannot invoke >> "javax.swing.JTextArea.append(String)" becau

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v5]

2024-09-29 Thread Prasanta Sadhukhan
On Thu, 26 Sep 2024 06:56:23 GMT, Tejesh R wrote: >> Open source these AWT Mouse and GraphicsEnvironment tests: >> >> java/awt/MouseClickCount/MouseClickCount.java >> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java >> java/awt/MouseDragTest/MouseDragTest.java >> java/awt/OpenWinDoubl

RFR: 8340719: Open source AWT List tests

2024-09-29 Thread Prasanta Sadhukhan
Opensource few AWT List tests... - Commit messages: - Merge master - 8340719: Open source AWT List tests Changes: https://git.openjdk.org/jdk/pull/21253/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21253&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340719 St

Integrated: 8340639: Open source few more AWT List tests

2024-09-29 Thread Prasanta Sadhukhan
On Thu, 26 Sep 2024 11:41:31 GMT, Prasanta Sadhukhan wrote: > Opensource few more AWT List tests This pull request has now been integrated. Changeset: dd569909 Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/dd56990962d58e4f482773f67bc43383d7748536 Stats:

Integrated: 8340621: Open source several AWT List tests

2024-09-29 Thread Prasanta Sadhukhan
On Thu, 26 Sep 2024 09:43:25 GMT, Prasanta Sadhukhan wrote: > Opensource few AWT List tests This pull request has now been integrated. Changeset: ae4d2f15 Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/ae4d2f15901bf02efceaac26ee4aa3ae666bf467 Stats:

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]

2024-09-27 Thread Prasanta Sadhukhan
On Fri, 27 Sep 2024 10:05:34 GMT, Tejesh R wrote: >> test/jdk/java/awt/Dialog/DialogResizeTest.java line 133: >> >>> 131: public void componentHidden(ComponentEvent e) { >>> 132: System.out.println("componentHidden event occurred."); >>> 133: } >> >> I guess PassFailJFrame.log w

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1

2024-09-27 Thread Prasanta Sadhukhan
On Wed, 25 Sep 2024 07:20:21 GMT, Tejesh R wrote: > Open source these AWT Mouse tests: > > java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java > java/awt/Dialog/FileDialogWrongNameCrash.java > java/awt/Dialog/DialogResizeTest.java > java/awt/Dialog/GetLocationTest_1.java > java/awt/Dialog

Re: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]

2024-09-26 Thread Prasanta Sadhukhan
On Thu, 26 Sep 2024 18:24:23 GMT, Harshitha Onkar wrote: >> test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java line 65: >> >>> 63: Verify that all indicators of checkboxes has the same size. >>> 64: Verify that all indicators of radio buttons has the same >>> size

Re: RFR: 8340621: Open source several AWT List tests [v2]

2024-09-26 Thread Prasanta Sadhukhan
> Opensource few AWT List tests Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: spacing - Changes: - all: https://git.openjdk.org/jdk/pull/21202/files - new: https://git.openjdk.org/jdk/pull/21202/fi

RFR: 8340639: Open source few more AWT List tests

2024-09-26 Thread Prasanta Sadhukhan
Opensource few more AWT List tests - Commit messages: - 8340639: Open source few more AWT List tests - 8340639: Open source few more AWT List tests Changes: https://git.openjdk.org/jdk/pull/21205/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21205&range=00 Issue: https

RFR: 8340621: Open source several AWT List tests

2024-09-26 Thread Prasanta Sadhukhan
Opensource few AWT List tests - Commit messages: - 8340621: Open source several AWT List tests Changes: https://git.openjdk.org/jdk/pull/21202/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21202&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340621 Stats: 500 li

Re: RFR: JDK-8340077 : Open source few Checkbox tests - Set2 [v3]

2024-09-25 Thread Prasanta Sadhukhan
On Wed, 25 Sep 2024 05:11:49 GMT, Harshitha Onkar wrote: >> Following tests are updated in this PR: >> >> 1. test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java >> 2. test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java >> 3. test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java >> 4.

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v4]

2024-09-24 Thread Prasanta Sadhukhan
On Tue, 24 Sep 2024 06:29:21 GMT, Tejesh R wrote: >> Open source these AWT Mouse and GraphicsEnvironment tests: >> >> java/awt/MouseClickCount/MouseClickCount.java >> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java >> java/awt/MouseDragTest/MouseDragTest.java >> java/awt/OpenWinDoubl

Integrated: 8339935: Open source several AWT focus tests - series 5

2024-09-24 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 03:23:26 GMT, Prasanta Sadhukhan wrote: > Opensource few AWT focus tests This pull request has now been integrated. Changeset: b1f8d2ea Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/b1f8d2ea76322a89eea84851a1e791f52c31261b Stats:

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v3]

2024-09-23 Thread Prasanta Sadhukhan
On Tue, 24 Sep 2024 04:38:05 GMT, Tejesh R wrote: >> Open source these AWT Mouse and GraphicsEnvironment tests: >> >> java/awt/MouseClickCount/MouseClickCount.java >> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java >> java/awt/MouseDragTest/MouseDragTest.java >> java/awt/OpenWinDoubl

Re: RFR: 8339935: Open source several AWT focus tests - series 5 [v2]

2024-09-23 Thread Prasanta Sadhukhan
> Opensource few AWT focus tests Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Review fix - Changes: - all: https://git.openjdk.org/jdk/pull/21103/files - new: https://git.openjdk.org/jdk/pull/21103/fi

Re: RFR: 8340143: Open source several Java2D rendering loop tests.

2024-09-23 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 23:27:11 GMT, Phil Race wrote: > Open source some Java2d loop rendering tests. Marked as reviewed by psadhukhan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/21114#pullrequestreview-2323886695

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2

2024-09-23 Thread Prasanta Sadhukhan
On Mon, 23 Sep 2024 06:40:55 GMT, Tejesh R wrote: > Open source these AWT Mouse and GraphicsEnvironment tests: > > java/awt/MouseClickCount/MouseClickCount.java > java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java > java/awt/MouseDragTest/MouseDragTest.java > java/awt/OpenWinDoubleClick

Re: RFR: 8339935: Open source several AWT focus tests - series 5 [v2]

2024-09-23 Thread Prasanta Sadhukhan
On Mon, 23 Sep 2024 18:03:52 GMT, Phil Race wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review fix > > test/jdk/java/awt/Focus/ProxiedWindowHideTest.java line 27: >

Integrated: 8340367: Opensource few AWT image tests

2024-09-23 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 03:58:20 GMT, Prasanta Sadhukhan wrote: > Opensource few image tests This pull request has now been integrated. Changeset: 6c91a16f Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/6c91a16f16cbeb1bb0a79459e7db1fd9f576e743 Stats: 513 li

Integrated: 8339995: Open source several AWT focus tests - series 6

2024-09-23 Thread Prasanta Sadhukhan
On Thu, 19 Sep 2024 05:25:17 GMT, Prasanta Sadhukhan wrote: > Opensource few Focus tests This pull request has now been integrated. Changeset: 3411f9df Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/3411f9dff79c2e7cb7ce8ebf036f8b3fd9bb647d Stats: 580 li

Re: RFR: 8340084: Open source AWT Frame related tests [v4]

2024-09-23 Thread Prasanta Sadhukhan
On Mon, 23 Sep 2024 04:21:27 GMT, Abhishek Kumar wrote: >> Few AWT Frame related tests are converted from applet to manual and moved to >> open. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > minor spacing Marked as re

Re: RFR: 8340393: Open source closed choice tests #2 [v3]

2024-09-20 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 09:35:31 GMT, Alexander Zvegintsev wrote: >> few manual tests to open source >> Tested on all platforms, all looks good. > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > instructions update Mark

Re: RFR: 8340393: Open source closed choice tests #2 [v2]

2024-09-20 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 09:13:29 GMT, Alexander Zvegintsev wrote: >> test/jdk/java/awt/Choice/DisabledList.java line 43: >> >>> 41: >>> 42: private static final String INSTRUCTIONS = """ >>> 43: 1) Switch checkbox >> >> Shouldn't it be "Enable checkbox"? > > I would read the "Enab

Re: RFR: 8340393: Open source closed choice tests #2

2024-09-20 Thread Prasanta Sadhukhan
On Thu, 19 Sep 2024 06:39:40 GMT, Alexander Zvegintsev wrote: > few manual tests to open source > Tested on all platforms, all looks good. Marked as reviewed by psadhukhan (Reviewer). test/jdk/java/awt/Choice/CheckChoiceTest.java line 29: > 27: import java.awt.BorderLayout; > 28: import java.

Re: RFR: 8340084: Open source AWT Frame related tests [v3]

2024-09-20 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 08:04:30 GMT, Abhishek Kumar wrote: >> Few AWT Frame related tests are converted from applet to manual and moved to >> open. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment update Mark

Re: RFR: 8340084: Open source AWT Frame related tests [v2]

2024-09-20 Thread Prasanta Sadhukhan
On Thu, 19 Sep 2024 05:21:02 GMT, Abhishek Kumar wrote: >> Few AWT Frame related tests are converted from applet to manual and moved to >> open. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment fix test/jd

Integrated: 8339906: Open source several AWT focus tests - series 4

2024-09-19 Thread Prasanta Sadhukhan
On Wed, 18 Sep 2024 03:51:08 GMT, Prasanta Sadhukhan wrote: > Opensource few Focus tests This pull request has now been integrated. Changeset: 46b02f49 Author: Prasanta Sadhukhan URL: https://git.openjdk.org/jdk/commit/46b02f49bcc730d94e37cf17fa996fdd12bdb990 Stats: 526 li

Re: RFR: 8339906: Open source several AWT focus tests - series 4 [v6]

2024-09-19 Thread Prasanta Sadhukhan
> Opensource few Focus tests Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision: - volatile - EDT - Changes: - all: https://git.openjdk.org/jdk/pull/21051/files - new: https://git.openjdk.org/jdk/pull/21051/fi

Re: RFR: 8339906: Open source several AWT focus tests - series 4 [v5]

2024-09-19 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 05:30:45 GMT, Abhishek Kumar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Formatting, EDT addition > > test/jdk/java/awt/Focus/ComponentLostFocusTest.java

Re: RFR: 8339906: Open source several AWT focus tests - series 4 [v4]

2024-09-19 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 05:22:33 GMT, Abhishek Kumar wrote: >> it will be same.. > > `println` method can be removed if `PassFailJFrame.log` is used directly. Then PassFailJFrame.log will be repeated, so it's same...dont think it's critical to change.. - PR Review Comment: https://git

Re: RFR: JDK-8340077 : Open source few Checkbox tests - Set2

2024-09-19 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 05:04:18 GMT, Harshitha Onkar wrote: >> Following tests are updated in this PR: >> >> 1. test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java >> 2. test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java >> 3. test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java >> 4.

Re: RFR: 8339906: Open source several AWT focus tests - series 4 [v5]

2024-09-19 Thread Prasanta Sadhukhan
> Opensource few Focus tests Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Formatting, EDT addition - Changes: - all: https://git.openjdk.org/jdk/pull/21051/files - new: https://git.openjdk.org/jdk/p

Re: RFR: 8339906: Open source several AWT focus tests - series 4 [v4]

2024-09-19 Thread Prasanta Sadhukhan
On Fri, 20 Sep 2024 04:02:12 GMT, Abhishek Kumar wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> typo > > test/jdk/java/awt/Focus/AltTabEventsTest.java line 61: > >>

Re: RFR: JDK-8340077 : Open source few Checkbox tests - Set2

2024-09-19 Thread Prasanta Sadhukhan
On Thu, 19 Sep 2024 17:59:26 GMT, Harshitha Onkar wrote: > Following tests are updated in this PR: > > 1.test/jdk/java/awt/Checkbox/CheckboxBoxSizeTest.java > 2.test/jdk/java/awt/Checkbox/CheckboxIndicatorSizeTest.java > 3.test/jdk/java/awt/Checkbox/CheckboxNullLabelTest.java > 4.

RFR: 8340367: Opensource few AWT image tests

2024-09-19 Thread Prasanta Sadhukhan
Opensource few image tests - Commit messages: - jcheck - 8340367: Opensource few AWT image tests - 8340367: Opensource few AWT image tests - 8340367: Opensource few AWT image tests Changes: https://git.openjdk.org/jdk/pull/21104/files Webrev: https://webrevs.openjdk.org/?repo=j

  1   2   3   4   5   6   7   8   9   10   >