On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L&F during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa
On Tue, 30 Jan 2024 21:49:12 GMT, Rajat Mahajan wrote:
> Modified the test to use PassFailJFrame and open sourced it.
> The test shows two windows, one for instructions and the other to perform
> testing on.
> Tested locally and it works fine.
This pull request has now bee
> Modified the test to use PassFailJFrame and open sourced it.
> The test shows two windows, one for instructions and the other to perform
> testing on.
> Tested locally and it works fine.
Rajat Mahajan has updated the pull request incrementally with two additional
commits si
Modified the test to use PassFailJFrame and moved it from closed to open.
The test shows two windows, one for instructions and the other to perform
testing on.
Tested locally and it works fine.
-
Commit messages:
- 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
Changes
On Fri, 12 Jan 2024 19:17:24 GMT, Rajat Mahajan wrote:
> ImageIcon.loadImage used to handle InterruptedException only by printing a
> message to the console. JDK-8236987 handled the interrupted state more
> gracefully, but it didn't restore the interrupted flag.
> This ch
lowing code
> to handle interruption and exit the thread; otherwise, the thread will
> continue to run.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update LoadInterruptTest.java
removed extra blank lines.
-
lowing code
> to handle interruption and exit the thread; otherwise, the thread will
> continue to run.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
add test case for this change
-
Changes:
- all: https://g
lowing code
> to handle interruption and exit the thread; otherwise, the thread will
> continue to run.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year.
-
Changes:
- all: https://git.openjdk.o
ImageIcon.loadImage used to handle InterruptedException only by printing a
message to the console. JDK-8236987 handled the interrupted state more
gracefully, but it didn't restore the interrupted flag.
This change restores the interrupted flag that will allow the following code to
handle interru
On Thu, 11 Jan 2024 18:43:00 GMT, Rajat Mahajan wrote:
> Remove commented out/ unused code from awt_List.cpp, which has been commented
> out since 2007, when the code was moved to Mercurial.
> The test ScrollPaneLimitation.java has been opened under
> [JDK-8306137](https://bugs
to remove this code now.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update awt_List.cpp
removed extra blank line at the end of the function.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17378/files
Remove commented out/ unused code from awt_List.cpp, which has been commented
out since 2007, when the code was moved to Mercurial.
The test ScrollPaneLimitation.java has been opened under
[JDK-8306137](https://bugs.openjdk.org/browse/JDK-8306137), and it should be
safe to remove this code now.
On Mon, 8 Jan 2024 18:45:05 GMT, Rajat Mahajan wrote:
> Since newInsets() function is a helper function used in ThemeReader.cpp only
> , this change declares it as static.
This pull request has now been integrated.
Changeset: d78e8dab
Author: Rajat Mahajan
Committer: Alexey Ivano
> 8322545: Declare newInsets as static in ThemeReader.cpp
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year 2024
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17310/files
- new: ht
8322545: Declare newInsets as static in ThemeReader.cpp
-
Commit messages:
- 8322545: Declare newInsets as static in ThemeReader.cpp
Changes: https://git.openjdk.org/jdk/pull/17310/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17310&range=00
Issue: https://bugs.openjdk.o
On Thu, 21 Dec 2023 01:19:40 GMT, Rajat Mahajan wrote:
> **Issue:**
> https://bugs.openjdk.org/browse/JDK-8294427 starts to use this API
> https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/nf-uxtheme-openthemedatafordpi
>
> which was introduced only in Windows 10
**Issue:**
https://bugs.openjdk.org/browse/JDK-8294427 starts to use this API
https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/nf-uxtheme-openthemedatafordpi
which was introduced only in Windows 10 1703.
So the theming engine won't load on anything earlier like the original windows
10
On Sun, 27 Aug 2023 21:41:43 GMT, Rajat Mahajan wrote:
> I have made the test changes to include radio button in menu and tested the
> same and it works fine.
This pull request has now been integrated.
Changeset: 4f90abaf
Author: Rajat Mahajan
Committer: Harshitha Onkar
URL:
> I have made the test changes to include radio button in menu and tested the
> same and it works fine.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update instructions for clarity
-
Changes:
- all:
On Thu, 31 Aug 2023 18:57:17 GMT, Harshitha Onkar wrote:
>>> @aivanov-jdk I tried it on my High DPI Windows monitor but with scale set
>>> to 100% and that threw the skipped exception. I know by default we always
>>> have some scale setting on Windows for High DPI Monitors, but do we expect
>>
On Thu, 31 Aug 2023 14:03:28 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 57:
>>
>>> 55: public static final String INSTRUCTIONS = "INSTRUCTIONS:\n\n"
>>> 56: + "Verify that high resolution system icons are used for
>>> JCheckBoxMenuIt
On Wed, 30 Aug 2023 20:36:45 GMT, Alexey Ivanov wrote:
>> Rajat Mahajan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update bug8031573.java
>>
>> remove macosx from summary .
>
> test/jd
> I have made the test changes to include radio button in menu and tested the
> same and it works fine.
Rajat Mahajan has updated the pull request incrementally with two additional
commits since the last revision:
- Update test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java
> I have made the test changes to include radio button in menu and tested the
> same and it works fine.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update bug8031573.java
remove macosx from s
> I have made the test changes to include radio button in menu and tested the
> same and it works fine.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
make changes suggested by reviewers
-
Changes:
- all:
> I have made the test changes to include radio button in menu and tested the
> same and it works fine.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java
Co-au
I have made the test changes to include radio button in menu and tested the
same and it works fine.
-
Commit messages:
- 8311585: Add JRadioButtonMenuItem to bug8031573.java
Changes: https://git.openjdk.org/jdk/pull/15441/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1544
On Thu, 27 Apr 2023 19:25:55 GMT, Rajat Mahajan wrote:
> Problem:
>
> Check boxes and radio buttons in Windows Look-and-Feel have rendering issues
> when window is moved from display with one scale to display with a different
> scale on a multi-monitor setup:
>
&g
_
> Monitor 1|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% |175%
&g
_
> Monitor 1|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% |175%
&g
_
> Monitor 1|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% |175%
&g
_
> Monitor 1|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% |175%
&g
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
On Thu, 8 Jun 2023 07:37:41 GMT, Sergey Bylokhov wrote:
>> So, we ask Windows for the component image based on a particular DPI , not
>> some specific size.
>> The basic premise here is that we expect Windows returning image that would
>> match the DPI , and then we perform our calculations acc
On Thu, 8 Jun 2023 00:16:27 GMT, Sergey Bylokhov wrote:
>> So, basically for w,h =19 we calculate a DPI of 140 and Dimension d =
>> getPartSize(getTheme(widget, dpi), part, state); at line 172 of
>> ThemeReader.java call returns a part size of 13 x 13 provided by windows as
>> it is closer to
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
On Thu, 1 Jun 2023 21:10:39 GMT, Alisen Chung wrote:
>> Rajat Mahajan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code changes as per code review
>
> src/java.desktop/share/classes/sun/swing/CachedPa
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
On Thu, 18 May 2023 23:00:25 GMT, Sergey Bylokhov wrote:
>> Perhaps, this needs additional details. The size of checkbox and radio
>> button is 13 as reported by Theme API for the standard DPI of 96. Being a
>> prime number, 13 doesn't scale well, there's always fractional part unless
>> the s
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
On Mon, 15 May 2023 21:53:58 GMT, Sergey Bylokhov wrote:
>> With clipRound this is what I see with 150% Scaling:
>>
>> 
>>
>> With the current code change this is what I see with 150% Scaling:
>>
>> !
On Wed, 10 May 2023 17:45:17 GMT, Sergey Bylokhov wrote:
>> So, I added this code specifically to have improved rendering for the 25%
>> cases, like 125%, 225%, 325% as rendering was a little off for these scale
>> values and empirically based on what we saw it looked better with this
>> calcu
On Mon, 8 May 2023 23:22:52 GMT, Sergey Bylokhov wrote:
>> No, Region.clipRound does something little different than what I intend to
>> do in
>> this code .
>> It works same as my code for 0.25 and 0.75 case. But not for 0.5 case.
>> For example in case of destwidth and destHeight = 19.5,
>>
|Monitor 2
> (Primary) |
>|
> 125% |175%
> 150% |175%
> 150% |225%
> 175% | 175%
> 175% |150%
>
On Mon, 8 May 2023 18:26:37 GMT, Sergey Bylokhov wrote:
>>> Why does everything else use defaultDPI, is it possible that some values
>>> depend on the DPI?
>>
>> Because Swing's user space coordinates use the default 96dpi. Some values do
>> depend on the DPI, yet layout code still uses the de
On Mon, 10 Apr 2023 21:32:30 GMT, Rajat Mahajan wrote:
> **Problem:**
>
> On pressing the Copy button we keep waiting in AWT-EventQueue thread in
> reconstruct() function as we detect that we have missing information for the
> animated image since we are copying single frame a
On Tue, 2 May 2023 15:05:23 GMT, Alexey Ivanov wrote:
>> Problem:
>>
>> Check boxes and radio buttons in Windows Look-and-Feel have rendering issues
>> when window is moved from display with one scale to display with a different
>> scale on a multi-monitor setup:
>>
>> - Scrawly ticks in chec
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
code cleanup
-
Changes:
- all: https://git.openjdk.org/jdk/pull
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
make code changes suggested by reviewers
-
Changes:
- all: https://git
On Tue, 2 May 2023 18:40:02 GMT, Alexey Ivanov wrote:
>> Rajat Mahajan has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update ImageRepresentation.java
>>
>>code cleanup
>> - Update
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.desktop/share/classes/sun/awt/image/ImageRepresentation.java
Co-a
On Sun, 30 Apr 2023 21:34:53 GMT, Rajat Mahajan wrote:
>> **Problem:**
>>
>> On pressing the Copy button we keep waiting in AWT-EventQueue thread in
>> reconstruct() function as we detect that we have missing information for the
>> animated image since we are
On Thu, 20 Apr 2023 19:26:52 GMT, Rajat Mahajan wrote:
>> **Problem:**
>>
>> On pressing the Copy button we keep waiting in AWT-EventQueue thread in
>> reconstruct() function as we detect that we have missing information for the
>> animated image since we are
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with three additional
commits since the last revision:
- Update ImageRepresentation.java
code cleanup
- Update ImageRepresentat
Problem:
Check boxes and radio buttons in Windows Look-and-Feel have rendering issues
when window is moved from display with one scale to display with a different
scale on a multi-monitor setup:
- Scrawly ticks in checkboxes;
- Wrong circle relations in selected radio buttons.
Root-cause:
We o
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
Update CopyAnimatedGIFTest.java
-
Changes:
- all: https://git.openjdk.
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with two additional
commits since the last revision:
- Update test/jdk/java/awt/Clipboard/CopyAnimatedGIFTest.java
Co
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
code cleanup
-
Changes:
- all: https://git.openjdk.org/jdk/pull
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
remove dispose() since jtreg will take care of disposing of the frame
---
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
fix end of line for file
-
Changes:
- all: https://git.openjdk.org/jd
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
remove the bug folder and fix end of line
-
Changes:
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with two additional
commits since the last revision:
- code cleanup
- code cleanup
-
Changes:
- all: https://git.openjdk.
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with three additional
commits since the last revision:
- Update test/jdk/javax/imageio/plugins/gif/6176679/CopyAnimatedGIFTest.java
On Fri, 14 Apr 2023 22:48:41 GMT, Rajat Mahajan wrote:
>> **Problem:**
>>
>> On pressing the Copy button we keep waiting in AWT-EventQueue thread in
>> reconstruct() function as we detect that we have missing information for the
>> animated image since we are
On Mon, 10 Apr 2023 21:32:30 GMT, Rajat Mahajan wrote:
> **Problem:**
>
> On pressing the Copy button we keep waiting in AWT-EventQueue thread in
> reconstruct() function as we detect that we have missing information for the
> animated image since we are copying single frame a
dded a test for this (bug6176679.java) and tested locally on my Windows
> machine and on mach5.
Rajat Mahajan has updated the pull request incrementally with one additional
commit since the last revision:
code cleanup and test changes as requested in code review
-
Changes:
On Mon, 10 Apr 2023 21:32:30 GMT, Rajat Mahajan wrote:
> **Problem:**
>
> On pressing the Copy button we keep waiting in AWT-EventQueue thread in
> reconstruct() function as we detect that we have missing information for the
> animated image since we are copying single frame a
**Problem:**
On pressing the Copy button we keep waiting in AWT-EventQueue thread in
reconstruct() function as we detect that we have missing information for the
animated image since we are copying single frame at a time.
Due to this infinite wait the application freezes.
**Proposed Fix:**
The
On Fri, 13 Jan 2023 20:53:31 GMT, Rajat Mahajan wrote:
> I tested by removing dpi-awareness settings from the manifest file, and then
> running my app with -Dsun.java2d.dpiaware=false. This showed java.exe as
> "Unaware" in task-manager, and with it set to true I saw "
> I tested by removing dpi-awareness settings from the manifest file, and then
> running my app with -Dsun.java2d.dpiaware=false. This showed java.exe as
> "Unaware" in task-manager, and with it set to true I saw "Per-Monitor (v2)"
> dpi awareness for java.exe
I tested by removing dpi-awareness settings from the manifest file, and then
running my app with -Dsun.java2d.dpiaware=false. This showed java.exe as
"Unaware" in task-manager, and with it set to true I saw "Per-Monitor (v2)" dpi
awareness for java.exe.
-
Commit messages:
- 828658
On Mon, 12 Dec 2022 22:43:08 GMT, Harshitha Onkar wrote:
>> In this fix, the common code required for scaled border rendering is unified
>> and added to SwingUtilities3. This is achieved by adding a functional
>> interface to SwingUtilities3 and calling the the respective paintBorder
>> functi
On Mon, 12 Dec 2022 19:09:02 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line
>> 190:
>>
>>> 188:
>>> 189: if (resetTransform) {
>>> 190: double xx = at.getScaleX() * x + at.getTranslateX();
>>
>> Can we combine thi
On Wed, 7 Dec 2022 21:34:12 GMT, Harshitha Onkar wrote:
> In this fix, the common code required for scaled border rendering is unified
> and added to SwingUtilities3. This is achieved by adding a functional
> interface to SwingUtilities3 and calling the the respective paintBorder
> function pa
On Sat, 3 Dec 2022 22:11:47 GMT, Rajat Mahajan wrote:
> The test is failing because there was no gap between the Textfields.
> I fixed it by adding Vertical Struts in between Textfields.
This pull request has now been integrated.
Changeset: ea83cb96
Author: Rajat Mahajan
Com
On Sat, 3 Dec 2022 22:11:47 GMT, Rajat Mahajan wrote:
> Added createVerticalStrut in between textfields to fix this issue.
The test is failing because there was no gap between the Textfields.
I fixed it by adding Vertical Struts in between Textfields.
-
PR: ht
Added createVerticalStrut in between textfields to fix this issue.
-
Commit messages:
- 8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter
Changes: https://git.openjdk.org/jdk/pull/11498/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11498&range=00
On Wed, 12 Oct 2022 16:41:52 GMT, Rajat Mahajan wrote:
> This fix is based on a similar approach as described here
> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
> We rescale the line border to render the Textfield border correctly, so that
> all sides of t
> This fix is based on a similar approach as described here
> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
> We rescale the line border to render the Textfield border correctly, so that
> all sides of the Textfield border are of same thickness.
Rajat Mahajan
> This fix is based on a similar approach as described here
> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
> We rescale the line border to render the Textfield border correctly, so that
> all sides of the Textfield border are of same thickness.
Rajat Mahajan
This fix is based on a similar approach as described here
https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
We rescale the line border to render the Textfield border correctly, so that
all sides of the Textfield border are of same thickness.
-
Commit messages:
- re
90 matches
Mail list logo
