Re: RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable

2025-01-29 Thread Tejesh R
On Tue, 28 Jan 2025 14:51:57 GMT, Alexey Ivanov wrote: > The `javax/swing/JButton/4796987/bug4796987.java` test strictly verifies if > it's run on Windows XP, for this reason it never runs on modern versions of > Windows. > > Since Windows XP is obsolete and visual styles cannot be disabled si

Re: RFR: 8318577: Windows Look-and-Feel JProgressBarUI does not render correctly on 2x UI scale [v3]

2025-01-29 Thread Tejesh R
On Fri, 24 Jan 2025 12:24:02 GMT, Prasanta Sadhukhan wrote: >> JProgressBar (StringPainted variant) does not render consistently on HiDPI >> displays (e.g. 200% Scale Factor) on Windows (using Windows Look-and-Feel) >> depending on the height at which JProgressBar is rendered, in which case th

Re: RFR: 8318577: Windows Look-and-Feel JProgressBarUI does not render correctly on 2x UI scale [v3]

2025-01-29 Thread Tejesh R
On Wed, 29 Jan 2025 08:24:16 GMT, Prasanta Sadhukhan wrote: > > I tested the fix with the proposed test, works as expected. I guess making > > the test automatic would be great. > > SInce finer details need to be looked at, I intended to keep it manual.. Actually I felt it the other way. To t

Re: RFR: 8318577: Windows Look-and-Feel JProgressBarUI does not render correctly on 2x UI scale [v3]

2025-01-29 Thread Tejesh R
On Fri, 24 Jan 2025 12:24:02 GMT, Prasanta Sadhukhan wrote: >> JProgressBar (StringPainted variant) does not render consistently on HiDPI >> displays (e.g. 200% Scale Factor) on Windows (using Windows Look-and-Feel) >> depending on the height at which JProgressBar is rendered, in which case th

Re: RFR: 8318577: Windows Look-and-Feel JProgressBarUI does not render correctly on 2x UI scale [v2]

2025-01-23 Thread Tejesh R
On Fri, 24 Jan 2025 06:38:36 GMT, Prasanta Sadhukhan wrote: > > ``` > > 2. If you can observe the "BAD" progress bar, the bottom border is visible, > > where as its not in "GOOD" progress bar. It's like the whole paint is > > shifted by pixel to top. > > ``` > > The "GOOD" progressbar size is

Re: RFR: 8318577: Windows Look-and-Feel JProgressBarUI does not render correctly on 2x UI scale [v2]

2025-01-23 Thread Tejesh R
On Wed, 22 Jan 2025 07:02:21 GMT, Prasanta Sadhukhan wrote: >> JProgressBar (StringPainted variant) does not render consistently on HiDPI >> displays (e.g. 200% Scale Factor) on Windows (using Windows Look-and-Feel) >> depending on the height at which JProgressBar is rendered, in which case th

Re: RFR: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04 [v2]

2024-12-12 Thread Tejesh R
On Fri, 13 Dec 2024 05:14:13 GMT, Prasanta Sadhukhan wrote: >> javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in >> ubuntu22.04 seems to fail in OCI system citing "Test failed" >> suggesting caret is not at expected place after text is typed, but I could >> not find any CI jobs

Re: RFR: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04

2024-12-12 Thread Tejesh R
On Thu, 12 Dec 2024 02:39:07 GMT, Prasanta Sadhukhan wrote: > javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04 > seems to fail in OCI system citing "Test failed" > suggesting caret is not at expected place after text is typed, but I could > not find any CI jobs hav

Re: RFR: 8342782: AWTEventMulticaster throws StackOverflowError using AquaButtonUI [v5]

2024-12-05 Thread Tejesh R
On Mon, 25 Nov 2024 22:34:46 GMT, Jeremy wrote: >> The AWTEventMulticaster is a tree node with 2 children. This PR proposes >> rebalancing that tree after 500 additions to avoid potential >> StackOverflowErrors when trying to interact with a large AWTEventMulticaster. >> >> In the original hea

Re: RFR: 8342782: AWTEventMulticaster throws StackOverflowError using AquaButtonUI [v5]

2024-12-05 Thread Tejesh R
On Mon, 25 Nov 2024 22:34:46 GMT, Jeremy wrote: >> The AWTEventMulticaster is a tree node with 2 children. This PR proposes >> rebalancing that tree after 500 additions to avoid potential >> StackOverflowErrors when trying to interact with a large AWTEventMulticaster. >> >> In the original hea

Re: RFR: 8345566: Deproblemlist test/jdk/javax/swing/JComboBox/6559152/bug6559152.java

2024-12-05 Thread Tejesh R
On Thu, 5 Dec 2024 10:04:25 GMT, Prasanta Sadhukhan wrote: > test/jdk/javax/swing/JComboBox/6559152/bug6559152.java does not seem to fail > in listed CI job but is problemlisted. > Test is passing in several OCI systems so deproblemlisting.. LGTM. - Marked as reviewed by tr (Revi

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v5]

2024-11-26 Thread Tejesh R
On Tue, 26 Nov 2024 11:58:54 GMT, Abhishek Kumar wrote: > Tested on win11 system and it didn't work as expected while dragging mouse > from text_box to any other component. Mouse cursor changed to default Arrow > style as soon as mouse is dragged out of text box. However the applet version > o

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v5]

2024-11-26 Thread Tejesh R
> The test is supposed to be problem listed on macos & Linux but the Problem > list points to the .java file instead of the .html file. > Hence converting java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest > to main which would automatically resolve the issue. Tejesh R

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v4]

2024-11-26 Thread Tejesh R
On Tue, 26 Nov 2024 11:08:34 GMT, Abhishek Kumar wrote: >> I didn't get it ?? > >> I didn't get it ?? > > No need to explicitly set number of rows. It has been taken care > [here](https://github.com/openjdk/jdk/pull/21039) Ok, updated. - PR Review Comment: https://git.openjdk.org

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v4]

2024-11-26 Thread Tejesh R
On Tue, 26 Nov 2024 08:37:14 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringA

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v4]

2024-11-26 Thread Tejesh R
On Tue, 26 Nov 2024 08:38:16 GMT, Abhishek Kumar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringA

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v3]

2024-11-24 Thread Tejesh R
On Fri, 22 Nov 2024 19:01:17 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringA

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v4]

2024-11-24 Thread Tejesh R
> The test is supposed to be problem listed on macos & Linux but the Problem > list points to the .java file instead of the .html file. > Hence converting java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest > to main which would automatically resolve the issue. Tejesh R

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v2]

2024-11-21 Thread Tejesh R
On Thu, 21 Nov 2024 17:47:34 GMT, Damon Nguyen wrote: >> I didn't get? > > Usually an empty newline at the end is used. I don't see it in other test, can u share any reference? - PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1853336922

Re: RFR: 8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException [v7]

2024-11-19 Thread Tejesh R
On Wed, 21 Aug 2024 08:39:31 GMT, Prasanta Sadhukhan wrote: >> When a printjob is cancelled midway, `PrinterAbortException `was not thrown >> in macos. because >> firstly,` cancelCheck` invokes` LWCToolkit.invokeLater` with null as >> parameter causing it to fail with NPE and >> secondly Prin

Re: RFR: 8344064: Remove doPrivileged calls from print/imageio/media classes in the java.desktop module [v2]

2024-11-19 Thread Tejesh R
On Tue, 19 Nov 2024 17:37:16 GMT, Phil Race wrote: >> Remove doPrivileged calls from javax.imageio, javax.print and some sound >> impl classes > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8344064 src/java.desktop/share/cl

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v3]

2024-11-18 Thread Tejesh R
> The test is supposed to be problem listed on macos & Linux but the Problem > list points to the .java file instead of the .html file. > Hence converting java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest > to main which would automatically resolve the issue. Tejesh R

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v2]

2024-11-18 Thread Tejesh R
On Mon, 18 Nov 2024 17:29:54 GMT, Damon Nguyen wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Instructions modified for macosx > > test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringA

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v2]

2024-11-18 Thread Tejesh R
On Mon, 18 Nov 2024 17:25:03 GMT, Damon Nguyen wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Instructions modified for macosx > > test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringA

Re: RFR: 8344064: Remove doPrivileged calls from print/imageio/media classes in the java.desktop module

2024-11-18 Thread Tejesh R
On Sun, 17 Nov 2024 20:51:26 GMT, Phil Race wrote: > Remove doPrivileged calls from javax.imageio, javax.print and some sound impl > classes src/java.desktop/share/classes/javax/print/PrintServiceLookup.java line 349: > 347: ArrayList los = > getListOfLookupServices(); > 348:

Re: RFR: 8316151: [macos14] ActionListenerCalledTwiceTest.java fails on macOS 14

2024-11-17 Thread Tejesh R
On Sun, 17 Nov 2024 10:41:21 GMT, Prasanta Sadhukhan wrote: > Test was failing due to apple bug in version < 14.5 and is passing in > latest..Tested in CI systems and all passed for several iterations, so > removing from PL.. Marked as reviewed by tr (Reviewer). - PR Review: htt

Re: RFR: 8343123: Nimbus: javax/swing/JInternalFrame/bug6726866.java does not have green undecorated window [v3]

2024-11-15 Thread Tejesh R
On Fri, 15 Nov 2024 12:02:23 GMT, Prasanta Sadhukhan wrote: >> Test fails in NimbusL&F as DesktopPane does not have green background as set >> by the user, which is because, the auto-generated [DesktopPanePainter >> class](https://github.com/openjdk/jdk/blob/eb40a88f4076360708402454a494907e8c0

Re: RFR: 8343123: Nimbus: javax/swing/JInternalFrame/bug6726866.java does not have green undecorated window

2024-11-15 Thread Tejesh R
On Wed, 13 Nov 2024 02:40:16 GMT, Prasanta Sadhukhan wrote: > Test fails in NimbusL&F as DesktopPane does not have green background as set > by the user, which is because, the auto-generated [DesktopPanePainter > class](https://github.com/openjdk/jdk/blob/eb40a88f4076360708402454a494907e8c0c84

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main [v2]

2024-11-14 Thread Tejesh R
> The test is supposed to be problem listed on macos & Linux but the Problem > list points to the .java file instead of the .html file. > Hence converting java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest > to main which would automatically resolve the issue. Tejesh R

Re: RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main

2024-11-14 Thread Tejesh R
On Tue, 12 Nov 2024 21:30:07 GMT, Alisen Chung wrote: >> The test is supposed to be problem listed on macos & Linux but the Problem >> list points to the .java file instead of the .html file. >> Hence converting >> java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main which >> w

RFR: 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main

2024-11-14 Thread Tejesh R
The test is supposed to be problem listed on macos & Linux but the Problem list points to the .java file instead of the .html file. Hence converting java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main which would automatically resolve the issue. - Commit messages:

Re: RFR: 6672644: JComboBox still scrolling if switch to another window and return back [v3]

2024-11-05 Thread Tejesh R
On Tue, 5 Nov 2024 22:29:08 GMT, Damon Nguyen wrote: >> In a JComboBox, if the user opens the dropdown list and clicks and holds the >> down-button, then ALT-TABs to switch focus, when the user re-focuses the >> frame with the JComboBox and opens the dropdown list again, the list will >> still

Re: RFR: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper cannot access

2024-10-30 Thread Tejesh R
On Wed, 30 Oct 2024 02:50:08 GMT, Prasanta Sadhukhan wrote: > Couple of printing tests dont have "public" modifier so CI testing fails to > run this test citing IllegalAccessException. > Fix is made to made the test class public. > > Additionally, modified PrintDlgPageable.java to use PFJ and

Re: RFR: 8342098: Write a test to compare the images [v2]

2024-10-30 Thread Tejesh R
On Wed, 30 Oct 2024 09:20:17 GMT, Naveen Narayanan wrote: > > Also the test is failing in windows local machine. Can you re-confirm once > > by testing it in any Windows machine? Or is there anything I might be > > missing while testing? > > Its color profile issues, will pass with sRGB. The

Re: RFR: 8342785: XWindowPeer::getNewLocation() adheres to ICCCM 4.1.5 only with some WMs

2024-10-24 Thread Tejesh R
On Thu, 24 Oct 2024 09:54:46 GMT, Vlad Zahorodnii wrote: > > Can u assign the JBS to your name, its still unassigned. > > Hmm, I don't think that I'm able to do this. One would need to have an > account at JBS, but in order to create an account at JBS, it seems like you > already need to be an

Re: RFR: 8342082: Remove unused BasicProgressBarUI.Animator.interval

2024-10-23 Thread Tejesh R
On Mon, 23 Sep 2024 09:44:21 GMT, Andrey Turbanov wrote: > The field `javax.swing.plaf.basic.BasicProgressBarUI.Animator.interval` is > unused and can be removed. Probably its better to remove the commented lines which were using `interval` variable - https://github.com/openjdk/jdk/blob/092f8

Re: RFR: 8342785: XWindowPeer::getNewLocation() adheres to ICCCM 4.1.5 only with some WMs

2024-10-23 Thread Tejesh R
On Tue, 22 Oct 2024 09:59:22 GMT, Vlad Zahorodnii wrote: > It is not guaranteed that the WM will always send a synthetic ConfigureNotify > event after changing the geometry. As ICCCM 4.1.5 suggests, the WM may not > send a synthetic configure notify event if the window is resized for real. In

Re: RFR: 8326027: [TEST_BUG]Comparing buffered images of white background frame fails in Mac

2024-10-23 Thread Tejesh R
On Tue, 22 Oct 2024 21:53:14 GMT, Phil Race wrote: > What makes it intermittent ? Does it fail on a non-retina ? or a retina ? or > both ? The test systems should all be set up with sRGB color profile, so that > ought not to be the issue. Have you seen it fail locally on a retina laptop > scre

RE: Seeking feedback on a possible JDatePicker Swing component

2024-10-22 Thread Tejesh R
publish as soon as it is ready. Regards, Tejesh R JDK client team [1] https://mail.openjdk.org/pipermail/client-libs-dev/2024-August/021805.html

Re: RFR: 8342098: Write a test to compare the images [v2]

2024-10-17 Thread Tejesh R
On Wed, 16 Oct 2024 16:13:33 GMT, Naveen Narayanan wrote: >> This testcase checks for the following: >> >> 1. An image is drawn on the screen and a portion of it is captured using a >> Robot. It is tested by comparing whether the captured image is same as the >> source image. >> >> Testing:

Re: RFR: 8342098: Write a test to compare the images [v2]

2024-10-17 Thread Tejesh R
On Wed, 16 Oct 2024 16:13:33 GMT, Naveen Narayanan wrote: >> This testcase checks for the following: >> >> 1. An image is drawn on the screen and a portion of it is captured using a >> Robot. It is tested by comparing whether the captured image is same as the >> source image. >> >> Testing:

Integrated: 8340279: Open source several AWT Dialog tests - Batch 2

2024-10-16 Thread Tejesh R
On Fri, 11 Oct 2024 07:24:57 GMT, Tejesh R wrote: > Open source these AWT Dialog tests: > > java/awt/Dialog/PrintToFileTest/PrintToFileRevoked.java > java/awt/Dialog/PrintToFileTest/PrintToFileGranted.java > java/awt/Dialog/TopmostModalDialogTest.java > java/awt/Dialog/FileDia

Re: RFR: 8340279: Open source several AWT Dialog tests - Batch 2 [v3]

2024-10-16 Thread Tejesh R
alog/DialogSystemMenu/DialogSystemMenu.java Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge Master - Merge Master - Open Source - Changes: https://git.openjdk.org/jdk/pull/21466/files Webrev: https:

Integrated: 8341072: Open source several AWT Canvas and Rectangle related tests

2024-10-16 Thread Tejesh R
On Fri, 11 Oct 2024 07:10:20 GMT, Tejesh R wrote: > Open source these AWT Canvas and Rectangle tests: > java/awt/Canvas/MultiDitherTest/MultiDitherTest.java > java/awt/Canvas/MultiGraphicsTest/MultiGraphicsTest.java > java/awt/Canvas/NoEventsLeakTest/NoEventsLeakTest.java > jav

Integrated: 8340790: Open source several AWT Dialog tests - Batch 4

2024-10-15 Thread Tejesh R
On Tue, 8 Oct 2024 10:39:34 GMT, Tejesh R wrote: > Open source these AWT Dialog tests: > > java/awt/Dialog/FileDialogGetFileTest.java > java/awt/Dialog/EnabledResetTest.java > java/awt/Dialog/ChoiceModalDialogTest.java > java/awt/Dialog/DialogBackgroundTest.java This pull re

Re: RFR: 6672644: JComboBox still scrolling if switch to another window and return back [v2]

2024-10-15 Thread Tejesh R
On Thu, 5 Sep 2024 20:32:07 GMT, Damon Nguyen wrote: >> In a JComboBox, if the user opens the dropdown list and clicks and holds the >> down-button, then ALT-TABs to switch focus, when the user re-focuses the >> frame with the JComboBox and opens the dropdown list again, the list will >> still

Re: RFR: 8340790: Open source several AWT Dialog tests - Batch 4 [v2]

2024-10-14 Thread Tejesh R
On Mon, 14 Oct 2024 19:53:13 GMT, Harshitha Onkar wrote: >> I don't think `CountDownLatch` is required here. Anyhow I have added some >> delays after keypress too. Still didn't get failure in CI system. Please >> check with updated test once and revert. > > Since you mentioned this test passes

Re: RFR: 8340790: Open source several AWT Dialog tests - Batch 4 [v4]

2024-10-14 Thread Tejesh R
> Open source these AWT Dialog tests: > > java/awt/Dialog/FileDialogGetFileTest.java > java/awt/Dialog/EnabledResetTest.java > java/awt/Dialog/ChoiceModalDialogTest.java > java/awt/Dialog/DialogBackgroundTest.java Tejesh R has updated the pull request with a new target base du

Re: RFR: 8340279: Open source several AWT Dialog tests - Batch 2

2024-10-13 Thread Tejesh R
On Fri, 11 Oct 2024 22:14:55 GMT, Damon Nguyen wrote: > @TejeshR13 Seems like you have a merge-conflict that you should resolve since > this involves the Problem list. Yeah, have resolved it now. - PR Comment: https://git.openjdk.org/jdk/pull/21466#issuecomment-2410172860

Re: RFR: 8340279: Open source several AWT Dialog tests - Batch 2 [v2]

2024-10-13 Thread Tejesh R
alog/DialogSystemMenu/DialogSystemMenu.java Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge Master - Open Source - Changes: https://git.openjdk.org/jdk/pull/21466/files Webrev: https://webrevs.openjdk.o

Re: RFR: 8326027: [TEST_BUG]Comparing buffered images of white background frame fails in Mac

2024-10-13 Thread Tejesh R
On Mon, 9 Sep 2024 18:45:45 GMT, Alexey Ivanov wrote: >>> > > Have you checked what is the root cause? Are the pixels drawn >>> > > incorrectly in the frame, or is the robot distorting the colors when it >>> > > grabs the pixels? >>> > >>> > >>> > The issue occurs intermittently/might be even

Re: RFR: 8340494: Open some dialog awt tests 4

2024-10-13 Thread Tejesh R
On Fri, 11 Oct 2024 22:09:00 GMT, Alisen Chung wrote: > Fifth set of swing test to open for fall 2024 test sprint test/jdk/java/awt/Container/ActivateOnFocusTest.java line 54: > 52: public static void main(String[] args) throws Exception { > 53: EventQueue.invokeAndWait(() -> { > 54

Re: RFR: 8341072: Open source several AWT Canvas and Rectangle related tests [v2]

2024-10-13 Thread Tejesh R
On Fri, 11 Oct 2024 18:31:12 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/Canvas/MultiDitherTest.java line 77: > &

Re: RFR: 8341072: Open source several AWT Canvas and Rectangle related tests [v2]

2024-10-13 Thread Tejesh R
> Open source these AWT Canvas and Rectangle tests: > java/awt/Canvas/MultiDitherTest/MultiDitherTest.java > java/awt/Canvas/MultiGraphicsTest/MultiGraphicsTest.java > java/awt/Canvas/NoEventsLeakTest/NoEventsLeakTest.java > java/awt/Rectangle/IntersectionTest/IntersectionTest.jav

RFR: 8340279: Open source several AWT Dialog tests - Batch 2

2024-10-11 Thread Tejesh R
Open source these AWT Dialog tests: java/awt/Dialog/PrintToFileTest/PrintToFileRevoked.java java/awt/Dialog/PrintToFileTest/PrintToFileGranted.java java/awt/Dialog/TopmostModalDialogTest.java java/awt/Dialog/FileDialogFilterTest.java java/awt/Dialog/DialogSystemMenu/DialogSystemMenu.java

RFR: 8341072: Open source several AWT Canvas and Rectangle related tests

2024-10-11 Thread Tejesh R
Open source these AWT Canvas and Rectangle tests: java/awt/Canvas/MultiDitherTest/MultiDitherTest.java java/awt/Canvas/MultiGraphicsTest/MultiGraphicsTest.java java/awt/Canvas/NoEventsLeakTest/NoEventsLeakTest.java java/awt/Rectangle/IntersectionTest/IntersectionTest.java - Commit mes

Integrated: 8340366: Open source several AWT Dialog tests - Batch 3

2024-10-10 Thread Tejesh R
On Fri, 27 Sep 2024 10:20:59 GMT, Tejesh R wrote: > Open source these AWT Dialog tests: > > java/awt/Dialog/ModalDialogTest.java > java/awt/Dialog/DialogModalityTest.java > java/awt/Dialog/DialogResizeTest2.java > java/awt/Dialog/HideDialogTest.java

Integrated: 8340193: Open source several AWT Dialog tests - Batch 1

2024-10-10 Thread Tejesh R
On Wed, 25 Sep 2024 07:20:21 GMT, Tejesh R wrote: > Open source these AWT Mouse tests: > > java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java > java/awt/Dialog/FileDialogWrongNameCrash.java > java/awt/Dialog/DialogResizeTest.java > java/awt/Dialog/GetLocationTest

Re: RFR: 8340790: Open source several AWT Dialog tests - Batch 4 [v2]

2024-10-10 Thread Tejesh R
On Wed, 9 Oct 2024 16:53:27 GMT, Harshitha Onkar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/Dialog/ChoiceModalDialo

Re: RFR: 8340790: Open source several AWT Dialog tests - Batch 4 [v3]

2024-10-10 Thread Tejesh R
> Open source these AWT Dialog tests: > > java/awt/Dialog/FileDialogGetFileTest.java > java/awt/Dialog/EnabledResetTest.java > java/awt/Dialog/ChoiceModalDialogTest.java > java/awt/Dialog/DialogBackgroundTest.java Tejesh R has updated the pull request incrementally with one

Re: RFR: 8340336: Open some checkbox awt tests

2024-10-09 Thread Tejesh R
On Thu, 10 Oct 2024 00:25:39 GMT, Alisen Chung wrote: > Fourth set of dialog swing tests to open during fall 2024 test sprint test/jdk/java/awt/Dialog/ClosingParentTest.java line 36: > 34: * @bug 4336913 > 35: * @summary On Win32, disable parent window controls while modal dialog > is being

Re: RFR: 8340790: Open source several AWT Dialog tests - Batch 4 [v2]

2024-10-09 Thread Tejesh R
> Open source these AWT Dialog tests: > > java/awt/Dialog/FileDialogGetFileTest.java > java/awt/Dialog/EnabledResetTest.java > java/awt/Dialog/ChoiceModalDialogTest.java > java/awt/Dialog/DialogBackgroundTest.java Tejesh R has updated the pull request incrementally with one

Re: RFR: 8340790: Open source several AWT Dialog tests - Batch 4 [v2]

2024-10-09 Thread Tejesh R
On Tue, 8 Oct 2024 16:44:15 GMT, Harshitha Onkar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated review comments > > test/jdk/java/awt/Dialog/ChoiceModalDial

Re: RFR: 8340790: Open source several AWT Dialog tests - Batch 4

2024-10-08 Thread Tejesh R
On Tue, 8 Oct 2024 16:43:29 GMT, Harshitha Onkar wrote: >> Open source these AWT Dialog tests: >> >> java/awt/Dialog/FileDialogGetFileTest.java >> java/awt/Dialog/EnabledResetTest.java >> java/awt/Dialog/ChoiceModalDialogTest.java >> java/awt/Dialog/DialogBackgroundTest.java > > test/jdk/java/aw

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v3]

2024-10-08 Thread Tejesh R
On Mon, 30 Sep 2024 03:30:19 GMT, Prasanta Sadhukhan wrote: >> Probably component is resized even before PassFailJFrame creates the logArea >> in Builder interface. >> The instructions says >> "When isResizable is true the dialog is resizable. When isResizable is false >> the dialog is non-re

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]

2024-10-08 Thread Tejesh R
On Mon, 30 Sep 2024 03:29:53 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments updated > > test/jdk/java/awt/Dialog/GetLocatio

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v3]

2024-10-08 Thread Tejesh R
> Open source these AWT Mouse tests: > > java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java > java/awt/Dialog/FileDialogWrongNameCrash.java > java/awt/Dialog/DialogResizeTest.java > java/awt/Dialog/GetLocationTest_1.java > java/awt/Dialog/DialogIconTest/DialogIconTe

RFR: 8340790: Open source several AWT Dialog tests - Batch 4

2024-10-08 Thread Tejesh R
Open source these AWT Dialog tests: java/awt/Dialog/FileDialogGetFileTest.java java/awt/Dialog/EnabledResetTest.java java/awt/Dialog/ChoiceModalDialogTest.java java/awt/Dialog/DialogBackgroundTest.java - Commit messages: - Open source Changes: https://git.openjdk.org/jdk/pull/21404

Integrated: 8339982: Open source several AWT Mouse tests - Batch 2

2024-10-07 Thread Tejesh R
On Mon, 23 Sep 2024 06:40:55 GMT, Tejesh R wrote: > Open source these AWT Mouse and GraphicsEnvironment tests: > > java/awt/MouseClickCount/MouseClickCount.java > java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java > java/awt/MouseDragTest/MouseDragTest.

Integrated: 8339836: Open source several AWT Mouse tests - Batch 1

2024-10-07 Thread Tejesh R
On Mon, 23 Sep 2024 04:56:43 GMT, Tejesh R wrote: > Open source these AWT Mouse tests: > > java/awt/Mouse/MouseEnterExitTest.java > java/awt/Mouse/MouseEnterExitTest2.java > java/awt/Mouse/MousePressedTest.java > java/awt/Mouse/MouseEnterExitTest4.java > java/awt/Mouse/Mou

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]

2024-09-27 Thread Tejesh R
> Open source these AWT Mouse tests: > > java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java > java/awt/Dialog/FileDialogWrongNameCrash.java > java/awt/Dialog/DialogResizeTest.java > java/awt/Dialog/GetLocationTest_1.java > java/awt/Dialog/DialogIconTest/DialogIconTe

RFR: 8340366: Open source several AWT Dialog tests - Batch 3

2024-09-27 Thread Tejesh R
Open source these AWT Dialog tests: java/awt/Dialog/ModalDialogTest.java java/awt/Dialog/DialogModalityTest.java java/awt/Dialog/DialogResizeTest2.java java/awt/Dialog/HideDialogTest.java java/awt/Dialog/FileDialogUserFilterTest.java - Commit messages: - Update ProblemList - Open S

Re: RFR: 8340193: Open source several AWT Dialog tests - Batch 1 [v2]

2024-09-27 Thread Tejesh R
On Fri, 27 Sep 2024 07:43:06 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments updated > > test/jdk/java/awt/Dialog/DialogResizeTest.java line 1

Re: RFR: 8339879: Open some dialog swing tests

2024-09-26 Thread Tejesh R
On Thu, 26 Sep 2024 01:11:03 GMT, Alisen Chung wrote: > First set of dialog swing tests to open during fall 2024 test sprint test/jdk/java/awt/Dialog/DialogInitialResizability.java line 35: > 33: * @summary Checks that with resizable set to false before show() > 34: * dialog can not

Re: RFR: 8340605: Open source several AWT PopupMenu tests [v2]

2024-09-25 Thread Tejesh R
On Wed, 25 Sep 2024 07:42:03 GMT, Abhishek Kumar wrote: >> Several AWT PopupMEnu related tests are converted from applet to manual and >> moved to open. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > remove blank line

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v5]

2024-09-25 Thread Tejesh R
st.java > java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java Tejesh R has updated the pull request incrementally with one additional commit since the last revision: ProblemList updated - Changes: - all: https://git.openjdk.org/jdk/pull/21126/files - new: https://git.openj

Re: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v4]

2024-09-25 Thread Tejesh R
> Open source these AWT Mouse tests: > > java/awt/Mouse/MouseEnterExitTest.java > java/awt/Mouse/MouseEnterExitTest2.java > java/awt/Mouse/MousePressedTest.java > java/awt/Mouse/MouseEnterExitTest4.java > java/awt/Mouse/MouseEnterExitTest3.java Tejesh R has updated the pull

Re: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v3]

2024-09-25 Thread Tejesh R
> Open source these AWT Mouse tests: > > java/awt/Mouse/MouseEnterExitTest.java > java/awt/Mouse/MouseEnterExitTest2.java > java/awt/Mouse/MousePressedTest.java > java/awt/Mouse/MouseEnterExitTest4.java > java/awt/Mouse/MouseEnterExitTest3.java Tejesh R has updated the pull

Re: RFR: 8340605: Open source several AWT PopupMenu tests

2024-09-25 Thread Tejesh R
On Tue, 24 Sep 2024 07:46:14 GMT, Abhishek Kumar wrote: > Several AWT PopupMEnu related tests are converted from applet to manual and > moved to open. test/jdk/java/awt/PopupMenu/PopupLeadingSeparatorTest.java line 48: > 46: Press mouse button on the frame. Popup menu without

RFR: 8340193: Open source several AWT Dialog tests - Batch 1

2024-09-25 Thread Tejesh R
Open source these AWT Mouse tests: java/awt/Dialog/FileDialogIconTest/FileDialogIconTest.java java/awt/Dialog/FileDialogWrongNameCrash.java java/awt/Dialog/DialogResizeTest.java java/awt/Dialog/GetLocationTest_1.java java/awt/Dialog/DialogIconTest/DialogIconTest.java - Commit message

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v3]

2024-09-23 Thread Tejesh R
On Tue, 24 Sep 2024 05:49:39 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments updated > > test/jdk/java/awt/Mouse/MouseDragEnterExitTest.

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v4]

2024-09-23 Thread Tejesh R
st.java > java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Review comments updated - Changes: - all: https://git.openjdk.org/jdk/pull/21126/files - new: https://git

Re: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v2]

2024-09-23 Thread Tejesh R
On Mon, 23 Sep 2024 20:49:54 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> MouseEnterExitTest converted to automated > > test/jdk/java/awt/Mouse/MouseEnterExitTest.java

Re: RFR: 8339836: Open source several AWT Mouse tests - Batch 1 [v2]

2024-09-23 Thread Tejesh R
> Open source these AWT Mouse tests: > > java/awt/Mouse/MouseEnterExitTest.java > java/awt/Mouse/MouseEnterExitTest2.java > java/awt/Mouse/MousePressedTest.java > java/awt/Mouse/MouseEnterExitTest4.java > java/awt/Mouse/MouseEnterExitTest3.java Tejesh R has updated the pull

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v3]

2024-09-23 Thread Tejesh R
st.java > java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Review comments updated - Changes: - all: https://git.openjdk.org/jdk/pull/21126/files - new: https://git

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v3]

2024-09-23 Thread Tejesh R
On Tue, 24 Sep 2024 02:27:07 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments updated > > test/jdk/java/awt/Mouse/MouseDragEnterExitTest.

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v2]

2024-09-23 Thread Tejesh R
On Tue, 24 Sep 2024 02:20:03 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Renamed OpenWinDoubleClickTest to DoubleClickTest >> - jtreg updates > > t

Re: RFR: 8339982: Open source several AWT Mouse tests - Batch 2 [v2]

2024-09-23 Thread Tejesh R
st.java > java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java Tejesh R has updated the pull request incrementally with two additional commits since the last revision: - Renamed OpenWinDoubleClickTest to DoubleClickTest - jtreg updates - Changes: - all: https://git.openjdk.org

RFR: 8339982: Open source several AWT Mouse tests - Batch 2

2024-09-22 Thread Tejesh R
Open source these AWT Mouse and GraphicsEnvironment tests: java/awt/MouseClickCount/MouseClickCount.java java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java java/awt/MouseDragTest/MouseDragTest.java java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java java/awt/GraphicsEnvironment/De

RFR: 8339836: Open source several AWT Mouse tests - Batch 1

2024-09-22 Thread Tejesh R
Open source these AWT Mouse tests: java/awt/Mouse/MouseEnterExitTest.java java/awt/Mouse/MouseEnterExitTest2.java java/awt/Mouse/MousePressedTest.java java/awt/Mouse/MouseEnterExitTest4.java java/awt/Mouse/MouseEnterExitTest3.java - Commit messages: - jtreg updates - Open Source fe

Re: RFR: 8326027: [TEST_BUG]Comparing buffered images of white background frame fails in Mac

2024-09-16 Thread Tejesh R
On Mon, 9 Sep 2024 18:45:45 GMT, Alexey Ivanov wrote: > > > This is why I asked the question: does the comparison remain accurate > > > without the need for tolerance if you use > > > `Robot.createMultiResolutionScreenCapture` and use the highest resolution > > > from the returned multi-resolu

Integrated: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine

2024-09-08 Thread Tejesh R
On Tue, 27 Aug 2024 06:04:47 GMT, Tejesh R wrote: > Test failed intermittently on particular host. Though analysis pointed out to > a test frame at left top on that host, I've updated the test for further > stabilizing it. Two things done here: > 1. Move the frame to cen

Re: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser [v4]

2024-09-08 Thread Tejesh R
On Fri, 6 Sep 2024 11:37:10 GMT, Abhishek Kumar wrote: >> There is no Swatches tab available for GTK Look and Feel due to the >> different ColorChooser UI design. Updated the test instructions. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser [v2]

2024-09-06 Thread Tejesh R
On Fri, 6 Sep 2024 07:09:12 GMT, Abhishek Kumar wrote: >> There is no Swatches tab available for GTK Look and Feel due to the >> different ColorChooser UI design. Updated the test instructions. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine [v7]

2024-09-05 Thread Tejesh R
tolerance checks for color comparison - this is based on analysis > reports where the image didn't had exact black color which is supposed to be. > So like other test cases, providing some tolerance for comparison. Tejesh R has updated the pull request incrementally with one additional

Re: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine [v6]

2024-09-05 Thread Tejesh R
tolerance checks for color comparison - this is based on analysis > reports where the image didn't had exact black color which is supposed to be. > So like other test cases, providing some tolerance for comparison. Tejesh R has updated the pull request incrementally with one additional

Re: RFR: 8339524: Clean up ExtendedRobot tests

2024-09-05 Thread Tejesh R
On Wed, 4 Sep 2024 03:34:34 GMT, Alisen Chung wrote: > Cleaning up tests building ExtendedRobot that shouldn't be. test/jdk/java/awt/Robot/ModifierRobotKey/ModifierRobotEnhancedKeyTest.java line 158: > 156: > 157: public void doTest() throws Exception { > 158: robot = new Extended

Re: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine [v5]

2024-09-05 Thread Tejesh R
tolerance checks for color comparison - this is based on analysis > reports where the image didn't had exact black color which is supposed to be. > So like other test cases, providing some tolerance for comparison. Tejesh R has updated the pull request incrementally with one additional

Re: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine [v4]

2024-09-05 Thread Tejesh R
On Thu, 5 Sep 2024 10:00:44 GMT, Abhishek Kumar wrote: > > It's used inside `EventQueue`, then have to covert to atomic. Better to > > retain as it is. > > I guess only `Point point = checkbox.getLocationOnScreen();` should be enough > to access on EDT, rest of the code can be executed on main

Re: RFR: 8338153: java/awt/Checkbox/CheckboxCheckerScalingTest.java test failed on linux machine [v4]

2024-09-05 Thread Tejesh R
On Thu, 5 Sep 2024 09:29:11 GMT, Abhishek Kumar wrote: > `private static BufferedImage imageAfterChecked;` can be move inside main > method. It's used inside `EventQueue`, then have to covert to atomic. Better to retain as it is. - PR Comment: https://git.openjdk.org/jdk/pull/207

  1   2   3   4   5   6   7   8   9   10   >