Re: RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-11-10 Thread Vladimir Kempik
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote: > Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused > parameter warnings: > > Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s) Well, you can just use --disable-warnings-as-errors configure

Re: RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-10-21 Thread Vladimir Kempik
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote: > Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused > parameter warnings: > > Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s) Hello, a jbs bug needs to be created first, let me create one

Re: [jdk19] RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-08 Thread Vladimir Kempik
On Fri, 8 Jul 2022 17:28:32 GMT, Vladimir Kempik wrote: > Clean backport to jdk19 Sorry. that wasn't clear from the jep text: https://openjdk.org/jeps/3 If the bug is current then develop a fix and either **integrate it when ready (in RDP 1)** or request approval to integrate it via the [

[jdk19] Integrated: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-08 Thread Vladimir Kempik
On Fri, 8 Jul 2022 17:28:32 GMT, Vladimir Kempik wrote: > Clean backport to jdk19 This pull request has now been integrated. Changeset: c142fbbb Author: Vladimir Kempik URL: https://git.openjdk.org/jdk19/commit/c142fbbbafcaa728cbdc56467c641eeed511f161 Stats: 12 lines in 1 f

[jdk19] RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-08 Thread Vladimir Kempik
Clean backport to jdk19 - Commit messages: - Backport d852e99ae9de4c611438c50ce37ea1806f58cbdf Changes: https://git.openjdk.org/jdk19/pull/125/files Webrev: https://webrevs.openjdk.org/?repo=jdk19=125=00 Issue: https://bugs.openjdk.org/browse/JDK-8289697 Stats: 12 lines in 1

Re: [jdk19] RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-08 Thread Vladimir Kempik
On Fri, 8 Jul 2022 17:28:32 GMT, Vladimir Kempik wrote: > Clean backport to jdk19 As far as I understand, between rdp1 and rdp2 dates I need no approval for p3 bug - PR: https://git.openjdk.org/jdk19/pull/125

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v7]

2022-07-08 Thread Vladimir Kempik
> Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence of 6 free elements. Vladimir Kempik has u

Integrated: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-08 Thread Vladimir Kempik
On Mon, 4 Jul 2022 15:40:56 GMT, Vladimir Kempik wrote: > Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix chec

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v6]

2022-07-08 Thread Vladimir Kempik
> Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence of 6 free elements. Vladimir Kempik has u

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v5]

2022-07-08 Thread Vladimir Kempik
> Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence of 6 free elements. Vladimir Kempik has u

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v4]

2022-07-07 Thread Vladimir Kempik
On Wed, 6 Jul 2022 20:31:31 GMT, Vladimir Kempik wrote: >> Please review this simple patch. When running idea on jdk17 with asan I have >> found this buffer overflow. >> The code checks the cache for at least one free element, while placing 6 >> elements to the

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v4]

2022-07-07 Thread Vladimir Kempik
> Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence of 6 free elements. Vladimir Kempik has u

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v3]

2022-07-06 Thread Vladimir Kempik
> Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence of 6 free elements. Vladimir Kempik has u

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v2]

2022-07-05 Thread Vladimir Kempik
On Tue, 5 Jul 2022 19:01:41 GMT, Phil Race wrote: > Are there any other cases like this ? We should look around. (PS I see Ajit > asked the same question and perhaps even answered it !) Did you find this by > inspection or did you hit it ? I hit this bug when running IDEA on asan-enabled

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v2]

2022-07-05 Thread Vladimir Kempik
> Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence of 6 free elements. Vladimir Kempik has u

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-05 Thread Vladimir Kempik
On Mon, 4 Jul 2022 15:40:56 GMT, Vladimir Kempik wrote: > Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix chec

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-05 Thread Vladimir Kempik
On Mon, 4 Jul 2022 15:40:56 GMT, Vladimir Kempik wrote: > Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix chec

RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-04 Thread Vladimir Kempik
Please review this simple patch. When running idea on jdk17 with asan I have found this buffer overflow. The code checks the cache for at least one free element, while placing 6 elements to the cache. The fix checks the presence of 6 free elements. - Commit messages: - 8289697: