On Wed, 8 Mar 2023 18:20:47 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.o
On Sat, 29 Apr 2023 08:29:39 GMT, Alexander Zuev wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
>> of security concerns. The issue was addressed in
>> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-829
On Fri, 7 Apr 2023 05:45:05 GMT, Phil Race wrote:
> how did you test it ?
The existing regression tests will be used for the testing. I will ask for a
Mach5 testing if approved. Hopefully, the current regression test coverage is
sufficient. I have no plan to add new test cases.
On Wed, 8 Mar 2023 18:20:47 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.o
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of
security concerns. The issue was addressed in
[JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
failure, and
[JDK-8299378](https://bugs.openjdk.org/browse
On Tue, 14 Feb 2023 20:41:39 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue
> was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)
> for
On Thu, 16 Feb 2023 21:46:19 GMT, Phil Race wrote:
> This is a fairly extensive set of changes so I'll contact you off-line to
> make sure you have done adequate testing.
Thank you for your looking into the issue.
I'm new to java.desktop. Exception the regression tests, what else should I
ru
k.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635)/[JDK-8301132](https://bugs.openjdk.org/browse/JDK-8301132)
> for testing issues . This is a break-down update for sprintf uses in
> java.desktop components.
>
> Thanks,
> Xuelei
Xue-Lei
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14 because of security concerns. The issue
was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for
building failure, and
[JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](http
On Tue, 27 Dec 2022 14:40:36 GMT, Christoph wrote:
> ERROR: Build failed for target 'run-test-tier1' in configuration
> 'macosx-aarch64-server-release' (exit code 2)
>
[JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) was filled to track
the issue. Thanks!
-
PR: https:
On Fri, 11 Nov 2022 22:41:19 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14 because of security concerns, and the
> use of it causing building failure. The build could pass if warnings are
> disabl
On Thu, 8 Dec 2022 17:19:56 GMT, Kim Barrett wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update on review feedback
>
> src/hotspot/share/adlc/formssel.cpp line 28:
>
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brou
On Wed, 7 Dec 2022 21:25:11 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warn
On Wed, 7 Dec 2022 08:46:45 GMT, Thomas Stuefe wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comment for snprintf_checked
>
> src/hotspot/share/adlc/output_c.cpp line 46:
&
On Wed, 7 Dec 2022 16:00:04 GMT, Laurent Bourgès wrote:
>> src/hotspot/os/bsd/attachListener_bsd.cpp line 260:
>>
>>> 258: // name ("load", "datadump", ...), and is an argument
>>> 259: int expected_str_count = 2 + AttachOperation::arg_count_max;
>>> 260: const int max_len = (ver_str_len
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
update on review feedback
--
On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warn
On Tue, 29 Nov 2022 07:57:36 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warn
On Sun, 27 Nov 2022 07:57:46 GMT, Thomas Stuefe wrote:
> How about renaming the existing os::snprintf to something like
> os::snprintf_unchecked, make os::snprintf the checked version, ...
The name `snprintf` may implies the function in C. For that purpose, I may use
a name different from`snp
On Sun, 27 Nov 2022 07:57:46 GMT, Thomas Stuefe wrote:
> Given all the near-duplicated checking of os::snprintf results, I think there
> is a place for a helper function to package this up.
Thank you for the suggestion. Updated to use snprintf_checked.
-
PR: https://git.openjdk.
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
comment for snprintf_checked
--
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
use checked snprintf for adlc
--
On Mon, 28 Nov 2022 07:48:23 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warn
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
use checked snprintf
-
Chang
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
no check on adlc
-
Changes:
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
revert use of assert
-
Chang
On Sun, 13 Nov 2022 20:48:04 GMT, Kim Barrett wrote:
>> Hi,
>>
>> May I have this update reviewed?
>>
>> The sprintf is deprecated in Xcode 14 because of security concerns, and the
>> use of it causing building failure. The build could pass if warnings are
>> disabled for codes that use spri
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
extra sizeof typo
-
Changes:
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
more size_t updare for windows build
--
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
fix size_t cast warning on windows
--
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
size_t cast
-
Changes:
- a
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
assert os::snprintf return value
--
On Tue, 15 Nov 2022 05:52:18 GMT, Thomas Stuefe wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> delete swp file
>
> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 226:
>
On Wed, 16 Nov 2022 04:55:17 GMT, Kim Barrett wrote:
>> The problem with using the return value of os::snprintf() is that we need to
>> handle the -1 case to prevent the position from running backward. Might be
>> better to use stringStream instead, which should handle the -1 case
>> transpare
On Tue, 15 Nov 2022 07:04:38 GMT, Kim Barrett wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> delete swp file
>
> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 226:
>
On Mon, 14 Nov 2022 16:53:07 GMT, Lutz Schmidt wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> include missing os head file
>
> src/hotspot/share/adlc/output_c.cpp line 5
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
address review comments
--
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
delete swp file
-
Changes:
On Mon, 14 Nov 2022 10:21:07 GMT, Thomas Stuefe wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> include missing os head file
>
> src/hotspot/share/adlc/output_c.cpp line
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
use helper macro
-
Changes:
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
include missing os head file
--
On Fri, 11 Nov 2022 22:41:19 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14 because of security concerns, and the
> use of it causing building failure. The build could pass if warnings are
> disabl
On Mon, 14 Nov 2022 01:51:32 GMT, David Holmes wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - use os::snprintf for desktop update
>> - use os::snprintf
>
> src/
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
revert update for desktop
--
On Sun, 13 Nov 2022 20:48:04 GMT, Kim Barrett wrote:
> Please don't add uses of `jio_snprintf` or `::snprintf` to hotspot. Use
> `os::snprintf`.
Updated to use os::snprintf, except the files under adlc where the os::snptintf
definition is not included. The use of snprintf could be cleaned up
e sprintf
> could be replaced with snprintf. This patch is trying to check if snprintf
> could be used.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with two
additional commits since the last revision:
- use os::snprintf fo
On Sun, 13 Nov 2022 07:50:43 GMT, Thomas Stuefe wrote:
> could you use `jio_snprintf` instead (see include/jvm_io.h)? That is what we
> usually do for snprintf. jio_snprintf hides platform particularities wrt
> snprintf.
>
Good to know that. Thank you!
While I was doing the replacement from
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14 because of security concerns, and the use
of it causing building failure. The build could pass if warnings are disabled
for codes that use sprintf method. For the long run, the sprintf could be
replaced with snprintf.
On Wed, 26 Oct 2022 17:24:59 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/URL.java line 852:
>>
>>> 850: * @since 20
>>> 851: */
>>> 852: public static URL fromURI(URI uri, URLStreamHandler streamHandler)
>>
>> What do you think to have this method in URI inste
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote:
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
> to parse or construct any URL.
>
> The `java.net.URL` class does not itself encode or decode any URL components
> according to the escaping mechanism defined in
51 matches
Mail list logo
