Re: RFR: 8337851: Some tests have name which confuse jtreg [v3]

2024-10-14 Thread duke
On Mon, 19 Aug 2024 01:28:20 GMT, toshiogata wrote: >> Rename the tests to prevent unexpected deletion of result files when >> `-retain` jtreg option is specified. >> Testing: modified tests > > toshiogata has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8339974: Graphics2D.drawString doesn't always work with Font derived from AffineTransform [v5]

2024-10-10 Thread duke
On Tue, 8 Oct 2024 17:41:31 GMT, Daniel Gredler wrote: >> There is a bug in `TextLayout.getOutline(AffineTransform)`, where the >> transformation is applied too early (before the layout path applies its >> mapping). The most obvious error caused by this bug is that >> `Graphics2D.drawString(..

Re: RFR: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos [v2]

2024-10-02 Thread duke
On Wed, 2 Oct 2024 08:31:13 GMT, Manukumar V S wrote: >> javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails >> sometimes in macos. >> This could be because of a synchronisation issue in the test. >> >> Fix: I have refactored the test to have a CountDownLatch to monitor the >>

Re: RFR: 8333403: Write a test to check various components events are triggered properly [v11]

2024-09-23 Thread duke
On Mon, 23 Sep 2024 04:19:20 GMT, Ravi Gupta wrote: >> This testcase checks for the following assertions for Component events: >> >> 1. When components are resized, moved, hidden and shown the respective >> events are triggered. >> 2. When the components are hidden/disabled also,the component e

Re: RFR: 8339845: Update color.org and wapforum.org links to use HTTPS instead of HTTP

2024-09-17 Thread duke
On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla wrote: > Can I get a review for this doc-only change? I updated some links because the > websites moved from HTTP to HTTPS. The redirects can cause some > false-positives on tests. > > TIA @nizarbenalla Your change (at version 06086104bf40bb76b

Re: RFR: 8339943: Frame not disposed in java/awt/dnd/DropActionChangeTest.java [v3]

2024-09-13 Thread duke
On Thu, 12 Sep 2024 17:00:18 GMT, Manukumar V S wrote: >> Stabilized the test by disposing the frame at the end, adding an auto delay, >> called panel.getLocationOnScreen() in invokeAndWait(), formatting changes, >> etc >> And for better debugging, added captureScreen() for failure cases. >>

Withdrawn: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show

2024-09-04 Thread duke
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote: > This is somewhat a continuation for > [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and > [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509). > > The former removed the `doIt` flag in #18584, but it introduced a regr

Re: RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v5]

2024-09-04 Thread duke
On Wed, 4 Sep 2024 17:30:59 GMT, Manukumar V S wrote: >> This is a highly intermittent failure, and it failed only once in CI on a >> particular windows machine and passed on all other runs. >> >> Failure reason: >> When the button was displayed for the first time, the focus rectangle drawn >

Re: RFR: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize [v4]

2024-09-03 Thread duke
On Tue, 3 Sep 2024 18:17:33 GMT, Manukumar V S wrote: >> This is a highly intermittent failure, and it failed only once in CI on a >> particular windows machine and passed on all other runs. >> >> Failure reason: >> When the button was displayed for the first time, the focus rectangle drawn >

Re: RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest [v10]

2024-08-28 Thread duke
On Wed, 28 Aug 2024 09:48:44 GMT, Manukumar V S wrote: >> This PR creates a new test by stabilising and open sourcing a closed test. >> This test verifies that the OpenGL pipeline does not create artifacts with >> swing components after window is zoomed to maximum size and then resized >> back

Withdrawn: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag

2024-08-27 Thread duke
On Thu, 17 Aug 2023 00:16:07 GMT, ScientificWare wrote: > This is referenced in Java Bug Database as > - [JDK-8314731 : Adds support for the alt attribute in the image type input > HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) > > This is tracked in JBS as > - [JDK-83147

Re: RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest [v4]

2024-08-23 Thread duke
On Thu, 22 Aug 2024 18:04:46 GMT, Manukumar V S wrote: >> This PR creates a new test by stabilising and open sourcing a closed test. >> This test verifies that the OpenGL pipeline does not create artifacts with >> swing components after window is zoomed to maximum size and then resized >> back

Withdrawn: 8297191 : [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

2024-08-22 Thread duke
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > This fix will resolve page range not printing proper pages if the rage begin > from 2 or above on Mac machines. > I have verified the manual range related tests like PageRanges.java, > ClippedImages.java

Withdrawn: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled

2024-08-19 Thread duke
On Mon, 8 Apr 2024 06:09:16 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > > Added pageloader cancel before new page creation along with code > restructuring. Moved all page loading calls inside synchronize to make it > thread safe. > > Regards, > Renjith. This pull request has be

Withdrawn: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-08-19 Thread duke
On Tue, 23 Apr 2024 13:56:32 GMT, Julian Waters wrote: > WIP > > This changeset contains hsdis for Windows/gcc Port. It supports both the > binutils and capstone backends, though the LLVM backend is left out due to > compatibility issues encountered during the build. Currently, which gcc > di

Re: RFR: 8290501 : Typo in javax.swing.BoundedRangeModel documentation [v3]

2024-08-18 Thread duke
On Fri, 16 Aug 2024 10:00:22 GMT, Renjith Kannath Pariyangad wrote: >> Documentation updated > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one additional commit since the last revision: > > Updated import @Renjithkannath Your change (at version 097976f04b

Re: RFR: 8337886: java/awt/Frame/MaximizeUndecoratedTest.java fails in OEL due to a slight color difference [v2]

2024-08-16 Thread duke
On Fri, 16 Aug 2024 07:36:01 GMT, Manukumar V S wrote: >> java/awt/Frame/MaximizeUndecoratedTest.java fails in OEL due to a slight >> color difference in the background color. This is currently reproduced only >> for Oracle Linux. >> >> The Color object I'm getting for each of these Point obj

Re: RFR: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java [v2]

2024-08-14 Thread duke
On Wed, 14 Aug 2024 21:36:18 GMT, lawrence.andrews wrote: >> 1) Replaced JApplet with JPanel >> 2) Tests passed before and after fix > > lawrence.andrews has updated the pull request incrementally with one > additional commit since the last revision: > > Removed the JApplet import @lawrence

Withdrawn: 8233177: Remove testcase for JDK-8001470 as fix has been reverted

2024-08-05 Thread duke
On Tue, 23 Jan 2024 08:18:33 GMT, Prasanta Sadhukhan wrote: > Existing regression test is failing because textfield height is not as per > test's expectation..Seems like the indic character being tried to render is > not being loaded (probably because of missing glyphs) leading to 0 > preferr

Re: RFR: 8337681: PNGImageWriter uses much more memory than necessary [v2]

2024-08-03 Thread duke
On Thu, 1 Aug 2024 21:51:04 GMT, Daniel Gredler wrote: >> At some point the `JPEGImageWriter` was optimized to reduce duplication / >> copying of rasters and data buffers (see `JDK-6266748`). However, >> `PNGImageWriter` never received a similar optimization, and is making >> unnecessary copie

Withdrawn: 8315113: Print request Chromaticity.MONOCHROME attribute does not work on macOS

2024-08-01 Thread duke
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy wrote: > The fix provides ability to print Black & White pages on macOS. > > Cocoa API has > [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) > function but it is marked

Withdrawn: 8323965: modify fix for 8317771 to remove reflection instantiation of the inner class

2024-07-19 Thread duke
On Fri, 19 Apr 2024 15:16:41 GMT, Artem Semenov wrote: > I replaced reflection with using an accessor > @azuev-java please review This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/18867

Re: RFR: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ [v2]

2024-07-07 Thread duke
On Fri, 5 Jul 2024 19:02:06 GMT, lawrence.andrews wrote: >> 1) After the fix , I could see the test was launched. > > lawrence.andrews has updated the pull request incrementally with one > additional commit since the last revision: > > updated the copyright @lawrence-andrew Your change (at

Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v4]

2024-07-04 Thread duke
On Wed, 26 Jun 2024 09:52:38 GMT, Nizar Benalla wrote: >> If you're currently reviewing this PR, thank you! >> Most fixes here are according to the reports by the since checker tool in >> #18934 and are pretty simple. >> >> To make reviewing easier >> - `BasicSliderUI` has the constructor `publ

Re: RFR: 8332103: since-checker - Add missing @ since tags to java.desktop [v2]

2024-07-04 Thread duke
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote: >> If you're currently reviewing this PR, thank you! >> Most fixes here are according to the reports by the since checker tool in >> #18934 and are pretty simple. >> >> To make reviewing easier >> - `BasicSliderUI` has the constructor `publ

Withdrawn: JDK-8324169 : Remove macOS from ProblemList for CycleDMIMage.java when fix is available for JDK-8312518

2024-07-03 Thread duke
On Thu, 18 Jan 2024 20:18:20 GMT, Harshitha Onkar wrote: > CycleDMIMage.java passes on macOS after > [JDK-8312518](https://bugs.openjdk.org/browse/JDK-8312518), > [PR#17358](https://github.com/openjdk/jdk/pull/17358). It is de-problemlisted > for macOS only. > > > CI testing looks good. Thi

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2024-06-27 Thread duke
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK

Withdrawn: 8309460: JScrollBar leaves behind clutter for non-integer UI scales

2024-05-08 Thread duke
On Thu, 18 Jan 2024 11:09:12 GMT, Prasanta Sadhukhan wrote: > Lines are left behind when moving the scrollbar in the positive direction. > but are cleaned up on mouse release. > Additonally, with right arrow clicks too, the lines are left behind. > Seems like for mouseDragged and scrollByUnit

Withdrawn: 8325858: Replace Unsafe usage in XEmbeddingContainer with FFM API

2024-05-08 Thread duke
On Wed, 14 Feb 2024 13:27:45 GMT, Per Minborg wrote: > This PR proposes to remove the use of `Unsafe` in the class > `XEmbeddingContainer ` and replace it with the supported FFM API. > > I tried to make this PR as small as possible while opening up for migration > of other classes later on (su

Withdrawn: 8319598: SMFParser misinterprets interrupted running status

2024-02-27 Thread duke
On Tue, 7 Nov 2023 19:18:28 GMT, Jan Trukenmüller wrote: > The MIDI file parser misinterprets events without status byte when they > appear directly after a Meta of SysEx event. > > For my bugfix I had to decide between two possible solutions: > - Strict solution: Throw an InvalidMidiDataExcept

Withdrawn: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea

2024-01-10 Thread duke
On Thu, 16 Mar 2023 06:06:50 GMT, 柳鲲鹏 wrote: > Candidat box can moving with caret on windows version. Someone must wrote > codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. > Why it doesn't work, is the key problem. > > 1, I wrote a example for linux: > https://githu

Withdrawn: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2024-01-10 Thread duke
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad > Th

Withdrawn: 8221452: Window.setMinimumSize does not respect DPI scaling

2023-12-23 Thread duke
On Mon, 8 May 2023 00:49:58 GMT, babblebubble wrote: > Hi, I'm not sure if I did the formatting of this pull request right, new to > this, but the bug was bothering me so I fixed it (took three attempts). > All I had to do was add ScaleUpX and ScaleUpY and it fixed it. > Sorry for being new to G

Withdrawn: 6681958: Maximization state of JInternalFrames is corrupted by WindowsDesktopManager

2023-12-14 Thread duke
On Mon, 9 Oct 2023 05:17:58 GMT, Prasanta Sadhukhan wrote: > Issue is if one internal frame is open and maximized and another internal > frame is created which is initialized with setMaximum(true) then after > opening the second internal frame both internal frames are non-maximized > It can al

Withdrawn: JDK-8302618: [macOS] Problem typing uppercase letters with java.awt.Robot when moving mouse

2023-12-08 Thread duke
On Fri, 30 Jun 2023 22:29:05 GMT, Harshitha Onkar wrote: > **Problem:** > > On macOS, Robot erroneously produces lowercase letter when mouse is moved > (manually) in unison with Robot's keyEvents. This issue was originally logged > by a developer of an on-screen accessibility keyboard - Touch

Withdrawn: 8269806: Emoji rendering on Linux

2023-12-02 Thread duke
On Thu, 15 Jul 2021 17:29:01 GMT, Nikita Gubarkov wrote: > It was implemented in JetBrains Runtime a year ago and was ported & > refactored for this PR > It includes: > - Bitmap glyph loading via Freetype > - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or > bilinear-m

Withdrawn: 8315584 : java/awt/print/Dialog/DialogType.java fails with option not supported: yesno

2023-11-15 Thread duke
On Sun, 3 Sep 2023 22:12:49 GMT, lawrence.andrews wrote: > Test was failing with "test result: Error. Parse Exception: Arguments to > `manual' option not supported: yesno" > Following are fixed > 1) Removed yesno > 2) Used PassFailJFrame manual test framework to show the test instruction & >

Withdrawn: 8302687 Implement interfaces and shared code for announcement feature

2023-10-17 Thread duke
On Mon, 13 Mar 2023 16:46:10 GMT, Artem Semenov wrote: > This enhancement covers basic API and shared code that should be implemented > for the Accessibility Announcement feature. > > CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 > "bugs.openjdk.org") > > @mrserb @prrace @azue

Withdrawn: JDK-8303950: [macos]Translucent Windows Flicker on Repaint

2023-09-15 Thread duke
On Wed, 7 Jun 2023 17:15:50 GMT, Jeremy wrote: > # Problem Summary > > For non-opaque windows, Window#paint calls `gg.fillRect(0, 0, getWidth(), > getHeight())` before `super.paint(g)`. > > This can cause flickering on Mac, and the flickering seems to have gotten > much worse in recent JVMs.

Withdrawn: 8305427: Write a test Check whether focus changes as expected when requestFocus is used to traverse randomly around the window

2023-08-23 Thread duke
On Mon, 3 Apr 2023 10:00:21 GMT, Ravi Gupta wrote: > This testcase Checking whether the Component becoming the Focus Owner and > FocusEvent.FOCUS_GAINED will be received by the Component when the focus is > requested on the component using requestFocus. > > Testing: > Tested using Mach5(20 tim

Withdrawn: 8307325: Verify the focus owner when non focused windows requesting focus

2023-08-23 Thread duke
On Thu, 4 May 2023 05:41:43 GMT, Ravi Gupta wrote: > Write a test Check, when the top level Window is not the focused Window > requesting for focus and becoming the Focus Owner for any Component in that > Window checking the following > > 1.The Component is the Focus Owner and the Window becom

Withdrawn: JDK-8292276 : Add named colors from CSS Color Module Level 4

2023-07-20 Thread duke
On Wed, 10 Aug 2022 20:00:29 GMT, ScientificWare wrote: > This is referenced in Java Bug Database as > - [JDK-8292276 : Add named colors from CSS Color Module Level > 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) > > This is tracked in JBS as > - [JDK-8292276 : Add named col

Withdrawn: JDK-8293776 : Adds CSS 4 and 8 digits hex coded Color

2023-07-20 Thread duke
On Fri, 16 Sep 2022 23:16:19 GMT, ScientificWare wrote: > This is referenced in Java Bug Database as > - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded > Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776) > > This is tracked in JBS as > - [JDK-8293776 : Adds CSS 4 and 8 dig

Withdrawn: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-07-06 Thread duke
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Withdrawn: JDK-8302281 - ImageReader and ImageWrite should implement Closable

2023-06-10 Thread duke
On Thu, 19 Jan 2023 18:41:08 GMT, Markus KARG wrote: > The fact that there is a `dispose()` method to be called is easily missed, as > people tend to look for a method called `close()`, or assume that resources > only need to get closed when they support try-with-resource. As a result, > there

Withdrawn: JDK-8303950: [macos]Translucent Windows Flicker on Repaint

2023-06-06 Thread duke
On Sun, 12 Mar 2023 17:35:40 GMT, Jeremy wrote: > I'm confident about the new test case for this ticket, but the resolution is > more invasive than I'd like. (It works, though.) > > In short: > This introduces a new RenderingHint (in SunHints) to bypass the call in > Window to `gg2d.fillRect(0

Withdrawn: 8303904: Transparent Windows Paint Wrong (Opaque) w/o Volatile Buffering

2023-06-06 Thread duke
On Mon, 27 Mar 2023 21:45:08 GMT, Jeremy wrote: > The original write-up contains two complaints: > 1. The window is opaque, so pixels that should be transparent are black. > 2. The window is the wrong resolution. On a 200% resolution monitor it > renders as if it were 100% (so it looks pixelated

Withdrawn: 8305321: Remove unused exports in java.desktop

2023-06-05 Thread duke
On Fri, 31 Mar 2023 07:34:50 GMT, Daniel Jeliński wrote: > Please review this patch that removes a number of unused exports from > java.desktop native libraries. > > In most cases I removed JNIEXPORT from methods and variables that are only > used within a single shared library. Other than tha

Withdrawn: 8304947: Unnecessary Vector usage in java.awt.MenuBar.shortcuts

2023-06-02 Thread duke
On Wed, 22 Mar 2023 19:12:34 GMT, Andrey Turbanov wrote: > Method `'java.awt.MenuBar#shortcuts` creates a 'Vector', fills > it and then returns its 'Enumeration elements()' as return value. > Instead of usage of legacy synchronized Vector here we can use ArrayList > instead. Wrap it in Collecti

Withdrawn: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11

2023-05-11 Thread duke
On Tue, 20 Dec 2022 23:25:30 GMT, Harshitha Onkar wrote: > ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added > robot.setAutoWaitForIdle() to ViewportOverlapping and its base class > (OverlappingTestBase) to stabilize the test. > > Additionally added awt & swings tes

Withdrawn: JDK-8266245: AWT Test FullScreenInsets.java fails due to incorrect pixel color and wrong window bounds

2023-05-01 Thread duke
On Thu, 1 Dec 2022 18:03:42 GMT, Harshitha Onkar wrote: > The above test was failing due to incorrect pixel color and wrong window > bounds on Mac-ARM, Windows and Linux platforms. > > The following changes have been made: > - Correct window bounds are obtained using the current ScreenDevice's

Withdrawn: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64

2023-05-01 Thread duke
On Mon, 27 Feb 2023 11:49:27 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under

Withdrawn: 8278620: properties installed by javax.swing.LookAndFeel installColors and installColorsAndFont are not uninstalled

2023-04-25 Thread duke
On Tue, 4 Oct 2022 22:52:30 GMT, SWinxy wrote: > Many `installDefaults` methods set the font, foreground, and background on > objects but their inverse methods `uninstallDefaults` do not remove them. > I've added an inverse method to remove the colors and font to call for the > `uninstallDefau

Withdrawn: 8299333: Unify exceptions used by all variants of ICC_Profile.getInstance(null)

2023-03-23 Thread duke
On Fri, 23 Dec 2022 23:32:45 GMT, Sergey Bylokhov wrote: > I tried to clean up the documentation in the `java.awt.color` package and > specify how the `null` parameters are handled here and there. But it looks > like the `ICC_profile` class is too specific so I would like to discuss it > separ

Withdrawn: 8282217: Key events (key char and key code) changed for Swiss keyboard

2023-03-21 Thread duke
On Fri, 6 Jan 2023 22:07:33 GMT, Alisen Chung wrote: > Removed check for MapVirtualKeyEx return value causing some keys to become > undefined This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/11887

Withdrawn: 7131166: SynthListUI / SynthInternalFrameTitlePane updateStyle() ignores method argument

2023-03-20 Thread duke
On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan wrote: > It seems Synth has two cases of updateStyle() where its argument is not > passed to the getContext() call. It seems to be an oversight as in other > Synth classes, the component argument passed to updateStyle is being passed > to ge

Withdrawn: 4365952: Cannot disable JFileChooser

2023-03-17 Thread duke
On Wed, 7 Dec 2022 05:48:57 GMT, Tejesh R wrote: > Disable functionality not working for JFileChooser. `public void > setEnabled(boolean enabled)` functionality is overridden in JFileChooser > class which enable/disable each sub-component of FileChooser. > The added functionality is tested in

Withdrawn: 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

2023-03-14 Thread duke
On Mon, 21 Nov 2022 14:32:50 GMT, Christian Heilmann wrote: > 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS > leads to not print This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/11266

Withdrawn: 8294807: Fix typos and clarify javadoc for SunToolKit.realsSync

2023-03-13 Thread duke
On Tue, 4 Oct 2022 20:21:10 GMT, Alexey Ivanov wrote: > I fixed the typo “serie” → "series" which was highlighted by a spellchecker. > > I also simplified the description, fixed the grammar, added `{@code}` around > types, added link to `requestFocus` in the example. This pull request has been

Withdrawn: 8295707: Create a regression test for JDK-7184401

2023-02-15 Thread duke
On Thu, 20 Oct 2022 08:59:20 GMT, Srinivas Mandalika wrote: > 8295707: Create a regression test for JDK-7184401 > > JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for 7162144 > Above bug got introduced due to a fix for > [JDK-7162144](https://bugs.openjdk.java.net/browse/JD

Withdrawn: 8298352: apple.laf.JRSUIUtils class creates many indirections

2023-02-07 Thread duke
On Sun, 18 Sep 2022 21:23:12 GMT, SWinxy wrote: > `JRSUIUtils.java` structurally does things weirdly. The utility class mostly > passes parameters from functions to other functions. The indirection makes > things harder to understand the eventual purpose. > > Take `AquaInternalFrameBorderMetri

Withdrawn: 8298006: Build failure by maybe-uninitialized error on Linux s390x GCC8

2023-02-01 Thread duke
On Fri, 2 Dec 2022 08:41:18 GMT, Ichiroh Takiguchi wrote: > I changed GCC toolchain from GCC6 to GCC8 on SLES12SP5 Linux s390x. > I could see following errors: > > src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c: In > function 'allocateRasterArray': > src/java.desktop/share/

Withdrawn: 8298042: Fix hidden but significant trailing whitespace in properties files for client code

2023-01-27 Thread duke
On Fri, 2 Dec 2022 16:38:54 GMT, Magnus Ihse Bursie wrote: > According to [the > specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) > trailing whitespaces in the values of properties files are (somewhat > surprisingly) ac

Withdrawn: 8296546: Add @spec tags to API

2023-01-27 Thread duke
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote: > Please review a "somewhat automated" change to insert `@spec` tags into doc > comments, as appropriate, to leverage the recent new javadoc feature to > generate a new page listing the references to all external specifications > listed

Withdrawn: 8295248: JEditorPane HTML form with multi-selection broke data after resetting

2023-01-24 Thread duke
On Thu, 13 Oct 2022 01:48:45 GMT, Toshio Nakamura wrote: > When JEditorPane shown HTML form with multi-selection, the reset operation > broke its data. > > The sample testcase were attached in JBS. The recreate steps are below: > 1. The sample shows a multi-selection form with 5 items. > 2. Sel

Withdrawn: 8296535: Unnecessary Vector usage in AquaFileSystemModel.FilesLoader

2023-01-03 Thread duke
On Wed, 2 Nov 2022 08:19:41 GMT, Andrey Turbanov wrote: > Couple of local variables in > `com.apple.laf.AquaFileSystemModel.FilesLoader#run` are used only within the > method from single thread. So we can avoid usage of legacy synchronized > `Vector` here and use `ArrayList` instead. This pul

Withdrawn: JDK-4305789: BasicToolBarUI: Request conversion of private instance variable

2022-12-30 Thread duke
On Fri, 16 Sep 2022 13:47:41 GMT, aLiEnHeAd13 wrote: > Fixed Bug JDK-4305789 to support docking to any instantiated JFrame > https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4305789 This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/p

Withdrawn: 5080391: ArrayIndexOutOfBounds during "undo" of Right-to-Left text insert

2022-12-15 Thread duke
On Tue, 27 Sep 2022 11:16:36 GMT, Prasanta Sadhukhan wrote: > javax.swing.text.AbstractDocument$BranchElement.replace(...) method throws an > `ArrayIndexOutOfBoundsException: arraycopy: length -1 is negative` when using > an UndoManager on the default document of a JTextArea and you try to und

Withdrawn: 7175396: The text on label is not painted red for Nimbus LaF.

2022-12-07 Thread duke
On Wed, 17 Aug 2022 10:46:07 GMT, Prasanta Sadhukhan wrote: > Label.foreground UIProperty is not honored by Nimbus L&F. > Added support for setting JLabel foreground color for Nimbus L&F This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/

Withdrawn: 8292588: [macos] Multiscreen/MultiScreenLocationTest/MultiScreenLocationTest.java: Robot.mouseMove test failed on Screen #0

2022-12-06 Thread duke
On Tue, 20 Sep 2022 18:24:26 GMT, Alisen Chung wrote: > Fixed test bug where mouse location was being calculated before robot > mouseMove operation was complete This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/10363

Withdrawn: 8289539: The color returned by CheckBox.interiorBackground is incorrect

2022-11-30 Thread duke
On Thu, 22 Sep 2022 06:59:59 GMT, Tejesh R wrote: > The color returned for `InteriorBackground` property is the default color > used for only _WindowsClassicLookAndFeel_. For _WindowsLookAndFeel_ the > `InteriorBackground` color is not been used when checkbox paint happens. In > _WindowsLookAn

Withdrawn: 4668290: unclear spec for Polygon.bounds field

2022-11-25 Thread duke
On Mon, 26 Sep 2022 02:27:53 GMT, SWinxy wrote: > New documentation replaces the `This value can be null.`: > > When created, {@link #invalidate() invalidated}, or {@link #reset() reset}, > this becomes {@code null}. To get out of the null state, > {@link #getBounds()} called with {@link #npoint

Withdrawn: 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor

2022-11-25 Thread duke
On Mon, 26 Sep 2022 02:49:36 GMT, SWinxy wrote: > Appends: `, copying the array contents of {@code xpoints} and {@code > ypoints}` to specify that the arrays in the constructor are explicitly copied. This pull request has been closed without being integrated. - PR: https://git.ope

Withdrawn: 8293478: [java.desktop/macOS] Condense SDRenderType usages in QuartzRenderer.m

2022-11-20 Thread duke
On Mon, 5 Sep 2022 23:41:40 GMT, SWinxy wrote: > The `SDRenderType` enum is often returned using a variable declared at the > start of functions. These can be inlined in the `return` itself. Using a > ternary operator condenses what may be 12 lines into one, in the most extreme > cases. `doRec

Withdrawn: 8292271 : Fix java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java test

2022-11-04 Thread duke
On Fri, 12 Aug 2022 17:00:25 GMT, lawrence.andrews wrote: > 1) This test was failing due to yesno > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > 2) PrintCheckboxManualTest.html file was missing > 3) Added os.family since test instruction says that

Withdrawn: 8288428: javax/swing/JInternalFrame/Test6505027.java fails frequently in MacOS 12 machines

2022-10-09 Thread duke
On Fri, 17 Jun 2022 14:28:15 GMT, Manukumar V S wrote: > javax/swing/JInternalFrame/Test6505027.java seems to be unstable in MacOS > machines, especially in MacOSX 12 machines and it fails intermittently in CI > causing some noise. > It seems to be a testbug as adding some stability improvement

Withdrawn: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

2022-10-07 Thread duke
On Thu, 16 Jun 2022 15:01:12 GMT, Manukumar V S wrote: > java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS > machines, especially in MacOSX 12 machines. It seems to be a testbug as > adding some stability improvements fix the issue. It intermittently fails in > CI causing

Withdrawn: 8282578: AIOOBE in javax.sound.sampled.Clip

2022-09-08 Thread duke
On Fri, 3 Jun 2022 15:43:39 GMT, Alexander Zuev wrote: > Add try/catch clause to ignore an exception since it is harmless for we > isolated > the massge data before passing it ro processor. > Add test case. This pull request has been closed without being integrated. - PR: https://

Withdrawn: 8285149: Using HashMap.newHashMap to replace new HashMap(int)

2022-08-03 Thread duke
On Tue, 19 Apr 2022 17:44:10 GMT, XenoAmess wrote: > These are the changes that too many to be reviewed in 8186958, thus split > some of them out. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/8301

Withdrawn: 7080150: [TEST_BUG][macosx] No mac os x EmbeddedFrame support in regression regtesthelpers

2022-07-19 Thread duke
On Thu, 21 Apr 2022 19:47:32 GMT, Alisen Chung wrote: > added EmbeddedFrame support for macosx in regtesthelpers This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/8348

Withdrawn: 8185261: Font fallback sometimes doesn't work in Swing text components

2022-07-11 Thread duke
On Tue, 1 Feb 2022 18:38:39 GMT, Dmitry Batrak wrote: > The proposed fix makes fonts with and without fallback components > distinguishable (in terms of `equals` method), so that > font metrics cache (and other similar code) can handle them separately. This > is achieved by adding a new boolean