Re: RFR: 8368357: Some source files have initial blank lines

2025-09-26 Thread duke
On Thu, 25 Sep 2025 13:44:13 GMT, Francesco Andreuzzi wrote: > Removing some spurious blank lines at the beginning of the file. Looks > trivial to me. @fandreuz Your change (at version 8a753ce5c03817bd5a007f0cb660fb45d77b6c5b) is now ready to be sponsored by a Committer. - PR C

Re: RFR: 8365379: SU3.applyInsets may produce wrong results [v15]

2025-09-19 Thread duke
On Thu, 18 Sep 2025 06:45:02 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the insets calculation, similar calculation observed in >> **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified >> code >> >> Please review and let me know your sugg

Re: RFR: 8365379: SU3.applyInsets may produce wrong results [v15]

2025-09-18 Thread duke
On Thu, 18 Sep 2025 06:45:02 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the insets calculation, similar calculation observed in >> **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified >> code >> >> Please review and let me know your sugg

Re: RFR: 8339791: Refactor MiscUndecorated/ActiveAWTWindowTest.java [v6]

2025-09-15 Thread duke
On Mon, 15 Sep 2025 07:46:39 GMT, Srinivas Mandalika wrote: >> The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object >> monitors and wait/notify to synchronise actions in the test. >> >> Using CountDownLatch could make the test simpler, shorter, clearer. >> Tested the co

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v12]

2025-09-13 Thread duke
On Thu, 11 Sep 2025 05:00:38 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK

Re: RFR: 8366764: Deproblemlist java/awt/ScrollPane/ScrollPositionTest.java

2025-09-09 Thread duke
On Fri, 5 Sep 2025 05:59:21 GMT, Disha Morye wrote: > The test is open sourced and is passing on linux. Hence, it can be removed > from the Problem List. @disha-morye Your change (at version 9f697c8b1ced41c256bd33f52bdcb2cede2adbf9) is now ready to be sponsored by a Committer. -

Re: RFR: 8366750: Remove test 'java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java' from problemlist [v2]

2025-09-06 Thread duke
On Fri, 5 Sep 2025 05:31:31 GMT, Sarvesh Kumar Jain wrote: >> The test is problem listed with incorrect bug JDK-6849371, >> The bug JDK-6849371 is for a different test and it is closed. >> A new bug has been raised for ChoiceMouseWheelTest.java test failure. > > Sarvesh Kumar Jain has updated the

Re: RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v30]

2025-09-06 Thread duke
On Wed, 3 Sep 2025 09:22:17 GMT, Khalid Boulanouare wrote: >> Many Mixing tests failed because the work around click lands on the >> minimizing area in the window control and causes the tests to fail. >> >> This fix changes the width of base frames which allows most of tests to pass. > > Khalid

Withdrawn: 8357687: Remove unnecessary Map.containsKey from GraphicsEnvironment implementations

2025-08-28 Thread duke
On Sun, 27 Apr 2025 21:04:34 GMT, Andrey Turbanov wrote: > `devices` contains only non-null values. It means instead of separate > `containsKey` call we can just call `HashMap.get` and then compare result > with `null`. This pull request has been closed without being integrated. -

Re: RFR: 8361521 : BogusFocusableWindowState.java fails with StackOverflowError on Linux [v6]

2025-08-28 Thread duke
On Thu, 28 Aug 2025 07:53:29 GMT, Anass Baya wrote: >> **Analysis:** >> The getFocusableWindowState() method is not intended to modify the >> configuration; doing so can cause recursive re-entry on Linux. >> >> **Proposed Fix:** >> We are intentionally overriding getFocusableWindowState() to al

Re: RFR: 8361521 : BogusFocusableWindowState.java fails with StackOverflowError on Linux [v5]

2025-08-25 Thread duke
On Wed, 20 Aug 2025 05:05:20 GMT, Anass Baya wrote: >> **Analysis:** >> The getFocusableWindowState() method is not intended to modify the >> configuration; doing so can cause recursive re-entry on Linux. >> >> **Proposed Fix:** >> We are intentionally overriding getFocusableWindowState() to al

Re: RFR: 8302057: Wrong BeanProperty description for JTable.setShowGrid [v4]

2025-08-25 Thread duke
On Mon, 25 Aug 2025 12:29:41 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Updated the Bean Property description with meaningful string for >> JTable.setShowGrid. >> >> Pleas review and let me know your suggestions if any. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block [v9]

2025-08-25 Thread duke
On Wed, 6 Aug 2025 09:43:48 GMT, Ravi Gupta wrote: >> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java >> left debris on system whenever fails its required frame.dispose() in finally >> block. >> >> >> finally { >> EventQueue.invokeAndWait(ExtraButtonDrag:

Withdrawn: 8352407: PixelInterleavedSampleModel with unused components throws RasterFormatException: Incorrect pixel stride

2025-08-20 Thread duke
On Wed, 19 Mar 2025 11:23:13 GMT, Nikita Gubarkov wrote: > 8352407: PixelInterleavedSampleModel with unused components throws > RasterFormatException: Incorrect pixel stride This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/24111

Re: RFR: 8365643: JShell EditPad out of bounds on Windows [v3]

2025-08-18 Thread duke
On Mon, 18 Aug 2025 19:45:12 GMT, David Alayachew wrote: >> When calling the `setLocationRelativeTo()` method, a null parameter means >> that it centers the window in the screen. However, any subsequent resizing >> operations will change only the size, not the location of the window. >> Unders

Re: RFR: 8364434: Inconsistent BufferedContext state after GC [v6]

2025-08-13 Thread duke
On Wed, 13 Aug 2025 16:07:45 GMT, Nikita Gubarkov wrote: >> For "true" null objects, reset the ref itself to null. Non-null ref with >> null content means that the object was GC'ed. GC'ed state always behaves as >> not-equal to the new one, causing corresponding ops to be written into RQ. >> >

Re: RFR: 8358813: JPasswordField identifies spaces in password via delete shortcuts [v5]

2025-08-06 Thread duke
On Wed, 6 Aug 2025 16:19:56 GMT, Jeremy Wood wrote: >> There were a few action bindings available in JPasswordFields in Aqua that >> let you identify the boundaries of words. >> >> This came to my attention while looking at the related work >> https://github.com/openjdk/jdk/pull/25443 . In tha

Re: RFR: 8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64

2025-08-01 Thread duke
On Mon, 28 Jul 2025 09:25:34 GMT, Ao Qi wrote: > After [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004), the > following code was added. > > > #ifndef PNG_LOONGARCH_LSX_OPT > # if defined(__loongarch_sx) > # define PNG_LOONGARCH_LSX_OPT 1 > # else > # define PNG_LOONGARCH_LSX_OPT 0 >

Withdrawn: 8224968: javax/swing/JColorChooser/Test6827032.java times out in Windows 10

2025-07-24 Thread duke
On Fri, 28 Feb 2025 15:42:51 GMT, Alexey Ivanov wrote: > **Problem:** > > The test hangs intermittently when run on Windows. (In some cases, handling > the timeout takes 2 hours.) > > Thread dump shows no AWT threads, yet jtreg harness still waits for the test > thread to finish, in particula

Re: RFR: 8359760: Remove the jdk.jsobject module [v2]

2025-07-23 Thread duke
On Tue, 22 Jul 2025 19:53:39 GMT, Kevin Rushforth wrote: >> This PR removes the terminally-deprecated `jdk.jsobject` module from the >> JDK. This module is now shipped with JavaFX, and has been since JavaFX 24. >> >> The following files still reference `jdk.jsobject` (or the >> `netscape.javas

Re: RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v11]

2025-07-10 Thread duke
On Wed, 9 Jul 2025 20:54:23 GMT, Jeremy Wood wrote: >> This resolves a gif parsing bug where an unwanted opaque rectangle could >> appear under these conditions: >> >> 1. The disposal method for frames is 1 (meaning "do not dispose", aka >> "DISPOSAL_SAVE") >> 2. The transparent pixel is non-z

Re: RFR: 8361839 : Problemlist BogusFocusableWindowState due to failures in the CI pipeline

2025-07-10 Thread duke
On Thu, 10 Jul 2025 10:32:19 GMT, Anass Baya wrote: > Problemlisting BogusFocusableWindowState test due to recurrent failures on > Linux @anass-baya Your change (at version b315b72f8e17064888eb215fb30a16f085a21a99) is now ready to be sponsored by a Committer. - PR Comment: https

Re: RFR: 8361484: Remove duplicate font filename mappings in fontconfig.properties for AIX

2025-07-07 Thread duke
On Mon, 16 Jun 2025 09:30:15 GMT, Ravi-Patel8 wrote: > Bug Ref: https://bugs.openjdk.org/browse/JDK-8361484 > > > The following keys are removed: > > `filename.-monotype-timesnewromanwt-medium-r-normal---%d-75-75--*-gb2312.1980-0=/usr/lpp/X11/lib/X11/fonts/TrueType/tnrwt_s.ttf` > > `filename.

Re: RFR: 8361463: Render method of javax.swing.text.AbstractDocument uses 'currency' instead of 'concurrency'

2025-07-07 Thread duke
On Mon, 7 Jul 2025 05:27:11 GMT, ANUPAM DEV wrote: > Hello, > This is a trivial change in the documentation of render method of > AbstractDocument class. > Changed currency to concurrency > > Kindly review. @anupamdev20 Your change (at version 8a0677a96671b7cfee19705e235c09881ae81863) is now

Re: [jdk25] RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-07-06 Thread duke
On Fri, 4 Jul 2025 09:27:33 GMT, Manukumar V S wrote: > This is the backport of a test stabilisation fix done by @manukumarvs and > approved by @aivanov-jdk. > > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the taskbar. This may op

Re: RFR: 8361115: javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of RuntimeException

2025-07-03 Thread duke
On Tue, 1 Jul 2025 04:57:05 GMT, Manukumar V S wrote: > Issue: > javax/swing/JComboBox/bug4276920.java unnecessarily throws Error instead of > RuntimeException whenever a test failure occurs. > This causes unnecessary extra attention in CI systems and triggers task > failures as throwing an Err

Re: RFR: 8355478: DoubleActionESC.java fails intermittently [v9]

2025-06-30 Thread duke
On Mon, 30 Jun 2025 18:57:26 GMT, Anass Baya wrote: >> **Analysis :** >> >> Whether the test passes on the main line or fails, the behavior is still >> incorrect. >> This test is meant to ensure that pressing ESC a second time while the file >> dialog is open behaves correctly. >> >> However,

Re: RFR: 8355478: DoubleActionESC.java fails intermittently [v8]

2025-06-29 Thread duke
On Mon, 9 Jun 2025 18:22:20 GMT, Anass Baya wrote: >> **Analysis :** >> >> Whether the test passes on the main line or fails, the behavior is still >> incorrect. >> This test is meant to ensure that pressing ESC a second time while the file >> dialog is open behaves correctly. >> >> However,

Re: RFR: 8346952 : GetGraphicsStressTest.java fails: Native resources unavailable [v12]

2025-06-29 Thread duke
On Fri, 27 Jun 2025 01:56:15 GMT, Anass Baya wrote: >> **Analysis:** >> >> We are encountering a race condition in the native code. While retrieving >> the screen number by calling _getScreenImOn(), the window is disposed. As a >> result, the AWT-Windows event loop processes the Dispose() call

Re: RFR: 8355904: Use variadic macros for J2dTrace [v7]

2025-06-20 Thread duke
On Fri, 6 Jun 2025 08:36:40 GMT, Nikita Gubarkov wrote: >> J2dTrace macros have multiple overloads specifying number of arguments, >> making it less convent to change number of arguments. There were cases when >> existing macros were not enough and people had to add new variants with even >> m

Re: RFR: 8359687: Use PassFailJFrame for java/awt/print/Dialog/DialogType.java [v9]

2025-06-20 Thread duke
On Fri, 20 Jun 2025 19:06:09 GMT, Srinivas Mandalika wrote: >> Use PassFailJFrame to streamline the test >> java/awt/print/Dialog/DialogType.java, as is for several of the manual tests. >> >> Modified Manual Test Passed when run using jtreg. > > Srinivas Mandalika has updated the pull request

Re: [jdk25] RFR: 8353950: Clipboard interaction on Windows is unstable

2025-06-20 Thread duke
On Thu, 19 Jun 2025 13:27:50 GMT, Matthias Bläsing wrote: > 8353950: Clipboard interaction on Windows is unstable @matthiasblaesing Your change (at version 1bff35bd3e7c7c59b5a63d0e7f82ada28ff66a50) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.or

Re: RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v6]

2025-06-19 Thread duke
On Thu, 19 Jun 2025 11:11:32 GMT, Manukumar V S wrote: >> Issue: >> MyanmarTextTest.java produces a false positive result when some of the test >> preconditions are not met. It checks whether certain fonts are present in >> the system, for example, 'Padauk' on Linux. If the required font is mis

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar [v2]

2025-06-18 Thread duke
On Wed, 18 Jun 2025 15:38:13 GMT, Manukumar V S wrote: >> Issue: >> In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers >> clicks on items pinned to the taskbar. This may open some other UI item and >> may interfere further testing on that machine. >> >> Fix: >> Move the tes

Re: RFR: 8359889: java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks on items pinned to the taskbar

2025-06-18 Thread duke
On Wed, 18 Jun 2025 09:33:50 GMT, Manukumar V S wrote: > Issue: > In Windows, java/awt/MenuItem/SetLabelTest.java inadvertently triggers clicks > on items pinned to the taskbar. This may open some other UI item and may > interfere further testing on that machine. > > Fix: > Move the test UI to

Re: RFR: 8359418: Test "javax/swing/text/GlyphView/bug4188841.java" failed because the phrase of text pane does not match the instructions

2025-06-17 Thread duke
On Fri, 13 Jun 2025 21:16:37 GMT, lawrence.andrews wrote: > Test instruction had "the quick brown fox jumps over the lazy dog" but the > actual "the\tslow\tbrown\tfox\tjumps\tover\tthe\tlazy\tdog!" > > Replaced slow with quick word to match the test instruction. @lawrence-andrew Your change

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v17]

2025-06-10 Thread duke
On Tue, 10 Jun 2025 16:22:52 GMT, Jeremy Wood wrote: >> Make sure AquaTextPasswordFieldUI can't use selectWordAction. >> >> The core problem here was we could call selectWordAction in the Aqua LAF on >> a JPasswordField. This problem was already solved in the >> BasicPasswordFieldUI . The same

Re: [jdk25] RFR: 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119)

2025-06-10 Thread duke
On Tue, 10 Jun 2025 16:09:13 GMT, Renjith Kannath Pariyangad wrote: > Hi all, > > This pull request contains a backport of commit > [2103dc15](https://github.com/openjdk/jdk/commit/2103dc15cb662fd8795b1b51d9cb61c389bed7a0) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >

Re: RFR: 8353950: Clipboard interaction on Windows is unstable [v6]

2025-06-09 Thread duke
On Wed, 4 Jun 2025 17:14:15 GMT, Matthias Bläsing wrote: >> - Introduce a lock into WClipboard that protects the code between >> openClipboard/closeClipboard invocations. >> The native side does not allow to open the clipboard multiple >> times or share the opened clipboard between multiple

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java fails: Window list is empty [v12]

2025-06-06 Thread duke
On Fri, 6 Jun 2025 08:00:34 GMT, Khalid Boulanouare wrote: >> Fixes issue in which the test fails when run on multi-screen machine. >> >> Tested on Ubuntu 24.04, MacOS 15 and Windows 11 >> >> JTREG >> >> runner starting test: java/awt/Frame/MultiScreenTest.java >> runner finished test: java/aw

Re: RFR: 8356803: Test TextLayout/TestControls fails on windows & linux: line and paragraph separator show non-zero advance

2025-06-03 Thread duke
On Fri, 30 May 2025 23:40:22 GMT, Daniel Gredler wrote: > Per discussion in JBS, adds the following chars to the list of ignorable > whitespace chars: U+000B (Vertical Tab), U+000C (Form Feed), U+0085 (Next > Line), U+2028 (Line Separator), U+2029 (Paragraph Separator). > > Adds the necessary

Re: RFR: 8347826: Introspector shows wrong method list after 8071693 [v16]

2025-06-02 Thread duke
On Fri, 30 May 2025 11:20:39 GMT, Roman Marchenko wrote: >> Fixed `com.sun.beans.introspect.MethodInfo` and >> `com.sun.beans.introspect.PropertyInfo` to make `Introspector.addMethod()` >> working properly when filtering methods out. >> >> Also, after PR discussion, added the approptiate test

Re: RFR: 8353230: Emoji rendering regression after JDK-8208377 [v4]

2025-05-30 Thread duke
On Thu, 29 May 2025 11:10:38 GMT, Daniel Gredler wrote: >> It looks like this regression actually fits into a longer series of fixes / >> regressions in this area: >> >> - [JDK-4517298](https://bugs.openjdk.org/browse/JDK-4517298) fixed metrics >> for zero-width characters, but broke some liga

Re: RFR: 8334016: Make PrintNullString.java automatic [v6]

2025-05-23 Thread duke
On Thu, 22 May 2025 11:24:34 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test and made it semi-automatic (need to click "Print") . >> Test will initiate a print and result will be generated automatic. >> >> Please review and let me know your suggestions.

Re: RFR: 8341370: Test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails intermittently on macOS-aarch64 [v2]

2025-05-23 Thread duke
On Fri, 23 May 2025 02:53:51 GMT, Manukumar V S wrote: >> ShapeNotSetSometimes.java fails intermittently with a RuntimeException on >> macOS-aarch64 >> Test threw exception: java.lang.RuntimeException: Test failed. The shape has >> not been applied. >> >> Fix: >> The test has been modified to

Re: RFR: 8356814: LineBreakMeasurer.nextLayout() slower than necessary when no break needed

2025-05-22 Thread duke
On Mon, 12 May 2025 20:35:52 GMT, Daniel Gredler wrote: > `LineBreakMeasurer.nextLayout()` calls `nextOffset()` internally to calculate > the layout limit. When this happens, a `GlyphVector` is created and the > layout engine is invoked to shape the text. The `GlyphVector` is cached in > the r

Re: RFR: 8356061: [macos] com/apple/laf/RootPane/RootPaneDefaultButtonTest.java test fails on macosx-aarch64 machine [v3]

2025-05-22 Thread duke
On Mon, 19 May 2025 05:37:05 GMT, Jeremy Wood wrote: >> Unfortunately I'm unable to reproduce this failure. I slowed the test down; >> it passes on my machine before and after this PR. >> >> I added a little bit of logging that might also help identify what's >> happening. >> >> Does anyone h

Re: RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java [v8]

2025-05-22 Thread duke
On Thu, 22 May 2025 13:19:43 GMT, Manukumar V S wrote: >> There are some compilation failures noticed in the recently open sourced >> test javax/swing/JMenuItem/bug6197830.java. The compilation failures are due >> to missing import statements and a missing dependency file MenuItemTest.java. >>

Re: RFR: 8343618: Stack smashing in awt_InputMethod.c on Linux s390x

2025-05-21 Thread duke
On Mon, 24 Mar 2025 13:41:44 GMT, Zdenek Zambersky wrote: > This fixes stack smashing issue in awt library on linux s390x. (jdk compiled > with `-fstack-protector-strong`) > > Fix is based on patch > [submitted](https://mail.openjdk.org/pipermail/awt-dev/2019-July/015337.html) > in JDK-822791

Re: RFR: 8355515: Clarify the purpose of forcePass() and forceFail() methods [v3]

2025-05-19 Thread duke
On Mon, 19 May 2025 12:57:43 GMT, Manukumar V S wrote: >> Clarified the purpose of forcePass() and forceFail() methods and recommended >> usage of these methods. >> >> forcePass() contained an incorrect sample; it's addressed by >> [JDK-8355441](https://bugs.openjdk.org/browse/JDK-8355441). >>

Re: RFR: 8356966: java/awt/Graphics2D/DrawString/IgnoredWhitespaceTest.java fails on Linux after JDK-8350203 [v3]

2025-05-19 Thread duke
On Thu, 15 May 2025 17:20:06 GMT, Daniel Gredler wrote: >> If the new test (`IgnoredWhitespaceTest`) runs on a system with Type1 >> physical fonts, it fails because the Type1 handling of ignorable whitespace >> characters does not match the behavior of the TrueType and macOS glyph >> mappers.

Withdrawn: 6734168: BasicButtonUI uses wrong FontMetrics to Layout JButtons text

2025-05-16 Thread duke
On Fri, 21 Mar 2025 11:26:34 GMT, Prasanta Sadhukhan wrote: > javax.swing.plaf.basic.BasicButtonUI uses wrong FontMetrics object to layout > the text on a JButton. > The paint(Graphics, JComponent) method of BasicButtonUI calculates the > [FontMetrics](https://github.com/openjdk/jdk/blob/6656

Re: RFR: 8355515: Clarify the purpose of forcePass() and forceFail() methods

2025-05-15 Thread duke
On Wed, 7 May 2025 12:28:52 GMT, Manukumar V S wrote: > Clarified the purpose of forcePass() and forceFail() methods and recommended > usage of these methods. > > forcePass() contained an incorrect sample; it's addressed by > [JDK-8355441](https://bugs.openjdk.org/browse/JDK-8355441). > > The

Re: RFR: 8332947: [macos] OpenURIHandler events not received when AWT is embedded in another toolkit [v7]

2025-05-15 Thread duke
On Wed, 7 May 2025 16:51:30 GMT, Pabulaner IV wrote: >> When trying to register an open URI handler when using JavaFX with a native >> menu, this task fails on Mac. >> Either the native menu is not shown or the URIs are not received. >> >> This pull request fixes this issue if AWT is registered

Re: RFR: 8350203: [macos] Newlines and tabs are not ignored when drawing text to a Graphics2D object [v3]

2025-05-12 Thread duke
On Fri, 9 May 2025 20:48:13 GMT, Daniel Gredler wrote: >> On other platforms like Windows and Linux, the `\n`, `\r` and `\t` >> characters are ignored when drawing text to a `Graphics2D` object. On macOS >> this is not currently the case. >> >> See, for example, `CMap.getControlCodeGlyph(int,

Re: RFR: 8354219 : Automate javax/swing/JComboBox/ComboPopupBug.java [v9]

2025-05-06 Thread duke
On Tue, 29 Apr 2025 01:23:00 GMT, Anass Baya wrote: >> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox w

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v5]

2025-05-04 Thread duke
On Fri, 2 May 2025 10:49:03 GMT, Manukumar V S wrote: >> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently >> in CI, especially in MacOS machines. >> Also the frame created in this test is not disposed which may interfere with >> other tests. >> >> Fix: >> Some stabi

Re: RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI [v4]

2025-04-29 Thread duke
On Mon, 28 Apr 2025 09:32:26 GMT, Manukumar V S wrote: >> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently >> in CI, especially in MacOS machines. >> Also the frame created in this test is not disposed which may interfere with >> other tests. >> >> Fix: >> Some stab

Re: RFR: 8351884: Refactor bug8033699.java test code [v7]

2025-04-28 Thread duke
On Mon, 28 Apr 2025 17:29:30 GMT, Rajat Mahajan wrote: >> Details: >> Refactored code as requested in the Bug description. >> >> Tested and verified the test passes. > > Rajat Mahajan has updated the pull request incrementally with one additional > commit since the last revision: > > code re

Re: RFR: 8355441: Remove antipattern from PassFailJFrame.forcePass javadoc [v4]

2025-04-28 Thread duke
On Sat, 26 Apr 2025 01:28:53 GMT, Manukumar V S wrote: >> The javadoc for PassFailJFrame.forcePass suggests an anti-pattern of >> forcibly passing the test if a resource is unavailable. >> >> If a resource is unavailable or a feature isn't supported, the test should >> throw jtreg.SkippedExcep

Re: RFR: 8355611: Get rid of SurfaceManagerFactory [v3]

2025-04-27 Thread duke
On Sat, 26 Apr 2025 11:07:04 GMT, Nikita Gubarkov wrote: >> `SurfaceManagerFactory` just checks a given `GraphicsConfiguration` against >> multiple types via `instanceof`, it has 3 platform-specific implementations, >> which rely on an ugly injection process. >> >> There is no reason to have t

Re: RFR: 8355203: [macos] AquaButtonUI and AquaRootPaneUI repaint default button unnecessarily [v3]

2025-04-25 Thread duke
On Fri, 25 Apr 2025 07:49:54 GMT, Jeremy Wood wrote: >> This removes the constant repainting of the AquaRootPaneUI's default button. >> >> A long time ago (before Mac OS Yosemite, around 2014) this was needed to >> match Aqua's native experience. But the default button no longer pulses, so >>

Re: RFR: 8355366: Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests

2025-04-24 Thread duke
On Thu, 24 Apr 2025 16:36:56 GMT, Manukumar V S wrote: > Fix the wrong usage of PassFailJFrame.forcePass() in some manual tests from > java.awt.Desktop package. These tests should be fixed similar to > [JDK-8352109](https://bugs.openjdk.org/browse/JDK-8352109) and > jtreg.SkippedException shou

Re: RFR: 8315113: Print request Chromaticity.MONOCHROME attribute does not work on macOS [v6]

2025-04-24 Thread duke
On Fri, 21 Mar 2025 15:42:29 GMT, GennadiyKrivoshein wrote: >> This update allows users to print with grayscale using color printers. >> Actually, it is not possible to use the "Monochrome" option from the "Color >> Appearance" panel. Also Chromaticity.MONOCHROME can't be used to print >> grays

Re: RFR: 8354191: GTK LaF should use pre-multiplied alpha same as cairo

2025-04-16 Thread duke
On Wed, 9 Apr 2025 14:42:05 GMT, Maxim Kartashev wrote: > The pixels that cairo produces for GTK LaF to draw on a Swing component have > their alpha components pre-multiplied as per [the > documentation](https://www.cairographics.org/manual/cairo-Image-Surfaces.html?spm=a2ty_o01.29997173.0.0.54

Re: RFR: 8353138: Screen capture for test TaskbarPositionTest.java, failure case [v7]

2025-04-10 Thread duke
On Mon, 7 Apr 2025 12:34:43 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Added screen capture in case of test failure using Robot. >> >> Please review and let me know your suggestion if any. > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one

Re: RFR: 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions [v10]

2025-04-10 Thread duke
On Wed, 9 Apr 2025 23:31:02 GMT, Jeremy Wood wrote: >> JPEG segments can only be 65535-bytes long. (The marker length is expressed >> as 2 bytes.) The problem in this ticket is that we were writing more than >> 65535 bytes to a segment, which later caused parsing errors when we tried to >> rea

Withdrawn: JDK-8348302 : [Test bug] Update FileDialogIconTest.java

2025-04-08 Thread duke
On Fri, 7 Feb 2025 19:50:03 GMT, Harshitha Onkar wrote: > FileDialogIconTest.java has been updated. > > Following changes were made. > > - Test instructions updated > - BugID associated with the test is updated to the correct one > - setIconBufferedImagesToFrame and setIconBufferedImagesToDi

Re: RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

2025-04-07 Thread duke
On Fri, 28 Mar 2025 09:41:22 GMT, Daniel Gredler wrote: > WTaskbarPeer contains a check as to whether the current Windows version is > Windows 7 or later. The current minimum supported version is Windows 10, so > this is no longer needed. > > There didn't seem to be a public test exercising th

Re: RFR: 8353138: Screen capture for test TaskbarPositionTest.java, failure case [v6]

2025-04-06 Thread duke
On Fri, 4 Apr 2025 08:45:22 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Added screen capture in case of test failure using Robot. >> >> Please review and let me know your suggestion if any. > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one

Re: RFR: 8352970: Remove unnecessary Windows version check in Win32ShellFolderManager2 [v2]

2025-03-28 Thread duke
On Wed, 26 Mar 2025 19:49:46 GMT, Daniel Gredler wrote: >> Win32ShellFolderManager2 contains a check as to whether the current Windows >> version is Windows 2000 or later. The current minimum supported version is >> Windows 10, so this is no longer needed. >> >> No test seems to currently exer

Re: RFR: 8352890: Remove unnecessary Windows version check in FileFontStrike [v3]

2025-03-27 Thread duke
On Wed, 26 Mar 2025 21:14:24 GMT, Daniel Gredler wrote: >> FileFontStrike contains a check as to whether the current Windows version is >> Windows XP or later. The current minimum supported version is Windows 10, so >> this is no longer needed. >> >> When the code in question was added 17 year

Withdrawn: 8349157: Unnecessary Hashtable usage in XKeysym.javaKeycode2KeysymHash

2025-03-26 Thread duke
On Wed, 29 Jan 2025 09:35:09 GMT, Andrey Turbanov wrote: > There is a field `sun.awt.X11.XKeysym#javaKeycode2KeysymHash` which uses > legacy Hashtable class. > As this map is read-only and all its content is initialized in `` we > can safely use immutable Map instead. This pull request has bee

Withdrawn: 8342870: Errors related to unused code on Windows after 8339120 in accessibility

2025-03-25 Thread duke
On Wed, 23 Oct 2024 05:17:33 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse

Re: RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported [v3]

2025-03-19 Thread duke
On Wed, 19 Mar 2025 02:41:48 GMT, Manukumar V S wrote: >> **Issue** >> java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not >> supported >> >> **Reason** >> In `MailTest.java`, there is a condition check(`if >> (!desktop.isSupported(Desktop.Action.MAIL))`) which will forc

Re: RFR: 8280818: Expand bug8033699.java to iterate over all LaFs

2025-03-13 Thread duke
On Mon, 10 Mar 2025 14:48:09 GMT, Rajat Mahajan wrote: > Added code to Iterates over all installed Look and Feel environments and > added related exception handling. > > Testing done. @rajamah Your change (at version 65d95acf8d92dd46aa6ded1aaa4c3db5f66969a7) is now ready to be sponsored by a

Re: RFR: 8351323: Parameterize compiler and linker flags for iconv [v3]

2025-03-13 Thread duke
On Thu, 13 Mar 2025 11:39:14 GMT, snake66 wrote: >> Allows for future support for platforms that require different flags for >> libiconv support. >> >> Sponsored-by: The FreeBSD Foundation > > snake66 has updated the pull request incrementally with one additional commit > since the last revisi

Re: RFR: 8351108: ImageIO.write(..) fails with exception when writing JPEG with IndexColorModel [v6]

2025-03-12 Thread duke
On Tue, 11 Mar 2025 21:47:38 GMT, Jeremy Wood wrote: >> Previously ImageTypeSpecifier treated all TYPE_BYTE_INDEXED as if they were >> opaque. >> >> In this ticket's case: an ImageWriter received the wrong ImageTypeSpecifier >> and mistakenly indicated it *could* support a BufferedImage. But w

Re: RFR: 8349350: Unable to print using InputSlot and OutputBin print attributes at the same time [v8]

2025-03-12 Thread duke
On Tue, 11 Mar 2025 14:48:12 GMT, GennadiyKrivoshein wrote: >> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use >> more that one print option. >> >> **Reason of the bug**: >> execCmd array uses one index per print flag, but 'OPTIONS' flag can use two >> indexes for

Re: RFR: 8349099: java/awt/Headless/HeadlessMalfunctionTest.java fails on CI with Compilation error [v4]

2025-03-11 Thread duke
On Fri, 7 Mar 2025 12:38:08 GMT, Karm Michal Babacek wrote: >> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile >> API. >> >> Test passes on Linux amd64 so far: >> >> TIME=`date +%s`; >> mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; >> jtreg -a -ignore:

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-11 Thread duke
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Re: RFR: 8270265: LineBreakMeasurer calculates incorrect line breaks with zero-width characters [v3]

2025-03-11 Thread duke
On Fri, 21 Feb 2025 21:13:16 GMT, Daniel Gredler wrote: >> When a string contains zero-width characters, `LineBreakMeasurer` calculates >> line breaks incorrectly. >> >> The root cause appears to be that `LineBreakMeasurer` eventually calls into >> `StandardGlyphVector.getGlyphInfo()`, which d

Withdrawn: 8337505: Footprint and startup regressions up to 20% in GUI apps

2025-03-10 Thread duke
On Mon, 28 Oct 2024 21:26:38 GMT, Phil Race wrote: > https://bugs.openjdk.org/browse/JDK-8338677 already improved things for this > so that's good. > > This fix adds to it lazy initialisation of VarHandles in StrikeCache at the > cost of some extra code. > Since these VarHandles get used more

Re: RFR: 8160327: Support for thumbnails present in APP1 marker for JPEG [v10]

2025-03-10 Thread duke
On Tue, 4 Mar 2025 03:41:10 GMT, Jeremy Wood wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time

Re: RFR: 8349932: PSPrinterJob sometimes generates unnecessary PostScript commands [v2]

2025-03-05 Thread duke
On Fri, 14 Feb 2025 23:51:49 GMT, Daniel Gredler wrote: >> Trying to print text which is ignored (e.g. `\r` or `\n` or `\t`), or trying >> to print empty shapes generates PostScript graphics context setup commands >> which are not necessary. This can lead to unnecessarily large PostScript >> f

Withdrawn: 8346436: Compilation with clang fails

2025-03-01 Thread duke
On Tue, 17 Dec 2024 14:57:42 GMT, Jan Kratochvil wrote: > clang-18.1.8-1.fc40.x86_64 > Fedora 40 x86_64 > fbd76ca8edd756ff2ebbc9f6477cc1a827df67b0 > > > src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: > ignoring return value of function declared with 'warn_unused_result

Withdrawn: 8336654: [lworld] Tests depending on sun.awt.AppContext can fail when run with migrated classes

2025-02-24 Thread duke
On Mon, 23 Dec 2024 17:18:15 GMT, Phil Race wrote: > The problem is that Boolean will be a value type in the future (Project > Valhalla) > and so it can't be the referent of a Reference. > > In this code, the abstract class that creates the Reference accepts a generic > type so isn't in contro

Withdrawn: 8342869: Errors related to unused code on Windows after 8339120 in awt

2025-02-17 Thread duke
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse

Re: RFR: 8349351 : Combine Screen Inset Tests into a Single File [v2]

2025-02-14 Thread duke
On Sun, 9 Feb 2025 19:56:48 GMT, anass baya wrote: >> While working on [JDK-6899304](https://bugs.openjdk.org/browse/JDK-6899304), >> we discovered that there are two tests meant to perform the same task. >> >> The first test is located at >> test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest

Withdrawn: 8346603: Cleanup Metacity.ThemeGetter class

2025-02-13 Thread duke
On Thu, 21 Nov 2024 06:38:26 GMT, Andrey Turbanov wrote: > There is opportunity to remove redundant nested class `Metacity.ThemeGetter`. > It was introduced in the SecurityManager era to handle privileged call. Now > (after > https://github.com/openjdk/jdk/pull/22186/files#diff-5e3ecade1f40933

Re: RFR: 6562489: Font-Renderer should ignore invisible characters \u2062 and \u2063

2025-02-12 Thread duke
On Tue, 11 Feb 2025 01:40:01 GMT, Daniel Gredler wrote: > Expands regression test to cover bug JDK-6562489. > > No additional fix is required after the JDK-8208377 fix (see #22670). @gredler Your change (at version e1f945066004c656f2bc275b6d8009c548c781ea) is now ready to be sponsored by a Co

Re: RFR: 8208377: Soft hyphens render if not using TextLayout [v5]

2025-02-10 Thread duke
On Mon, 10 Feb 2025 20:36:46 GMT, Daniel Gredler wrote: >> Soft hyphens should never render, regardless of the rendering path used >> internally. >> >> This PR does not expand the categorization of "complex" characters in >> `FontUtilities` in order to force the use of `TextLayout` rendering c

Re: RFR: 8347826: Introspector shows wrong method list after 8071693 [v4]

2025-02-06 Thread duke
On Thu, 6 Feb 2025 14:13:50 GMT, Roman Marchenko wrote: >> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make >> `Introspector.addMethod()` working properly when filtering methods out. >> >> Also fixed the test, and added the approptiate test case. > > Roman Marchenko has updated t

Re: RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]

2025-02-03 Thread duke
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Added pageloader cancel before new page creation along with code >> restructuring. Moved all page loading calls inside synchronize to make it >> thread safe. >> >> Regards, >> Renjith. > > Renjith Kann

Re: RFR: 6899304 : java.awt.Toolkit.getScreenInsets(GraphicsConfiguration) returns incorrect values [v8]

2025-01-31 Thread duke
On Wed, 29 Jan 2025 12:25:29 GMT, anass baya wrote: >> Screen number 0 is not always the primary screen, so we’ve removed the code >> that assumes it is. >> >> We used an existing test and took the following considerations into account >> for Windows: >> >> - On Windows, undecorated maximized

Re: RFR: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS [v4]

2025-01-30 Thread duke
On Thu, 30 Jan 2025 13:26:08 GMT, Naveen Narayanan wrote: >> This contains test fixes for the following issue in >> ScreenCaptureRobotTest.java >> >> •Failures in Mac OS because of mouse pointer visible on top of the image >> that is screen captured by robot. >> >> Testing: >> Tested usin

Re: RFR: 8336382: Fix error reporting in loading AWT [v10]

2025-01-30 Thread duke
On Tue, 26 Nov 2024 15:11:58 GMT, Karm Michal Babacek wrote: >> If there is a problem with finding and calling e.g. >> `java/awt/GraphicsEnvironment` in `AWTIsHeadless`, the env' Exception >> remains set and it is not cleared. Later, that manifests as: >> >> Fatal error reported via JNI: C

Re: RFR: 8344637: Fix Page8 of manual test java/awt/print/PrinterJob/PrintTextTest.java on Linux and Windows [v7]

2025-01-28 Thread duke
On Wed, 20 Nov 2024 19:07:28 GMT, Daniel Gredler wrote: >> This PR fixes the issue identified in JDK-8148334 in screenshots >> `Page8_landscape.JPG` and `Page8_portrait.JPG`. >> >> It does not address `mac_Page1.png` or `mac_Page8.png`, which I'm not even >> sure are still issues (I have no ac

Re: RFR: 8344119: CUPSPrinter does not respect PostScript printer definition specification in case of reading ImageableArea values from PPD files [v8]

2025-01-26 Thread duke
On Wed, 22 Jan 2025 12:15:19 GMT, GennadiyKrivoshein wrote: >> **Description:** >> The PR updates sun.print.CUPSPrinter's behavior in terms of reading media >> imageable area values according to the PostScript Printer Description File >> Format Specification. >> The actual implementation reads

Re: RFR: 8282862: AwtWindow::SetIconData leaks old icon handles if an exception is detected [v6]

2025-01-23 Thread duke
On Fri, 17 Jan 2025 18:22:57 GMT, Rajat Mahajan wrote: >> **Issue:** >> AwtWindow::SetIconData leaks the old icon handles in hOldIcon and hOldIconSm >> if CreateIconFromRaster raises an exception. Additionally, an exception is >> checked only after the first call to CreateIconFromRaster. >> >

  1   2   3   >