Re: RFR: 8343128: PassFailJFrame.java test result: Error. Bad action for script: build}

2024-10-30 Thread lawrence . andrews
On Tue, 29 Oct 2024 15:18:42 GMT, Alexey Ivanov wrote: > After updating documentation for `PassFailJFrame.java` in > [JDK-8340785](https://bugs.openjdk.org/browse/JDK-8340785) / #21162, jtreg > interprets the file as a test because it finds `@test` tag in the file. This > results in a failed t

Re: RFR: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos

2024-10-01 Thread lawrence . andrews
On Tue, 1 Oct 2024 17:00:55 GMT, Manukumar V S wrote: > javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails > sometimes in macos. > This could be because of a synchronisation issue in the test. > > Fix: I have refactored the test to have a CountDownLatch to monitor the > Progr

Re: RFR: 8340306: Add border around instructions in PassFailJFrame

2024-09-17 Thread lawrence . andrews
On Tue, 17 Sep 2024 12:52:46 GMT, Alexey Ivanov wrote: >> A trivial change which adds border around instruction text. It makes the >> text easier to read. >> >> (In some tests, people added leading spaces to each line to make the >> instructions easier to read; with the added border, there's n

Re: RFR: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest [v3]

2024-08-21 Thread lawrence . andrews
On Wed, 21 Aug 2024 19:12:41 GMT, Manukumar V S wrote: >> This PR creates a new test by stabilising and open sourcing a closed test. >> This test verifies that the OpenGL pipeline does not create artifacts with >> swing components after window is zoomed to maximum size and then resized >> back

Integrated: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java

2024-08-15 Thread lawrence . andrews
On Sat, 3 Aug 2024 18:07:16 GMT, lawrence.andrews wrote: > 1) Replaced JApplet with JPanel > 2) Tests passed before and after fix This pull request has now been integrated. Changeset: 7d1bbff0 Author:lawrence.andrews Committer: Harshitha Onkar URL: https://git.openjdk.org/jdk/comm

RFR: 8338425: java.lang.NullPointerException when About MenuItem is selected from SwingSet2DemoTest.java

2024-08-14 Thread lawrence . andrews
Added the missing jpg file & tested and NPE is not seen any more - Commit messages: - 8338425: java.lang.NullPointerException when About MenuItem is selected from SwingSet2DemoTest.java Changes: https://git.openjdk.org/jdk/pull/20589/files Webrev: https://webrevs.openjdk.org/?rep

Re: RFR: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java [v2]

2024-08-14 Thread lawrence . andrews
> 1) Replaced JApplet with JPanel > 2) Tests passed before and after fix lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Removed the JApplet import - Changes: - all: https://git.openjdk.org/jdk/pull/20450/files

Re: RFR: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java

2024-08-10 Thread lawrence . andrews
On Sat, 3 Aug 2024 18:07:16 GMT, lawrence.andrews wrote: > 1) Replaced JApplet with JPanel > 2) Tests passed before and after fix I can file a new ticket and work on the NPE. - PR Comment: https://git.openjdk.org/jdk/pull/20450#issuecomment-2282331277

RFR: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java

2024-08-03 Thread lawrence . andrews
1) Replaced JApplet with JPanel 2) Tests passed before and after fix - Commit messages: - Left a blank line at the end of the file - 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java Changes: https://git.openjdk.org/jdk/pull/20450/files Web

Integrated: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @

2024-07-08 Thread lawrence . andrews
On Fri, 5 Jul 2024 18:06:18 GMT, lawrence.andrews wrote: > 1) After the fix , I could see the test was launched. This pull request has now been integrated. Changeset: 3733fe3a Author:lawrence.andrews Committer: Alexey Ivanov URL: https://git.openjdk.org/jdk/commit/3733fe3a207078b58

Re: RFR: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ [v2]

2024-07-05 Thread lawrence . andrews
> 1) After the fix , I could see the test was launched. lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: updated the copyright - Changes: - all: https://git.openjdk.org/jdk/pull/20057/files - new: https://git.open

RFR: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @

2024-07-05 Thread lawrence . andrews
1) After the fix , I could see the test was launched. - Commit messages: - 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @ Changes: https://git.openjdk.org/jdk/pull/20057/files Webrev: https://webrevs.openjdk.org/?repo=jd

Re: RFR: 8333403: Write a test to check various components events are triggered properly [v2]

2024-06-05 Thread lawrence . andrews
On Wed, 5 Jun 2024 08:29:11 GMT, Ravi Gupta wrote: >> This testcase checks for the following assertions for Component events: >> >> 1. When components are resized, moved, hidden and shown the respective >> events are triggered. >> 2. When the components are hidden/disabled also,the component ev

Re: RFR: 8333403: Write a test to check various components events are triggered properly

2024-06-03 Thread lawrence . andrews
On Mon, 3 Jun 2024 12:22:53 GMT, Ravi Gupta wrote: > This testcase checks for the following assertions for Component events: > > 1. When components are resized, moved, hidden and shown the respective events > are triggered. > 2. When the components are hidden/disabled also,the component events

Re: RFR: 8280990: [XWayland] XTest emulated mouse click does not bring window to front

2024-06-01 Thread lawrence . andrews
On Tue, 28 May 2024 02:25:46 GMT, Alexander Zvegintsev wrote: > Some of the modal tests fail in X11 compatibility mode on Wayland, because a > mouse click emulated with XTEST does not not cause the windows to be > reordered. > > This is a known limitation because these click events do not lea

Re: RFR: JDK-8329692 : Add more details to FrameStateTest.java test instructions [v5]

2024-04-30 Thread lawrence . andrews
On Tue, 30 Apr 2024 17:57:14 GMT, Harshitha Onkar wrote: >> For the following manual test, more instructions are added as to what to >> expect for "hide,iconify and show" vs "hide,iconify,show and restore" for >> clarity. > > Harshitha Onkar has updated the pull request incrementally with one

Re: RFR: 8328242: Add a log area to the PassFailJFrame [v2]

2024-03-15 Thread lawrence . andrews
On Fri, 15 Mar 2024 15:42:42 GMT, Alexey Ivanov wrote: >> 'Clear log' button calling logClear(). > > @lawrence-andrew I can't see much value… > > Capturing logs by a screenshot is not something that you should ever do — > copy the messages and paste them as text into a bug report. > > However,

Re: RFR: 8328242: Add a log area to the PassFailJFrame [v2]

2024-03-15 Thread lawrence . andrews
On Fri, 15 Mar 2024 15:05:28 GMT, Alexey Ivanov wrote: >> I keep it for consistency across builder methods, e.g. `screenCapture` does >> not need to specify it either. > > Okay. Most methods of the builder use `this.` prefix when assigning something > to a field. How about having a clear log b

Re: RFR: 8328242: Add a log area to the PassFailJFrame [v2]

2024-03-15 Thread lawrence . andrews
On Fri, 15 Mar 2024 15:33:30 GMT, lawrence.andrews wrote: >> Okay. Most methods of the builder use `this.` prefix when assigning >> something to a field. > > How about having a clear log button. Just an idea > Example : > I have a mouse event test & I am using the logArea to add all the events

Integrated: 8318580 : "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053

2023-11-06 Thread lawrence . andrews
On Fri, 27 Oct 2023 23:29:19 GMT, lawrence.andrews wrote: > 1) Fixed the @library regtesthelpers file path > 2) Added @build PassFailJFrame > 3) Added a empty line at the end of the file that was missing. This pull request has now been integrated. Changeset: e4803e0c Author:lawrence.andrew

RFR: 8318580 : "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053

2023-10-27 Thread lawrence . andrews
1) Fixed the @library regtesthelpers file path 2) Added @build PassFailJFrame 3) Added a empty line at the end of the file that was missing. - Commit messages: - 8318580 : "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/

Integrated: 8317751 : ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows

2023-10-10 Thread lawrence . andrews
On Mon, 9 Oct 2023 20:14:40 GMT, lawrence.andrews wrote: > ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & > MouseModifiersUnitTest_Standard.java for windows > > @prrace This pull request has now been integrated. Changeset: f40ea510 Author:lawrence.andrews <873

Re: RFR: 8317751 : ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows [v2]

2023-10-10 Thread lawrence . andrews
> ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & > MouseModifiersUnitTest_Standard.java for windows > > @prrace lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Update ProblemList.txt Fixed the b

RFR: 8317751 : ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows

2023-10-10 Thread lawrence . andrews
ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows @prrace - Commit messages: - 8317751 : ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for win

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-13 Thread lawrence . andrews
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote: >> This enhances the `Builder` pattern added in >> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method >> `testUI` which allows passing a lambda expression or a method reference to >> create *the test UI window*. >

Re: RFR: 8316017: Refactor timeout handler in PassFailJFrame

2023-09-11 Thread lawrence . andrews
On Mon, 11 Sep 2023 18:18:28 GMT, Alexey Ivanov wrote: > Refactored timeout handling in PassFailJFrame: > > 1. Managing the timer and formatting the time left is inside `TimeoutHandler` > class. > 2. The class handles timer events and updates the label accordingly. > > This is implemented on t

Re: RFR: 8315584 : java/awt/print/Dialog/DialogType.java fails with option not supported: yesno [v2]

2023-09-05 Thread lawrence . andrews
> Test was failing with "test result: Error. Parse Exception: Arguments to > `manual' option not supported: yesno" > Following are fixed > 1) Removed yesno > 2) Used PassFailJFrame manual test framework to show the test instruction & > allow the user to decide test execution result. > 3) Added

RFR: 8315584 : java/awt/print/Dialog/DialogType.java fails with option not supported: yesno

2023-09-03 Thread lawrence . andrews
Test was failing with "test result: Error. Parse Exception: Arguments to `manual' option not supported: yesno" Following are fixed 1) Removed yesno 2) Added test PassFailJFrame manual framework 3) Added SkippedException in case Printer is not configured on the test host. 4) Updated the instructi

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI

2023-08-31 Thread lawrence . andrews
On Thu, 31 Aug 2023 16:07:03 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 47: >> >>> 45: ByteArrayOutputStream baos = new >>> ByteArrayOutputStream(); >>> 46: ObjectOutputStream oos = new ObjectOutputStream(

Re: RFR: 6450193: After the first Serialization, JTableHeader does not uninstall its UI

2023-08-31 Thread lawrence . andrews
On Thu, 31 Aug 2023 08:02:35 GMT, Prasanta Sadhukhan wrote: > After the first time a JTableHeader is serialized, it no longer will > uninstall its UI upon subsequent serializations. > This happens for classes that use the BasicTableHeaderUI class. Any LAF that > extends the BasicTableHeaderUI

Integrated: 8315071 : Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage

2023-08-28 Thread lawrence . andrews
On Sat, 26 Aug 2023 21:11:11 GMT, lawrence.andrews wrote: > Both the tests demonstrates how to use the PassFailJFrame's builder pattern. > 1) TrayIconScalingTest.java demonstrates how to add screen shot method > 2) PrintLatinCJKTest.java demonstrates how to use PassFailJFrame's builder > patter

Re: RFR: 8311585: Add JRadioButtonMenuItem to bug8031573.java

2023-08-28 Thread lawrence . andrews
On Mon, 28 Aug 2023 18:57:18 GMT, Harshitha Onkar wrote: >> I have made the test changes to include radio button in menu and tested the >> same and it works fine. > > @lawrence-andrew This test (bug8031573.java) can be a good manual test > candidate to be re-written using the new PassFailJFrame

RFR: 8315071 : Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage

2023-08-26 Thread lawrence . andrews
Both the tests demonstrates how to use the PassFailJFrame's builder pattern. 1) TrayIconScalingTest.java demonstrates how to add screen shot method 2) PrintLatinCJKTest.java demonstrates how to use PassFailJFrame's builder pattern without screen shot method. @aivanov-jdk @honkar-jdk --

Integrated: 8294535 : Add screen capture functionality to PassFailJFrame

2023-08-23 Thread lawrence . andrews
On Tue, 23 May 2023 02:52:03 GMT, lawrence.andrews wrote: > 1) Used builder pattern > 2) Tested AWT tests and it passed This pull request has now been integrated. Changeset: dbb788f3 Author:lawrence.andrews Committer: Alexey Ivanov URL: https://git.openjdk.org/jdk/commit/dbb788f34

Re: RFR: 8139208: [macosx] Issue with setExtendedState of JFrame [v6]

2023-08-23 Thread lawrence . andrews
On Wed, 23 Aug 2023 17:42:54 GMT, Alisen Chung wrote: >> Swapped order of showing frame and managing extended frame state. > > Alisen Chung has updated the pull request incrementally with four additional > commits since the last revision: > > - add copyright > - update test > - update test >

Re: RFR: 8139208: [macosx] Issue with setExtendedState of JFrame [v2]

2023-08-23 Thread lawrence . andrews
On Mon, 14 Aug 2023 21:00:56 GMT, Alisen Chung wrote: >> @alisenchung >> >> An automated test can be created by adding Component Listener to the >> reproducer test in JBS. The following code throws Runtime Exception if the >> frame was visible at the original size of 200 x 200 before it was m

Re: RFR: 8139208: [macosx] Issue with setExtendedState of JFrame [v3]

2023-08-21 Thread lawrence . andrews
On Mon, 21 Aug 2023 16:54:00 GMT, Alisen Chung wrote: >> Swapped order of showing frame and managing extended frame state. > > Alisen Chung has updated the pull request incrementally with two additional > commits since the last revision: > > - test update > - added test, updated comment test

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v4]

2023-08-10 Thread lawrence . andrews
> 1) Used builder pattern > 2) Tested AWT tests and it passed lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Changed enableScreenCapture to screenCapture - Changes: - all: https://git.openjdk.org/jdk/pull/14094/f

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v3]

2023-08-10 Thread lawrence . andrews
On Wed, 9 Aug 2023 20:55:32 GMT, lawrence.andrews wrote: >> 1) Used builder pattern >> 2) Tested AWT tests and it passed > > lawrence.andrews has updated the pull request incrementally with two > additional commits since the last revision: > > - Changed enableScreenCapture method name to scre

Re: RFR: 8139208: [macosx] Issue with setExtendedState of JFrame

2023-08-10 Thread lawrence . andrews
On Thu, 10 Aug 2023 23:10:15 GMT, Alisen Chung wrote: > Swapped order of showing frame and managing extended frame state. src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 1005: > 1003: int prevWindowState = peer.getState(); > 1004: if (prevWindowState =

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v3]

2023-08-09 Thread lawrence . andrews
On Wed, 9 Aug 2023 21:02:37 GMT, Harshitha Onkar wrote: >> lawrence.andrews has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Changed enableScreenCapture method name to screenCapture shorter method >> name >> - Update full name > > tes

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v3]

2023-08-09 Thread lawrence . andrews
> 1) Used builder pattern > 2) Tested AWT tests and it passed lawrence.andrews has updated the pull request incrementally with two additional commits since the last revision: - Changed enableScreenCapture method name to screenCapture shorter method name - Update full name - Chan

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v2]

2023-08-08 Thread lawrence . andrews
> 1) Used builder pattern > 2) Tested AWT tests and it passed lawrence.andrews has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits: - Revert changes to PrintLatinCJKTest.java - Refactor screen capture Move creating sc

Re: RFR: JDK-8302618: Problem typing uppercase letters with java.awt.Robot on Mac when moving mouse [v2]

2023-07-02 Thread lawrence . andrews
On Sat, 1 Jul 2023 00:29:11 GMT, Harshitha Onkar wrote: >> **Problem:** >> >> Robot erroneously produces lowercase letter when mouse is moved (manually) >> in unison with Robot's keyEvents on MacOS. This issue was originally logged >> by a developer of an on-screen accessibility keyboard - To

RFR: 8294535 : Add screen capture functionality to PassFailJFrame

2023-05-24 Thread lawrence . andrews
1) Used builder pattern 2) Tested AWT tests and it passed - Commit messages: - minor changes - Used builder pattern for PassFailJFrame.java - Merge branch 'master' into PassFailJFrame_Screen_Shot - Fixed review comments - Added screen shot functionality to PassFailJFrame.java C

Re: RFR: 8305427: Write a test Check whether focus changes as expected when requestFocus is used to traverse randomly around the window [v5]

2023-05-11 Thread lawrence . andrews
On Thu, 4 May 2023 09:56:18 GMT, Ravi Gupta wrote: >> This testcase Checking whether the Component becoming the Focus Owner and >> FocusEvent.FOCUS_GAINED will be received by the Component when the focus is >> requested on the component using requestFocus. >> >> Testing: >> Tested using Mach5(

Re: RFR: 8307325: Verify the focus owner when non focused windows requesting focus

2023-05-11 Thread lawrence . andrews
On Thu, 4 May 2023 05:41:43 GMT, Ravi Gupta wrote: > Write a test Check, when the top level Window is not the focused Window > requesting for focus and becoming the Focus Owner for any Component in that > Window checking the following > > 1.The Component is the Focus Owner and the Window becom

Re: RFR: 8306137: Open source several AWT ScrollPane related tests

2023-04-24 Thread lawrence . andrews
On Mon, 24 Apr 2023 17:39:17 GMT, Tejesh R wrote: > Open source few AWT ScrollPane related tests. test/jdk/java/awt/ScrollPane/ComponentScrollTest/ComponentScrollTest.java line 48: > 46: public Frame frame; > 47: public int count = 0; > 48: public static void main(String[] args) th

Re: RFR: 8306072: Open source several AWT MouseInfo related tests [v3]

2023-04-24 Thread lawrence . andrews
On Mon, 24 Apr 2023 15:36:34 GMT, lawrence.andrews wrote: >> @lawrence-andrew, BTW, why `transient`? Should it be `volatile` instead? > > Oh, yes, sorry I was meant to say volatile but I typed transient. Sorry for > the confusion. Looks good to me. - PR Review Comment: https://git

Re: RFR: 8306072: Open source several AWT MouseInfo related tests [v3]

2023-04-24 Thread lawrence . andrews
On Mon, 24 Apr 2023 14:58:06 GMT, Nikita Provotorov wrote: >> It is allowed please use transient keyword for xPos & yPos > > @lawrence-andrew, BTW, why `transient`? Should it be `volatile` instead? Oh, yes, sorry I was meant to say volatile but I typed transient. Sorry for the confusion. -

Re: RFR: 8306072: Open source several AWT MouseInfo related tests [v3]

2023-04-24 Thread lawrence . andrews
On Mon, 24 Apr 2023 14:08:24 GMT, Tejesh R wrote: >> test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java line 88: >> >>> 86: EventQueue.invokeAndWait(() -> { >>> 87: Point p = button.getLocationOnScreen(); >>> 88: xPos = p.x + button.getWidth()

Re: RFR: 8306072: Open source several AWT MouseInfo related tests [v3]

2023-04-24 Thread lawrence . andrews
On Mon, 24 Apr 2023 10:04:49 GMT, Tejesh R wrote: >> This open source AWT Mouse Info related tests. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Updated test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java line 88:

Re: RFR: 8306072: Open source several AWT MouseInfo related tests

2023-04-21 Thread lawrence . andrews
On Fri, 21 Apr 2023 05:19:14 GMT, Tejesh R wrote: > This open source AWT Mouse Info related tests. test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java line 92: > 90: throw new RuntimeException("Test failed: Container is > overlapped by " + " child and it should be taken

Re: RFR: 8306133: Open source few AWT Drag & Drop related tests

2023-04-21 Thread lawrence . andrews
On Fri, 21 Apr 2023 21:07:32 GMT, Damon Nguyen wrote: > This PR open sources few AWT DnD related tests test/jdk/java/awt/dnd/NextDropActionTest/NextDropActionTest.java line 159: > 157: } > 158: } finally { > 159: if (frame != null) { frame is created with in EDT

Re: RFR: 8306575: Clean up and open source four Dialog related tests

2023-04-21 Thread lawrence . andrews
On Fri, 21 Apr 2023 21:11:46 GMT, Alexander Zuev wrote: > Cleaned up and stabilized four Dialog-related tests. test/jdk/java/awt/Dialog/ModalDialogOnNonEdt.java line 47: > 45: > 46: public class ModalDialogOnNonEdt { > 47: public void start () { Can you leave a blank line here --

Re: RFR: 8306575: Clean up and open source four Dialog related tests

2023-04-21 Thread lawrence . andrews
On Fri, 21 Apr 2023 21:11:46 GMT, Alexander Zuev wrote: > Cleaned up and stabilized four Dialog-related tests. test/jdk/java/awt/Dialog/DialogLocationTest.java line 142: > 140: int lastX, lastY; > 141: String message = "Failed in componentMoved() expect:[%d,%d]" > 142:

Re: RFR: 8306135: Clean up and open source some AWT tests [v2]

2023-04-18 Thread lawrence . andrews
On Tue, 18 Apr 2023 20:12:16 GMT, Alexander Zuev wrote: >> Cleaning up and open sourcing three AWT tests > > Alexander Zuev has updated the pull request incrementally with two additional > commits since the last revision: > > - Cosmitic change: couple of extra-long strings were reformatted to

Re: RFR: 8306135: Clean up and open source some AWT tests

2023-04-18 Thread lawrence . andrews
On Tue, 18 Apr 2023 18:55:42 GMT, Alexander Zuev wrote: > Cleaning up and open sourcing three AWT tests Set to 80-column limit where ever it required. - PR Comment: https://git.openjdk.org/jdk/pull/13518#issuecomment-1513737817

Re: RFR: 8306135: Clean up and open source some AWT tests

2023-04-18 Thread lawrence . andrews
On Tue, 18 Apr 2023 18:55:42 GMT, Alexander Zuev wrote: > Cleaning up and open sourcing three AWT tests test/jdk/java/awt/Dialog/DialogAsParentOfFileDialog.java line 182: > 180: } > 181: > 182: public static void main(String[] args) throws InterruptedException, > InvocationTargetExcep

Re: RFR: 8306135: Clean up and open source some AWT tests

2023-04-18 Thread lawrence . andrews
On Tue, 18 Apr 2023 18:55:42 GMT, Alexander Zuev wrote: > Cleaning up and open sourcing three AWT tests All the 3 tests are new to open repo and there copy right years are different. - PR Comment: https://git.openjdk.org/jdk/pull/13518#issuecomment-1513670080

Re: RFR: 8306135: Clean up and open source some AWT tests

2023-04-18 Thread lawrence . andrews
On Tue, 18 Apr 2023 18:55:42 GMT, Alexander Zuev wrote: > Cleaning up and open sourcing three AWT tests test/jdk/java/awt/Cursor/SingleColorCursorTest.java line 42: > 40: import java.awt.image.BufferedImage; > 41: import java.lang.reflect.InvocationTargetException; > 42: public class SingleColo

Re: RFR: 6995195: Static initialization deadlock in sun.java2d.loops.Blit and GraphicsPrimitiveMgr

2023-04-13 Thread lawrence . andrews
On Thu, 13 Apr 2023 13:03:37 GMT, Dmitry Cherepanov wrote: > This PR suggests to move generalPrimitives array to a new static nested > GeneralPrimitives class to eliminate the possible deadlock. The Blit class > (and other classes that register as general primitives) calls to > GeneralPrimiti

Re: RFR: 8305427: Write a test Check whether focus changes as expected when requestFocus is used to traverse randomly around the window [v2]

2023-04-07 Thread lawrence . andrews
On Wed, 5 Apr 2023 11:47:06 GMT, Ravi Gupta wrote: >> This testcase Checking whether the Component becoming the Focus Owner and >> FocusEvent.FOCUS_GAINED will be received by the Component when the focus is >> requested on the component using requestFocus. >> >> Testing: >> Tested using Mach5(

Integrated: 8299043 : test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java fails with java.lang.NullPointerException

2022-12-19 Thread lawrence . andrews
On Mon, 19 Dec 2022 20:20:11 GMT, lawrence.andrews wrote: > Test was failing with java.lang.NullPointerException due to image file > extension was specified in upper case ( GIF ) > https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java#L44-L50 >

Integrated: 8299044 : test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac

2022-12-19 Thread lawrence . andrews
On Mon, 19 Dec 2022 19:34:21 GMT, lawrence.andrews wrote: > This test needs to be executed on mac os only > > @shurymury > @honkar-jdk This pull request has now been integrated. Changeset: abc12976 Author:lawrence.andrews Committer: Harshitha Onkar URL: https://git.openjdk.org/jd

Re: RFR: 8299044 : test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac

2022-12-19 Thread lawrence . andrews
On Mon, 19 Dec 2022 20:55:14 GMT, Harshitha Onkar wrote: >> This test needs to be executed on mac os only >> >> @shurymury >> @honkar-jdk > > @lawrence-andrew Since it is manual test, I think adding that it is as > mac-only test to the instructions would provide more clarity. @honkar-jdk , ex

RFR: 8299043 : test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java fails with java.lang.NullPointerException

2022-12-19 Thread lawrence . andrews
Test was failing with java.lang.NullPointerException due to image file extension was specified in upper case ( GIF ) https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java#L44-L50 but actually it is in smaller case ( gif ) https://github.com/ope

RFR: 8299044 : test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac

2022-12-19 Thread lawrence . andrews
This test needs to be executed on mac os only @shurymury @honkar-jdk - Commit messages: - 8299044 : test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac Changes: https://git.openjdk.org/jdk/pull/11730/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=117

Re: [jdk20] RFR: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display [v2]

2022-12-16 Thread lawrence . andrews
On Fri, 16 Dec 2022 20:05:37 GMT, Alexander Zvegintsev wrote: >> openjdk/jdk#9525 has changed behavior of PassFailJFrame. >> it doesn't call `setVisible()` from its constructor on instruction window >> anymore and some tests were not ready for that. >> >> So adding `positionTestWindow()` fixes

Re: [jdk20] RFR: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display [v2]

2022-12-16 Thread lawrence . andrews
On Fri, 16 Dec 2022 20:00:51 GMT, Alexander Zvegintsev wrote: >> openjdk/jdk#9525 has changed behavior of PassFailJFrame. >> it doesn't call `setVisible()` from its constructor on instruction window >> anymore and some tests were not ready for that. >> >> So adding `positionTestWindow()` fixes

Re: [jdk20] RFR: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display

2022-12-16 Thread lawrence . andrews
On Fri, 16 Dec 2022 14:55:13 GMT, Alexander Zvegintsev wrote: > openjdk/jdk#9525 has changed behavior of PassFailJFrame. > it doesn't call `setVisible()` from its constructor on instruction window > anymore and some tests were not ready for that. > > So adding `positionTestWindow()` fixes the

Re: [jdk20] RFR: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display

2022-12-16 Thread lawrence . andrews
On Fri, 16 Dec 2022 14:55:13 GMT, Alexander Zvegintsev wrote: > openjdk/jdk#9525 has changed behavior of PassFailJFrame. > it doesn't call `setVisible()` from its constructor on instruction window > anymore and some tests were not ready for that. > > So adding `positionTestWindow()` fixes the

Re: RFR: 8295707: Create a regression test for JDK-7184401 [v2]

2022-11-14 Thread lawrence . andrews
On Mon, 7 Nov 2022 07:28:02 GMT, Srinivas Mandalika wrote: >> 8295707: Create a regression test for JDK-7184401 >> >> JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for >> 7162144 >> Above bug got introduced due to a fix for >> [JDK-7162144](https://bugs.openjdk.java.net/b

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-14 Thread lawrence . andrews
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296632: Write a test to verify the content change of TextArea sends TextEvent. [v4]

2022-11-11 Thread lawrence . andrews
On Fri, 11 Nov 2022 08:20:55 GMT, ravi gupta wrote: >> This testcase Verify the content changes of a TextArea for the following >> assertions. >> >> a. TextListener get invoked when the content of a TextArea gets changed. >> b. TextListener not get invoked during text selection or when Special

Re: RFR: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

2022-11-09 Thread lawrence . andrews
On Wed, 9 Nov 2022 10:37:24 GMT, Prasanta Sadhukhan wrote: > Test intermittently fails in VM citing "Tree is not editing". Seems to be > problem with mouse clicks not getting registered properly.. > Similar test test/jdk/javax/swing/JTable/6263446/bug6263446.java is not > affected, so made the

Re: RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem.

2022-11-08 Thread lawrence . andrews
On Tue, 8 Nov 2022 08:57:54 GMT, Naveen Narayanan wrote: > Colocate JMenuItemSetAcceleratorTest to a regression test. > > This testcase will > 1) Verify setAccelerator method of JMenuitem. > 2) Check that the selection of a menu item in the menu bar will generate > action by a key combination o

Re: RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem.

2022-11-08 Thread lawrence . andrews
On Tue, 8 Nov 2022 08:57:54 GMT, Naveen Narayanan wrote: > Colocate JMenuItemSetAcceleratorTest to a regression test. > > This testcase will > 1) Verify setAccelerator method of JMenuitem. > 2) Check that the selection of a menu item in the menu bar will generate > action by a key combination o

Integrated: 8296335 : Fix accessibility manual test instruction

2022-11-05 Thread lawrence . andrews
On Fri, 4 Nov 2022 20:18:09 GMT, lawrence.andrews wrote: > Fixed test instruction that helps the manual tester to perform actions > > @shurymury This pull request has now been integrated. Changeset: c2f76383 Author:lawrence.andrews <87324768+lawrence-and...@users.noreply.github.com> Commit

Re: RFR: 8296335 : Fix accessibility manual test instruction [v8]

2022-11-04 Thread lawrence . andrews
> Fixed test instruction that helps the manual tester to perform actions > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Update OptionPaneDemo.html - Changes: - all: https://git.openjdk.org/jdk/pull

Re: RFR: 8296335 : Fix accessibility manual test instruction [v7]

2022-11-04 Thread lawrence . andrews
> Fixed test instruction that helps the manual tester to perform actions > > @shurymury lawrence.andrews has updated the pull request incrementally with four additional commits since the last revision: - Update TreeDemo.html - Update TableDemo.html - Update ComboBoxDemo.html - Update Button

Re: RFR: 8296335 : Fix accessibility manual test instruction [v6]

2022-11-04 Thread lawrence . andrews
> Fixed test instruction that helps the manual tester to perform actions > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Fixed the review comments - Changes: - all: https://git.openjdk.org/jdk/pull/

Re: RFR: 8296335 : Fix accessibility manual test instruction [v5]

2022-11-04 Thread lawrence . andrews
> Fixed test instruction that helps the manual tester to perform actions > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Fixed the review comments - Changes: - all: https://git.openjdk.org/jdk/pull/

Re: RFR: 8296335 : Fix accessibility manual test instruction [v4]

2022-11-04 Thread lawrence . andrews
> Fixed test instruction that helps the manual tester to perform actions > > @shurymury lawrence.andrews has updated the pull request incrementally with two additional commits since the last revision: - Fixed the review comments - html files with just one empty last line - Chang

Re: RFR: 8296335 : Fix accessibility manual test instruction [v3]

2022-11-04 Thread lawrence . andrews
> Fixed test instruction that helps the manual tester to perform actions > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Add a blank line - Changes: - all: https://git.openjdk.org/jdk/pull/10996/fil

Re: RFR: 8296335 : Fix accessibility manual test instruction [v2]

2022-11-04 Thread lawrence . andrews
> Fixed test instruction that helps the manual tester to perform actions > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Preserve last line - Changes: - all: https://git.openjdk.org/jdk/pull/10996/f

RFR: 8296335 : Fix accessibility manual test instruction

2022-11-04 Thread lawrence . andrews
Fixed test instruction that helps the manual tester to perform actions @shurymury - Commit messages: - 8296335 : Fix accessibility manual test instruction Changes: https://git.openjdk.org/jdk/pull/10996/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10996&range=00 Issue:

Re: RFR: 8295707: Create a regression test for JDK-7184401

2022-11-02 Thread lawrence . andrews
On Thu, 20 Oct 2022 08:59:20 GMT, Srinivas Mandalika wrote: > 8295707: Create a regression test for JDK-7184401 > > JDK-7184401 - JDk7u6 : Missing main menu bar in Netbeans after fix for 7162144 > Above bug got introduced due to a fix for > [JDK-7162144](https://bugs.openjdk.java.net/browse/JD

Integrated: 8292309 : Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test

2022-10-04 Thread lawrence . andrews
On Fri, 12 Aug 2022 23:10:01 GMT, lawrence.andrews wrote: > 1) Fixed Parse Exception by removing yesno > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > 2) Throw jtreg.SkippedException when printer is not configured on the test > host > 3) Replaced Sys

Integrated: 8292328 : AccessibleActionsTest.java test instruction for show popup on JLabel did not specify shift key

2022-09-22 Thread lawrence . andrews
On Sat, 13 Aug 2022 22:44:52 GMT, lawrence.andrews wrote: > Corrected the test instruction to show the popup menu on JLabel when voice > over is enabled . > > @shurymury This pull request has now been integrated. Changeset: df53fa75 Author:lawrence.andrews Committer: Alexey Ivanov URL:

Re: RFR: 8292309 : Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test [v3]

2022-09-20 Thread lawrence . andrews
> 1) Fixed Parse Exception by removing yesno > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > 2) Throw jtreg.SkippedException when printer is not configured on the test > host > 3) Replaced Sysout & TestDialog with ManualTestFrame, which allows to the

Re: RFR: 8292309 : Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test [v2]

2022-09-20 Thread lawrence . andrews
On Wed, 7 Sep 2022 22:42:35 GMT, lawrence.andrews wrote: >> 1) Fixed Parse Exception by removing yesno >> test result: Error. Parse Exception: Arguments to `manual' option not >> supported: yesno >> 2) Throw jtreg.SkippedException when printer is not configured on the test >> host >> 3) Replace

Re: RFR: 8293811: Provide a reason for PassFailJFrame.forceFail

2022-09-14 Thread lawrence . andrews
On Wed, 14 Sep 2022 16:27:36 GMT, Alexey Ivanov wrote: > Add `forceFail` implementation which allows passing the reason why the test > is failed. > > I used the newly added method `forceFail(reason)` instead of throwing an > exception in `PrintAllPagesTest`. When the test is run outside of jtr

Integrated: 8292738 : JInternalFrame backgroundShadowBorder & foregroundShadowBorder line is longer in Mac Look and Feel

2022-09-12 Thread lawrence . andrews
On Mon, 22 Aug 2022 21:20:54 GMT, lawrence.andrews wrote: > Border line is seen outside round Rectangle both for JInternalFrame > backgroundShadowBorder & foregroundShadowBorder line in mac L&F. > ![Screen Shot 2022-08-22 at 4 17 49 > PM](https://user-images.githubusercontent.com/87324768/1860

Re: RFR: 8292271 : Fix java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java test [v5]

2022-09-08 Thread lawrence . andrews
> 1) This test was failing due to yesno > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > 2) PrintCheckboxManualTest.html file was missing > 3) Added os.family since test instruction says that its a linux and solair > toolkit only test > 4) Removed Sys

Re: RFR: 8292309 : Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test [v2]

2022-09-07 Thread lawrence . andrews
> 1) Fixed Parse Exception by removing yesno > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > 2) Throw jtreg.SkippedException when printer is not configured on the test > host > 3) Replaced Sysout & TestDialog with ManualTestFrame, which allows to the

Re: RFR: 8292271 : Fix java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java test [v3]

2022-09-07 Thread lawrence . andrews
> 1) This test was failing due to yesno > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > 2) PrintCheckboxManualTest.html file was missing > 3) Added os.family since test instruction says that its a linux and solair > toolkit only test > 4) Removed Sys

Re: RFR: 8292271 : Fix java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java test [v4]

2022-09-07 Thread lawrence . andrews
> 1) This test was failing due to yesno > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > 2) PrintCheckboxManualTest.html file was missing > 3) Added os.family since test instruction says that its a linux and solair > toolkit only test > 4) Removed Sys

Re: RFR: 8292271 : Fix java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java test [v2]

2022-09-07 Thread lawrence . andrews
> 1) This test was failing due to yesno > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > 2) PrintCheckboxManualTest.html file was missing > 3) Added os.family since test instruction says that its a linux and solair > toolkit only test > 4) Removed Sys

Re: RFR: 8292738 : JInternalFrame backgroundShadowBorder & foregroundShadowBorder line is longer in Mac Look and Feel

2022-09-06 Thread lawrence . andrews
On Mon, 22 Aug 2022 21:20:54 GMT, lawrence.andrews wrote: > Border line is seen outside round Rectangle both for JInternalFrame > backgroundShadowBorder & foregroundShadowBorder line in mac L&F. > ![Screen Shot 2022-08-22 at 4 17 49 > PM](https://user-images.githubusercontent.com/87324768/1860

  1   2   >