On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote:
>> @magicus why can't we just use `-pthread` everywhere? My recollection is
>> that `-pthread` both sets compiler directives needed for pthread programming
>> and links to libpthread, so it seems to be what we should be using. ??
>
>> Anothe
On Tue, 11 Mar 2025 19:22:34 GMT, snake66 wrote:
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
This pull request has now been integrated.
Changeset: 771e160d
Author:Harald Ei
On Thu, 13 Mar 2025 13:28:32 GMT, Magnus Ihse Bursie wrote:
>> snake66 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unbreak libjdwp build
>
> Then I think the current solution is fine. Even if OpenBSD
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
snake66 has updated the pull request incrementally with one additional commit
since the last revision:
Unbreak libjdwp build
--
On Wed, 12 Mar 2025 16:56:32 GMT, Magnus Ihse Bursie wrote:
> Also, to double check, are the new variables `ICONV_CFLAGS` and
> `ICONV_LDFLAGS` going to be non-empty on BSD?
Yes, the current BSD port has the following in `libraries.m4`:
if test "x$OPENJDK_TARGET_OS" = "xbsd"; then
if te
On Wed, 12 Mar 2025 12:15:18 GMT, Magnus Ihse Bursie wrote:
> > Another way to phrase this is perhaps: "why don't we need iconv on linux?"
>
> I googled this and can answer it myself: because `iconv()` is built into
> glibc.
Yes, that's what I came to as well. Sorry I didn't include that info
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
snake66 has updated the pull request incrementally with one additional commit
since the last revision:
Set ICONV_* flags for aix and
On Tue, 11 Mar 2025 19:35:45 GMT, Erik Joelsson wrote:
>> Allows for future support for platforms that require different flags for
>> libiconv support.
>>
>> Sponsored-by: The FreeBSD Foundation
>
> I think this looks ok, but please wait for Magnus to have a look too.
@erikj79 Thanks for the r
Allows for future support for platforms that require different flags for
libiconv support.
Sponsored-by: The FreeBSD Foundation
-
Commit messages:
- 8351323: Parameterize libiconv compiler and linker flags
Changes: https://git.openjdk.org/jdk/pull/23995/files
Webrev: https://web
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote:
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
> possible to parameterize this for platforms that use different flags for
> enabling posix threads.
>
> This work is a continuation of the wor
d for the full JDK, and set at the configure stage.
>
> Sponsored by: The FreeBSD Foundation
> Co-authored-by: Greg Lewis
>
> [1]:
> https://github.com/battleblow/jdk23u/commit/dbd90aa8ab0b7f5e4865864a7c63d975daacabf4
snake66 has updated the pull request incrementally with
On Thu, 6 Mar 2025 15:56:43 GMT, Magnus Ihse Bursie wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done
On Thu, 6 Mar 2025 13:53:31 GMT, Antonio Vieiro wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by G
On Thu, 6 Mar 2025 14:15:38 GMT, Erik Joelsson wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by Gr
On Thu, 6 Mar 2025 12:46:25 GMT, David Holmes wrote:
> Abstracting this out seems reasonable to me, though I should say I thought we
> already used `-pthread` rather than `-lpthread`.
I noticed there were a few places that used `-pthread` by default. I left these
alone in this PR.
---
Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's
possible to parameterize this for platforms that use different flags for
enabling posix threads.
This work is a continuation of the work done by Greg Lewis in [1], but
generalized for the full JDK, and set at the conf
16 matches
Mail list logo
