On Tue, 6 Aug 2024 05:51:35 GMT, toshiogata wrote:
> Rename the tests to prevent unexpected deletion of result files when
> `-retain` jtreg option is specified.
> Testing: modified tests
This pull request has now been integrated.
Changeset: e6698f51
Author:t.ogata
Committer:
On Fri, 11 Oct 2024 14:20:46 GMT, Magnus Ihse Bursie wrote:
>> @jonathan-gibbons
>> I was wondering if you have had a chance to see my response and
>> aivanov-jdk's question. I would appreciate your reaction. Thank you.
>
> @toshiogata Jon Gibbons is no longer work
On Fri, 23 Aug 2024 22:36:51 GMT, Jonathan Gibbons wrote:
>> Moving files from one directory to another can sometimes be a bit risky,
>> especially for `javac` tests, because that implies moving the classes from
>> one unnamed package to a different unnamed package.
>>
>> Please confirm that a
On Fri, 23 Aug 2024 22:36:51 GMT, Jonathan Gibbons wrote:
>> Moving files from one directory to another can sometimes be a bit risky,
>> especially for `javac` tests, because that implies moving the classes from
>> one unnamed package to a different unnamed package.
>>
>> Please confirm that a
On Fri, 16 Aug 2024 11:43:05 GMT, Alexey Ivanov wrote:
>> toshiogata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move jtreg tags and expand wildcard imports
>
> I suggest not to edit the files and only
On Fri, 16 Aug 2024 01:02:17 GMT, toshiogata wrote:
>> test/langtools/tools/javac/warnings/Serial/Serial.java line 1:
>>
>>> 1: /*
>>
>> move jtreg tags below imports and add copyrights
>
> The copyright has been intentionally omitted as explained in
On Fri, 16 Aug 2024 11:40:20 GMT, Alexey Ivanov wrote:
>> As you mentioned, it's a good time to make a minor improvement, so I
>> modified the test.
>
> I propose not to edit the renamed files.
>
> First of all, the purpose of this PR is to *rename tests* to workaround a
> _misfeature_ of jtre
> Rename the tests to prevent unexpected deletion of result files when
> `-retain` jtreg option is specified.
> Testing: modified tests
toshiogata has updated the pull request incrementally with one additional
commit since the last revision:
Revert "Move jtreg tags and e
On Wed, 14 Aug 2024 23:43:14 GMT, Alisen Chung wrote:
>> toshiogata has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move jtreg tags and expand wildcard imports
>
> test/langtools/tools/java
> Rename the tests to prevent unexpected deletion of result files when
> `-retain` jtreg option is specified.
> Testing: modified tests
toshiogata has updated the pull request incrementally with one additional
commit since the last revision:
Move jtreg tags and expand wildcar
Rename the tests to prevent unexpected deletion of result files when `-retain`
jtreg option is specified.
Testing: modified tests
-
Commit messages:
- Merge branch 'master' into 8337851
- 8337851: Some tests have name which confuse jtreg
Changes: https://git.openjdk.org/jdk/pull/2
11 matches
Mail list logo
