Re: RFR: 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor

2022-12-07 Thread Julian Waters
On Fri, 30 Sep 2022 22:28:40 GMT, SWinxy wrote: >> Appends: `, copying the array contents of {@code xpoints} and {@code >> ypoints}` to specify that the arrays in the constructor are explicitly >> copied. > > The projects page on openjdk.org says that two integrated PRs are required, > but I

Re: RFR: 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor

2022-09-30 Thread SWinxy
On Mon, 26 Sep 2022 02:49:36 GMT, SWinxy wrote: > Appends: `, copying the array contents of {@code xpoints} and {@code > ypoints}` to specify that the arrays in the constructor are explicitly copied. The projects page on openjdk.org says that two integrated PRs are required, but I only have

Re: RFR: 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor

2022-09-30 Thread Phil Race
On Fri, 30 Sep 2022 21:06:51 GMT, SWinxy wrote: >Unfortunately I do not have a JBS account so I'm unable to add the issue to >the CSR board. You need it for the other one too. I think the best thing is for you to request one. See https://openjdk.org/guide/#becoming-an-author Otherwise 99% of

Re: RFR: 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor

2022-09-30 Thread SWinxy
On Fri, 30 Sep 2022 21:00:30 GMT, Phil Race wrote: > So OK, let's add the new text but the reason we need it is because of > questionable design. Mhmm. OK. Unfortunately I do not have a JBS account so I'm unable to add the issue to the CSR board. - PR:

Re: RFR: 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor

2022-09-30 Thread SWinxy
On Mon, 26 Sep 2022 02:49:36 GMT, SWinxy wrote: > Appends: `, copying the array contents of {@code xpoints} and {@code > ypoints}` to specify that the arrays in the constructor are explicitly copied. Alright then. Just an old issue that wasn't really an issue. - PR:

Re: RFR: 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor

2022-09-30 Thread Phil Race
On Mon, 26 Sep 2022 02:49:36 GMT, SWinxy wrote: > Appends: `, copying the array contents of {@code xpoints} and {@code > ypoints}` to specify that the arrays in the constructor are explicitly copied. Marked as reviewed by prr (Reviewer). Really I'm not sure this is needed. "Constructs and

RFR: 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor

2022-09-25 Thread SWinxy
Appends: `, copying the array contents of {@code xpoints} and {@code ypoints}` to specify that the arrays in the constructor are explicitly copied. - Commit messages: - 4756278: RFE: Insufficient API documentation for java.awt.Polygon constructor Changes: