Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v3]

2023-07-13 Thread Phil Race
On Tue, 11 Jul 2023 15:54:56 GMT, Liam Miller-Cushon wrote: >> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to >> use the reported length of the segment instead of assuming it's always >> exactly 14 bytes. > > Liam Miller-Cushon has updated the pull request increment

Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v3]

2023-07-11 Thread Phil Race
On Tue, 11 Jul 2023 15:54:56 GMT, Liam Miller-Cushon wrote: >> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to >> use the reported length of the segment instead of assuming it's always >> exactly 14 bytes. > > Liam Miller-Cushon has updated the pull request increment

Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v2]

2023-07-11 Thread Liam Miller-Cushon
On Tue, 11 Jul 2023 07:24:36 GMT, Jeremy wrote: > Does anyone want to reinstate a test for this? I created a simple 10x10 black > jpeg that reproduces the problem: > > https://drive.google.com/file/d/15rhf9-aMqajgoc3OKFhJq92hIu4OmG32/view?usp=sharing Thanks! I have reinstated the test with tha

Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v3]

2023-07-11 Thread Liam Miller-Cushon
> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to > use the reported length of the segment instead of assuming it's always > exactly 14 bytes. Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision: Restore

Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v2]

2023-07-11 Thread Jeremy
On Wed, 5 Jul 2023 23:51:11 GMT, Liam Miller-Cushon wrote: >> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to >> use the reported length of the segment instead of assuming it's always >> exactly 14 bytes. > > Liam Miller-Cushon has updated the pull request with a new

Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v2]

2023-07-10 Thread Sergey Bylokhov
On Wed, 5 Jul 2023 23:51:11 GMT, Liam Miller-Cushon wrote: >> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to >> use the reported length of the segment instead of assuming it's always >> exactly 14 bytes. > > Liam Miller-Cushon has updated the pull request with a new

Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v2]

2023-07-10 Thread Phil Race
On Wed, 5 Jul 2023 23:51:11 GMT, Liam Miller-Cushon wrote: >> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to >> use the reported length of the segment instead of assuming it's always >> exactly 14 bytes. > > Liam Miller-Cushon has updated the pull request with a new

Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG

2023-07-05 Thread Liam Miller-Cushon
On Wed, 5 Jul 2023 23:19:39 GMT, Liam Miller-Cushon wrote: > Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to > use the reported length of the segment instead of assuming it's always > exactly 14 bytes. Thanks, I have removed the test - PR Comment: http

Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG [v2]

2023-07-05 Thread Liam Miller-Cushon
> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to > use the reported length of the segment instead of assuming it's always > exactly 14 bytes. Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The pull request now cont

Re: RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG

2023-07-05 Thread Phil Race
On Wed, 5 Jul 2023 23:19:39 GMT, Liam Miller-Cushon wrote: > Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to > use the reported length of the segment instead of assuming it's always > exactly 14 bytes. The provided image for the test looks to me like a down-sized ve

RFR: 6355567: AdobeMarkerSegment causes failure to read valid JPEG

2023-07-05 Thread Liam Miller-Cushon
Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to use the reported length of the segment instead of assuming it's always exactly 14 bytes. - Commit messages: - 6355567: AdobeMarkerSegment causes failure to read valid JPEG Changes: https://git.openjdk.org/