Re: RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding [v2]

2023-03-23 Thread Prasanta Sadhukhan
On Thu, 23 Mar 2023 07:28:05 GMT, Jayathirth D V wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comment > > test/jdk/javax/swing/JToggleButton/TestSelectedKey.java line 26: > >> 24: /* @test >> 25:

Re: RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding [v2]

2023-03-23 Thread Prasanta Sadhukhan
> When the Action.SELECTED_KEY property action is assigned to ToggleButton and > an accelerator key binding is mapped to the action, then pressing the > accelerator key binding does not toggle the toggle button. > This is because SwingUtilities.notifyAction does not fire itemStateChanged > event

Re: RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding

2023-03-23 Thread Jayathirth D V
On Fri, 27 Jan 2023 10:26:10 GMT, Prasanta Sadhukhan wrote: > When the Action.SELECTED_KEY property action is assigned to ToggleButton and > an accelerator key binding is mapped to the action, then pressing the > accelerator key binding does not toggle the toggle button. > This is because Swin

Re: RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding

2023-01-30 Thread Andrey Turbanov
On Fri, 27 Jan 2023 10:26:10 GMT, Prasanta Sadhukhan wrote: > When the Action.SELECTED_KEY property action is assigned to ToggleButton and > an accelerator key binding is mapped to the action, then pressing the > accelerator key binding does not toggle the toggle button. > This is because Swin

Re: RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding

2023-01-27 Thread SWinxy
On Fri, 27 Jan 2023 10:26:10 GMT, Prasanta Sadhukhan wrote: > When the Action.SELECTED_KEY property action is assigned to ToggleButton and > an accelerator key binding is mapped to the action, then pressing the > accelerator key binding does not toggle the toggle button. > This is because Swin

Re: RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding

2023-01-27 Thread Tejesh R
On Fri, 27 Jan 2023 10:26:10 GMT, Prasanta Sadhukhan wrote: > When the Action.SELECTED_KEY property action is assigned to ToggleButton and > an accelerator key binding is mapped to the action, then pressing the > accelerator key binding does not toggle the toggle button. > This is because Swin

RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding

2023-01-27 Thread Prasanta Sadhukhan
When the Action.SELECTED_KEY property action is assigned to ToggleButton and an accelerator key binding is mapped to the action, then pressing the accelerator key binding does not toggle the toggle button. This is because SwingUtilities.notifyAction does not fire itemStateChanged event for such