Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-08-11 Thread Damon Nguyen
On Tue, 12 Jul 2022 22:56:37 GMT, Damon Nguyen wrote: >> When a JComboBox is editable, the button segment of the combo box is >> misaligned vertically and has a different height. This change fixes these >> issues and adds a manual test that checks the appearance of an editable and >> non-edita

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-08-08 Thread Damon Nguyen
On Thu, 14 Jul 2022 16:25:12 GMT, Damon Nguyen wrote: > Can you please show before and after fix image of the editable combobox? It > seems the border around the button makes it feel it's still not aligned > properly which gives the impression that the button is bigger than textfield. > Probab

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-07-15 Thread Prasanta Sadhukhan
On Thu, 14 Jul 2022 16:25:12 GMT, Damon Nguyen wrote: >. I tried these but none removed the border (even though appearance changes >for a standard JButton in testing): > > * arrowButton.setBorder(javax.swing.BorderFactory.createEmptyBorder()); > * arrowButton.setBorderPainted(false); > * arrowB

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-07-14 Thread Damon Nguyen
On Tue, 12 Jul 2022 22:56:37 GMT, Damon Nguyen wrote: >> When a JComboBox is editable, the button segment of the combo box is >> misaligned vertically and has a different height. This change fixes these >> issues and adds a manual test that checks the appearance of an editable and >> non-edita

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-07-13 Thread Prasanta Sadhukhan
On Tue, 12 Jul 2022 22:56:37 GMT, Damon Nguyen wrote: >> When a JComboBox is editable, the button segment of the combo box is >> misaligned vertically and has a different height. This change fixes these >> issues and adds a manual test that checks the appearance of an editable and >> non-edita

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-07-13 Thread Damon Nguyen
On Wed, 13 Jul 2022 11:31:07 GMT, Prasanta Sadhukhan wrote: > Can you please show before and after fix image of the editable combobox? It > seems the border around the button makes it feel it's still not aligned > properly which gives the impression that the button is bigger than textfield. >

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-07-13 Thread Prasanta Sadhukhan
On Tue, 12 Jul 2022 22:56:37 GMT, Damon Nguyen wrote: >> When a JComboBox is editable, the button segment of the combo box is >> misaligned vertically and has a different height. This change fixes these >> issues and adds a manual test that checks the appearance of an editable and >> non-edita

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-07-12 Thread Damon Nguyen
On Tue, 12 Jul 2022 19:49:49 GMT, Harshitha Onkar wrote: >> Damon Nguyen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commi

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-07-12 Thread Damon Nguyen
> When a JComboBox is editable, the button segment of the combo box is > misaligned vertically and has a different height. This change fixes these > issues and adds a manual test that checks the appearance of an editable and > non-editable JComboBox. > > One of the discussions revolving this is