On Thu, 30 May 2024 20:18:16 GMT, Alisen Chung wrote:
>>> why does the get method also set the `isMnemonicHidden` flag? Shouldn't
>>> this only be done on the set method?
>>
>> `isMnemonicHidden` is set to false to make sure if the UI defaults don't
>> support to hide mnemonics, then don't hid
On Fri, 10 May 2024 05:48:35 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
>> line 1085:
>>
>>> 1083: if (UIManager.getBoolean("Button.showMnemonics")) {
>>> 1084: // Do not hide mnemonics if the UI defaults do not
On Thu, 9 May 2024 17:47:03 GMT, Phil Race wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Var moved to local scope
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
> line 668:
>
On Thu, 9 May 2024 20:49:55 GMT, Alisen Chung wrote:
> why does the get method also set the `isMnemonicHidden` flag? Shouldn't this
> only be done on the set method?
`isMnemonicHidden` is set to false to make sure if the UI defaults don't
support to hide mnemonics, then don't hide it.
---
On Thu, 9 May 2024 17:47:03 GMT, Phil Race wrote:
> Or perhaps this should be pushed down to the GTK L&F
I tried to have this implementation in GTK L&F but there were some build issue
I was facing. So, moved it to Synth L&F but that impacts Nimbus L&F as well.
> This doesn't seem like an idea
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>
On Wed, 8 May 2024 06:56:40 GMT, Tejesh R wrote:
> `postProcessKeyEvent(KeyEvent ev)` method from `AquaMnemonicHandler` class is
> reused instead of `WindowsRootPaneUI` class, any reason for that? (Since I
> see some differences in the way they are processing the event).
In Windows, the behavi
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
>
On Wed, 8 May 2024 05:05:02 GMT, Tejesh R wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Var moved to local scope
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestMenuMnemonicOnAltPress.java line 48:
>
>> 46: p
> In GTK LAF, the menu mnemonics are always displayed which is different from
> the native behavior. In native application **(tested with gedit**), the menu
> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
> and then toggles between show/hide on `ALT` press.
> Propo
12 matches
Mail list logo
