Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v9]

2024-06-28 Thread Abhishek Kumar
On Thu, 27 Jun 2024 17:17:12 GMT, Alexey Ivanov wrote: >> Abhishek Kumar has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Mnemonic handler class >> - Mnemonic handler added and previous implementation revert back > > I think we're movi

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v9]

2024-06-28 Thread Abhishek Kumar
On Thu, 27 Jun 2024 17:17:12 GMT, Alexey Ivanov wrote: > I think we're moving in the right direction. > > My idea was to extract the common functionality as the methods > `setMnemonicHidden`, `isMnemonicHidden` and `repaintMnemonicsInWindow`, > `repaintMnemonicsInContainer` into a helper class

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v9]

2024-06-27 Thread Alexey Ivanov
On Thu, 27 Jun 2024 10:06:49 GMT, Abhishek Kumar wrote: >> In GTK LAF, the menu mnemonics are always displayed which is different from >> the native behavior. In native application **(tested with gedit for normal >> buttons and tested with libreoffice for menu**), the menu mnemonics toggle >>

Re: RFR: 8155030: The Menu Mnemonics are always displayed for GTK LAF [v9]

2024-06-27 Thread Abhishek Kumar
> In GTK LAF, the menu mnemonics are always displayed which is different from > the native behavior. In native application **(tested with gedit for normal > buttons and tested with libreoffice for menu**), the menu mnemonics toggle on > press of `ALT` key. Menu mnemonics are hidden initially and