Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]

2024-06-04 Thread Alexey Ivanov
On Mon, 3 Jun 2024 05:48:18 GMT, Abhishek Kumar wrote: >> Previous formatting was less confusing and aligned with Java Coding Style >> Guidelines. >> >> The parameters to the method are aligned to the opening parenthesis; the >> `throws` clause is not part of the parameters and it's placed on

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]

2024-06-02 Thread Abhishek Kumar
On Fri, 31 May 2024 20:47:52 GMT, Alexey Ivanov wrote: >> Updated. > > Previous formatting was less confusing and aligned with Java Coding Style > Guidelines. > > The parameters to the method are aligned to the opening parenthesis; the > `throws` clause is not part of the parameters and it's

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]

2024-05-31 Thread Alexey Ivanov
On Fri, 31 May 2024 04:39:24 GMT, Abhishek Kumar wrote: >> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 136: >> >>> 134: if (refimg.getWidth() != testimg.getWidth() || >>> 135: refimg.getHeight() != testimg.getHeight()) >>> 136: {

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]

2024-05-31 Thread Alexey Ivanov
On Fri, 31 May 2024 05:02:16 GMT, Abhishek Kumar wrote: >> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 70: >> >>> 68: Class >>> type) >>> 69: throws Throwable >>> 70: { >> >> I think formatting here looks a little odd, could

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]

2024-05-30 Thread Abhishek Kumar
On Thu, 30 May 2024 19:24:32 GMT, Alisen Chung wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> background method removed > > test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 61: > >> 59:

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]

2024-05-30 Thread Abhishek Kumar
On Thu, 30 May 2024 19:59:40 GMT, Alisen Chung wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> background method removed > > test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 136: > >> 134:

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]

2024-05-30 Thread Alisen Chung
On Thu, 30 May 2024 07:33:31 GMT, Abhishek Kumar wrote: >> bug6492108.java test always fails in GTK L in single as well as dual >> screen linux machines. Since this test was not marked as "_headful_" in it's >> initial version, it never failed but after the fix of >>

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]

2024-05-30 Thread Abhishek Kumar
> bug6492108.java test always fails in GTK L in single as well as dual screen > linux machines. Since this test was not marked as "_headful_" in it's initial > version, it never failed but after the fix of > [JDK-8287051](https://bugs.openjdk.org/browse/JDK-8287051) this test was > problem

Re: RFR: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L [v3]

2024-05-30 Thread Abhishek Kumar
On Thu, 30 May 2024 07:16:20 GMT, Tejesh R wrote: >> Actually I can see the debug output in my local run. >> `invoking: onEDT10 >> onEDT10 >> invoking: onBackgroundThread20 >> onBackgroundThread20 >> invoking: onBackgroundThread30 >> onBackgroundThread30` >> >> But as I told before this may not