On Thu, 26 Oct 2023 06:11:50 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
On Thu, 26 Oct 2023 06:11:50 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
> Hi Reviewers,
>
> I have added additional CountDownLatch for making sure button is visible
> before proceeding,(observe this was one of the key reason for failure) so
> this helps to improve test case stability. Modified _await()_ function by
> adding 1sec timeout with exception, this will he
On Wed, 25 Oct 2023 03:23:01 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
> Hi Reviewers,
>
> I have added additional CountDownLatch for making sure button is visible
> before proceeding,(observe this was one of the key reason for failure) so
> this helps to improve test case stability. Modified _await()_ function by
> adding 1sec timeout with exception, this will he
On Mon, 23 Oct 2023 17:45:38 GMT, Alexey Ivanov wrote:
> The updated test failed once on Linux when I ran the test on Friday…
I've run this test on all the platforms a few times more, no failures detected.
So I consider that failure a one-off glitch.
-
PR Comment: https://git.open
On Mon, 23 Oct 2023 03:28:00 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
On Mon, 23 Oct 2023 03:28:00 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
On Mon, 23 Oct 2023 03:28:00 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
On Fri, 20 Oct 2023 06:59:17 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have added additional CountDownLatch for making sure button is visible
> before proceeding,(observe this was one of the key reason for failure) so
> this helps to improve test case stability. Modified _a
> Hi Reviewers,
>
> I have added additional CountDownLatch for making sure button is visible
> before proceeding,(observe this was one of the key reason for failure) so
> this helps to improve test case stability. Modified _await()_ function by
> adding 1sec timeout with exception, this will he
On Fri, 20 Oct 2023 11:42:03 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/event/MouseWheelEvent/WheelModifier/WheelModifier.java
>> line 173:
>>
>>> 171: test.run();
>>> 172: } finally {
>>> 173: SwingUtilities.invokeAndWait(test.f::dispose);
>>
>> It would be
On Fri, 20 Oct 2023 10:13:40 GMT, Dmitry Markov wrote:
> It would be good to ensure that f is not NULL before dispose.
I know we're doing it all the time… But is it really relevant?
This has been bothering me for a while now… Let's clear things up.
If the frame is `null`, something has gone aw
On Fri, 20 Oct 2023 06:59:17 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have added additional CountDownLatch for making sure button is visible
> before proceeding,(observe this was one of the key reason for failure) so
> this helps to improve test case stability. Modified _a
On Fri, 20 Oct 2023 06:59:17 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have added additional CountDownLatch for making sure button is visible
> before proceeding,(observe this was one of the key reason for failure) so
> this helps to improve test case stability. Modified _a
Hi Reviewers,
I have added additional CountDownLatch for making sure button is visible before
proceeding,(observe this was one of the key reason for failure) so this helps
to improve test case stability. Modified _await()_ function by adding 1sec
timeout with exception, this will help to reduce
On Fri, 13 Oct 2023 15:07:30 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Revivers,
>
> Part of stability improvement for the test case **WheelModifier.java** I have
> moved _getLocationOnScreen()_ and _getSize()_ into EDT, part of warning
> removal updated _BUTTON1_MASK_ with _BUTTON1_DOWN_MA
Hi Revivers,
Part of stability improvement for the test case **WheelModifier.java** I have
moved _getLocationOnScreen()_ and _getSize()_ into EDT, part of warning removal
updated _BUTTON1_MASK_ with _BUTTON1_DOWN_MASK_
Please review and let me know your suggestions.
-
Commit messa
18 matches
Mail list logo