On Wed, 21 Feb 2024 04:27:13 GMT, Tejesh R wrote:
>> That code was added by me to implement the shaped windows on macOS, that is
>> the only platform we support the translucent backbuffer in RepaintManager.
>> For the translucent backbuffer and even opaque component it is necessary to
>>
On Tue, 20 Feb 2024 07:21:18 GMT, Sergey Bylokhov wrote:
>> This how it is done in
>> [RepaintManager](https://github.com/openjdk/jdk/blob/69a11c7f7ea7c4195a8ee56391bdf04c75bd8156/src/java.desktop/share/classes/javax/swing/RepaintManager.java#L1711),
>> it uses background color of the
On Tue, 20 Feb 2024 07:21:18 GMT, Sergey Bylokhov wrote:
>> This how it is done in
>> [RepaintManager](https://github.com/openjdk/jdk/blob/69a11c7f7ea7c4195a8ee56391bdf04c75bd8156/src/java.desktop/share/classes/javax/swing/RepaintManager.java#L1711),
>> it uses background color of the
On Tue, 20 Feb 2024 05:36:55 GMT, Tejesh R wrote:
>> Since this is an intermediate buffer its content should not affect the
>> rendering, so it should contain only the image rendered by the component
>> itself.
>
> This how it is done in
>
On Tue, 20 Feb 2024 05:34:00 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/javax/swing/BufferStrategyPaintManager.java
>> line 252:
>>
>>> 250:
>>> g2d.setBackground(paintingComponent.getBackground());
>>> 251: g2d.clearRect(x, y, w, h);
On Tue, 20 Feb 2024 05:17:04 GMT, Sergey Bylokhov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Frame dispose moved into EDT
>
> src/java.desktop/share/classes/javax/swing/BufferStrategyPaintManager.java
> line
On Mon, 12 Feb 2024 05:38:17 GMT, Tejesh R wrote:
>> This is happening in linux where `BuffereStrategyPaintManager` is used to
>> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
>> to offscreen where the background is not refreshed, which does only clipping
>> and
On Mon, 12 Feb 2024 05:38:17 GMT, Tejesh R wrote:
>> This is happening in linux where `BuffereStrategyPaintManager` is used to
>> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
>> to offscreen where the background is not refreshed, which does only clipping
>> and
On Thu, 15 Feb 2024 18:46:37 GMT, Alexander Zvegintsev
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Frame dispose moved into EDT
>
> Marked as reviewed by azvegint (Reviewer).
@azvegint @mrserb I have created two
On Mon, 12 Feb 2024 05:38:17 GMT, Tejesh R wrote:
>> This is happening in linux where `BuffereStrategyPaintManager` is used to
>> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
>> to offscreen where the background is not refreshed, which does only clipping
>> and
On Thu, 15 Feb 2024 18:46:25 GMT, Alexander Zvegintsev
wrote:
>> On windows the robot mouse move doesn't drag the frame as smooth as in
>> linux, it is getting stuck within the white frame. On Mac though the drag is
>> smooth, somehow the test is failing sometimes on CI system (Nothing to do
On Thu, 15 Feb 2024 05:28:22 GMT, Tejesh R wrote:
>> It is better to check why it fails there, it uses the public api only and it
>> should work on all platforms.
>
> On windows the robot mouse move doesn't drag the frame as smooth as in linux,
> it is getting stuck within the white frame. On
On Mon, 12 Feb 2024 05:38:17 GMT, Tejesh R wrote:
>> This is happening in linux where `BuffereStrategyPaintManager` is used to
>> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
>> to offscreen where the background is not refreshed, which does only clipping
>> and
On Thu, 15 Feb 2024 03:35:17 GMT, Sergey Bylokhov wrote:
>> Somehow the automated test is not working flawless in windows and mac. In
>> windows the image is getting stuck at center of white frame when its made
>> automatic and in mac CI machines are failing even though the white screen is
>>
On Tue, 6 Feb 2024 08:09:20 GMT, Tejesh R wrote:
>> Since the fix was done for linux alone, I have restricted the test to it.
>> Anyhow it works on windows and mac.
>
> Somehow the automated test is not working flawless in windows and mac. In
> windows the image is getting stuck at center of
> This is happening in linux where `BuffereStrategyPaintManager` is used to
> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
> to offscreen where the background is not refreshed, which does only clipping
> and then paints to offscreen. In order to handle the screen
On Tue, 6 Feb 2024 08:08:04 GMT, Tejesh R wrote:
>> This is happening in linux where `BuffereStrategyPaintManager` is used to
>> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
>> to offscreen where the background is not refreshed, which does only clipping
>> and
On Fri, 2 Feb 2024 07:01:20 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/BufferStrategyPaintManager.java
>> line 251:
>>
>>> 249: g2d.setBackground(paintingComponent.getBackground());
>>> 250: g2d.clearRect(x, y, w, h);
>>> 251:
On Fri, 2 Feb 2024 07:03:09 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JFrame/JFrameBackgroundRefreshTest.java line 77:
>>
>>> 75:
>>> 76: frame = new JFrame("JFrame Background refresh test");
>>> 77: passFailJFrame = new PassFailJFrame("Test Instructions",
>>
>> This test
> This is happening in linux where `BuffereStrategyPaintManager` is used to
> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
> to offscreen where the background is not refreshed, which does only clipping
> and then paints to offscreen. In order to handle the screen
On Thu, 1 Feb 2024 16:23:01 GMT, Alexander Zvegintsev
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/BufferStrategyPaintManager.java
> line 251:
>
>> 249:
On Fri, 12 Jan 2024 07:17:37 GMT, Tejesh R wrote:
>> This is happening in linux where `BuffereStrategyPaintManager` is used to
>> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
>> to offscreen where the background is not refreshed, which does only clipping
>> and
> This is happening in linux where `BuffereStrategyPaintManager` is used to
> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
> to offscreen where the background is not refreshed, which does only clipping
> and then paints to offscreen. In order to handle the screen
On Fri, 12 Jan 2024 06:32:55 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JFrame/JFrameBackgroundRefreshTest.java line 129:
>
>> 127:
On Tue, 12 Dec 2023 13:04:26 GMT, Tejesh R wrote:
> This is happening in linux where `BuffereStrategyPaintManager` is used to
> paint to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint
> to offscreen where the background is not refreshed, which does only clipping
> and
On Mon, 18 Dec 2023 16:15:09 GMT, Alexey Ivanov wrote:
> > > > This is happening in linux
> > > > Is it the Linux only? If yes why it cannot be reproduced on macOS and
> > > > Windows?
> >
> >
> > Yes, This is happening only in linux. The paintToOffScreen is done by
> >
On Mon, 18 Dec 2023 05:02:42 GMT, Tejesh R wrote:
> > > This is happening in linux
> > > Is it the Linux only? If yes why it cannot be reproduced on macOS and
> > > Windows?
>
> Yes, This is happening only in linux. The paintToOffScreen is done by
> BufferStrategyPaintManager rather than
On Fri, 15 Dec 2023 19:41:53 GMT, Sergey Bylokhov wrote:
> > This is happening in linux
> > Is it the Linux only? If yes why it cannot be reproduced on macOS and
> > Windows?
Yes, This is happening only in linux. The paintToOffScreen is done by
BufferStrategyPaintManager rather than
On Tue, 12 Dec 2023 13:04:26 GMT, Tejesh R wrote:
>This is happening in linux
Is it the Linux only? If yes why it cannot be reproduced on macOS and Windows?
-
PR Comment: https://git.openjdk.org/jdk/pull/17081#issuecomment-1858401386
This is happening in linux where `BuffereStrategyPaintManager` is used to paint
to offscreen. Here `bsg` bufferStrategy SunGraphics2D is used to paint to
offscreen where the background is not refreshed, which does only clipping and
then paints to offscreen. In order to handle the screen
30 matches
Mail list logo
