Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2]

2024-10-14 Thread Steven Loomis
On Sat, 25 May 2024 23:16:02 GMT, Phil Race wrote: >>> I'm able to build this again, but not satisfied that it solves the issue, >>> so I am still investigating. Should I rebase this upon latest master or >>> somewhere else (now that 22 is released)? @prrace >> >> @srl295 >> You are based on

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2]

2024-05-25 Thread Steven Loomis
On Sat, 25 May 2024 00:02:36 GMT, Steven Loomis wrote: >>> I'm able to build this again, but not satisfied that it solves the issue, >>> so I am still investigating. Should I rebase this upon latest master or >>> somewhere else (now that 22 is released)? @prrace >> >> @srl295 >> You are based

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2]

2024-05-25 Thread Phil Race
On Wed, 20 Mar 2024 17:27:12 GMT, Phil Race wrote: >> Marked as reviewed by prr (Reviewer). > >> I'm able to build this again, but not satisfied that it solves the issue, so >> I am still investigating. Should I rebase this upon latest master or >> somewhere else (now that 22 is released)? @prr

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2]

2024-05-25 Thread Phil Race
On Fri, 24 May 2024 23:34:23 GMT, Steven Loomis wrote: >> 8195675: Call to insertText with single character from custom Input Method >> ignored > > Steven Loomis has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated chang

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2]

2024-05-24 Thread Steven Loomis
On Wed, 20 Mar 2024 17:27:12 GMT, Phil Race wrote: >> Marked as reviewed by prr (Reviewer). > >> I'm able to build this again, but not satisfied that it solves the issue, so >> I am still investigating. Should I rebase this upon latest master or >> somewhere else (now that 22 is released)? @prr

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2]

2024-05-24 Thread Steven Loomis
On Fri, 24 May 2024 23:34:23 GMT, Steven Loomis wrote: >> 8195675: Call to insertText with single character from custom Input Method >> ignored > > Steven Loomis has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated chang

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2]

2024-05-24 Thread Steven Loomis
On Wed, 20 Mar 2024 17:27:12 GMT, Phil Race wrote: >> Marked as reviewed by prr (Reviewer). > >> I'm able to build this again, but not satisfied that it solves the issue, so >> I am still investigating. Should I rebase this upon latest master or >> somewhere else (now that 22 is released)? @prr

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2]

2024-05-24 Thread Steven Loomis
> 8195675: Call to insertText with single character from custom Input Method > ignored Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains th

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored

2024-05-08 Thread Steven Loomis
On Wed, 20 Mar 2024 17:27:12 GMT, Phil Race wrote: >> Marked as reviewed by prr (Reviewer). > >> I'm able to build this again, but not satisfied that it solves the issue, so >> I am still investigating. Should I rebase this upon latest master or >> somewhere else (now that 22 is released)? @prr

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored

2024-05-08 Thread Steven Loomis
On Tue, 20 Feb 2024 02:08:09 GMT, Steven Loomis wrote: > 8195675: Call to insertText with single character from custom Input Method > ignored Just got my Mac setup again today - will commence testing - PR Comment: https://git.openjdk.org/jdk/pull/17921#issuecomment-2101596229

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored

2024-03-20 Thread Steven Loomis
On Tue, 20 Feb 2024 02:08:09 GMT, Steven Loomis wrote: > 8195675: Call to insertText with single character from custom Input Method > ignored Great. I'll keep investigating - PR Comment: https://git.openjdk.org/jdk/pull/17921#issuecomment-2010198705

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored

2024-03-20 Thread Phil Race
On Mon, 4 Mar 2024 17:02:29 GMT, Phil Race wrote: >> 8195675: Call to insertText with single character from custom Input Method >> ignored > > Marked as reviewed by prr (Reviewer). > I'm able to build this again, but not satisfied that it solves the issue, so > I am still investigating. Should

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored

2024-03-19 Thread Steven Loomis
On Tue, 20 Feb 2024 02:08:09 GMT, Steven Loomis wrote: > 8195675: Call to insertText with single character from custom Input Method > ignored I'm able to build this again, but not satisfied that it solves the issue, so I am still investigating. Should I rebase this upon latest master or somew

Re: RFR: 8195675: Call to insertText with single character from custom Input Method ignored

2024-03-04 Thread Phil Race
On Tue, 20 Feb 2024 02:08:09 GMT, Steven Loomis wrote: > 8195675: Call to insertText with single character from custom Input Method > ignored Marked as reviewed by prr (Reviewer). src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m line 972: > 970: ((utf8Length > 1) && [self >

RFR: 8195675: Call to insertText with single character from custom Input Method ignored

2024-02-29 Thread Steven Loomis
8195675: Call to insertText with single character from custom Input Method ignored - Commit messages: - 8195675: Update AWTView.m - 8195675: [MacOS] fix Keyman input methods on mac Changes: https://git.openjdk.org/jdk/pull/17921/files Webrev: https://webrevs.openjdk.org/?repo=jdk