Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu [v3]

2023-01-18 Thread Julian Waters
On Wed, 18 Jan 2023 15:21:34 GMT, SWinxy wrote: >> Please review this small change to cache a component's popup menu in BLAF. > > SWinxy has updated the pull request incrementally with one additional commit > since the last revision: > > order imports Good Work buddy :) - PR: h

Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu [v3]

2023-01-18 Thread SWinxy
On Wed, 18 Jan 2023 15:21:34 GMT, SWinxy wrote: >> Please review this small change to cache a component's popup menu in BLAF. > > SWinxy has updated the pull request incrementally with one additional commit > since the last revision: > > order imports @TheShermanTanker you might be needed he

Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu [v3]

2023-01-18 Thread Prasanta Sadhukhan
On Wed, 18 Jan 2023 15:21:34 GMT, SWinxy wrote: >> Please review this small change to cache a component's popup menu in BLAF. > > SWinxy has updated the pull request incrementally with one additional commit > since the last revision: > > order imports Marked as reviewed by psadhukhan (Review

Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu [v3]

2023-01-18 Thread SWinxy
> Please review this small change to cache a component's popup menu in BLAF. SWinxy has updated the pull request incrementally with one additional commit since the last revision: order imports - Changes: - all: https://git.openjdk.org/jdk/pull/12017/files - new: https://git.o

Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu [v2]

2023-01-18 Thread Alexey Ivanov
On Tue, 17 Jan 2023 16:50:51 GMT, SWinxy wrote: >> Please review this small change to cache a component's popup menu in BLAF. > > SWinxy has updated the pull request incrementally with one additional commit > since the last revision: > > Single-class imports Please change your IDE settings t

Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu [v2]

2023-01-17 Thread SWinxy
On Tue, 17 Jan 2023 05:14:35 GMT, Prasanta Sadhukhan wrote: >> SWinxy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Single-class imports > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java > line 35: > >>

Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu [v2]

2023-01-17 Thread SWinxy
> Please review this small change to cache a component's popup menu in BLAF. SWinxy has updated the pull request incrementally with one additional commit since the last revision: Single-class imports - Changes: - all: https://git.openjdk.org/jdk/pull/12017/files - new: https:

Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu

2023-01-16 Thread Prasanta Sadhukhan
On Mon, 16 Jan 2023 20:07:07 GMT, SWinxy wrote: > Please review this small change to cache a component's popup menu in BLAF. src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java line 35: > 33: > 34: import javax.sound.sampled.*; > 35: import javax.swing.*; Fix looks ok

RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu

2023-01-16 Thread SWinxy
Please review this small change to cache a component's popup menu in BLAF. - Commit messages: - 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu Changes: https://git.openjdk.org/jdk/pull/12017/files Webrev: https://webrevs.openjdk.org/?repo